Re: clang-format-vsix: versioning patch and show stderrors patch

2016-12-05 Thread Antonio Maiorano via cfe-commits
I've created the two reivews on phabricator: https://reviews.llvm.org/D27438 https://reviews.llvm.org/D27440 Thanks! On Mon, 5 Dec 2016 at 11:01 Manuel Klimek wrote: > On Mon, Dec 5, 2016 at 3:53 PM Antonio Maiorano > wrote: > > Hi Manuel, > > Okay,

Re: clang-format-vsix: versioning patch and show stderrors patch

2016-12-05 Thread Manuel Klimek via cfe-commits
On Mon, Dec 5, 2016 at 3:53 PM Antonio Maiorano wrote: > Hi Manuel, > > Okay, I'll submit both patches via phabricator as you recommend. I'll add > you, and I'll add Hans Wennborg and Zachary Turner, who were both involved > with the first clang-format-vsix patch I worked

Re: clang-format-vsix: versioning patch and show stderrors patch

2016-12-05 Thread Antonio Maiorano via cfe-commits
Hi Manuel, Okay, I'll submit both patches via phabricator as you recommend. I'll add you, and I'll add Hans Wennborg and Zachary Turner, who were both involved with the first clang-format-vsix patch I worked on: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161128/178569.html Does

Re: clang-format-vsix: versioning patch and show stderrors patch

2016-12-05 Thread Manuel Klimek via cfe-commits
Awesome, thanks for working on this. If you submit the patches via phabricator (http://llvm.org/docs/Phabricator.html) I'll get to it faster :) Feel free to directly add me as reviewer, btw (add 'klimek'). On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits <

clang-format-vsix: versioning patch and show stderrors patch

2016-12-02 Thread Antonio Maiorano via cfe-commits
Hello, I have two patches for clang-format-vsix to offer up for review: 0001-clang-format-vsix-versioning.patch clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability Presently, the version number of the VSIX matches the LLVM version number. However, as this