r246991 - When building the alloca for a local variable, set its name

Author: rjmccall Date: Tue Sep 8 04:18:30 2015 New Revision: 246991 URL: http://llvm.org/viewvc/llvm-project?rev=246991=rev Log: When building the alloca for a local variable, set its name separately from building the instruction so that it's preserved even in -Asserts builds. Employ C++'s

Re: r246991 - When building the alloca for a local variable, set its name

> On Sep 8, 2015, at 10:52 AM, Chandler Carruth wrote: > None of my performance concerns were relevant to this change FWIW. > > I think the reason that this got "fixed" was because people had a tendancy to > *rely* on the name downstream when we made it always present. =/

Re: r246991 - When building the alloca for a local variable, set its name

On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rjmccall > Date: Tue Sep 8 04:18:30 2015 > New Revision: 246991 > > URL: http://llvm.org/viewvc/llvm-project?rev=246991=rev > Log: > When building the alloca for a local variable, set its

Re: r246991 - When building the alloca for a local variable, set its name

On Tue, Sep 8, 2015 at 10:26 AM, John McCall wrote: > On Sep 8, 2015, at 8:25 AM, David Blaikie wrote: > On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rjmccall >> Date: Tue Sep 8 04:18:30

Re: r246991 - When building the alloca for a local variable, set its name

None of my performance concerns were relevant to this change FWIW. I think the reason that this got "fixed" was because people had a tendancy to *rely* on the name downstream when we made it always present. =/ Personally, I like having *no* names in a no-asserts build because it ensures that

Re: r246991 - When building the alloca for a local variable, set its name

> On Sep 8, 2015, at 8:25 AM, David Blaikie wrote: > On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits > > wrote: > Author: rjmccall > Date: Tue Sep 8 04:18:30 2015 > New Revision: 246991 > > URL:

Re: r246991 - When building the alloca for a local variable, set its name

On Tue, Sep 8, 2015 at 10:52 AM, Chandler Carruth wrote: > None of my performance concerns were relevant to this change FWIW. > Good to know - if we wanted to go down this path I figure we could just provide overloads - StringRef and Twine, the StringRef one could always

Re: r246991 - When building the alloca for a local variable, set its name

I agree with Chandler the default should be no names for -Asserts builds. What I wanted originally was that the stripping of names be a runtime choice (since the performance overhead of it was minimal when I measured it), so that when we need to debug with a production compiler, it would still be