Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

not_ubsan was added a long time ago, I presume it is still needed due to recursion in sema as well. not_asan was added recently to 2 tests after r260760. I tentatively removed it from 'index-many-call-ops.cpp’ and if all looks good I’ll remove from the other as well. > On Feb 29, 2016, at 9:57

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

If the test shouldn't require large stack usage, should the not_ubsan, not_asan tags be removed? On Mon, Feb 29, 2016 at 9:55 PM, Justin Lebar wrote: > Works! Thank you for fixing this, and so quickly. > > On Mon, Feb 29, 2016 at 6:51 PM, Argyrios Kyrtzidis

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Works! Thank you for fixing this, and so quickly. On Mon, Feb 29, 2016 at 6:51 PM, Argyrios Kyrtzidis wrote: > Try with r262290. > >> On Feb 29, 2016, at 6:23 PM, Argyrios Kyrtzidis wrote: >> >> Ah, I see the problem in the code, will fix shortly. >> >>>

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Try with r262290. > On Feb 29, 2016, at 6:23 PM, Argyrios Kyrtzidis wrote: > > Ah, I see the problem in the code, will fix shortly. > >> On Feb 29, 2016, at 5:43 PM, Justin Lebar wrote: >> >>> How are you configuring >> >> cmake -G "Ninja"

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Ah, I see the problem in the code, will fix shortly. > On Feb 29, 2016, at 5:43 PM, Justin Lebar wrote: > >> How are you configuring > > cmake -G "Ninja" -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang > -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ENABLE_ASSERTIONS=On >

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

I don’t quite understand how it gets that stack trace, dataTraverseNode() was introduced to avoid exactly this. How are you configuring and what compiler and version are you using ? > On Feb 29, 2016, at 3:14 PM, Justin Lebar wrote: > >> Is this still an issue after r260785

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

> Is this still an issue after r260785 ? I just sync'ed to r262268 and was able to reproduce the segfault. > Could you provide a stack trace ? $ gdb --args release/bin/c-index-test -index-file /usr/local/google/home/jlebar/code/llvm/src/tools/clang/test/Index/index-many-call-ops.cpp (gdb) run

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Is this still an issue after r260785 ? Could you provide a stack trace ? > On Feb 29, 2016, at 2:27 PM, Justin Lebar wrote: > > Hi, I think this broke clang/test/Index/index-many-call-ops.cpp. I > get a segfault due to recursive stack overflow in release builds on my > linux

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Hi, I think this broke clang/test/Index/index-many-call-ops.cpp. I get a segfault due to recursive stack overflow in release builds on my linux x86-64 box when running that test -- it seems the purpose of that test is to check that we *don't* segfault. This has been broken for a while, and

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

On 12 February 2016 at 23:11, Argyrios Kyrtzidis via cfe-commits wrote: > Author: akirtzidis > Date: Fri Feb 12 17:10:59 2016 > New Revision: 260760 > > URL: http://llvm.org/viewvc/llvm-project?rev=260760=rev > Log: > [libclang] Separate the underlying indexing

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

Sorry, I looked at it but it wasn’t clear to me what the problem is: FAILED: : /home/linaro/buildbot/clang-cmake-armv7-a15/stage1/tools/clang/clang.order: file not recognized: File truncated I thought it was some build SNAFU, do you have some hint on what I need to do to fix this ? > On Feb

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

clangIndex library is not part of that command so I don’t understand how my changes affect linking the clang binary, clangIndex is only used for libclang. > On Feb 13, 2016, at 11:55 AM, Argyrios Kyrtzidis wrote: > > Sorry, I looked at it but it wasn’t clear to me what the

Re: r260760 - [libclang] Separate the underlying indexing functionality of libclang and introduce it into the clangIndex library.

I guess refreshing the build directory fixed the bots now. You may want to look into ccache as possibly the issue here. > On Feb 13, 2016, at 12:08 PM, Argyrios Kyrtzidis wrote: > > clangIndex library is not part of that command so I don’t understand how my > changes affect