Author: alexshap Date: Tue Aug 15 12:23:54 2017 New Revision: 310948 URL: http://llvm.org/viewvc/llvm-project?rev=310948&view=rev Log: [clang] Code cleanup in clang/tooling
1. Add missing explicit for SymbolName constructor. 2. Add missing std::move in createRenameReplacements. Differential revision: https://reviews.llvm.org/D36715 Modified: cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp Modified: cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h?rev=310948&r1=310947&r2=310948&view=diff ============================================================================== --- cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h (original) +++ cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h Tue Aug 15 12:23:54 2017 @@ -29,7 +29,7 @@ namespace tooling { /// \endcode class SymbolName { public: - SymbolName(StringRef Name) { + explicit SymbolName(StringRef Name) { // While empty symbol names are valid (Objective-C selectors can have empty // name pieces), occurrences Objective-C selectors are created using an // array of strings instead of just one string. Modified: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp?rev=310948&r1=310947&r2=310948&view=diff ============================================================================== --- cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp (original) +++ cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp Tue Aug 15 12:23:54 2017 @@ -53,7 +53,7 @@ createRenameReplacements(const SymbolOcc } Changes.push_back(std::move(Change)); } - return Changes; + return std::move(Changes); } /// Takes each atomic change and inserts its replacements into the set of _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits