n, Eli ; Keane, Erich <
> erich.ke...@intel.com>; Nico Weber
> *Cc:* cfe-commits
> *Subject:* RE: r314262 - Emit section information for extern variables.
>
>
>
> Alright. Will do. Thanks!
>
>
>
> *From:* Friedman, Eli [mailto:efrie...@codeaurora.org
> ]
&g
Elizabeth gave me a patch, submitted it with a test in r314939
From: Andrews, Elizabeth
Sent: Wednesday, October 4, 2017 1:54 PM
To: Friedman, Eli ; Keane, Erich
; Nico Weber
Cc: cfe-commits
Subject: RE: r314262 - Emit section information for extern variables.
Alright. Will do. Thanks!
From
Alright. Will do. Thanks!
From: Friedman, Eli [mailto:efrie...@codeaurora.org]
Sent: Wednesday, October 4, 2017 4:51 PM
To: Keane, Erich ; Andrews, Elizabeth
; Nico Weber
Cc: cfe-commits
Subject: Re: r314262 - Emit section information for extern variables.
On 10/4/2017 1:48 PM, Keane, Erich
lto:tha...@google.com>] *On Behalf Of *Nico Weber
*Sent:* Wednesday, October 4, 2017 1:14 PM
*To:* Keane, Erich mailto:erich.ke...@intel.com>>
*Cc:* Andrews, Elizabeth mailto:elizabeth.andr...@intel.com>>; Friedman, Eli
mailto:efrie...@codeaurora.org>>
beth ; Nico Weber
Cc: cfe-commits ; Keane, Erich
Subject: Re: r314262 - Emit section information for extern variables.
Oh, that's easy to explain; sorry, I didn't think of it when I was reviewing.
DefinitionKind has three possible values: DeclarationOnly, TentativeDefinition,
rich
*Cc:* Andrews, Elizabeth ; Friedman, Eli
; cfe-commits
*Subject:* Re: r314262 - Emit section information for extern variables.
All I know about this code that it used to build (and still builds
with gcc) and now it doesn't, sorry :-) What that code does seems
somewhat questionable, but
it.
Thanks,
Elizabeth
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Wednesday, October 4, 2017 4:29 PM
To: Keane, Erich
Cc: Andrews, Elizabeth ; Friedman, Eli
; cfe-commits
Subject: Re: r314262 - Emit section information for extern variables.
All I know about
gle.com>] On Behalf Of Nico Weber
Sent: Wednesday, October 4, 2017 12:59 PM
To: Keane, Erich mailto:erich.ke...@intel.com>>
Cc: cfe-commits mailto:cfe-commits@lists.llvm.org>>
Subject: Re: r314262 - Emit section information for extern variables.
Hi Erich,
this breaks existing code.
gle.com [mailto:tha...@google.com] *On Behalf Of *Nico
> Weber
> *Sent:* Wednesday, October 4, 2017 1:14 PM
> *To:* Keane, Erich
> *Cc:* Andrews, Elizabeth ; Friedman, Eli <
> efrie...@codeaurora.org>; cfe-commits
>
> *Subject:* Re: r314262 - Emit section information for e
piling (which is almost definitely a bug).
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Wednesday, October 4, 2017 1:14 PM
To: Keane, Erich
Cc: Andrews, Elizabeth ; Friedman, Eli
; cfe-commits
Subject: Re: r314262 - Emit section information for extern variable
red thanks to this new warning.
>
>
>
> Is there a good/reasonable reason the source of nacl wants to redeclare
> this with a different ‘section’?
>
>
>
>
>
> *From:* tha...@google.com [mailto:tha...@google.com] *On Behalf Of *Nico
> Weber
> *Sent:* Wednesday, Oct
source of nacl wants to redeclare this
with a different ‘section’?
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Wednesday, October 4, 2017 12:59 PM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r314262 - Emit section information for extern variables.
Hi Erich
Hi Erich,
this breaks existing code. NaCl does this:
#include
struct r_debug _r_debug __attribute__((nocommon, section(".r_debug")));
(There's a lengthy-ish comment for why in
https://cs.chromium.org/chromium/src/native_client/src/trusted/service_runtime/linux/nacl_bootstrap.c?q=nacl_bootstrap.
Author: erichkeane
Date: Tue Sep 26 16:42:34 2017
New Revision: 314262
URL: http://llvm.org/viewvc/llvm-project?rev=314262&view=rev
Log:
Emit section information for extern variables.
Currently, if _attribute_((section())) is used for extern variables,
section information is not emitted in gene
14 matches
Mail list logo
