Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-13 Thread John McCall via cfe-commits
> On Apr 9, 2018, at 3:47 PM, Akira Hatanaka wrote: > > >> On Apr 5, 2018, at 1:25 PM, John McCall > > wrote: >> >> >> >>> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka >> >

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-09 Thread Akira Hatanaka via cfe-commits
> On Apr 5, 2018, at 1:25 PM, John McCall wrote: > > > >> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka > > wrote: >> >> >>> On Apr 5, 2018, at 12:39 PM, John McCall >> >

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-05 Thread John McCall via cfe-commits
> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka wrote: > > >> On Apr 5, 2018, at 12:39 PM, John McCall > > wrote: >> >> >> >>> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka >>

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-05 Thread Akira Hatanaka via cfe-commits
> On Apr 5, 2018, at 12:39 PM, John McCall wrote: > > > >> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka > > wrote: >> >> >> >>> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits >>>

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-05 Thread John McCall via cfe-commits
> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka wrote: > > > >> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits >> > wrote: >> >>> >>> On Apr 4, 2018, at 3:38 PM, Richard Smith

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-05 Thread Akira Hatanaka via cfe-commits
> On Apr 4, 2018, at 5:38 PM, Richard Smith wrote: > > On 4 April 2018 at 16:57, Akira Hatanaka via cfe-commits > > wrote: > >> On Apr 4, 2018, at 4:47 PM, Richard Smith >

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Richard Smith via cfe-commits
On 4 April 2018 at 16:57, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 4, 2018, at 4:47 PM, Richard Smith wrote: > > On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits lists.llvm.org> wrote: > >> >> On Apr 4, 2018, at

r329247 - Revert r328680 ("[ObjC] Make C++ triviality type traits available to non-trivial C structs.")

2018-04-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 4 17:34:54 2018 New Revision: 329247 URL: http://llvm.org/viewvc/llvm-project?rev=329247=rev Log: Revert r328680 ("[ObjC] Make C++ triviality type traits available to non-trivial C structs.") It unintentionally caused the values of the __has_* type traits

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Akira Hatanaka via cfe-commits
> On Apr 4, 2018, at 4:47 PM, Richard Smith wrote: > > On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits > > wrote: > >> On Apr 4, 2018, at 3:38 PM, Richard Smith >

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Richard Smith via cfe-commits
On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the C++ versions of these type traits for classes > with volatile members. Such

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Richard Smith via cfe-commits
On 4 April 2018 at 16:37, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > >

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Richard Smith via cfe-commits
On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the C++ versions of these type traits for classes > with volatile members. Such

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Akira Hatanaka via cfe-commits
> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits > wrote: > >> >> On Apr 4, 2018, at 3:38 PM, Richard Smith > > wrote: >> >> Hi Akira, >> >> This change has broken the C++ versions of these type

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Akira Hatanaka via cfe-commits
> On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the C++ versions of these type traits for classes with > volatile members. Such classes are required to claim to be trivial per C++ DR > 2094

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-04-04 Thread Richard Smith via cfe-commits
Hi Akira, This change has broken the C++ versions of these type traits for classes with volatile members. Such classes are required to claim to be trivial per C++ DR 2094 ( http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2094) but return false from isNonTrivialToPrimitiveCopy().

r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

2018-03-27 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Tue Mar 27 17:12:08 2018 New Revision: 328680 URL: http://llvm.org/viewvc/llvm-project?rev=328680=rev Log: [ObjC] Make C++ triviality type traits available to non-trivial C structs. r326307 and r327870 made changes that allowed using non-trivial C structs with fields