Author: george.karpenkov Date: Thu Oct 25 16:38:24 2018 New Revision: 345339
URL: http://llvm.org/viewvc/llvm-project?rev=345339&view=rev Log: [analyzer] Remove custom rule for OSIterator in RetainCountChecker Differential Revision: https://reviews.llvm.org/D53628 Modified: cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp?rev=345339&r1=345338&r2=345339&view=diff ============================================================================== --- cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp (original) +++ cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp Thu Oct 25 16:38:24 2018 @@ -69,10 +69,6 @@ static bool isOSObjectDynamicCast(String return S == "safeMetaCast"; } -static bool isOSIteratorSubclass(const Decl *D) { - return isSubclass(D, "OSIterator"); -} - static bool hasRCAnnotation(const Decl *D, StringRef rcAnnotation) { for (const auto *Ann : D->specific_attrs<AnnotateAttr>()) { if (Ann->getAnnotation() == rcAnnotation) @@ -240,10 +236,6 @@ RetainSummaryManager::generateSummary(co // All objects returned with functions starting with "get" are getters. if (II->getName().startswith("get")) { - - // ...except for iterators. - if (isOSIteratorSubclass(PD)) - return getOSSummaryCreateRule(FD); return getOSSummaryGetRule(FD); } else { return getOSSummaryCreateRule(FD); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits