This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL286873: [change-namespace] consider typedef/using alias
decls in the moved namespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix bucket_count() assumptions.
With a max_load_factor of 1.0, the only guarantee is that
bucket_count() >= size(). (Note: setting max_load_factor without
rehas
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] future_error::what() is implementation-defined.
https://reviews.llvm.org/D26625
Files:
test/std/thread/futures/futures.future_error/what.pass.cpp
Index: t
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix an improper assumption about Null Forward Iterators.
Value-initialized iterators still can't be compared to those with parents.
https://reviews.llvm.org/D
manmanren added a comment.
@ Ben,
We are hitting this issue when building large projects, but the reproducibility
is quite low.
This proposed patch is currently a little too complicated. I am thinking about
just fixing the testing case for now, and adding the check later when we start
to shar
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Swapping non-equal non-POCS allocators is UB.
test_allocator is a non-POCS allocator. Instead of swapping containers
with A(1) and A(2), which triggers undefine
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix ordering assumptions in unordered container tests.
https://reviews.llvm.org/D26627
Files:
test/std/containers/unord/unord.multimap/unord.multimap.modif
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> Is it correct to emit a type check at this point? Looking at [0
Author: marshall
Date: Mon Nov 14 14:38:43 2016
New Revision: 286883
URL: http://llvm.org/viewvc/llvm-project?rev=286883&view=rev
Log:
Missed a test with exceptions disabled earlier. Oops.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp
Modified:
libcxx
krasin updated this revision to Diff 77868.
krasin added a comment.
Add a regression test.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-null.cpp
Index: test/CodeGenCXX/ubsan-null.cpp
Author: marshall
Date: Mon Nov 14 14:41:17 2016
New Revision: 286884
URL: http://llvm.org/viewvc/llvm-project?rev=286884&view=rev
Log:
P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t and
istream_iterator. No code changes were needed, but I updated a few tests. Also
resolved
ahatanak added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4427
+const CXXRecordDecl *ClosureClass = MD->getParent();
+assert((std::distance(ClosureClass->captures_begin(),
+ ClosureClass->captures_end()) == 0) &&
---
ahatanak added a comment.
Are there any further comments?
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir added a comment.
> Does it mean that a system module should only import system modules? If a
> system module is allowed to import non-system modules, for a non-system
> module, we will validate diagnostic options differently depending on whether
> a system module or a non-system mod
beanz added inline comments.
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
Should this really be fatal? It seems to me in many cases you mig
Hi Faisal,
Our ASan bot started complaining after this commit.
I'm not 100% sure this caused it yet, though I'm running tests.
Could you take a look?
thanks,
vedant
FAIL: Clang :: SemaCXX/constant-expression-cxx11.cpp (9393 of 29261)
TEST 'Clang :: SemaCXX/constant-expre
mgorny added inline comments.
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
beanz wrote:
> Should this really be fatal? It seems to me in ma
krasin added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> pcc wrote:
> > Is it correct to emit a type check at this po
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
krasin wrote:
> pcc wrote:
> > pcc wrote:
> > > Is it correct to emit a type
Reverting this commit doesn't solve anything, sorry for the noise.
It seems to hit an infinite loop:
frame #17: 0x0001083d48ab clang`::Visit() [inlined]
HandleConditionalOperator + 165 at
ExprConstant.cpp:4212
frame #18: 0x0001083d4806 clang`::Visit() [inlined]
VisitConditional
Author: kuba.brecka
Date: Mon Nov 14 16:38:57 2016
New Revision: 286898
URL: http://llvm.org/viewvc/llvm-project?rev=286898&view=rev
Log:
[sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET when building compiler-rt
from clang/runtime/CMakeLists.txt
This breaks some Swift builds, because Swift's
Author: dcoughlin
Date: Mon Nov 14 16:46:02 2016
New Revision: 286901
URL: http://llvm.org/viewvc/llvm-project?rev=286901&view=rev
Log:
[analyzer] Fix crash in NullabilityChecker calling block with too few arguments
Fix a crash when checking parameter nullability on a block invocation
with fewer
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/lit.cfg:109
+if not llvm_shlib_dir:
+lit_config.fatal('No LLVM shlib dir set!')
llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)
-
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
Split out optimization from https://reviews.llvm.org/D26061
https://reviews.llvm.org/D26642
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
Index: lib/StaticAnalyzer/Core/
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
The name is slightly confusing, since the constraint is not necessarily within
the range unless `Assumption` is true. Split out renaming for
ConstraintManager.h from https://reviews.llvm
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM, other then some indentation issues for arguments and parameters after the
rename. Please fix those and commit! And thanks for splitting this up.
Comment at:
inc
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Please commit!
https://reviews.llvm.org/D26642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
manmanren added a comment.
In https://reviews.llvm.org/D25916#594844, @benlangmuir wrote:
> > Does it mean that a system module should only import system modules? If a
> > system module is allowed to import non-system modules, for a non-system
> > module, we will validate diagnostic options dif
phosek created this revision.
phosek added a reviewer: beanz.
phosek added subscribers: cfe-commits, ruiu.
phosek set the repository for this revision to rL LLVM.
Herald added subscribers: mehdi_amini, mgorny.
lld has LTO support, if requested we should add a dependency on lld rather than
LLVMgol
mehdi_amini added a comment.
Make sense to me, but I don't think it is enough: LLVM_ENABLE_LLD should be
passed to stage-2, and it also should be set to the absolute path of the
stage-1 lld build.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
mehdi_amini added inline comments.
Comment at: CMakeLists.txt:516
if(BOOTSTRAP_LLVM_ENABLE_LTO OR LLVM_ENABLE_LTO AND NOT
LLVM_BUILD_INSTRUMENTED)
add_dependencies(clang-bootstrap-deps LTO)
if(APPLE)
This dep does not make sense when using either ll
phosek created this revision.
phosek added a reviewer: beanz.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added a subscriber: mgorny.
These cache files can be used to build Fuchsia Clang toolchain. They also
demonstrate the use of multi-t
dtarditi added a comment.
I sync'ed to the head of the tree. I tried to reproduce the failures that you
saw and couldn't.I'm building on Windows 10 x64 using Visual Studio. What
platform/OS did you build on? I built and test both Debug and RelWithDebugInfo.
Here's what I saw for RelWithD
faisalv updated this revision to Diff 77926.
faisalv marked an inline comment as done.
faisalv added a comment.
Simplify the check for zero captures in a lambda expression (within the assert)
by comparing the begin and end pointers directly (as opposed to using distance)
- thanks to Akira!
htt
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D26649#595213, @mehdi_amini wrote:
> Make sense to me, but I don't think it is enough: LLVM_ENABLE_LLD should be
> passed to stage-2, and it also should be set to the absolute path of the
> stage-1 lld build.
What is search directori
spyffe added a reviewer: beanz.
spyffe updated this revision to Diff 77928.
spyffe added a comment.
Updated the locations so the structure is now
a/test.c
a/Inputs/a1.c
a/Inputs/a2.c
The naming of "test.c" is no longer a requirement but only a convention. Also
`lit.site.cfg` is no longer
phosek added a comment.
It's sufficient, I just tested it. I'm not actually sure if `LLVM_ENABLE_LLD`
here is correct, `LLVM_ENABLE_LLD` forces the use of lld, but lld might not be
available during first stage. We need `LLVM_ENABLE_LLD` to be set, but only for
the second stage (which is somethi
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595296, @phosek wrote:
> It's sufficient, I just tested it. I'm not actually sure if `LLVM_ENABLE_LLD`
> here is correct, `LLVM_ENABLE_LLD` forces the use of lld, but lld might not
> be available during first stage. We need `LLVM_E
Eugene.Zelenko added a comment.
I think this should be handled in higher level script
(utils/release/test-release.sh or similar), not in CMake. CMake compiler tests
just need to fail when LLVM_ENABLE_LLD is used without actually having them.
Repository:
rL LLVM
https://reviews.llvm.org/D266
Author: ddcc
Date: Mon Nov 14 19:40:58 2016
New Revision: 286925
URL: http://llvm.org/viewvc/llvm-project?rev=286925&view=rev
Log:
[analyzer] Minor optimization: avoid setting state if unchanged
Summary: Split out optimization from D26061
Reviewers: zaks.anna, dcoughlin
Subscribers: cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286925: [analyzer] Minor optimization: avoid setting state
if unchanged (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26642?vs=77897&id=77929#toc
Repository:
rL LLVM
https:/
ddcc updated this revision to Diff 77930.
ddcc added a comment.
Fix formatting
https://reviews.llvm.org/D26644
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
lib/StaticAnalyzer/Checkers/StdLibraryFu
Author: ddcc
Date: Mon Nov 14 19:54:41 2016
New Revision: 286927
URL: http://llvm.org/viewvc/llvm-project?rev=286927&view=rev
Log:
[analyzer] Rename assumeWithinInclusiveRange*()
Summary: The name is slightly confusing, since the constraint is not
necessarily within the range unless `Assumption`
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286927: [analyzer] Rename assumeWithinInclusiveRange*()
(authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26644?vs=77930&id=77933#toc
Repository:
rL LLVM
https://reviews.llvm.or
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595301, @Eugene.Zelenko wrote:
> I think this should be handled in higher level script
> (utils/release/test-release.sh or similar), not in CMake. CMake compiler
> tests just need to fail when LLVM_ENABLE_LLD is used without actual
Eugene.Zelenko added a comment.
I meant that multi-stage build is processed by higher level script. So it
should take care about consistency of source code srt versus later stages build
options.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
_
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595334, @Eugene.Zelenko wrote:
> I meant that multi-stage build is processed by higher level script. So it
> should take care about consistency of source code srt versus later stages
> build options.
We have a 2-stage build direc
Eugene.Zelenko added a comment.
Yes, you are correct, I meant later.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595296, @phosek wrote:
> It's sufficient, I just tested it.
How did you check it? I don't understand how LLVM_ENABLE_LLD is propagated to
stage-2?
Comment at: CMakeLists.txt:534
+add_dependencies(LLVMgo
phosek added a comment.
In https://reviews.llvm.org/D26649#595356, @mehdi_amini wrote:
> In https://reviews.llvm.org/D26649#595296, @phosek wrote:
>
> > It's sufficient, I just tested it.
>
>
> How did you check it? I don't understand how LLVM_ENABLE_LLD is propagated to
> stage-2?
Sufficient
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595361, @phosek wrote:
> In https://reviews.llvm.org/D26649#595356, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D26649#595296, @phosek wrote:
> >
> > > It's sufficient, I just tested it.
> >
> >
> > How did you check it? I
phosek added a comment.
In https://reviews.llvm.org/D26649#595367, @mehdi_amini wrote:
> OK, but still, LLVM_ENABLE_LLD needs to be passed to stage-2, so it needs to
> be actually BOOTSTRAP_LLVM_ENABLE_LLD.
> I looked at all the CMake `_PASSTHROUGH` and didn't find it mentioned
> anywhere. We
phosek updated this revision to Diff 77938.
phosek marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@
sfertile added inline comments.
Comment at: lib/Headers/altivec.h:11908
+#define vec_extract4b(__a, __b)
\
+ vec_reve((vector unsigned long long)
\
+__builtin_vsx_xxextractuw
smeenai created this revision.
smeenai added reviewers: compnerd, hans.
smeenai added a subscriber: cfe-commits.
On MSVC, if an implicit instantiation already exists and an explicit
instantiation definition with a DLL attribute is created, the DLL
attribute still takes effect. Make clang match thi
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:735
+ const FunctionDecl *FunctionDecl = SFC->getDecl()->getAsFunction();
+ unsigned NumArgs = FunctionDecl->getNumParams();
+ assert(ArgIdx < NumArgs && "Arg access out of ra
krasin updated this revision to Diff 77941.
krasin added a comment.
Do better job with destructors.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
mehdi_amini accepted this revision.
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cf
krasin added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
pcc wrote:
> krasin wrote:
> > pcc wrote:
> > > pcc wrote:
> > > > Is it
mehdi_amini requested changes to this revision.
mehdi_amini added inline comments.
This revision now requires changes to proceed.
Comment at: CMakeLists.txt:516
if(BOOTSTRAP_LLVM_ENABLE_LTO OR LLVM_ENABLE_LTO AND NOT
LLVM_BUILD_INSTRUMENTED)
-add_dependencies(clang-bootst
mehdi_amini added a comment.
What about the following logic?
if(BOOTSTRAP_LLVM_ENABLE_LLD)
add_dependencies(clang-bootstrap-deps lld)
endif()
if(APPLE)
# on Darwin we need to set DARWIN_LTO_LIBRARY so that -flto will work
# using the just-built compiler, and we need t
Author: marshall
Date: Mon Nov 14 23:03:22 2016
New Revision: 286932
URL: http://llvm.org/viewvc/llvm-project?rev=286932&view=rev
Log:
Missed one of the try blocks the first time :-(. Thanks to Renato for the heads
up.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_s
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Comment at: lib/CodeGen/BackendUtil.cpp:422
// Set up the per-function pass manager.
+ FPM.add(new TargetLibraryInfoWrapperPass(*TLII));
if (Co
phosek added a comment.
AFAIK lld on Darwin doesn't support LTO (last I heard it cannot even self-host
at the moment) so I'm not sure if it makes sense to enable it `if(APPLE)`.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#595429, @phosek wrote:
> AFAIK lld on Darwin doesn't support LTO (last I heard it cannot even
> self-host at the moment) so I'm not sure if it makes sense to enable it
> `if(APPLE)`.
OK, we could error instead of ignoring then.
B
phosek updated this revision to Diff 77950.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -511,10 +511,10 @@
set(STAMP_DIR ${CMA
zaks.anna added a comment.
Hi and welcome to the project!
This patch definitely looks quite complex for a first contribution, so great
job at digging through the analyzer internals!
One higher level comment I have is that you should try and split patches
whenever possible. For example, in the
EricWF updated this revision to Diff 2.
EricWF added a comment.
Add final touches. This patch is ready to go.
@chandlerc mentioned he would still like to see more per-function granularity
for enabling/disabling the libc++ [[nodiscard]] macro in order to ease adoption
in large code bases. Ho
Alpha added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rogfer01
Date: Mon Nov 14 02:53:27 2016
New Revision: 286798
URL: http://llvm.org/viewvc/llvm-project?rev=286798&view=rev
Log:
Remove some false positives when taking the address of packed members
Differential Revision: https://reviews.llvm.org/D23657
Modified:
cfe/trunk/include/cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286798: Remove some false positives when taking the address
of packed members (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D23657?vs=77498&id=3#toc
Repository:
rL LLV
rogfer01 added a comment.
Ping? :)
https://reviews.llvm.org/D26457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments. There are a couple of tests which don't explicitly
assert if they throw or not. Please address those tests before committing.
Comment at:
test/
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D26458#590865, @rmaprath wrote:
> Not sure if either of these tests add much value to the no-exceptions
> variant, using `std::nested_exception` with such a library
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. The consensus is against adding `TEST_TRY` and `TEST_CATCH`.
https://reviews.llvm.org/D26139
___
cfe-commits mailing list
cfe-commits@lists
a.sidorin added a comment.
Wow, thank you for such a contribution! Did you evaluate this checker on some
real code?
I have some minor inline comments below.
Comment at: lib/StaticAnalyzer/Checkers/CMakeLists.txt:41
IdenticalExprChecker.cpp
+RecursionChecker.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286809: Protect smart-pointer tests under no exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26457?vs=77361&id=8#toc
Repository:
rL LLVM
https://reviews.llv
Author: rogfer01
Date: Mon Nov 14 04:27:56 2016
New Revision: 286809
URL: http://llvm.org/viewvc/llvm-project?rev=286809&view=rev
Log:
Protect smart-pointer tests under no exceptions
Skip tests that expect an exception be thrown under no-exceptions.
Differential Revision: https://reviews.llvm.or
k-wisniewski added a comment.
@a.sidorin
Thank you for your review! I'll upload the new patch this evening that will
include fixes for the things you pointed out. Can I also add you as a reviewer?
Also: Can you have a look at my other patch that I have linked in the
description? Thanks in adva
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286812: Update tests for strings conversions under
libcpp-no-exceptions (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26139?vs=76373&id=9#toc
Repository:
rL LLVM
htt
Author: rogfer01
Date: Mon Nov 14 04:44:26 2016
New Revision: 286812
URL: http://llvm.org/viewvc/llvm-project?rev=286812&view=rev
Log:
Update tests for strings conversions under libcpp-no-exceptions
Differential Revision: https://reviews.llvm.org/D26139
Modified:
libcxx/trunk/test/std/strin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286813: Protect nested-exceptions tests under no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26458?vs=77363&id=77782#toc
Repository:
rL LLVM
https://reviews
Author: rogfer01
Date: Mon Nov 14 05:00:28 2016
New Revision: 286813
URL: http://llvm.org/viewvc/llvm-project?rev=286813&view=rev
Log:
Protect nested-exceptions tests under no-exceptions
Differential Revision: https://reviews.llvm.org/D26458
Modified:
libcxx/trunk/test/std/language.support
Author: neil.hickey
Date: Mon Nov 14 05:15:51 2016
New Revision: 286815
URL: http://llvm.org/viewvc/llvm-project?rev=286815&view=rev
Log:
Improve handling of floating point literals in OpenCL to only use double
precision if the target supports fp64.
This change makes sure single-precision floati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286815: Improve handling of floating point literals in
OpenCL to only use double… (authored by neil.hickey).
Changed prior to commit:
https://reviews.llvm.org/D24235?vs=77600&id=77783#toc
Repository:
Anastasia added a comment.
I see. If I say something like:
- For the number of event argument allow to pass larger integers than 32 bits
as soon as compiler can prove that the range fits in 32 bits. If not, the
diagnostic will be given.
- Change type of the arguments specifying sizes of the co
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:139
+class ClassDeclarationMatcher : public MatchFinder::MatchCallback {
+public:
ioeric wrote:
> Why is this called a Matcher?
Rename it to a better name "Match".
https://reviews.llvm.org/D26
hokein updated this revision to Diff 77788.
hokein marked 2 inline comments as done.
hokein added a comment.
Split to small functions.
https://reviews.llvm.org/D26515
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
Index: clang-move/ClangMove.h
==
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
rogfer01 updated this revision to Diff 77789.
rogfer01 added a comment.
Add missing asserts as pointed out by @EricWF
https://reviews.llvm.org/D26512
Files:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp
test/std/input.output/iostreams.base/ios/basic.ios.members
Author: rengolin
Date: Mon Nov 14 06:19:18 2016
New Revision: 286818
URL: http://llvm.org/viewvc/llvm-project?rev=286818&view=rev
Log:
Revert "Improve handling of floating point literals in OpenCL to only use
double precision if the target supports fp64."
This reverts commit r286815, as it broke
On 14 November 2016 at 11:15, Neil Hickey via cfe-commits
wrote:
> Author: neil.hickey
> Date: Mon Nov 14 05:15:51 2016
> New Revision: 286815
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286815&view=rev
> Log:
> Improve handling of floating point literals in OpenCL to only use double
> preci
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks
https://reviews.llvm.org/D26522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with a few comments.
(There are two empty comments that can't be deleted due to a phabricator
bugs...)
Comment at: clang-move/ClangMove.cpp:407
+ auto MovedClass =
+
hokein updated this revision to Diff 77794.
hokein added a comment.
Add comments and update patch descriptions.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
===
SilverGeri updated this revision to Diff 77784.
SilverGeri added a comment.
Herald added a subscriber: modocache.
move checker to readability module
add missing description to header file
https://reviews.llvm.org/D21298
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Del
pekka.jaaskelainen closed this revision.
pekka.jaaskelainen added a comment.
Committed in r286819.
Repository:
rL LLVM
https://reviews.llvm.org/D26157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rengolin added a comment.
Looks like an oversight. Aren't there any tests for this? Maybe there should be
one.
Repository:
rL LLVM
https://reviews.llvm.org/D26464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: pjaaskel
Date: Mon Nov 14 07:14:38 2016
New Revision: 286821
URL: http://llvm.org/viewvc/llvm-project?rev=286821&view=rev
Log:
Fix r286819 (accidentally patched multiple times.
Modified:
cfe/trunk/test/CodeGenOpenCL/kernel-arg-info-single-as.cl
Modified: cfe/trunk/test/CodeGenOpenCL/
Author: pjaaskel
Date: Mon Nov 14 07:08:30 2016
New Revision: 286819
URL: http://llvm.org/viewvc/llvm-project?rev=286819&view=rev
Log:
[OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD
It doesn't make sense to use the target's address space ids in this context as
this is metada
1 - 100 of 149 matches
Mail list logo
