Author: krasimir
Date: Wed Mar 8 02:55:12 2017
New Revision: 297261
URL: http://llvm.org/viewvc/llvm-project?rev=297261&view=rev
Log:
[clang-format] Enable comment reflowing in multiline comments containing pragmas
Summary:
This patch enables comment reflowing of lines not matching the comment p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297261: [clang-format] Enable comment reflowing in multiline
comments containing pragmas (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D30697?vs=90864&id=90984#toc
Repositor
Author: krasimir
Date: Wed Mar 8 02:58:44 2017
New Revision: 297262
URL: http://llvm.org/viewvc/llvm-project?rev=297262&view=rev
Log:
[clang-format] Reformat BreakableToken.h; NFC
Modified:
cfe/trunk/lib/Format/BreakableToken.h
Modified: cfe/trunk/lib/Format/BreakableToken.h
URL:
http://ll
Author: krasimir
Date: Wed Mar 8 03:02:39 2017
New Revision: 297263
URL: http://llvm.org/viewvc/llvm-project?rev=297263&view=rev
Log:
[clang-format] Fix parameter name comment; NFC
Modified:
cfe/trunk/lib/Format/UnwrappedLineFormatter.cpp
Modified: cfe/trunk/lib/Format/UnwrappedLineFormatte
hokein added a comment.
> We may want to track individual occurrences (line number, full type info)
> and aggregate this during mapreduce, but that's not done here.
Seems reasonable. So we will introduce a new structure to track these
occurrences? Or reuse the `SymbolInfo::Signals`?
Author: hahnfeld
Date: Wed Mar 8 03:07:33 2017
New Revision: 297264
URL: http://llvm.org/viewvc/llvm-project?rev=297264&view=rev
Log:
[test] Unbreak OpenMP/linking.c with arch-specific libdir
After rL296927, -rpath gets added after linking the OpenMP runtime.
That's why -lgcc does not immediatel
Author: krasimir
Date: Wed Mar 8 03:13:25 2017
New Revision: 297265
URL: http://llvm.org/viewvc/llvm-project?rev=297265&view=rev
Log:
[clang-format] Fixed a typo in Format.cpp and a clang-tidy nit about
std::function copying; NFC
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trun
Author: rizsotto
Date: Wed Mar 8 03:27:53 2017
New Revision: 297266
URL: http://llvm.org/viewvc/llvm-project?rev=297266&view=rev
Log:
[scan-build-py] fix some line separator issues
Differential Revision: https://reviews.llvm.org/D30600
Modified:
cfe/trunk/tools/scan-build-py/libear/__init__
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/TokenAnnotator.cpp:1056
+} else if (Current.is(tok::exclaim)) {
+ if (Style.Language == FormatStyle::LK_JavaScript) {
+if (Curre
Hahnfeld updated this revision to Diff 90987.
Hahnfeld added a comment.
Rebase for recent refactoring and ping.
https://reviews.llvm.org/D30087
Files:
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChains/CommonArgs.h
lib/Driver/ToolChains/Darwin.cpp
lib/Driver/ToolChains/FreeBSD.c
erikjv added a comment.
@kfunk yes and yes, so @bkramer or @klimek : ping?
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Wed Mar 8 03:49:12 2017
New Revision: 297268
URL: http://llvm.org/viewvc/llvm-project?rev=297268&view=rev
Log:
clang-format: Get slightly better at understanding */&.
Before:
void f() { MACRO(A * const a); }
After:
void f() { MACRO(A *const a); }
Modified:
cfe/tru
mprobst marked 2 inline comments as done.
mprobst added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1056
+} else if (Current.is(tok::exclaim)) {
+ if (Style.Language == FormatStyle::LK_JavaScript) {
+if (Current.Previous &&
djasper
mprobst updated this revision to Diff 90988.
mprobst marked an inline comment as done.
mprobst added a comment.
- Introduce TT_JsNonNullAssertion to centralize determining token types.
- Move up language specific code in determineTokenType.
https://reviews.llvm.org/D30705
Files:
lib/Format/Fo
sammccall updated this revision to Diff 90990.
sammccall added a comment.
Address review comments. Uncovered two bugs:
- accidentally casting through bool: EXPECT_EQ(1, hasSymbol) was a lie
- we were double counting uses of typedefs where the underlying type was built
in, because qualType(hasDec
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D30685#695284, @hokein wrote:
> > We may want to track individual occurrences (line number, full type info)
> > and aggregate this during mapreduce, but that's not done here.
>
> Seems reasonable.
bkramer added a comment.
I assume this is fine but I don't really understand what's going on. A test
case would be great.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
klimek added a comment.
Is the diff view on phab broken, or am I missing something? I only see a single
line of diff now, and don't see a way to change the diff.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:852
+ bool CanBreakProtrudingToken =
+ State.Stack.empty() || (!State.Stack.back().NoLineBreak &&
+ !State.Stack.back().NoLineBreakInOperand);
I thin
erikjv added a comment.
@klimek no, it's a 1 line fix. The rest was the previous version of the patch.
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hahnfeld
Date: Wed Mar 8 06:06:44 2017
New Revision: 297271
URL: http://llvm.org/viewvc/llvm-project?rev=297271&view=rev
Log:
[XRay] Use AddCXXStdlibLibArgs. NFCI.
This function already does the very same thing.
Modified:
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
Modified: cfe/trunk/
klimek added a comment.
In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote:
> I think we should refactor this check as part of Static Analyzer, since it's
> path-sensitive.
Are you saying it should be path sensitive? Because currently it's not, right?
https://reviews.llvm.org/D
tyomitch added a comment.
When compiling for softfp targets, this new warning doesn't make sense: there
are no VFP registers to save.
Jonathan, would you please conditionalize it to only affect hardfp targets?
https://reviews.llvm.org/D28820
___
cf
Hahnfeld added a comment.
No build system will ever set `-frtlib-add-rpath` to enable this "feature". I'm
for keeping this opt-out until we have configuration files to set this by
default. Making it opt-in would weaken its main reason of existence: Not to
break simple binaries for the user, and
Hahnfeld created this revision.
Herald added a reviewer: EricWF.
libc++ may be installed there as a runtime library.
https://reviews.llvm.org/D30733
Files:
lib/Driver/ToolChain.cpp
Index: lib/Driver/ToolChain.cpp
===
--- lib/Dr
bkramer added a comment.
Generally makes sense. Is there any reason for the #ifdef? Windows has errno
and EINTR too.
Repository:
rL LLVM
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
mboehme added a comment.
In https://reviews.llvm.org/D30650#695350, @klimek wrote:
> In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote:
>
> > I think we should refactor this check as part of Static Analyzer, since
> > it's path-sensitive.
>
>
> Are you saying it should be path sen
Author: mboehme
Date: Wed Mar 8 06:34:51 2017
New Revision: 297272
URL: http://llvm.org/viewvc/llvm-project?rev=297272&view=rev
Log:
[clang-tidy] misc-use-after-move: Fix failing assertion
Summary:
I've added a test case that (without the fix) triggers the assertion,
which happens when a move ha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297272: [clang-tidy] misc-use-after-move: Fix failing
assertion (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D30650?vs=90692&id=90997#toc
Repository:
rL LLVM
https://revi
krasimir updated this revision to Diff 90999.
krasimir added a comment.
- Remove empty stack check
https://reviews.llvm.org/D30575
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297274: [clang-format] Look at NoLineBreak and
NoLineBreakInOperand before… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D30575?vs=90999&id=91000#toc
Repository:
rL LLVM
Author: krasimir
Date: Wed Mar 8 06:54:50 2017
New Revision: 297274
URL: http://llvm.org/viewvc/llvm-project?rev=297274&view=rev
Log:
[clang-format] Look at NoLineBreak and NoLineBreakInOperand before
breakProtrudingToken
Summary:
This patch makes ContinuationIndenter call breakProtrudingToken
sylvestre.ledru created this revision.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D30734
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
===
--- include
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Please upload patches with full context or use arc
(https://secure.phabricator.com/book/phabricator/article/arcanist/).
Generally looks good, just minor comments.
Comment
sylvestre.ledru updated this revision to Diff 91002.
sylvestre.ledru added a comment.
with the changes, I will land it now
https://reviews.llvm.org/D30734
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
Author: sylvestre
Date: Wed Mar 8 07:24:46 2017
New Revision: 297275
URL: http://llvm.org/viewvc/llvm-project?rev=297275&view=rev
Log:
Add more examples to clang-format configuration
Reviewers: djasper
Reviewed By: djasper
Subscribers: cfe-commits, klimek
Differential Revision: https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297275: Add more examples to clang-format configuration
(authored by sylvestre).
Changed prior to commit:
https://reviews.llvm.org/D30734?vs=91002&id=91003#toc
Repository:
rL LLVM
https://reviews.ll
jroelofs added a comment.
In https://reviews.llvm.org/D28820#695356, @tyomitch wrote:
> When compiling for softfp targets, this new warning doesn't make sense: there
> are no VFP registers to save.
> Jonathan, would you please conditionalize it to only affect hardfp targets?
Sure, I can do th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297276: Honor __unaligned in codegen for declarations and
expressions (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D30166?vs=89989&id=91005#toc
Repository:
rL LLVM
https
Author: rogfer01
Date: Wed Mar 8 08:00:44 2017
New Revision: 297276
URL: http://llvm.org/viewvc/llvm-project?rev=297276&view=rev
Log:
Honor __unaligned in codegen for declarations and expressions
This patch honors the unaligned type qualifier (currently available through he
keyword __unaligned a
ioeric created this revision.
Just realized the implementation is missing...
https://reviews.llvm.org/D30735
Files:
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTest.cpp
=
ioeric updated this revision to Diff 91010.
ioeric added a comment.
- Removed unnecessary variable.
https://reviews.llvm.org/D30735
Files:
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTest.cpp
==
Hi Marshall,
2017-03-08 15:47 GMT+01:00 Marshall Clow :
> I'm having trouble building libunwind this morning (on a Mac).
Ah, thanks for reporting. I only tested this on FreeBSD and CloudABI.
On those systems we don't build Unwind_AppleExtras.cpp.
> /Sources/LLVM/llvm/projects/libunwind/src/EHHea
Hi Asiri,
2017-03-07 20:42 GMT+01:00 Asiri Rathnayake :
> Could you please always include cfe-commits as a subscriber in you phab
> reviews?
>
> We would like to be aware of these changes in advance before they land.
Sure thing! I'll try to do that from now on.
That said, if the policy is to add
arphaman added a comment.
You should also add a test for `enum E : unsigned`.
https://reviews.llvm.org/D30729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: danielmarjamaki
Date: Wed Mar 8 09:22:24 2017
New Revision: 297283
URL: http://llvm.org/viewvc/llvm-project?rev=297283&view=rev
Log:
[analyzer] Clarify 'uninitialized function argument' messages
Differential Revision: https://reviews.llvm.org/D30341
Modified:
cfe/trunk/lib/StaticAna
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297283: [analyzer] Clarify 'uninitialized function argument'
messages (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D30341?vs=90471&id=91012#toc
Repository:
rL LLVM
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D30675#695370, @bkramer wrote:
> Generally makes sense. Is there any reason for the #ifdef? Windows has errno
> and EINTR too.
I have no reasonable expectation that getline will produce a EINTR on Windows.
But perhaps there's no
filcab added inline comments.
Comment at: test/CodeGenObjC/ubsan-bool.m:26
+ // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize
+ // OBJC: call void @__ubsan_handle_load_invalid_value
+
jroelofs wrote:
> vsk wrote:
> > jroelofs wrote:
> > > vsk wrote
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D30735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: ioeric
Date: Wed Mar 8 09:53:10 2017
New Revision: 297289
URL: http://llvm.org/viewvc/llvm-project?rev=297289&view=rev
Log:
Add missing implementation for AtomicChange::replace(...)
Summary: Just realized the implementation is missing...
Reviewers: klimek
Reviewed By: klimek
Subscribe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297289: Add missing implementation for
AtomicChange::replace(...) (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D30735?vs=91010&id=91020#toc
Repository:
rL LLVM
https://rev
Author: compnerd
Date: Wed Mar 8 10:03:27 2017
New Revision: 297291
URL: http://llvm.org/viewvc/llvm-project?rev=297291&view=rev
Log:
DARWF: silence some warnings about conversions
Add a check for an overflow and explicitly cast the value. We would
have silently overflowed previously.
Modified
fpetrogalli created this revision.
Herald added subscribers: rengolin, aemerson.
This patch enables the code generation of vector function names that are
described by attaching a "#pragma omp declare simd" directive to the
scalar function definition/declaration, for the Advanced SIMD (NEON)
vector
filcab added inline comments.
Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:39
+ // CHECK-NOT: !nosanitize
+ return s->e3;
+}
Add checks/check-nots to make sure the thing you don't want isn't emitted, not
just `!nosanitize`
The checks help document what you'
sylvestre.ledru created this revision.
For example, "int\* a;" is displayed instead of "int* a;"
https://reviews.llvm.org/D30740
Files:
docs/ClangFormatStyleOptions.rst
docs/tools/dump_format_style.py
Index: docs/ClangFormatStyleOptions.rst
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM once Ben has no other comments. Be careful before submitting it (this
patch also changes the interface).
https://reviews.llvm.org/D30685
__
@Renato: What's your take on Ed's idea?
We use phab for all sorts of reviews, but it should be possible to figure
out which repository a review is intended to land on and add cfe-commits or
llvm-commits appropriately.
Although, for throw-away reviews, it might generate too much spam.
Cheers,
/
fhahn added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6664
+
+ static void
+ emitTargetDeclareSimdFunction(const FunctionDecl *FD, llvm::Function *Fn,
Shouldn't this indentation be on the same level as namespace{}?
https://reviews.llvm.org/
vsk added inline comments.
Comment at: test/CodeGenObjC/ubsan-bool.m:26
+ // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize
+ // OBJC: call void @__ubsan_handle_load_invalid_value
+
filcab wrote:
> jroelofs wrote:
> > vsk wrote:
> > > jroelofs wrote
hokein added inline comments.
Comment at: include-fixer/FuzzySymbolIndex.cpp:138
+return llvm::errorCodeToError(Buffer.getError());
+ return std::unique_ptr(new MemSymbolIndex(
+ find_all_symbols::ReadSymbolInfosFromYAML(Buffer.get()->getBuffer(;
ni
vsk added a comment.
In https://reviews.llvm.org/D30729#695463, @arphaman wrote:
> You should also add a test for `enum E : unsigned`.
Ubsan doesn't try to infer the range of enums with a fixed, underlying type.
I'll add a test case to make sure we don't insert a check.
Com
vsk updated this revision to Diff 91030.
vsk added a comment.
- Make check-not's a bit stricter per Filipe's comment.
- Add a negative test for fixed enums.
https://reviews.llvm.org/D30729
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCXX/ubsan-bitfields.cpp
Ind
filcab added a comment.
LGTM since my issue is only an issue on ObjC platforms and it seems those are
the semantics it should have there.
Comment at: test/CodeGenObjC/ubsan-bool.m:26
+ // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize
+ // OBJC: call void @__ubsa
bkramer accepted this revision.
bkramer added a comment.
lg
https://reviews.llvm.org/D30685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
In https://reviews.llvm.org/D30423#695608, @filcab wrote:
> LGTM since my issue is only an issue on ObjC platforms and it seems those are
> the semantics it should have there.
Thanks for the review.
> P.S: If it documented that the only possible values for BOOL are YES an
fpetrogalli updated this revision to Diff 91035.
fpetrogalli marked an inline comment as done.
fpetrogalli added a comment.
Changes:
- fixed formatting;
- added two tests that were missing.
https://reviews.llvm.org/D30739
Files:
lib/Basic/Targets.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
test/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297298: [ubsan] Detect UB loads from bitfields (authored by
vedantk).
Changed prior to commit:
https://reviews.llvm.org/D30423?vs=90869&id=91041#toc
Repository:
rL LLVM
https://reviews.llvm.org/D304
Author: vedantk
Date: Wed Mar 8 11:38:57 2017
New Revision: 297298
URL: http://llvm.org/viewvc/llvm-project?rev=297298&view=rev
Log:
[ubsan] Detect UB loads from bitfields
It's possible to load out-of-range values from bitfields backed by a
boolean or an enum. Check for UB loads from bitfields.
sammccall updated this revision to Diff 91042.
sammccall marked 4 inline comments as done.
sammccall added a comment.
Address review comments.
https://reviews.llvm.org/D30720
Files:
include-fixer/CMakeLists.txt
include-fixer/FuzzySymbolIndex.cpp
include-fixer/FuzzySymbolIndex.h
include-
sammccall added a comment.
Thanks for the comments!
Comment at: include-fixer/SymbolIndexManager.cpp:106
// Match the identifier name without qualifier.
- if (Symbol.getName() == Names.back()) {
-bool IsMatched = true;
hokein wrote:
> Just w
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D30650#695350, @klimek wrote:
> In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote:
>
> > I think we should refactor this check as part of Static Analyzer, since
> > it's path-sensitive.
>
>
> Are you saying it should be p
idlecode created this revision.
Lexer::GetBeginningOfToken produced invalid location when
backtracking across escaped new lines.
This fixes PR26228
https://reviews.llvm.org/D30748
Files:
lib/Lex/Lexer.cpp
unittests/Lex/LexerTest.cpp
Index: unittests/Lex/LexerTest.cpp
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: ericwf
Date: Wed Mar 8 14:06:01 2017
New Revision: 297306
URL: http://llvm.org/viewvc/llvm-project?rev=297306&view=rev
Log:
Fix PR32183 - Wrap GCC exception implementation in missing namespace std
Modified:
libcxx/trunk/src/support/runtime/exception_glibcxx.ipp
libcxx/trunk/src/s
kzhuravl created this revision.
Herald added subscribers: mgorny, wdng, sdardis.
- Mips is architecture, not a toolchain
- Might help eliminate the confusion in the future by not having header files
with the same name
https://reviews.llvm.org/D30753
Files:
lib/Driver/CMakeLists.txt
lib/Dri
dlj accepted this revision.
dlj added a comment.
This revision is now accepted and ready to land.
Looks like a good improvement. Sorry for the confusion.
https://reviews.llvm.org/D30753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
mgorny added a comment.
@compnerd, I presume that the option would do nothing when using
`-rtlib=libgcc`, correct? Or do we support combining libgcc with another
unwinder?
https://reviews.llvm.org/D25402
___
cfe-commits mailing list
cfe-commits@li
Author: rizsotto
Date: Wed Mar 8 15:18:51 2017
New Revision: 297307
URL: http://llvm.org/viewvc/llvm-project?rev=297307&view=rev
Log:
[scan-build-py] move argument parsing into separate module
Differential Revision: https://reviews.llvm.org/D30601
Modified:
cfe/trunk/tools/scan-build-py/bin
Author: rizsotto
Date: Wed Mar 8 15:22:32 2017
New Revision: 297308
URL: http://llvm.org/viewvc/llvm-project?rev=297308&view=rev
Log:
[scan-build-py] move argument parsing into separate module
Forgot to add the new module.
Added:
cfe/trunk/tools/scan-build-py/libscanbuild/arguments.py
Adde
EricWF added a comment.
This LGTM, but I don't know enough Clang to be 100% on it. Perhaps somebody
else could give it a quick second look?
Comment at: lib/Sema/SemaCoroutine.cpp:157
+ if (S.RequireCompleteType(Loc, CoroHandleType,
+diag::err_corou
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thi has been committed in r290505.
https://reviews.llvm.org/D22862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
On second thought if @rsmith already reviewed most of this offline then I feel
comfortable giving it the thumbs up.
https://reviews.llvm.org/D26316
Author: alexfh
Date: Wed Mar 8 16:19:55 2017
New Revision: 297311
URL: http://llvm.org/viewvc/llvm-project?rev=297311&view=rev
Log:
[clang-tidy] readability-function-size: remove default param count threshold
Modified:
clang-tools-extra/trunk/clang-tidy/readability/FunctionSizeCheck.cpp
Mod
Author: kzhuravl
Date: Wed Mar 8 16:36:04 2017
New Revision: 297312
URL: http://llvm.org/viewvc/llvm-project?rev=297312&view=rev
Log:
Driver/ToolChains: Mips -> MipsLinux
- Mips is architecture, not a toolchain
- Might help eliminate the confusion in the future by not having header files
wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297312: Driver/ToolChains: Mips -> MipsLinux (authored by
kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D30753?vs=91060&id=91078#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3075
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D30740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: rsmith
Date: Wed Mar 8 17:00:26 2017
New Revision: 297316
URL: http://llvm.org/viewvc/llvm-project?rev=297316&view=rev
Log:
Take into account C++17's noexcept function types during merging -- it should
be possible to merge a declaration with an unresolved function type against one
with a
vsk created this revision.
Teach UBSan how to detect violations of the _Nonnull annotation when
passing arguments to callees, in assignments, and in return stmts.
Because _Nonnull does not affect IRGen, the new checks are disabled by
default. The new driver flags are:
-fsanitize=nullability-ar
EricWF added a comment.
@GorNishanov You forgot to update `test/SemaCXX/coreturn.cpp`.
https://reviews.llvm.org/D26316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini created this revision.
Both libc++ and libc++abi export a weak definition of operator
new/delete. On Darwin, this can often cause dirty __DATA in the
shared cache when having to switch from one to the other. Instead,
libc++ should reexport libc++abi's implementation of these symbols.
mehdi_amini added a comment.
Note: this is already shipping like this for ~2 years in our OSes.
https://reviews.llvm.org/D30765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
srhines added a comment.
You probably want to remove the Change-Id section above in your description (or
at least drop that when you finally submit this to libc++).
https://reviews.llvm.org/D30764
___
cfe-commits mailing list
cfe-commits@lists.llvm
ahatanak created this revision.
This patch adds support for a new attribute that will be used to distinguish
between extensible and inextensible enums. The attribute was discussed on
cfe-dev a few weeks ago and I've made a few modifications to the original
proposal based on the feedback I recei
Author: kzhuravl
Date: Wed Mar 8 17:56:48 2017
New Revision: 297321
URL: http://llvm.org/viewvc/llvm-project?rev=297321&view=rev
Log:
[DebugInfo] Add address space when creating DIDerivedTypes
Differential Revision: https://reviews.llvm.org/D29671
Added:
cfe/trunk/test/CodeGenOpenCL/amdgpu-
Author: dblaikie
Date: Wed Mar 8 17:57:08 2017
New Revision: 297322
URL: http://llvm.org/viewvc/llvm-project?rev=297322&view=rev
Log:
Defensively ensure that GetExternalDeclStmt protects itself from nested
deserialization
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/tr
aprantl added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:98
+ pointer as a function parameter which is annotated with ``_Nonnull``,
+ or assigning null to a lvalue marked ``_Nonnull``. You can enable
+ just the return value check with ``-fsanitiz
Author: zaks
Date: Wed Mar 8 18:01:07 2017
New Revision: 297324
URL: http://llvm.org/viewvc/llvm-project?rev=297324&view=rev
Log:
[analyzer] Add bug visitor for taint checker.
Add a bug visitor to the taint checker to make it easy to distinguish where
the tainted value originated. This is especi
Author: zaks
Date: Wed Mar 8 18:01:10 2017
New Revision: 297325
URL: http://llvm.org/viewvc/llvm-project?rev=297325&view=rev
Log:
[analyzer] Improve usability of ExprInspectionChecker
Some of the magic functions take arguments of arbitrary type. However,
for semantic correctness, the compiler st
1 - 100 of 145 matches
Mail list logo
