This revision was automatically updated to reflect the committed changes.
Closed by commit rC325175: [Debug] Annotate compiler generated range-for loop
variables. (authored by mattd, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42813
Files:
include/clang/Sema/Scope.h
lib
Author: mattd
Date: Wed Feb 14 13:22:11 2018
New Revision: 325175
URL: http://llvm.org/viewvc/llvm-project?rev=325175&view=rev
Log:
[Debug] Annotate compiler generated range-for loop variables.
Summary:
This change aims to simplify debugging by annotating the range-for loop
artificial variables
modocache updated this revision to Diff 134304.
modocache added a comment.
Thanks for the review, @GorNishanov, and for pointing out that part of the
standard! I added a reference to the implicit object parameter, as well as some
tests for that behavior. And thanks for pointing out the flaw in
MaskRay updated this revision to Diff 134305.
MaskRay marked 2 inline comments as done.
MaskRay added a comment.
Add an option `Suggest`.
Only suggest P0214 alternatives if it is true.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLi
simark updated this revision to Diff 134306.
simark added a comment.
Generate Hover by pretty-printing the AST
This new version of the patch generates the hover by pretty-printing the AST.
The unit tests are updated accordingly. There are some inconsistencies in how
things are printed. For exam
krytarowski added a comment.
It looks good to me, I can land this for you.
https://reviews.llvm.org/D43279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t-tye requested changes to this revision.
t-tye added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/AMDGPU.cpp:362
+Builder.defineMacro(Twine("__") + Twine(GPUName));
+Builder.defineMacro(Twine("__") + Twine(GPUName) + Twine
simark added inline comments.
Comment at: unittests/clangd/XRefsTests.cpp:561
+
+EXPECT_EQ(H.contents.value, Test.expectedHover.str()) << Test.input;
+ }
Note that I used `.str()` here to make the output of failing tests readable and
useful. By default, gt
t-tye accepted this revision.
t-tye added a comment.
For now seems reasonable to fix amdgpu as PIC. If/when other clients of amdgpu
have tool chains defined then can switch to controling in the toolchain
isPICDefault() function.
https://reviews.llvm.org/D43094
__
Author: vitalybuka
Date: Wed Feb 14 14:41:15 2018
New Revision: 325182
URL: http://llvm.org/viewvc/llvm-project?rev=325182&view=rev
Log:
[ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK
Summary:
TypeID summaries are used by CFI and need to be serialized by ThinLTO
indexing for
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325182: [ThinLTO/CFI] Include TYPE_ID summaries into
GLOBALVAL_SUMMARY_BLOCK (authored by vitalybuka, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325182: [ThinLTO/CFI] Include TYPE_ID summaries into
GLOBALVAL_SUMMARY_BLOCK (authored by vitalybuka, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42611?vs=134317&id=134321#toc
Re
Author: vitalybuka
Date: Wed Feb 14 14:52:49 2018
New Revision: 325184
URL: http://llvm.org/viewvc/llvm-project?rev=325184&view=rev
Log:
Moved CHECK in test closer to source code
Modified:
cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
Modified: cfe/trunk/test/CodeGen/thinlto-distr
vitalybuka marked an inline comment as done.
vitalybuka added inline comments.
Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll:59
+ ; Check that the call was devirtualized.
+ ; CHECK-IR: %call = tail call i32 @_ZN1A1nEi
+ %1 = tail call { i8*, i1 } @llvm.type.
rnk created this revision.
rnk added a reviewer: rsmith.
When the C++ committee changed the wording around non-type template
arguments, they naively thought that every global declarations address
would be a constant expression, but this is not the case. There is no
PE/COFF relocation that allows
eandrews created this revision.
eandrews added reviewers: rsmith, aaron.ballman, erichkeane.
This patch is related to https://reviews.llvm.org/rC325081
The patch improves documentation for the attribute and removes reference to GCC
documentation.
https://reviews.llvm.org/D43321
Files:
inclu
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D43321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: erichkeane
Date: Wed Feb 14 15:00:31 2018
New Revision: 325186
URL: http://llvm.org/viewvc/llvm-project?rev=325186&view=rev
Log:
Improve documentation for attribute artificial
This patch is related to https://reviews.llvm.org/rC325081
The patch improves documentation for the attribute an
apazos added inline comments.
Comment at: lib/Basic/Targets/RISCV.h:85
+ bool hasInt128Type(const LangOptions &Opts) const override {
+return Opts.UseInt128;
+ }
kito-cheng wrote:
> efriedma wrote:
> > Maybe make this a cross-platform flag, rather than risc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325186: Improve documentation for attribute artificial
(authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43321
Files:
include/clang/Basic/AttrDocs.td
Index: i
krytarowski added inline comments.
Comment at: FreeBSD.cpp:397
Res |= SanitizerKind::FuzzerNoLink;
+if (IsX86_64)
+Res |= SanitizerKind::Memory;
I would keep it in a dedicated `if (IsX86_64)` (similar to NetBSD). Otherwise
it looks fine.
Repos
Quuxplusone created this revision.
Quuxplusone added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds two new diagnostics, which are off by default:
**-Wreturn-std-move**
Diagnose cases of `return x` or `throw x`, where `x` is the name of a local
variable or parameter,
devnexen updated this revision to Diff 134331.
https://reviews.llvm.org/D43148
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/Driver/ToolChains/FreeBSD.cpp
+++ lib/Driver/ToolChains/
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:23
+def warn_return_std_move : Warning<
+ "adding 'std::move' here would select a better conversion sequence">,
+ InGroup, DefaultIgnore;
Can we say something like "local varia
kzhuravl updated this revision to Diff 134335.
kzhuravl edited the summary of this revision.
kzhuravl added a comment.
Address review feedback.
https://reviews.llvm.org/D36802
Files:
lib/Basic/Targets/AMDGPU.cpp
lib/Basic/Targets/AMDGPU.h
test/Driver/amdgpu-macros.cl
Index: test/Driver/a
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: kzhuravl
Date: Wed Feb 14 16:20:26 2018
New Revision: 325193
URL: http://llvm.org/viewvc/llvm-project?rev=325193&view=rev
Log:
AMDGPU: Cleanup most of the macros
- Insert __AMD__ macro
- Insert __AMDGPU__ macro
- Insert __devicename__ macro
- Add missing tests for arch macros
Differentia
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325193: AMDGPU: Cleanup most of the macros (authored by
kzhuravl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D36802?vs=134335&id=134336#to
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:10166-10182
+EvalInfo Info(Ctx, Result, EvalInfo::EM_ConstantFold);
+Info.IsNonTypeTemplateArgument = true;
+LValue LV;
+if (!EvaluateLValue(this, LV, Info) || Result.HasSideEffects ||
+
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:10166-10182
+EvalInfo Info(Ctx, Result, EvalInfo::EM_ConstantFold);
+Info.IsNonTypeTemplateArgument = true;
+LValue LV;
+if (!EvaluateLValue(this, LV, Info) || Result.HasSideEffects ||
+
Author: rsmith
Date: Wed Feb 14 17:01:06 2018
New Revision: 325195
URL: http://llvm.org/viewvc/llvm-project?rev=325195&view=rev
Log:
Add missing definition for class static after r325193.
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.cpp
Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp
URL:
Author: kzhuravl
Date: Wed Feb 14 17:01:53 2018
New Revision: 325196
URL: http://llvm.org/viewvc/llvm-project?rev=325196&view=rev
Log:
AMDGPU: Enable PIC by default for amdgcn
Differential Revision: https://reviews.llvm.org/D43094
Added:
cfe/trunk/test/Driver/amdgcn-toolchain-pic.cl
Modified
NoQ updated this revision to Diff 134341.
NoQ added a comment.
All right, so the assertion that we actually destroy all temporaries in our
`InitializedTemporaries` map is still violated quite often - every time we do
any sort of lifetime extension, we're actually calling the destructor on a
di
NoQ updated this revision to Diff 134346.
NoQ added a comment.
Update the comment with some thoughts from
http://lists.llvm.org/pipermail/cfe-dev/2018-February/056898.html
https://reviews.llvm.org/D42876
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer
NoQ updated this revision to Diff 134351.
NoQ added a comment.
Whoops - recall that we still need to cleanup the temporaries map even, now
that we know that we cannot assert that it's already empty. Clean up the map
and enable the assertion that becomes tautological until the respective FIXME
i
Author: kzhuravl
Date: Wed Feb 14 18:27:45 2018
New Revision: 325200
URL: http://llvm.org/viewvc/llvm-project?rev=325200&view=rev
Log:
Revert r325193 as it breaks buildbots
Removed:
cfe/trunk/test/Driver/amdgpu-macros.cl
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.cpp
cfe/trunk/lib/B
Author: dergachev
Date: Wed Feb 14 18:30:20 2018
New Revision: 325201
URL: http://llvm.org/viewvc/llvm-project?rev=325201&view=rev
Log:
[analyzer] NFC: Remove dead checks when computing DeclStmt construction region.
In CFG, every DeclStmt has exactly one decl, which is always a variable.
It is a
Author: dergachev
Date: Wed Feb 14 18:32:32 2018
New Revision: 325202
URL: http://llvm.org/viewvc/llvm-project?rev=325202&view=rev
Log:
[analyzer] Allow inlining constructors into return values.
This only affects the cfg-temporary-dtors mode - in this mode we begin inlining
constructors that are
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325196: AMDGPU: Enable PIC by default for amdgcn (authored
by kzhuravl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43094?vs=133520&id=134
I did not see this. I will reapply the patch. Sorry for the noise.
From: cfe-commits on behalf of Richard
Smith via cfe-commits
Sent: Wednesday, February 14, 2018 8:01 PM
To: cfe-commits@lists.llvm.org
Subject: r325195 - Add missing definition for class static af
Author: kzhuravl
Date: Wed Feb 14 18:37:04 2018
New Revision: 325203
URL: http://llvm.org/viewvc/llvm-project?rev=325203&view=rev
Log:
Reapply r325193
Added:
cfe/trunk/test/Driver/amdgpu-macros.cl
- copied unchanged from r325199, cfe/trunk/test/Driver/amdgpu-macros.cl
Modified:
cfe/
Author: ericwf
Date: Wed Feb 14 18:41:19 2018
New Revision: 325205
URL: http://llvm.org/viewvc/llvm-project?rev=325205&view=rev
Log:
Fix test failure on compilers w/o deduction guides
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp
libcxx/tr
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Committed this but put a wrong phabricator link in the commit message, sorry >_<
https://reviews.llvm.org/rC325202
https://reviews.llvm.org/D42876
___
pcc added a comment.
Herald added subscribers: llvm-commits, mehdi_amini.
Maybe I'm missing something, but I don't see why we need this attribute.
Couldn't clang have been changed to implement `-ftrap-function` by generating a
call to the trap function instead of emitting an `llvm.trap` intrinsi
Author: dergachev
Date: Wed Feb 14 18:51:58 2018
New Revision: 325209
URL: http://llvm.org/viewvc/llvm-project?rev=325209&view=rev
Log:
[analyzer] Decide on inlining destructors via EvalCallOptions.
EvalCallOptions were introduced in r324018 for allowing various parts of
ExprEngine to notify the
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325209: [analyzer] Decide on inlining destructors via
EvalCallOptions. (authored by dergachev, committed by ).
Herald adde
NoQ added a comment.
https://reviews.llvm.org/rC325202 is attached to this revision accidentally; it
should have been attached to https://reviews.llvm.org/D42876.
Repository:
rL LLVM
https://reviews.llvm.org/D42875
___
cfe-commits mailing list
c
It could, but then you'd need to change every front end to have the same
sort of behavior, maybe you want to configure it differently, etc.
That said, I really have no strong opinions here :)
-eric
On Wed, Feb 14, 2018 at 6:51 PM Peter Collingbourne via Phabricator <
revi...@reviews.llvm.org> wr
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325210: [CFG] Provide construction contexts for temproary
objects. (authored by dergachev, committed by ).
Repository:
Author: dergachev
Date: Wed Feb 14 19:13:36 2018
New Revision: 325210
URL: http://llvm.org/viewvc/llvm-project?rev=325210&view=rev
Log:
[CFG] Provide construction contexts for temproary objects.
Constructors of C++ temporary objects that have destructors now can be queried
to discover that they'r
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325210: [CFG] Provide construction contexts for temproary
objects. (authored by dergachev, committed by ).
Herald added a
Author: dergachev
Date: Wed Feb 14 19:26:43 2018
New Revision: 325211
URL: http://llvm.org/viewvc/llvm-project?rev=325211&view=rev
Log:
[analyzer] Inline constructors for destroyable temporaries.
Since r325210, in cfg-temporary-dtors mode, we can rely on the CFG to tell us
that we're indeed const
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325211: [analyzer] Inline constructors for destroyable
temporaries. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43
nruslan updated this revision to Diff 134377.
nruslan marked 3 inline comments as done.
nruslan added a comment.
Added mstack-arg-probe, tests, and changes related to other comments of the
reviewers
https://reviews.llvm.org/D43108
Files:
docs/ClangCommandLineReference.rst
include/clang/Dri
nruslan added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4038
+ if (Args.hasArg(options::OPT_mno_stack_arg_probe))
+CmdArgs.push_back("-mno-stack-arg-probe");
+
hans wrote:
> I think you can just do
>
> ```
> Args.AddLastArg(CmdArgs, optio
ahatanak added a comment.
AMDGPUAnnotateKernelFeatures::addFeatureAttributes looks for an llvm.trap
instruction and adds attribute "amdgpu-queue-ptr" to the function if it finds
one.
Other than that, it looks like your idea would work too.
Repository:
rL LLVM
https://reviews.llvm.org/D1083
nruslan added a comment.
@hans: I responded to the comments and also updated diff for clang with new
changes.
https://reviews.llvm.org/D43108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
On Wed, Feb 14, 2018 at 10:45 AM Ilya Biryukov wrote:
> Personally, I'm not a big fan of environment variables. There are harder
> to discover than command-line flags and I still have to change editor
> config often to switch between different builds of clangd.
> I know it may sound weird, but ma
101 - 158 of 158 matches
Mail list logo
