Szelethus planned changes to this revision.
Szelethus added a comment.
I'll put this patch on hold while I'm investigating the issue @xazax.hun
mentioned.
Mind you, again, other patches don't depend strictly on this part, I'll only
need to change the for loop. Hopefully. You never know.
grimar added a comment.
In https://reviews.llvm.org/D52296#1281642, @echristo wrote:
> Can you elaborate on your motivations and what you're trying to do?
>
> Thanks!
We want to see:
- No extra files. The compiler produces just a .o.
- The linker leaves most debug info in the .o files.
That m
JonasToth added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:158
+ *Result.Context)
+ .empty()) {
+ diag(ArgExpr->getBeginLoc(), Message);
astrelni wrote:
> JonasToth wrote:
> > You could ellide
JonasToth updated this revision to Diff 171947.
JonasToth added a comment.
- Merge branch 'master' into experiment_isolate_decl
- remove unused matcher
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/I
phosek updated this revision to Diff 171948.
phosek marked 2 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D53854
Files:
clang/lib/Driver/ToolChains/Fuchsia.cpp
clang/test/Driver/fuchsia.cpp
Index: clang/test/Driver/fuchsia.cpp
===
On Wed, Oct 31, 2018 at 7:39 AM wrote:
> Also, don't we usually put ABI changes under an ABI compatibility check?
> This would be making Clang incompatible with itself.
>
I don't think it's worth it because nobody can use i128 in a meaningful way
on x64 Windows right now. If you do i128 multipli
Author: jonastoth
Date: Wed Oct 31 09:50:44 2018
New Revision: 345735
URL: http://llvm.org/viewvc/llvm-project?rev=345735&view=rev
Log:
[clang-tidy] new check 'readability-isolate-declaration'
Summary:
This patch introduces a new clang-tidy check that matches on all `declStmt`
that declare more
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345735: [clang-tidy] new check
'readability-isolate-declaration' (authored by JonasToth, committed
by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51949
F
Author: jonastoth
Date: Wed Oct 31 09:59:41 2018
New Revision: 345736
URL: http://llvm.org/viewvc/llvm-project?rev=345736&view=rev
Log:
[clang-tools-extra] fix broken link in release notes
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseN
Author: jonastoth
Date: Wed Oct 31 10:00:50 2018
New Revision: 345737
URL: http://llvm.org/viewvc/llvm-project?rev=345737&view=rev
Log:
[clang] try-fix broken documentation builder
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewv
Author: jonastoth
Date: Wed Oct 31 10:08:09 2018
New Revision: 345738
URL: http://llvm.org/viewvc/llvm-project?rev=345738&view=rev
Log:
[clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp
M
ymandel marked 4 inline comments as done.
ymandel added a comment.
Aaron, Jonas,
Thank you both so much for being fantastic reviewers! This was my first
experience contributing to clang (upstream) and it has been extremely positive.
In https://reviews.llvm.org/D53025#1282194, @aaron.ballman wr
steveire added inline comments.
Comment at: clang-tidy/ClangTidy.h:11
+//
+// It should remain as stable as possible, as many out-of-tree checks exist.
+//===--===//
Clang C++ code does not have
shafik added a comment.
I am happy to discuss and review a revised version of this change.
Repository:
rC Clang
https://reviews.llvm.org/D44100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Szelethus created this revision.
Szelethus added a reviewer: dblaikie.
Herald added subscribers: cfe-commits, dkrupp.
I'm currently working on including macro expansions in the Static Analyzer's
plist output, where I can only access a `const SourceManager`.
Repository:
rC Clang
https://revie
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks fine
Repository:
rC Clang
https://reviews.llvm.org/D53940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Szelethus added a comment.
Thanks! That was super fast!
Repository:
rC Clang
https://reviews.llvm.org/D53940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie added a comment.
In https://reviews.llvm.org/D52296#1282369, @grimar wrote:
> In https://reviews.llvm.org/D52296#1281642, @echristo wrote:
>
> > Can you elaborate on your motivations and what you're trying to do?
> >
> > Thanks!
>
>
> We want to see:
>
> - No extra files. The compiler pr
ilya-biryukov created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
A prototype that I made a while ago and never landed.
Not suppossed to be a final solution and will probably merge-conflict now,
publishing to not loose it.
Repository:
rC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345741: [Lex] Make MacroDirective::findDirectiveAtLoc take
const SourceManager (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
Author: szelethus
Date: Wed Oct 31 10:19:20 2018
New Revision: 345741
URL: http://llvm.org/viewvc/llvm-project?rev=345741&view=rev
Log:
[Lex] Make MacroDirective::findDirectiveAtLoc take const SourceManager
I'm currently working on including macro expansions in the Static Analyzer's
plist output,
craig.topper added a comment.
Retitling to just the x86-64 case. 32-bit mode has issues on arguments too I
think and will need more work. The IsIllegalVectorType function is a member of
the X86_64ABIInfo so we need to refactor or add a new one for 32-bit.
Repository:
rC Clang
https://review
Author: jonastoth
Date: Wed Oct 31 10:26:10 2018
New Revision: 345742
URL: http://llvm.org/viewvc/llvm-project?rev=345742&view=rev
Log:
[clang-tidy] add missing '--' in RUN-line, unbreak buildbot
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp
Modified:
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:16411
// this constant. Skip this enum since it may be ill-formed.
-if (!ECD) {
- return;
-}
+if (!ECD) return;
probably don't need to adjust this line
Repository:
Author: george.karpenkov
Date: Wed Oct 31 10:38:29 2018
New Revision: 345746
URL: http://llvm.org/viewvc/llvm-project?rev=345746&view=rev
Log:
[analyzer] RetainCountChecker: for now, do not trust the summaries of inlined
code
Trusting summaries of inlined code would require a more thorough work,
Author: george.karpenkov
Date: Wed Oct 31 10:38:12 2018
New Revision: 345745
URL: http://llvm.org/viewvc/llvm-project?rev=345745&view=rev
Log:
[analyzer] Enable retain count checking for OSObject by defa
The FP rate seems to be good enough now.
Differential Revision: https://reviews.llvm.org/D53
Author: george.karpenkov
Date: Wed Oct 31 10:38:46 2018
New Revision: 345747
URL: http://llvm.org/viewvc/llvm-project?rev=345747&view=rev
Log:
[analyzer] Re-add custom OSIterator rule for RetainCountChecker
Turns out the rule is quite ubiquitous.
Revert of https://reviews.llvm.org/D53628
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345746: [analyzer] RetainCountChecker: for now, do not trust
the summaries of inlined… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
htt
Szelethus updated this revision to Diff 171962.
Szelethus added a comment.
Fixes according to @xazax.hun's remarks. Thanks for catching that, it was a
non-trivial cornercase!
- Now I'm acquiring the macro directive history, and choosing the appropriate
macro definition in `getMacroNameAndInfo`
Author: rnk
Date: Wed Oct 31 10:43:55 2018
New Revision: 345748
URL: http://llvm.org/viewvc/llvm-project?rev=345748&view=rev
Log:
Re-land r345676 "[Win64] Handle passing i128 by value"
Fix the unintended switch/case fallthrough to avoid changing long double
behavior.
Added:
cfe/trunk/test/Co
Szelethus marked 10 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:667
+
+//===--===//
+// Declarations of helper functions and data structures
Szelethus added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:502
+
+ auto AssertM = callExpr(callee(functionDecl(hasName("assert";
+ auto GuardM =
Szelethus wrote:
> NoQ wrote:
> > In a lot of
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:176
+
+ Warns when the `std` namespace is used, as its use is against Zircon's libc++
+ policy for the kernel.
JonasToth wrote:
> alexfh wrote:
> > JonasToth wrote:
> > >
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D52676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: krasimir
Date: Wed Oct 31 10:56:57 2018
New Revision: 345753
URL: http://llvm.org/viewvc/llvm-project?rev=345753&view=rev
Log:
[clang-format] tweaked another case of lambda formatting
Summary:
This is done in order to improve cases where the lambda's body is moved too far
to the right. C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345753: [clang-format] tweaked another case of lambda
formatting (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52676?
yvvan added a comment.
@ilya-biryukov
As far as I understand the problem the same thing happens when you are in the
header a.h which includes b.h and b.h includes a.h at the same time. So you get
this recursion indirectly and very often because that's why include guards are
there.
Repository
probinson added a comment.
In https://reviews.llvm.org/D52296#1282458, @dblaikie wrote:
> I guess in that case your distributed build system would have a constraint
> that it always ships all the object files back to the primary machine (where
> you'd be running the debugger)? (perhaps it just
dblaikie added a comment.
In https://reviews.llvm.org/D52296#1282587, @probinson wrote:
> In https://reviews.llvm.org/D52296#1282458, @dblaikie wrote:
>
> > I guess in that case your distributed build system would have a constraint
> > that it always ships all the object files back to the primar
astrelni updated this revision to Diff 171973.
astrelni added a comment.
Combine template instantiation matching into the other matcher registration.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/UpgradeDur
astrelni marked 3 inline comments as done.
astrelni added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:158
+ *Result.Context)
+ .empty()) {
+ diag(ArgExpr->getBeginLoc(), Message);
JonasToth wro
void updated this revision to Diff 171976.
void retitled this revision from "Compound literals and enums require constant
inits" to "Compound literals, global array decls, and enums require constant
inits".
void edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.or
void added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:16411
// this constant. Skip this enum since it may be ill-formed.
-if (!ECD) {
- return;
-}
+if (!ECD) return;
nickdesaulniers wrote:
> probably don't need to adjust this line
probinson added a comment.
In https://reviews.llvm.org/D52296#1282589, @dblaikie wrote:
> In https://reviews.llvm.org/D52296#1282587, @probinson wrote:
>
> > Any distributed build has to make this work, so the paths in the line table
> > are usable. Not clear what you're thinking might be the p
aaron.ballman added a comment.
In https://reviews.llvm.org/D53025#1282423, @ymandel wrote:
> Aaron, Jonas,
>
> Thank you both so much for being fantastic reviewers! This was my first
> experience contributing to clang (upstream) and it has been extremely
> positive.
Congratulations on contri
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: kadircet, jfb, arphaman, jkorous, MaskRay, ioeric,
javed.absar.
NFC on the LSP level, only produces notifications in the C++ API.
Useful for the clients of the C++ API that provide an indicat
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.h:77
+class DiagnosticsResult {
+public:
To avoid boilerplate this could be changed to:
```
using DiagnosticsResult = Optional>;
```
Would still keep it a named typedef to allow documenting wh
sammccall added inline comments.
Comment at: clang-tidy/ClangTidy.h:11
+//
+// It should remain as stable as possible, as many out-of-tree checks exist.
+//===--===//
steveire wrote:
> Clang C++
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345760: [ASTImporter][Structural Eq] Check for
isBeingDefined (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53697?vs=171723&id=171984#toc
Repository:
rC Cla
Author: martong
Date: Wed Oct 31 11:46:13 2018
New Revision: 345760
URL: http://llvm.org/viewvc/llvm-project?rev=345760&view=rev
Log:
[ASTImporter][Structural Eq] Check for isBeingDefined
Summary:
If one definition is currently being defined, we do not compare for
equality and we assume that the
JonasToth added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:167
+// likely needed.
+diag(ArgExpr->getBeginLoc(), Message);
+return;
Minor, but you can move `diag(...)` out the if condition like this:
```
auto Di
ymandel updated this revision to Diff 171985.
ymandel marked an inline comment as done.
ymandel added a comment.
Rebased patch onto trunk.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstReturnTyp
gtbercea updated this revision to Diff 171988.
gtbercea added a comment.
Address comments.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
Files:
libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
libomptarget/deviceRTLs/nvptx/src/interface.h
libomptarget/deviceRTLs/nvptx/src/
dblaikie added a comment.
In https://reviews.llvm.org/D52296#1282603, @probinson wrote:
> In https://reviews.llvm.org/D52296#1282589, @dblaikie wrote:
>
> > In https://reviews.llvm.org/D52296#1282587, @probinson wrote:
> >
> > > Any distributed build has to make this work, so the paths in the lin
ABataev added inline comments.
Comment at: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu:442
+}
+ } while (!FrameP);
Do you realy need the loop here? Seems to me it is better to have it in `else`
branch of the `if (IsWarpMaster)` statement
Repositor
efriedma added a comment.
As far as I know, according to the ABI docs, it's impossible to return a
256-bit vector from a function if AVX is disabled.
Given that we aren't rejecting the testcase, we're effectively implementing a
new "no-AVX" ABI variant. That variant is not defined anywhere, so
lebedev.ri created this revision.
lebedev.ri added reviewers: rsmith, regehr, vsk, rjmccall, Sanitizers.
lebedev.ri added projects: clang, Sanitizers.
Not yet for an //actual// review, needs tests.
As reported by @regehr (thanks!) on twitter
(https://twitter.com/johnregehr/status/105768149625581
JonasToth added a comment.
Thank you very much for contributing to LLVM/clang-tidy! More patches are
always welcome ;)
I found one issue we have overseen that should be fixed. Would you be so kind
and do that before comitting?
Comment at: test/clang-tidy/readability-const-re
Author: aaronballman
Date: Wed Oct 31 12:11:38 2018
New Revision: 345764
URL: http://llvm.org/viewvc/llvm-project?rev=345764&view=rev
Log:
Implement the readability-const-return-type check.
This check flags function top-level const-qualified return types and suggests
removing the mostly-superflu
JonasToth added inline comments.
Comment at: test/clang-tidy/readability-const-return-type.cpp:6
+
+#include
+
JonasToth wrote:
> One nit: system headers are not allowed in clang-tidy tests. We do mock the
> required content. Sorry that I overlooked that.
>
>
aaron.ballman closed this revision.
aaron.ballman added a comment.
In https://reviews.llvm.org/D53025#1282668, @ymandel wrote:
> Rebased patch onto trunk.
Thanks! I've commit in r345764. If there are any issues with your patch, I'll
revert and let you know what's going on. You're also welcome
hjl.tools added a comment.
In https://reviews.llvm.org/D53919#1282692, @efriedma wrote:
> As far as I know, according to the ABI docs, it's impossible to return a
> 256-bit vector from a function if AVX is disabled.
>
> Given that we aren't rejecting the testcase, we're effectively implementing
JonasToth added a comment.
Don't mind my last nit, we are doing this slight modification.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
efriedma added a comment.
Whatever you call it, the question remains; what specification and/or compiler
are we trying to be compatible with?
Repository:
rC Clang
https://reviews.llvm.org/D53919
___
cfe-commits mailing list
cfe-commits@lists.llv
Author: aaronballman
Date: Wed Oct 31 12:17:44 2018
New Revision: 345766
URL: http://llvm.org/viewvc/llvm-project?rev=345766&view=rev
Log:
Removing a reliance on system headers from this test; NFC.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-const-return-type.cpp
Modified:
aaron.ballman added a comment.
In https://reviews.llvm.org/D53025#1282720, @JonasToth wrote:
> Thank you very much for contributing to LLVM/clang-tidy! More patches are
> always welcome ;)
>
> I found one issue we have overseen that should be fixed. Would you be so kind
> and do that before com
hjl.tools added a comment.
In https://reviews.llvm.org/D53919#1282734, @efriedma wrote:
> Whatever you call it, the question remains; what specification and/or
> compiler are we trying to be compatible with?
The ABI before AVX was introduced.
Repository:
rC Clang
https://reviews.llvm.org/
sammccall added a comment.
Discussed offline a bit. We should be judicious with intrusive changes to
support out-of-tree clients, and this interface seems a bit messy.
There are alternatives with advantages:
1. less intrusive: clients can create a context before calling addDocument and
observe
leonardchan marked 2 inline comments as done.
leonardchan added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:102-104
+ Actions.PushExpressionEvaluationContext(
+ Actions.ExprEvalContexts.back().Context);
ParenBraceBracketBalancer BalancerRAIIObj(*this);
-
efriedma added a comment.
The ABI document before AVX was introduced didn't say anything at all about
256-bit vectors. So we're talking about compatibility with some other
compiler. Which compiler?
Repository:
rC Clang
https://reviews.llvm.org/D53919
___
xbolva00 added a comment.
Are you still looking at this?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 171993.
gtbercea added a comment.
Move while on else branch.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
Files:
libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
libomptarget/deviceRTLs/nvptx/src/interface.h
libomptarget/deviceRTLs/nvp
JonasToth added a comment.
I am, but this revision relies on support on the analysis in the
frontend. This seems currently stalled as the developer there seems busy
with other stuff.
Once i implement transofmration-capabilites i will evaluate if there are
any false-positives that would break. Onc
mgrang updated this revision to Diff 171994.
mgrang retitled this revision from "[COFF, ARM64] Add aarch64_seh_recoverfp
intrinsic" to "[COFF, ARM64] Support SEH for ARM64 Windows".
mgrang edited the summary of this revision.
mgrang added a comment.
Updated the patch with the following changes:
ABataev added inline comments.
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:159
omptarget_nvptx_threadPrivateContext->Level1TaskDescr(threadId);
- ASSERT0(LT_FUSSY, newTaskDescr, "expected a task descr");
newTaskDescr->InitLevelOneTaskDescr(ThreadLi
hjl.tools added a comment.
In https://reviews.llvm.org/D53919#1282748, @efriedma wrote:
> The ABI document before AVX was introduced didn't say anything at all about
> 256-bit vectors. So we're talking about compatibility with some other
> compiler. Which compiler?
X86-64 compilers created
aaron.ballman added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:151-152
+ const auto *ArgExpr = Result.Nodes.getNodeAs("arg");
+ llvm::StringRef Message = "perform explicit cast on expression getting "
+"implici
tlively added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:12528
+ case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4:
+ case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: {
Value *Src = EmitScalarExpr(E->getArg(0));
aheejin wrote:
aheejin added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:12528
+ case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4:
+ case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: {
Value *Src = EmitScalarExpr(E->getArg(0));
tlively wrote:
efriedma added a comment.
I just tried clang 3.3, and as far as I can tell it behaves the same way as
trunk.
If the argument is that we should be compatible with gcc on Linux, that's fine,
but we should explicitly state that in a comment.
Repository:
rC Clang
https://reviews.llvm.org/D5391
efriedma added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:471
+ }
+ EH |= SEHExceptions;
+
I'm suspicious about adding a new default for AArch64 specifically; why do we
need this if x86-64 doesn't?
https://reviews.llvm.org/D53541
___
rjmccall added a comment.
Seems reasonable to me.
Repository:
rC Clang
https://reviews.llvm.org/D53925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hjl.tools added a comment.
In https://reviews.llvm.org/D53919#1282797, @efriedma wrote:
> I just tried clang 3.3, and as far as I can tell it behaves the same way as
> trunk.
>
> If the argument is that we should be compatible with gcc on Linux, that's
> fine, but we should explicitly state tha
astrelni updated this revision to Diff 172000.
astrelni marked 2 inline comments as done.
astrelni added a comment.
Reply to review comments:
- minor code reorder
- improve test coverage
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLi
astrelni added inline comments.
Comment at: test/clang-tidy/abseil-upgrade-duration-conversions.cpp:142
+
+template void templateForOpsSpecialization(T) {}
+template <>
JonasToth wrote:
> astrelni wrote:
> > JonasToth wrote:
> > > what about non-type template pa
efriedma added a comment.
No, AVX512 wasn't even announced when clang 3.3 came out.
Repository:
rC Clang
https://reviews.llvm.org/D53919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev updated this revision to Diff 172003.
ABataev added a comment.
Updated processing of the debug options. -g1 (line-tables) is considered as the
regular debug directive, which may emit some useful debug info.
Repository:
rC Clang
https://reviews.llvm.org/D51554
Files:
include/clang/
hjl.tools added a comment.
In https://reviews.llvm.org/D53919#1282811, @efriedma wrote:
> No, AVX512 wasn't even announced when clang 3.3 came out.
Try this with clang 3.3 and clang 7.0.
[hjl@gnu-cfl-1 tmp]$ cat z.c
typedef int __attribute__((mode(SI))) si;
typedef si __attribute__((vector_siz
astrelni updated this revision to Diff 172005.
astrelni marked 3 inline comments as done.
astrelni added a comment.
Reply to comments:
- Change diagnostic message
- Update documentation
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLis
astrelni added inline comments.
Comment at: docs/clang-tidy/checks/abseil-upgrade-duration-conversions.rst:22
+prevent unintended behavior. Passing an argument of class type will result in
+compile error, even if the type is implicitly convertible to an arithmetic
type.
+
--
ilya-biryukov updated this revision to Diff 172006.
ilya-biryukov added a comment.
- Instead of changing the interface, added a test we can rely on Context to
give us what we need
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53946
Files:
unittests/clangd/ClangdTests.cpp
I
gtbercea updated this revision to Diff 172007.
gtbercea added a comment.
Reinstate assert.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
Files:
libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
libomptarget/deviceRTLs/nvptx/src/interface.h
libomptarget/deviceRTLs/nvptx/src/
ilya-biryukov added a comment.
Added a test that the context behaves the way we want it to.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
gtbercea marked an inline comment as done.
gtbercea added inline comments.
Comment at: libomptarget/deviceRTLs/nvptx/src/supporti.h:191
PRINT(LD_MEM, "malloc data of size %zu for %s: 0x%llx\n", size, msg,
P64(ptr));
- ASSERT(LT_SAFETY, ptr, "failed to allocate %zu bytes for
ilya-biryukov updated this revision to Diff 172008.
ilya-biryukov added a comment.
- Fix a typo
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53946
Files:
unittests/clangd/ClangdTests.cpp
Index: unittests/clangd/ClangdTests.cpp
==
Author: rsmith
Date: Wed Oct 31 13:39:26 2018
New Revision: 345774
URL: http://llvm.org/viewvc/llvm-project?rev=345774&view=rev
Log:
Part of PR39508: Emit an @llvm.invariant.start after storing to
__tls_guard.
__tls_guard can only ever transition from 0 to 1, and only once. This
permits LLVM to r
ilya-biryukov added a comment.
In https://reviews.llvm.org/D53866#1282582, @yvvan wrote:
> @ilya-biryukov
> As far as I understand the problem the same thing happens when you are in
> the header a.h which includes b.h and b.h includes a.h at the same time. So
> you get this recursion indirect
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5266-5268
+ bool VisitConstantExpr(const ConstantExpr *E) {
+return Visit(E->getSubExpr());
+ }
This shouldn't be necessary because you changed the CRTP base class
`ExprEvaluatorBase` to do
regehr added a comment.
I can test this and write a few test cases.
Repository:
rC Clang
https://reviews.llvm.org/D53949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
Looks good once some tests are added.
Repository:
rC Clang
https://reviews.llvm.org/D53949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 287 matches
Mail list logo
