rnk added a comment.
Want to stamp this? It's 4pm on the Friday before Christmas, what could go
wrong? :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55853/new/
https://reviews.llvm.org/D55853
___
cfe-commits mailing list
cfe-commits@lis
dberris added inline comments.
Comment at: lib/xray/xray_defs.h:22
+#if !SANITIZER_NETBSD
+#define XRAY_TLS_ALIGNAS(x) alignas(x)
krytarowski wrote:
> I would switch the order, in order to remove unneeded negation.
>
> ```
> #if SANITIZER_NETBSD
> ...
> #else
tra updated this revision to Diff 179387.
tra added a comment.
Fixed a typo.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56033/new/
https://reviews.llvm.org/D56033
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGenCUDA/device-stub.cu
Index: clang/test/CodeGenCUDA/dev
rsmith added a comment.
>> I think there is a case to be made for warning on this specific language
>> feature, because using CTAD on class templates that weren't designed for it
>> is dangerous and creates source compatibility problems for future changes to
>> that library.
>
> Personally I w
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with `s/ConstantExpr/FullExpr/`.
Comment at: clang/lib/AST/Expr.cpp:2550
}
+if (ConstantExpr *CE = dyn_cast(E)) {
+ E = CE->getSubExpr();
NoQ updated this revision to Diff 179389.
NoQ added a comment.
Herald added a subscriber: jfb.
Add a denote - express test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55875/new/
https://reviews.llvm.org/D55875
Files:
lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp
lib/Stat
Author: tra
Date: Fri Dec 21 17:11:09 2018
New Revision: 349981
URL: http://llvm.org/viewvc/llvm-project?rev=349981&view=rev
Log:
[CUDA] Treat extern global variable shadows same as regular extern vars.
This fixes compiler crash when we attempted to compile this code:
extern __device__ int data;
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349981: [CUDA] Treat extern global variable shadows same as
regular extern vars. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, george.karpenkov, a_sidorin,
rnkovacs, mikhail.ramalho, baloghadamsoftware.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
a.sidorin, szepet.
All right guys, now this one's weird.
This patch looks fairl
Author: dergachev
Date: Fri Dec 21 18:06:51 2018
New Revision: 349984
URL: http://llvm.org/viewvc/llvm-project?rev=349984&view=rev
Log:
[analyzer] pr38668: Do not attempt to cast loaded integers to floats.
This patch is a different approach to landing the reverted r349701.
It is expected to have
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349984: [analyzer] pr38668: Do not attempt to cast loaded
integers to floats. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349986: [gn build] Add build files for
clang/lib/{ASTMatchers,CrossTU}… (authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D559
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349987: [gn build] Add build file for clang/lib/ARCMigrate
(authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55979?vs=179231&
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349988: [gn build] Add build file for clang/lib/FrontendTool
(authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55980?vs=17923
phosek created this revision.
phosek added a reviewer: echristo.
Herald added a subscriber: cfe-commits.
Using static library is already a default. This makes it easier to change the
parameter type in the future.
Repository:
rC Clang
https://reviews.llvm.org/D56043
Files:
clang/lib/Driver
phosek created this revision.
phosek added a reviewer: echristo.
Herald added subscribers: cfe-commits, atanasyan, jrtc27, dberris, sdardis.
This change introduces support for object files in addition to static
and shared libraries which were already supported which requires
changing the type of t
thakis marked 2 inline comments as done.
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn:6
+
+files = [
+ "adxintrin.h",
phosek wrote:
> Why not just inline this? This variable doesn't seem to be used from anywhere
>
thakis updated this revision to Diff 179404.
thakis marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55981/new/
https://reviews.llvm.org/D55981
Files:
llvm/utils/gn/secondary/BUILD.gn
llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
llvm/utils/gn/se
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55981/new/
https://reviews.llvm.org/D55981
___
cfe-commits mailing list
cfe-commits@l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349991: [gn build] Add build files for clang,
clang-offload-bundler, and… (authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349992: [gn build] Embed __TEXT __info_plist section into
clang binary on macOS (authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
101 - 121 of 121 matches
Mail list logo