[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 266880. pestctrl added a comment. clang-format for the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

samparker accepted this revision. samparker added a comment. This revision is now accepted and ready to land. > csilUcUsUiUlhfPcPsQcQsQiQlQUcQUsQUiQUlQhQfQPcQPs. I cry inside every time I see those wonderful strings, but oh well... probably best to appease the lint gods before committing. Repo

[PATCH] D80725: [Analyzer][StreamChecker] Updated initialization of BugType's.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. BugType objects

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266883. MyDeveloperDay added a comment. That's a rotate! Remove the multiple swap functions for a single rotateTokens function (Thanks for the inspiration @curdeius) extract the various combination of 2,3,4,5 qualifier types to a simple begin and en

[PATCH] D80727: AMDGPU: Add intrinsic for s_setreg

arsenm created this revision. arsenm added reviewers: rampitec, yaxunl, kerbowa. Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: LLVM. This will be more useful with fenv access implemented. https://reviews.llvm.org/D80727 F

[clang-tools-extra] 8e325cf - [clangd] Work around PS4 -fno-exceptions, easier than disabling tests?

Author: Sam McCall Date: 2020-05-28T17:14:23+02:00 New Revision: 8e325cfc1456820e2253909e4aa0c3014f1e050c URL: https://github.com/llvm/llvm-project/commit/8e325cfc1456820e2253909e4aa0c3014f1e050c DIFF: https://github.com/llvm/llvm-project/commit/8e325cfc1456820e2253909e4aa0c3014f1e050c.diff LO

Re: [PATCH] D78454: [clangd] Highlight related control flow.

Added workaround in 6dd1629770d686831bdb2649650b86c37f0f7091 - will look at disabling tests properly tomorrow. On Thu, May 28, 2020 at 4:55 PM Sam McCall wrote: > On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < > revi...@reviews.llvm.org> wrote: > >> russell.gallop added a comme

RE: [PATCH] D78454: [clangd] Highlight related control flow.

Hi Sam, Thanks for looking at this. You could use something like in clang/ ./unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp: if (llvm::Triple(llvm::sys::getDefaultTargetTriple()).isPS4()) return; // PS4 does not support fastcall. Regards Russ From: Sam McCall Sent: 28 May 20

[clang] 04a96aa - [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

Author: Yitzhak Mandelbaum Date: 2020-05-28T11:18:37-04:00 New Revision: 04a96aa3e430a66767732f44acea00c6e13c9f78 URL: https://github.com/llvm/llvm-project/commit/04a96aa3e430a66767732f44acea00c6e13c9f78 DIFF: https://github.com/llvm/llvm-project/commit/04a96aa3e430a66767732f44acea00c6e13c9f78.

Re: [PATCH] D78454: [clangd] Highlight related control flow.

On Thu, May 28, 2020 at 5:17 PM Gallop, Russell wrote: > Hi Sam, > > > > Thanks for looking at this. You could use something like in clang/ > ./unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp: > > > > if (llvm::Triple(llvm::sys::getDefaultTargetTriple()).isPS4()) > > return; // PS

[PATCH] D80725: [Analyzer][StreamChecker] Updated initialization of BugType's.

balazske added a comment. Why is `BuiltinBug` used instead of `BugType`? The differentiation between these classes looks not obvious. There is even a non-virtual `getDescription` function in both classes and a confusion with meaning of "name" and "description". Repository: rG LLVM Github Mo

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

curdeius marked an inline comment as done. curdeius added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:195 +FormatToken *Tok) { + // We only need to think about streams that begin with const. + if (!Tok->is(tok::kw_const))

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

alanphipps added a comment. clang/test/CodeGen/sanitize-coverage.c is also failing our downstream embedded ARMv7 validations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 _

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266887. oontvoo marked 2 inline comments as done. oontvoo added a comment. Change tests to us no/matchesObjC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: cl

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/Decl.cpp:4129 SourceRange TagDecl::getSourceRange() const { - SourceLocation RBraceLoc = BraceRange.getEnd(); - SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation();

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266890. vsavchenko added a comment. Fix code review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: llvm/cmake/modules/AddLLVM.cmake:1916 endif() - if(EXISTS "${path}/.svn") -set(svn_files Nit: can this be in a

[clang] ce5780b - [libTooling] Fix Transformer to work with ambient traversal kinds.

Author: Yitzhak Mandelbaum Date: 2020-05-28T11:42:07-04:00 New Revision: ce5780b88c6e2f3303afd266e5e29c1badd9eb3b URL: https://github.com/llvm/llvm-project/commit/ce5780b88c6e2f3303afd266e5e29c1badd9eb3b DIFF: https://github.com/llvm/llvm-project/commit/ce5780b88c6e2f3303afd266e5e29c1badd9eb3b.

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG04a96aa3e430: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher` (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5780b88c6e: [libTooling] Fix Transformer to work with ambient traversal kinds. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/n

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver added a comment. In D79628#2060254 , @alanphipps wrote: > clang/test/CodeGen/sanitize-coverage.c is also failing our downstream > embedded ARMv7 validations. https://reviews.llvm.org/D80668 has been submitted. It would be good if someone with ac

[clang] bb2ae74 - [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs

Author: Valeriy Savchenko Date: 2020-05-28T18:54:27+03:00 New Revision: bb2ae74717a25ba268e7bd17a2a572d931ed094e URL: https://github.com/llvm/llvm-project/commit/bb2ae74717a25ba268e7bd17a2a572d931ed094e DIFF: https://github.com/llvm/llvm-project/commit/bb2ae74717a25ba268e7bd17a2a572d931ed094e.d

[clang] 1f57d76 - [analyzer] Refactor range inference for symbolic expressions

Author: Valeriy Savchenko Date: 2020-05-28T18:54:52+03:00 New Revision: 1f57d76a8dd00611aaa4b33048be195ea9a2dc44 URL: https://github.com/llvm/llvm-project/commit/1f57d76a8dd00611aaa4b33048be195ea9a2dc44 DIFF: https://github.com/llvm/llvm-project/commit/1f57d76a8dd00611aaa4b33048be195ea9a2dc44.d

[clang] 47c4b8b - [analyzer] Generalize bitwise OR rules for ranges

Author: Valeriy Savchenko Date: 2020-05-28T18:55:22+03:00 New Revision: 47c4b8bd68698b1827f39c3056783ed042faf718 URL: https://github.com/llvm/llvm-project/commit/47c4b8bd68698b1827f39c3056783ed042faf718 DIFF: https://github.com/llvm/llvm-project/commit/47c4b8bd68698b1827f39c3056783ed042faf718.d

[clang] 2a09daf - [analyzer] Generalize bitwise AND rules for ranges

Author: Valeriy Savchenko Date: 2020-05-28T18:55:49+03:00 New Revision: 2a09daff0f902e70a08f2b30f3461fb8848f5ab1 URL: https://github.com/llvm/llvm-project/commit/2a09daff0f902e70a08f2b30f3461fb8848f5ab1 DIFF: https://github.com/llvm/llvm-project/commit/2a09daff0f902e70a08f2b30f3461fb8848f5ab1.d

[clang] 73c120a - [analyzer] Introduce reasoning about symbolic remainder operator

Author: Valeriy Savchenko Date: 2020-05-28T18:56:38+03:00 New Revision: 73c120a9895a7e12e3c29a755d64096c8bd0220f URL: https://github.com/llvm/llvm-project/commit/73c120a9895a7e12e3c29a755d64096c8bd0220f DIFF: https://github.com/llvm/llvm-project/commit/73c120a9895a7e12e3c29a755d64096c8bd0220f.d

[clang] 3549227 - Remove WrapperMatcherInterface

Author: Dmitri Gribenko Date: 2020-05-28T17:58:29+02:00 New Revision: 35492270ed705ea9ac98ba04c6fda1adafef613a URL: https://github.com/llvm/llvm-project/commit/35492270ed705ea9ac98ba04c6fda1adafef613a DIFF: https://github.com/llvm/llvm-project/commit/35492270ed705ea9ac98ba04c6fda1adafef613a.dif

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. > @MyDeveloperDay , @Typz -- could you please take a look at these two issues > and give your feedback? (E) looks pretty bad. I'm not familiar enough with > this patch to judge how easy / hard would it be to mitigate these. I agree 'E' is a regression from r

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for use_device_addr clause. The components of the list items are mapped as a kind of RETURN components and then the returned base a

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius added inline comments. Comment at: clang/docs/tools/generate_formatted_state.py:17 +with open(DOC_FILE, 'wb') as output: +output.write(".. raw:: html\n") +output.write("\n") It will still not work with Python 3, you need to pass `bytes` to `write

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. I wondered if it was the < and [] causing issues return aaagggbbb ? ccceeeddd ? 0 : 2 : fff ? 1 : 2; but it seem its not return aaagggbbb ? ccceeeddd ? 0 : 2 : fff

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, baloghadamsoftware wrote: > NoQ wrote: > > balazske wr

[PATCH] D80731: Improve test infrastructure in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. - Test if the code sourcing the SyntaxTree compiles - Output compiler errors and warnings to err - Fix tests with code that did not compile Repository

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

sammccall added inline comments. Comment at: clang/lib/AST/Decl.cpp:4129 SourceRange TagDecl::getSourceRange() const { - SourceLocation RBraceLoc = BraceRange.getEnd(); - SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation(); + SourceLocation E = BraceRange.getBe

[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

steven.zhang added inline comments. Comment at: clang/lib/Headers/altivec.h:13670 + ) +#elif defined(__VSX__) +#define vec_splats(N) \ I am not sure if this is by intention. It is not semantics the same with this change. Befo

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 266901. LukeZhuang added a comment. **updated: 05/28/2020** (1) remove redundant "else" according to coding standard (2) change a few document words Thank you Erich! I think removing this "else" here makes sense. CHANGES SINCE LAST ACTION https://revie

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

hokein added a comment. Friendly ping, in case it is out of your radar -- this fixes another recovery-ast crash-on-invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80221/new/ https://reviews.llvm.org/D80221 ___

[PATCH] D80733: [AST][RecoveryExpr] Build RecoveryExpr for "undef_var" cases.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. For a no-function-like unresolved expression, clang builds a TypoExpr for it, and tries to correct it afterwards. If the typo-co

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. > This change even doesn't break my local check-clang LIT tests run, but I'm > not really sure that such change is in scope of this patch, because > DiagnoseUseOfDecl contains a lot of o

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. Take a look at D80735 , it works fine for me locally. Is that what you did? What problems do you observe now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80222/new/ https://reviews.llvm

[PATCH] D80735: [OpenMP][NFC] Reuse `llvm::omp::types::IdentPtr` in clang

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, fghanim. Herald added subscribers: sstefan1, guansong, bollu, yaxunl. Herald added a project: clang. We should replace the uses of `QualType IdentQTy` with DataLayout queries encapsulated in a helper (inside `llvm::omp::types`)

[PATCH] D79156: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb2ae74717a2: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a09daff0f90: [analyzer] Generalize bitwise AND rules for ranges (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D79434?vs=264606&id=266911#toc Repository: rG LLVM Github

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c4b8bd6869: [analyzer] Generalize bitwise OR rules for ranges (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://r

[PATCH] D80704: Remove WrapperMatcherInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rG35492270ed70: Remove WrapperMatcherInterface (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80704/new/ https://reviews.llvm.org/D807

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f57d76a8dd0: [analyzer] Refactor range inference for symbolic expressions (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c120a9895a: [analyzer] Introduce reasoning about symbolic remainder operator (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/

[clang-tools-extra] 7cfdff7 - [clang-tidy] Add abseil-string-find-str-contains checker.

Author: Tom Lokovic Date: 2020-05-28T12:35:57-04:00 New Revision: 7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385 URL: https://github.com/llvm/llvm-project/commit/7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385 DIFF: https://github.com/llvm/llvm-project/commit/7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385.diff L

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

jdoerfert planned changes to this revision. jdoerfert added a comment. Herald added a subscriber: sstefan1. I think this will be fixed by D74387 , we should include the tests somewhere though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

JakeMerdichAMD added a comment. Great idea on this! I may borrow this idea and make something similar for some migrations I'm working on. Sanity check: is this going to be run automatically when docs are generated or done offline with results committed? I don't have a preference, either has pro

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 added a comment. In D80222#2060420 , @jdoerfert wrote: > Take a look at D80735 , it works fine for me > locally. Is that what you did? What problems do you observe now? That's pretty much what I did. If I kept in

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:4658 bool IgnoreConstraints) { + // FIXME: continue the following steps if the type is k

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Indeed, I saw the emails, but I didn't have time to check or investigate the issues. As for E, this is more tricky than this. At the moment, the code does not look at what is in the first "branch" of the ternary operator : it does not care if this is a nested ternary oper

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong marked 7 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:697 if (auto *FD = dyn_cast(D)) { - if (S.matchesSignature(FD)) { + if (S.Sign.matches(FD) && S.validat

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Did you think about implementing it in the compiler instead of the runtime? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400 + if (OASE || OAShE || + dyn_cast(I->getAssociatedExpression())) { +DimSize++; + } ---

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong updated this revision to Diff 266918. martong marked 4 inline comments as done. martong added a comment. - Rename: validate -> checkValidity, sanityCheck -> checkSpecificValidity - Rename: Summary::checkValidity -> validateByConstraints - Add more docs to the Summary class - Rename matches

[PATCH] D80733: [AST][RecoveryExpr] Build RecoveryExpr for "undef_var" cases.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/Sema/SemaExprCXX.cpp:8310 +// to RecoveryExpr. +// FIXME: we lose source locations for RecoveryExpr, as TypoExpr doesn't +// tra

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 266921. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenM

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Regarding `?:`, this is definitely not considered, and should be relatively easy to handle. Regarding case `D`, this looks like a bug... The break in the first operand is kind of unexpected (as in "not the usual case"), and I had many such corner cases while making and te

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

ymandel added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:286 + + virtual llvm::Optional TraversalKind() const { +return {}; aaron.ballman wrote: > `traversalKind()` Stephen -- What was the resolution on this comment? I came

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cfdff7b4a67: [clang-tidy] Add abseil-string-find-str-contains checker. (authored by tdl-g, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400 + if (OASE || OAShE || + dyn_cast(I->getAssociatedExpression())) { +DimSize++; + } ABataev wrote: > Do you

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

Fznamznon added a comment. In D77918#2060446 , @jdoerfert wrote: > I think this will be fixed by D74387 , we > should include the tests somewhere though. D74387 includes a test case with

[clang] db3b970 - [analyzer] Remove unused function. NFC.

Author: Valeriy Savchenko Date: 2020-05-28T20:22:50+03:00 New Revision: db3b970a84325e326bbcec4bc3e5e663f148a481 URL: https://github.com/llvm/llvm-project/commit/db3b970a84325e326bbcec4bc3e5e663f148a481 DIFF: https://github.com/llvm/llvm-project/commit/db3b970a84325e326bbcec4bc3e5e663f148a481.d

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

jdoerfert abandoned this revision. jdoerfert added a comment. Great. I'll ask in the other patch to add these three lines just to be sure ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77918/new/ https://reviews.llvm.org/D77918 ___

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

jdoerfert added a comment. Can you include these: long double qa, qb; decltype(qa + qb) qc; double qd[sizeof(-(-(qc * 2)))]; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387

[PATCH] D80740: [SveEmitter] Add SVE ACLE for svld1ro.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. fpetrogalli added a parent revision: D80738: [llvm][SVE] IR intrinsic for LD1RO.. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

vddvss added inline comments. Comment at: clang/lib/Headers/altivec.h:13670 + ) +#elif defined(__VSX__) +#define vec_splats(N) \ steven.zhang wrote: > I am not sure if this is by intention. It is not semantics the same with th

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay added a comment. In D80627#2060463 , @JakeMerdichAMD wrote: > Great idea on this! I may borrow this idea and make something similar for > some migrations I'm working on. > > Sanity check: is this going to be run automatically when docs are

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. This passes all the tests? I think we should go with it and investigate the cast thing later. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:124 + return {FnTy, Fn}; +} } Are you sure we need to do the cast here? I

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16537 AllowWholeSizeArraySection = false; +} else if (DKind == OMPD_target_update && + SemaRef.getLangOpts().OpenMP >= 50) { cchen wrote: > ABataev wrote: > > cche

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11989 + else +return false; + rjmccall wrote: > fhahn wrote: > > rjmccall wrote: > > > I would suggest checking some preconditions and then just calling > > > `PrepareScalarCast`. > > > >

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added a comment. Yes, this passed all the tests on my machine at least. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:124 + return {FnTy, Fn}; +} } jdoerfert wrote: > Are you sure we need to

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g added a comment. We see this broke the build for shared-lib config http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/1879 Looking now (and I look forward to determining what I should have done to avoid this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 116dcbe - [analyzer] Remove unused function declaration. NFC.

Author: Valeriy Savchenko Date: 2020-05-28T20:28:17+03:00 New Revision: 116dcbebc6a1648b4acd1a1a391c1d66a3eb4b5f URL: https://github.com/llvm/llvm-project/commit/116dcbebc6a1648b4acd1a1a391c1d66a3eb4b5f DIFF: https://github.com/llvm/llvm-project/commit/116dcbebc6a1648b4acd1a1a391c1d66a3eb4b5f.d

[clang-tools-extra] a1b88af - [clang-tidy] Fix build broken by commit 7cfdff7b4a6704b8ef2a1b594e1ec19d2d89f385 (D80023)

Author: Yitzhak Mandelbaum Date: 2020-05-28T13:39:58-04:00 New Revision: a1b88afe46d7a0f72d2acd8792951bd959b27545 URL: https://github.com/llvm/llvm-project/commit/a1b88afe46d7a0f72d2acd8792951bd959b27545 DIFF: https://github.com/llvm/llvm-project/commit/a1b88afe46d7a0f72d2acd8792951bd959b27545.

[clang] 5395389 - [analyzer] SATestBuild.py: Make verbosity level a cmd option

Author: Valeriy Savchenko Date: 2020-05-28T20:47:06+03:00 New Revision: 5395389475bcaba16966ab62125f2f54ea81c915 URL: https://github.com/llvm/llvm-project/commit/5395389475bcaba16966ab62125f2f54ea81c915 DIFF: https://github.com/llvm/llvm-project/commit/5395389475bcaba16966ab62125f2f54ea81c915.d

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane added a comment. I hope that @rsmith pays particular attention here for me, I'm unable to come up with any cases where this isn't sufficient/breaks other things, but I also don't feel like I know deduction guides well enough to claim that I don't break anything :) All the lit tests

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall. erichkeane added a comment. I hope that @rsmith pays particular attention here for me, I'm unable to come up with any cases where this isn't sufficient/breaks other things, but I also don't feel like I know deduction

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266942. Fznamznon marked an inline comment as done and an inline comment as not done. Fznamznon added a comment. Included test cases from Johannes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ htt

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

ymandel added a comment. Fixed with commit a1b88afe46d7a0f72d2acd8792951bd959b27545 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80023/new/ https://reviews.llvm.org/D80023

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 added a comment. Few changes and nits then LGTM Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.cpp:25 + const SourceManager &SM) + : Check(Check), PP(PP), SM(SM) {} + nit: You don't need to store a

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:195 +FormatToken *Tok) { + // We only need to think about streams that begin with const. + if (!Tok->is(tok

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 _

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

rjmccall added a comment. Thanks, functionality is looking good for the non-assignment operators. Comment at: clang/lib/Sema/SemaExpr.cpp:12112 +return InvalidOperands(Loc, OriginalLHS, OriginalRHS); + } + You need to not actually apply this conversion to

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. I figured out what the problem is and we can relatively easily fix it *once* we always have an OpenMPIRBuilder available in Clangs CG. As noted in D80735 , we should remove `IdentQTy` as it is used to create a new ident_t in some situa

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5395389475bc: [analyzer] SATestBuild.py: Make verbosity level a cmd option (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80626/new/

[clang] 0073c29 - [clang] Avoid linking libdl unless needed

Author: Tobias Hieta Date: 2020-05-28T21:08:00+03:00 New Revision: 0073c293a401774ac96b4b3d27f05e13f379f98e URL: https://github.com/llvm/llvm-project/commit/0073c293a401774ac96b4b3d27f05e13f379f98e DIFF: https://github.com/llvm/llvm-project/commit/0073c293a401774ac96b4b3d27f05e13f379f98e.diff

[clang] 97f3f0b - AMDGPU: Add intrinsic for s_setreg

Author: Matt Arsenault Date: 2020-05-28T14:26:38-04:00 New Revision: 97f3f0bab0982f84745c7ac5ce8fb6b0918ff718 URL: https://github.com/llvm/llvm-project/commit/97f3f0bab0982f84745c7ac5ce8fb6b0918ff718 DIFF: https://github.com/llvm/llvm-project/commit/97f3f0bab0982f84745c7ac5ce8fb6b0918ff718.diff

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

njames93 updated this revision to Diff 266957. njames93 added a comment. - Renamed makeRule to buildRule to avoid ambiguity with tooling::makeRule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80697/new/ https://reviews.llvm.org/D80697 Files: cl

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference between this and the /// legacy PassManag

[PATCH] D80727: AMDGPU: Add intrinsic for s_setreg

arsenm closed this revision. arsenm added a comment. 97f3f0bab0982f84745c7ac5ce8fb6b0918ff718 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80727/new/ https://reviews.llvm.org/D80727 __

[PATCH] D80748: [clang] Add '-Wundef-prefix' warning option

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zixuw abandoned this revision. Add an `-Wundef-prefix=,...` option, which is similar to `-Wundef`, but only give warnings for undefined macros with the given prefixes. Make `-Wundef` an alias of `-W

[PATCH] D80492: Avoid linking libdl unless needed

This revision was automatically updated to reflect the committed changes. Closed by commit rG0073c293a401: [clang] Avoid linking libdl unless needed (authored by thieta, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 266976. yaxunl added a comment. Emit target id module flag metadata. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/Off

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zixuw added reviewers: ributzka, steven_wu, cishida, bruno, arphaman. Herald added a subscriber: dexonsmith. zixuw edited the summary of this revision. - Add an `-Wundef-prefix=,...` option, which i

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

ymandel added a comment. Thanks for the suggestioned change. However, I think we can do somewhat simpler. What do you think of just providing a setter on the super class void setRule(Optional Rule) { this->Rule = std::move(Rule); } Subclasses will call `setRule` in their constructor body . O

cfe-commits@lists.llvm.org

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, t.p.northover, sdesmalen, labrinea. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D80716: [AArch64]: BFlo

<    1   2   3   >