[PATCH] D83088: Introduce CfgTraits abstraction

kuhar added a comment. Hi Nicoali, In D83088#2227151 , @nhaehnle wrote: > ... > Take a look here for example: > https://github.com/nhaehnle/llvm-project/blob/715450fa7f968ceefaf9c3b04b47066866c97206/llvm/lib/Analysis/GenericConvergenceUtils.cpp#L499 > -

[PATCH] D86187: [X86] Add support 'tune' in target attribute

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D86029: [analyzer] Add modeling for unque_ptr::get()

vrnithinkumar updated this revision to Diff 286675. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. - Using conjureSymbolVal in case of missing inner pointer value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86029

[PATCH] D86029: [analyzer] Add modeling for unque_ptr::get()

vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363 + const auto *InnerPointVal = State->get(ThisRegion); + if (!InnerPointVal) +return; + xazax.hun

[PATCH] D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys

CodaFi updated this revision to Diff 286679. CodaFi retitled this revision from "[clang][Modules] Use File Names Instead of inodes As Loaded Module Keys" to "[clang][Modules] Increase the Entropy of ModuleManager Map Keys". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] c1c1bed - [c++14] Implement missed piece of N3323: use "converted constant" rules

Author: Richard Smith Date: 2020-08-19T15:45:51-07:00 New Revision: c1c1bed5d0828f1905f1e9a09a32c02f05de9b41 URL: https://github.com/llvm/llvm-project/commit/c1c1bed5d0828f1905f1e9a09a32c02f05de9b41 DIFF: https://github.com/llvm/llvm-project/commit/c1c1bed5d0828f1905f1e9a09a32c02f05de9b41.diff

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

steakhal added a comment. In D86223#2226876 , @xazax.hun wrote: > Exactly, but you could return a StringRef to static storage. > > I am fine with both approach. Whichever you find cleaner. Eh, I'm not sure if it worth it to put these into virtual function

[clang] 4a36711 - [X86] Add mtune command line test cases that should have gone with 4cbceb74bb5676d0181d4d0cab5194d90a42c2ec

Author: Craig Topper Date: 2020-08-19T15:58:06-07:00 New Revision: 4a367114397ab5d175cb8b74ee6144978e7fdeba URL: https://github.com/llvm/llvm-project/commit/4a367114397ab5d175cb8b74ee6144978e7fdeba DIFF: https://github.com/llvm/llvm-project/commit/4a367114397ab5d175cb8b74ee6144978e7fdeba.diff

[clang] 724f570 - [X86] Add support 'tune' in target attribute

Author: Craig Topper Date: 2020-08-19T15:58:19-07:00 New Revision: 724f570ad25568acc3a33dcdce9cadd776de2382 URL: https://github.com/llvm/llvm-project/commit/724f570ad25568acc3a33dcdce9cadd776de2382 DIFF: https://github.com/llvm/llvm-project/commit/724f570ad25568acc3a33dcdce9cadd776de2382.diff

[PATCH] D86187: [X86] Add support 'tune' in target attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG724f570ad255: [X86] Add support 'tune' in target attribute (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

rsmith accepted this revision. rsmith added a comment. This looks OK to me. I think we'll also need updates for `_ExtInt` now too -- we have more fundamental types with padding than only `long double` and `bool` now. (I continue to be displeased that we assume 8-bit `char` in `__builtin_bit_cas

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu updated this revision to Diff 286688. zequanwu added a comment. minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 Files: clang/include/clang/Lex/Lexer.h clang/include/clang/Lex/Preproc

[PATCH] D82860: Port ObjCMTAction to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___

[PATCH] D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys

CodaFi updated this revision to Diff 286697. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 Files: clang/include/clang/Serialization/ModuleManager.h clang/lib/Serialization/ModuleManager.cpp Index: clan

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT |

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/ https://reviews.llvm.org/D83298 __

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

kaz7 added a comment. Thank you preparing this i1 patch and doing it on clang side only. We were testing this patch and sending problem reports. Now, we can use this patch without modifying llvm code. We can define vector mask types like below. Then, we can define intrinsic functions using

[PATCH] D85692: python bindings: fix DeprecationWarning

jdenny added a comment. Does this mean we officially no longer support python 2, which this change breaks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85692/new/ https://reviews.llvm.org/D85692 ___ cf

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85706/new/ https://reviews.llvm.org/D85706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

<    1   2