[PATCH] D129691: [clang][test] fix typo in fn attr

erichkeane accepted this revision. erichkeane added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129691/new/ https://reviews.llvm.org/D129691 ___ cfe-commits mailing list

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

erichkeane added a comment. Please include the full context of the patch with -U9. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

curdeius added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:40 static unsigned getLengthToMatchingParen(const FormatToken , - const std::vector ) { + const SmallVector )

[clang] b7e77ff - Rewording "static_assert" diagnostics

Author: Muhammad Usman Shahid Date: 2022-07-14T07:47:37-04:00 New Revision: b7e77ff25fb2412f6ab6d6cc75b0e2f97bd3 URL: https://github.com/llvm/llvm-project/commit/b7e77ff25fb2412f6ab6d6cc75b0e2f97bd3 DIFF:

[PATCH] D129048: Rewording the "static_assert" to static assertion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e77ff25fb2: Rewording static_assert diagnostics (authored by Codesbyusman, committed by aaron.ballman). Changed prior to commit:

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:435 /// Used to implement lazy copy and rewriting strategies. class Future : public SExpr { public: By the way, I considered using this, but it didn't seem

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

nhaehnle added a comment. I can't judge the Clang changes. On the LLVM side, can you also add the implementation and a test for the GlobalISel path? Plus, I have some minor inline comments. Comment at: llvm/docs/LangRef.rst:24546 + +The first argument is pointer, which

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

erichkeane added a comment. I guess I don't have a good idea why this attribute would cause ODR issues? It would seem that if it appeared in 2 different TUs that we could just 'pick' whichever we wanted, right? The description in the bug report of the problem isn't clear to me what the

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin marked 4 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2933 + auto *FD = LambdaCaptureFields.lookup(BD); + assert(FD); + return EmitCapturedFieldLValue(*this, FD, CXXABIThisValue);

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan updated this revision to Diff 444638. ebevhan added a comment. Herald added a subscriber: steakhal. Rebased and addressed some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 Files:

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_update_messages.cpp:17 -static int y; -#pragma omp declare target(y) - -void yyy() { -#pragma omp target update to(y) // expected-error {{the host cannot update a declare target variable that is not

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. Appears that this regressed examples like this: // before int i = int{16} * 1024; // after int i = int{16}* 1024; Naively it looks like in all added examples, the token preceding the matching `{` of the `}` is one of `struct`, `class`, `union`, `enum`, or a

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, vsapsai, ilya-biryukov, erichkeane, iains, v.g.vassilev. ChuanqiXu added a project: clang-modules. Herald added a reviewer: aaron.ballman. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, efriedma. Herald added a reviewer: NoQ. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We might have a CK_NoOp cast

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

arsenm added a comment. In D128907#3650750 , @jdoerfert wrote: > That said, I doubt this is even what we want. Throwing away the benefits of > the noundef for one special case. IIRC, I mentioned alternatives in the other > discussion already,... not

[PATCH] D109977: LLVM Driver Multicall tool

abrachet marked an inline comment as done. abrachet added a comment. In D109977#3611683 , @mgorny wrote: > This seems to have broken standalone builds for Gentoo. > > While building Clang, I get: > > CMake Error at

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. In D127873#3651364 , @jackhong12 wrote: > I think we cannot identify `struct`, `union`, `class` or `enum` by the right > bracket. Clang-format will split the input into multiple lines. For instance > `struct Tmp {} *tmp;`

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://github.com/llvm/llvm-project/commit/b646f0955574c6ad4c156c9db522e46f597cfda9, the added regression test

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

int3 added a comment. @davide just adding you in case you have opinions on the wording around the bincompat issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129772/new/ https://reviews.llvm.org/D129772

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

int3 created this revision. int3 added reviewers: lld-macho, davide. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129772 Files:

[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

martong added a comment. Thanks, nice work! Comment at: clang/lib/AST/ASTImporter.cpp:3237 + ParentMapContext = DC->getParentASTContext().getParentMapContext(); + DynTypedNodeList P = ParentC.getParents(*S); + while (!P.empty()) {

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

skc7 updated this revision to Diff 444657. skc7 added a comment. Rebase and fix for review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128907/new/ https://reviews.llvm.org/D128907 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. In D129654#3650590 , @3405691582 wrote: > As mentioned, this replicates https://reviews.llvm.org/D126289 for OpenBSD > which fixes #28283. That particular issue caused a build problem in Swift's > use of VFS in which I verified

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. In D129832#3654066 , @MaskRay wrote: > In D129832#3654040 , @vitalybuka > wrote: > >> problem with included files that we don't know which non-inlined version of >> the function

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chapuni added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index == FDSz && It causes a

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a subscriber: teemperor. JDevlieghere added a comment. In D112374#3653702 , @mizvekov wrote: > @JDevlieghere I spent a lot of time trying to get this test running on my > machine to no avail. I think lldb build and test setup is quite

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

MaskRay created this revision. MaskRay added reviewers: Sanitizers, hctim, kstoimenov, vitalybuka. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

MaskRay added a comment. In D129832#3654040 , @vitalybuka wrote: > problem with included files that we don't know which non-inlined version of > the function will endup in the binary > so using this option, user may unintentionally disable

[PATCH] D129798: [clang-tidy] Add a "clang-" namespace prefix to the make-confusable-target executable

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added projects: LLVM,

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project:

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad updated this revision to Diff 444791. brad added a comment. Disable -pie when using -r. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 Files: clang/lib/Driver/ToolChains/Ananas.cpp

[PATCH] D129048: Rewording the "static_assert" to static assertion

ldionne added a comment. Most of the libc++ CI testing happens on BuildKite, and we only trigger the libc++ buildkite pipeline if files in `libcxx/` (and a few others) have changed. This wasn't the case here. If you want to re-land without breaking libc++, you'd have to go through libc++'s

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, beanz wrote: > Do we need this group

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444830. python3kgae marked an inline comment as done. python3kgae added a comment. Merge change from Chris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

brad added a comment. Also -stdlib=libc++ is the default on OpenBSD and FreeBSD so you can probably leave that out and I think you can remove --gcc-toolchain="". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. problem with included files that we don't know which non-inlined version of the function will endup in the binary so using this option, user may unintentionally disable instrumentation on all included headers, even when included from a different place Repository:

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu updated this revision to Diff 444880. ChuanqiXu marked 3 inline comments as done. ChuanqiXu added a comment. Address comments and remove verifier due to the automatic merging for constant expression I mentioned above. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D125291#3651640 , @nhaehnle wrote: > I can't judge the Clang changes. Now the clang part is moved to D129833 . > On the LLVM side, can you also

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

tahonermann added a comment. >> Additionally, the type of a character constant in C is int. > > This means that char32_t c4 = U'\U00064321'; is invalid in C No. A character constant that does not have an encoding prefix has type `int` in C. Character constants that have an encoding prefix have

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

efriedma added a comment. `atomicrmw add [...] sync_seq_cst` is supposed to be equivalent to `fence seq_cst; atomicrmw add seq_cst; fence seq_cst`, I think. The extra fences aren't necessary for most uses of `__sync_*`, but the difference is theoretically visible for exotic synchronization

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7c51f02effdb: [clang] Implement ElaboratedType sugaring for types written bare (authored by mizvekov). Changed prior to

[PATCH] D54214: [RISCV] Set triple based on -march flag

zixuan-wu added a comment. Herald added subscribers: sunshaoce, pcwang-thead, eopXD, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, MaskRay, arichardson. Herald added a project: All. In D54214#1737255 , @simoncook wrote: >

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. In D129748#3651771 , @erichkeane wrote: > I guess I don't have a good idea why this attribute would cause ODR issues? > It would seem that if it appeared in 2 different TUs that we could just > 'pick' whichever we wanted,

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

jasonmolenda added a comment. In D128465#3652525 , @ckissane wrote: > In D128465#3651025 , @aemerson > wrote: > >> I just reverted this in 6e6be5f9504d >>

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. I did verify that `-fvisibility=hidden` still devirtualizes, and same with `-Wl,--lto-whole-program-visibility`, but not if both are missing Comment at: llvm/lib/LTO/LTOBackend.cpp:595 + updatePublicTypeTestCalls(Mod,

[PATCH] D129772: [clang] Document -femit-compact-unwind option in the User’s Manual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dbfc4fc065d: [clang] Document -femit-compact-unwind option in the User’s Manual (authored by int3). Changed prior to commit:

[clang] 7dbfc4f - [clang] Document -femit-compact-unwind option in the User’s Manual

Author: Jez Ng Date: 2022-07-14T16:50:36-04:00 New Revision: 7dbfc4fc065d7f1bd85988351399c7fd2db1ec53 URL: https://github.com/llvm/llvm-project/commit/7dbfc4fc065d7f1bd85988351399c7fd2db1ec53 DIFF: https://github.com/llvm/llvm-project/commit/7dbfc4fc065d7f1bd85988351399c7fd2db1ec53.diff LOG:

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6318 + HelpText<"CL.EXE COMPATIBILITY OPTIONS">; + def cl_compile_Group : OptionGroup<"">, Do we need this group or can it just be `cl_Group`? Repository: rG LLVM Github

[clang] 6ab7307 - [clang-format] Fix invalid-code-generation by RemoveBracesLLVM

Author: owenca Date: 2022-07-14T15:19:57-07:00 New Revision: 6ab7307177c336d7ca5910fc434c012f35245fd1 URL: https://github.com/llvm/llvm-project/commit/6ab7307177c336d7ca5910fc434c012f35245fd1 DIFF: https://github.com/llvm/llvm-project/commit/6ab7307177c336d7ca5910fc434c012f35245fd1.diff LOG:

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

jyknight added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65697 is the relevant discussion thread that added these to GCC. I personally never found it very convincing, even back in 2015 when they first made the change. And, now, 7 years later, I'd be even more reluctant to add

[PATCH] D129742: [clang-format] Fix invalid-code-generation by RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ab7307177c3: [clang-format] Fix invalid-code-generation by RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 444820. njames93 added a comment. More code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.org/D129706 Files: clang-tools-extra/clang-tidy/GlobList.cpp

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson created this revision. Herald added a project: All. royjacobson updated this revision to Diff 444173. royjacobson added a comment. royjacobson updated this revision to Diff 19. royjacobson retitled this revision from "[WIP][Clang] Implement P0848 (Conditionally Trivial Special

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. This change works and avoids the duplicated group. The duplicated group results in the help spew duplicating the group heading, which is undesirable. diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444834. python3kgae added a comment. Remove DXCJoinedOrSeparateConflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/ https://reviews.llvm.org/D128462 Files:

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. @JDevlieghere I spent a lot of time trying to get this test running on my machine to no avail. I think lldb build and test setup is quite convoluted, fragile and antiquated. It uses many deprecated CMake features, It fails to properly link to system libraries it needs

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

jackhong12 accepted this revision. jackhong12 added a comment. I think we can also add new test cases in `clang/unittests/Format/TokenAnnotatorTest.cpp`. Tokens = annotate("int i = int{42} * 34;"); ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

mstorsjo created this revision. mstorsjo added reviewers: serge-sans-paille, sammccall, whisperity, aaron.ballman. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project:

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. Looks very promising. Comment at: clang/include/clang/Format/Format.h:396 + /// \version 15 + RequiresExpressionIndentationKind RequiresExpressionIndentation; + Please resort. Comment at:

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3653051 , @jasonmolenda wrote: > In D128465#3652525 , @ckissane > wrote: > >> In D128465#3651025 , @aemerson >> wrote: >> >>> I

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 444803. python3kgae marked an inline comment as done. python3kgae added a comment. Add CLDXCOption flag and share option with CL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128462/new/

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

dblaikie added a comment. In D125693#3648942 , @krisb wrote: > In D125693#3644029 , @dblaikie > wrote: > >> In D125693#3641742 , @krisb wrote: >> >>> @dblaikie, could

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ychen added inline comments. Comment at: llvm/docs/LangRef.rst:24541 + + declare ptr @llvm.threadlocal.address(ptr) nounwind readnone willreturn + Like @jyknight already did, any idea what it would take to change the parameter type from pointer to token?

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

jrtc27 added a comment. Does GCC allow this or not? Because this strikes me as a bad idea at first sight… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 ___

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3653895 , @jrtc27 wrote: > Does GCC allow this or not? Because this strikes me as a bad idea at first > sight… GCC can deduce from -mcpu but not -mabi. > riscv64-unknown-linux-gnu-gcc a.c -mabi=ilp32 > cc1: error:

[PATCH] D129706: [NFCI][clang-tidy] Reimplement GlobList without relying on Regex.

njames93 updated this revision to Diff 444786. njames93 added a comment. Added functionality for Checking equivalence to a StringRef without having to build the Glob. These features are ground work for upcoming patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai updated this revision to Diff 444787. vsapsai added a comment. Rebase and unhoist `ComputeTemplateParameterListODRHash`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 Files:

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

jrtc27 added a comment. I can't obviously see a description of what the additional barriers implied by the sync variants is (which should be in an update to LangRef at the very least, if not also in the summary itself). Inferring it from the AArch64 assembly is also difficult, and the RISC-V

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

jasonmolenda added a comment. In D128465#3653216 , @ckissane wrote: > In D128465#3653051 , @jasonmolenda > wrote: > >> In D128465#3652525 , @ckissane >> wrote: >> >>>

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 444844. vangthao added a comment. Change `auto &` to `auto Argument`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 Files:

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. In D112374#3651218 , @mizvekov wrote: > Can you confirm that this `NoPrincipalGetURI` matcher would, in clang version > without this patch here, fail to match if you had rewritten the `GetUri` > method to use a qualified name?

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu created this revision. zixuan-wu added reviewers: simoncook, lenary, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo added a comment. As the name of the tool becomes somewhat public and stable at this point, feel free to suggest shorter/neater names in D129798 too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b032e3f - [analyzer] Evaluate construction of non-POD type arrays

Author: isuckatcs Date: 2022-07-14T23:30:21+02:00 New Revision: b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2 URL: https://github.com/llvm/llvm-project/commit/b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2 DIFF: https://github.com/llvm/llvm-project/commit/b032e3ff6121a969b2e90ad7bf493c2d5d7ac3a2.diff

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb032e3ff6121: [analyzer] Evaluate construction of non-POD type arrays (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository:

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1207 + auto EmitResourceUsageRemark = [&](StringRef RemarkName, + StringRef RemarkLabel, auto &) { +// Add an indent for every line besides the

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG80dec2ecfffe: [Clang] Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 80dec2e - [Clang] Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

Author: Shafik Yaghmour Date: 2022-07-14T16:09:52-07:00 New Revision: 80dec2ecfffe30f86ecfeec8f553b16bb992c48b URL: https://github.com/llvm/llvm-project/commit/80dec2ecfffe30f86ecfeec8f553b16bb992c48b DIFF:

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar updated this revision to Diff 444843. tstellar added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

sammccall added a comment. In D129642#3648197 , @sammccall wrote: > It's possible we should *only* be checking the IsHeaderFile flag here and > drop all the sourcemanager stuff, but I'm not sure of the implications - > thoughts appreciated. As

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:1784 if (D->isInvalidDecl() || D->isUsed() || D->hasAttr()) return false; sammccall wrote: >

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM if the comments about diagnostic get addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128921/new/

[PATCH] D129737: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129737/new/ https://reviews.llvm.org/D129737

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added subscribers: efriedma, rsmith. aaronpuchert added a comment. Adding @rsmith because this essentially reverts rGe97654b2f28072ad9123006c05e03efd82852982 , and @efriedma because it partially reverts D76943

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

thakis added a comment. In D122258#3478727 , @davide wrote: > Compact unwind was developed as a goal to replace the DWARF unwind. Some apps > did not work if the OS was missing DWARF unwind, so we kept both for Intel. > The binary compatibility issue

[clang] cab3cfd - [clang] Do not crash on "requires" after a fatal error occurred.

Author: Adam Czachorowski Date: 2022-07-14T15:45:32+02:00 New Revision: cab3cfd013cf92c441c3acbfcc1844b267ab8659 URL: https://github.com/llvm/llvm-project/commit/cab3cfd013cf92c441c3acbfcc1844b267ab8659 DIFF:

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab3cfd013cf: [clang] Do not crash on requires after a fatal error occurred. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new/

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. Proposed https://reviews.llvm.org/D129771. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___ cfe-commits mailing list

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. One question, should the backends be passing -pie when using -r? I had adjusted the tests but cannot remember why I had changed the logic of the backend before submitting the diff. I had originally had -pie disabled with -r for Ananas and NetBSD. I noticed Fuchsia had...

[PATCH] D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy

t-rasmud updated this revision to Diff 444527. t-rasmud added a reviewer: ziqingluo-90. t-rasmud added a comment. Addresses review comments from the previously uploaded diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126097/new/ https://reviews.llvm.org/D126097 Files:

[clang] cb2c8f6 - [clang] Use value instead of getValue (NFC)

Author: Kazu Hirata Date: 2022-07-13T23:39:33-07:00 New Revision: cb2c8f694db15c488f46de6db5a7db444a189fc4 URL: https://github.com/llvm/llvm-project/commit/cb2c8f694db15c488f46de6db5a7db444a189fc4 DIFF: https://github.com/llvm/llvm-project/commit/cb2c8f694db15c488f46de6db5a7db444a189fc4.diff

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

iains added a comment. Hi @ChuanqiXu, I have no comment on the technical content of the patch (it looks reasonable to me). However, I wonder if we should be supplying this option at all because in: https://eel.is/c++draft/module#reach-2 note2 says "[Note 2: It is advisable to avoid depending

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e95921bc303: [clang-tidy] Improve check cert-dcl58-cpp. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129353/new/

[clang-tools-extra] 0e95921 - [clang-tidy] Improve check cert-dcl58-cpp.

Author: Balázs Kéri Date: 2022-07-14T09:04:03+02:00 New Revision: 0e95921bc303a206cc6ae1c21ee90ec223bf9e78 URL: https://github.com/llvm/llvm-project/commit/0e95921bc303a206cc6ae1c21ee90ec223bf9e78 DIFF: https://github.com/llvm/llvm-project/commit/0e95921bc303a206cc6ae1c21ee90ec223bf9e78.diff

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. In D127187#3650824 , @iains wrote: > Hi @ChuanqiXu, > I have no comment on the technical content of the patch (it looks reasonable > to me). > > However, I wonder if we should be supplying

[PATCH] D129737: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

OikawaKirie created this revision. OikawaKirie added reviewers: vsavchenko, NoQ, ASDenysPetrov. OikawaKirie added a project: clang. Herald added subscribers: steakhal, manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a

[PATCH] D127812: [AArch64] Function multiversioning support added.

echristo added a comment. In D127812#3616603 , @danielkiss wrote: > In D127812#3602688 , @aaron.ballman > wrote: > >> In D127812#3602645 , @erichkeane >> wrote: >> >>>

[clang] 42b3a5f - [clang] Add missing header include

Author: Shoaib Meenai Date: 2022-07-14T00:21:09-07:00 New Revision: 42b3a5fb463fd616d981888abaf0f48ab0065a8d URL: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d DIFF: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d.diff

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

sebastian-ne added a comment. This breaks builds when LLVM is included with CMake’s `add_subdirectory`. I think the zstd target needs to be marked as imported. The following patch fixes the problem, although I’m not familiar enough with CMake to know if this is the right way to go: diff --git

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

aemerson added a comment. I just reverted this in 6e6be5f9504d because it seems to have broken macOS builds: llvm/lib/Support/Compression.cpp:24:10: fatal error: 'zstd.h' file not found #include ^~~~

<    1   2   3   >