[PATCH] D147969: Add InsertBraces to ChromiumStyle

MyDeveloperDay added a comment. RFC https://groups.google.com/g/llvm-dev/c/wka1Bnrd-aU?pli=1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147969/new/ https://reviews.llvm.org/D147969 ___ cfe-commits mai

[clang] 86946eb - [clang] Add test for CWG1822

Author: Vlad Serebrennikov Date: 2023-04-11T11:08:22+03:00 New Revision: 86946ebb796c4ccde85b34aa52964e9aadabc692 URL: https://github.com/llvm/llvm-project/commit/86946ebb796c4ccde85b34aa52964e9aadabc692 DIFF: https://github.com/llvm/llvm-project/commit/86946ebb796c4ccde85b34aa52964e9aadabc692.

[PATCH] D147836: [clang] Add test for CWG1822

This revision was automatically updated to reflect the committed changes. Closed by commit rG86946ebb796c: [clang] Add test for CWG1822 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147836/new/ https://reviews.llvm.org/D147836

[PATCH] D145868: [clang][ASTImporter] Fix import of typedef with unnamed structures

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. This commit eliminates crashes caused by a rare corner case (typedefs to types derived from unnamed structs) of the AST import procedure; but introduces some incorrect behavior in a ra

[PATCH] D147848: [clang] Add test for CWG2370

Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type); shafik wrote: > The implementation seems to all accept this example: > https://go

[PATCH] D147920: [clang] Add test for CWG399

Endill added a comment. I think I haven't stressed it enough, but this whole test is copied from dr244, which is written by Richard. Comment at: clang/test/CXX/drs/dr3xx.cpp:1492 +// This is technically ill-formed; G is looked up in 'N::' and is not found. +// Rejecti

[PATCH] D147839: [clang] Add test for CWG2007

Endill updated this revision to Diff 512365. Endill added a comment. Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary template instantiation (presumably to find overloaded unary `&`), and make Clang compliant since 3.4 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

Szelethus accepted this revision. Szelethus added a comment. LGTM! Most of the diagnostic messages are short but precise. I like this very much. Well done! Balázs actually tested the change on open source projects, but accidentally uploaded it to our internal server, so I have seen them, and th

[PATCH] D147848: [clang] Add test for CWG2370

Endill added a comment. Bug report filed: https://github.com/llvm/llvm-project/issues/62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848 ___ cfe-commits mail

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 512377. sammccall marked an inline comment as done. sammccall added a comment. use llvm::printHTMLEscaped Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files: c

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:77 + +void escape(char C, llvm::raw_ostream &OS) { + switch (C) { xazax.hun wrote: > We already sort of have a way to escape HTML here: > https://github.com/llvm/llvm-p

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:58 using namespace sema; - +bool isEnumClass = false; Sema::DeclGroupPtrTy Sema::ConvertDeclToDeclGroup(Decl *Ptr, Decl *OwnedType) { This being global could lead to issues where one overwr

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added reviewers: mboehme, aaron.ballman. samtebbs added a comment. Looping in some people who have worked on and reviewed patches in this area for some experienced eyes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://re

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 512381. koops added a comment. Moving the code to SemaOpenMP.cpp from CodeGen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Basic/Diagno

[PATCH] D148004: [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.c:4 // RUN: %clang_cc1 -fexperimental-strict-floating-point -ffp-exception-behavior=strict -triple %itanium_abi_triple -emit-llvm %s -o - -fms-extensions -DMS | FileCheck --check-prefixes=CHECK,S

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 512388. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c ==

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. Herald added a subscriber: bviyer. ping for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___ cfe-commits mailing

[PATCH] D148006: [clang][dataflow] Associate `FunctionToPointerDecay` nodes with a value.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To ensure that we have a pointee for the `Pointe

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added subscribers: aprantl, dblaikie. Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/no_unique_address/main.cpp:38 + long v = 42; +} _f3; + I haven't checked the reworked logic yet, but it still crashes on this: ``` self.expect_e

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

mboehme added a comment. @gribozavr2 Just to make sure I understand you correctly here (before I make any changes to the code): IIUC you recommend simply doing nothing on a delete expression? (Your arguments for this make sense to me, just want to double-check I understood correctly.) Reposit

[PATCH] D147986: [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice versa.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147986/new/ https://reviews.llvm.org/D147986 ___ cfe-

[clang] 991c7e1 - [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`.

Author: Martin Braenne Date: 2023-04-11T11:31:56Z New Revision: 991c7e11728f6f6372e5dc865e3a4c0636a575ea URL: https://github.com/llvm/llvm-project/commit/991c7e11728f6f6372e5dc865e3a4c0636a575ea DIFF: https://github.com/llvm/llvm-project/commit/991c7e11728f6f6372e5dc865e3a4c0636a575ea.diff LOG

[PATCH] D148004: [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG991c7e11728f: [clang][dataflow][NFC] Remove unused parameter from `insertIfGlobal()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman added a comment. Thank you for working on this! The changes are missing test coverage; please be sure to add that, along with a release note about the fix. I think there's likely more work to be done here as well, considering this behavior: https://godbolt.org/z/sdK3Gef75 (notice

[PATCH] D147978: [RISCV] Remove getCPUFeaturesExceptStdExt.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147978/new/ https://reviews.llvm.org/D147978 ___ cfe-

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:138 APIRecord(RecordKind Kind, StringRef USR, StringRef Name, -PresumedLoc Location, AvailabilitySet Availabilities, +PresumedLoc Location, const AvailabilitySet &Availabilitie

[PATCH] D147935: [RISCV] Add SiFive extension support

asb added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:465 RVV_REQ_FullMultiply = 1 << 1, + RVV_REQ_xsfvcp = 1 << 2, Nit: It would better match the surrounding capitalisation to call this RVV_REQ_Xsfvcp Repository: rG

[PATCH] D147941: [Flang][Driver][OpenMP] Enable flags for filtering of offloading passes in flang

skatrak updated this revision to Diff 512399. skatrak added a comment. Address reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147941/new/ https://reviews.llvm.org/D147941 Files: clang/include/clang/Driver/Options.td flang/te

[PATCH] D147989: [clang] Fix Attribute Placement

mboehme added a comment. In D147989#4257539 , @samtebbs wrote: > Looping in some people who have worked on and reviewed patches in this area > for some experienced eyes. Nothing else to add beyond what @aaron.ballman has noted. Thanks for working on th

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

skatrak marked 4 inline comments as done. skatrak added a comment. In D147941#4255622 , @awarzynski wrote: > In the context of LLVM, I would normally associate "pass" with something > else. I'm not that familiar with offloading, so perhaps that's the la

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. In D147256#4249527 , @zequanwu wrote: > - Add a `-use-target-path-separator` flag for llc. > - Add test for llc with that flag. But where does `TM.Options.ObjectFilenameForDebug` come from? Presumably it comes from Clang at some po

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder marked an inline comment as done. tbaeder added a comment. Wow, in `FixIt/fixits-function-call`, this output: ./array.cpp:123:3: error: no matching function for call to 'f1' f1(a + 1); ^~ ./array.cpp:114:6: note: candidate function not viable: no known conversion from 'intTy2

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

BeMg added a comment. test_nontemporal_load_v16i8 test_nontemporal_load_v8i16 These two test cases in nontemporal.ll are affected by `areTwoSDNodeTargetMMOFlagsMergeable`. Does we need extra testcases for `areTwoSDNodeTargetMMOFlagsMergeable`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147962: [RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding the codegen code owners for their approval, but in general I think this is a good idea. Comment at: clang/lib/CodeGen/ABIInfoImpl.h:33-52 +bool isAggregateTypeForABI(QualType T); + +llvm::

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

gribozavr2 added a comment. In D147698#4257698 , @mboehme wrote: > @gribozavr2 Just to make sure I understand you correctly here (before I make > any changes to the code): IIUC you recommend simply doing nothing on a delete > expression? (Your arguments

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512419. ipriyanshi1708 added a comment. Implemented the required changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/include/clang/Basic/Dia

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; --

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512421. ipriyanshi1708 added a comment. Removed the spurious whitespace changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/include/clang/Ba

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257721 , @aaron.ballman wrote: > Thank you for working on this! > > The changes are missing test coverage; please be sure to add that, along with > a release note about the fix. I think there's likely more wor

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske updated this revision to Diff 512425. balazske added a comment. Fixed documentation issues. Check is added to list.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138777/new/ https://reviews.llvm.org/D138777 Files: clang-tools-extra/

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa added a comment. In D143813#4256969 , @ahatanak wrote: > I think this patch is causing the assertion in > `CodeGenFunction::setAddrOfLocalVar` to fail when the following code is > compiled: > > void foo(unsigned long long t) { > __sync_bool_

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added a comment. Thanks for the input Aaron and Martin. This is looking good. With the suggested changes (don't forget the test, you could try adding one to clang/test/Sema/attr-declspec-ignored.c and clang/test/SemaCXX/attr-declspec-ignored.cpp) and some formatting

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for addressing my comments. I'd wait a day before landing this - just in case other reviewers have comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D147779: [clang-tidy] Fix hungarian notation failed to indicate the number of asterisks in check-clang-extra-clang-tidy-checkers-readability

dougpuob added a comment. In D147779#4257212 , @PiotrZSL wrote: > arc land should work, I usually use arc patch --nobranch to check things > before committing and then git push. Hi @PiotrZSL, thank you for the help :) Repository: rG LLVM Github Mono

[PATCH] D147698: [clang][dataflow] Add support for new and delete expressions.

mboehme updated this revision to Diff 512434. mboehme added a comment. Eliminate specific handling of delete expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147698/new/ https://reviews.llvm.org/D147698 Files: clang/lib/Analysis/FlowSe

[PATCH] D147698: [clang][dataflow] Add support for new expressions.

mboehme marked 3 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:315 + /// `D` must currently be associated with a value. + void unsetChild(const ValueDecl &D) { +auto It = Children.find(&D); --

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512437. ipriyanshi1708 added a comment. Added the Release note for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 added a comment. In D147989#4257947 , @samtebbs wrote: > Thanks for the input Aaron and Martin. This is looking good. With the > suggested changes and some formatting > I thi

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:91 + ExceptionType, ExceptionReferenceType))); + auto BadAllocCatchingTryBlock = cxxTryStmt(hasHandlerFor(CatchBadAllocType

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added a comment. This is right on the line of what I think is reasonable in terms of diagnostics from the backend. It provides useful information to users about inlining decisions, so that's awesome when that information is helpful. But those inlining decisions can be arbitrarily

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

erichkeane added a comment. Just comments from the CFE. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:94 +def note_fe_backend_in : Note<"In function '%0'">; +def note_fe_backend_inlined : Note<"\twhich inlined function '%0'">; This tab in t

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

sstwcw added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:844 "};"); - ASSERT_EQ(Tokens.size(), 44u); + ASSERT_EQ(Tokens.size(), 44u) << Tokens; EXPECT_TOKEN(Tokens[13], tok::kw_requires, TT_RequiresClause);

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 512445. ipriyanshi1708 added a comment. Applied C++ Overloading Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://reviews.llvm.org/D147989 Files: clang/docs/ReleaseNotes.rst clang/in

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

sammccall added a comment. Herald added a project: All. Time to wake up an old review! Going to put high-level thoughts on https://github.com/clangd/clangd/discussions/1206, but since one of them is memory usage I wanted to have a look at the concrete data structure here. TL;DR: I think we can

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.js:47-50 +for (tmpl of root.getElementsByTagName('template')) { + // Clear previously rendered te

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 512447. jrmolin marked 3 inline comments as done. jrmolin added a comment. - updated the tests to use long-form - added new tests to verify the no-parameter cases - updated the documentation to minimize formatting variables - ran the style guide generator Re

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 2 inline comments as done. jrmolin added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1380 + Example uses + ``AlwaysBreakAfterReturnType`` set to ``All``. + MyDeveloperDay wrote: > This isn't relevant is it? `AlwaysBreakAft

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 512449. jrmolin marked an inline comment as done. jrmolin added a comment. - updated the documentation to show the option works for function declaration and definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 512448. koops added a comment. Removing changes from : 1. clang/include/clang/AST/StmtOpenMP.h 2. clang/lib/AST/StmtOpenMP.cpp 3. clang/include/clang/Parse/Parser.h These were useful when the code was in CodeGen to handle the bind clause. CHANGES SINCE LAST

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6124 BindKind = BC->getBindKind(); + // First check CancelRegion which is then used in checkNestingOfRegions. Remove this new line Comment at: clang/lib/Sema/SemaO

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases PiotrZSL wrote: > ccotter wrote: >

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 512455. ccotter marked an inline comment as done. ccotter added a comment. Fix tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D147989: [clang] Fix Attribute Placement

tbaeder added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3424 "attribute %0 is ignored, place it after " - "\"%select{class|struct|interface|union|enum}1\" to apply attribute to " + "\"%select{class|struct|interface|union|enum|enum class}1\

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148021 Files: clang/lib/Headers/fmaintrin.h Index: clang/lib/Headers/fmaintrin.h

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

pengfei added inline comments. Comment at: clang/lib/Headers/fmaintrin.h:22 +/// Computes a multiply-add of 128-bit vectors of [4 x float]. +///For each element, computes (__A * __B) + __C . +/// We are using a special format to describute the function in a

[PATCH] D147909: [clang] Implement CWG 2397

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added a comment. The changes need a release note, but also this should have changes to `clang/test/CXX/drs/dr23xx.cpp` with the proper dr markings and update `clang/www/cxx_dr_status.html`. Comment at: clang/tes

[PATCH] D147909: [clang] Implement CWG 2397

Endill added a comment. Agree, this test clearly belongs to `clang/test/CXX/drs/dr23xx.cpp`. There is a `clang/www/make_cxx_dr_status` script to update cxx_dr_status page, so you don't have to edit it manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 512480. jrmolin added a comment. fix a comment in the documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added a comment. > When the `.clang-tidy` file is checked into the source control(git). It means > that anyone who contributes to the project will need to ensure that they have > a version of clang-tidy that will be able to read the file. > This can cause problems as binaries of cl

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub requested changes to this revision. kamaub added a comment. This revision now requires changes to proceed. Sorry I should have requested changes before for this comment below, but I do want these test moved to codegen and expanded, please let me know if anything is unclear. In D143467#42

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Again not an expert here, but lgtm. (Nit: the https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaExprCXX.cpp#L1528-L1530 link in the description seems to point to the wrong code no

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4258384 , @hans wrote: > Again not an expert here, but lgtm. > > (Nit: the > https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaExprCXX.cpp#L1528-L1530 > link in the description seems to point to

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:91 + ExceptionType, ExceptionReferenceType))); + auto BadAllocCatchingTryBlock =

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4257797 , @hans wrote: > In D147256#4249527 , @zequanwu > wrote: > >> - Add a `-use-target-path-separator` flag for llc. >> - Add test for llc with that flag. > > But where do

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258396 , @aaron.ballman wrote: > In D147073#4258384 , @hans wrote: > >> Again not an expert here, but lgtm. >> >> (Nit: the >> https://github.com/llvm/llvm-project/blob/main

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 512488. krzysz00 added a comment. Rebase, since we have addrspace 128 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp c

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512489. paulkirth marked 2 inline comments as done. paulkirth added a comment. Add spaces to parantheticals. Shorten link to discussion on psABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ http

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

SimeonEhrig added a comment. Except using an in-memory solution for generated fatbin code, the code looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146389/new/ https://reviews.llvm.org/D146389 _

[PATCH] D148024: [clang-format] Don't modify template arguments on the LHS of assignment

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. After clang-format has determined that an eq

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4258426 , @zequanwu wrote: > In D147073#4258396 , @aaron.ballman > wrote: > >> In D147073#4258384 , @hans wrote: >> >>> Again no

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because the comment parser does not support slices, we emit a warning for comments that do contain a splice within their d

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

efriedma added a comment. I think the issue is that you're calling EmitPointerWithAlignment() on the argument, then calling EmitScalarExpr on the same argument. Essentially, emitting the argument twice. If emitting the argument has side-effects, that will cause an issue. Sorry, should have s

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

cor3ntin updated this revision to Diff 512505. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148029/new/ https://reviews.llvm.org/D148029 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Raw

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

paulkirth created this revision. paulkirth added reviewers: phosek, abrachet, dvyukov, vitalybuka, aaron.ballman. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, we can't check if ShadowCall

[PATCH] D147848: [clang] Add test for CWG2370

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type); E

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258529 , @aaron.ballman wrote: > In D147073#4258426 , @zequanwu > wrote: > >> In D147073#4258396 , >> @aaron.ballman wrote: >> >>>

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: aaron.ballman. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > Despite a couple of FIXME in CWG244 test (out of do

[PATCH] D147920: [clang] Add test for CWG399

shafik added a comment. In D147920#4257369 , @Endill wrote: > I think I haven't stressed it enough, but this whole test is copied from > dr244, which is written by Richard. Understood, I appreciate the patience in explaining what I am missing. Sometime

[PATCH] D147839: [clang] Add test for CWG2007

shafik added a comment. In D147839#4257394 , @Endill wrote: > Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary > template instantiation (presumably to find overloaded unary `&`), and make > Clang compliant since 3.4 Nice approach

[PATCH] D147839: [clang] Add test for CWG2007

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you again for all the effort in documenting these and adding tests, it is much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D147839: [clang] Add test for CWG2007

Endill added a comment. In D147839#4258681 , @shafik wrote: > In D147839#4257394 , @Endill wrote: > >> Replace unary `&` with `__builtin_addressof()`. It prevents unnecessary >> template instantiation (presumably

[clang] 393a1c3 - [PS4][clang] Pass -flto-jobs argument to orbis-ld

Author: Matthew Voss Date: 2023-04-11T10:33:16-07:00 New Revision: 393a1c3b4fcded56a1078d2c01c69af2f2ec05cf URL: https://github.com/llvm/llvm-project/commit/393a1c3b4fcded56a1078d2c01c69af2f2ec05cf DIFF: https://github.com/llvm/llvm-project/commit/393a1c3b4fcded56a1078d2c01c69af2f2ec05cf.diff

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393a1c3b4fcd: [PS4][clang] Pass -flto-jobs argument to orbis-ld (authored by ormris). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147660/new/ https://reviews.llvm.org/D147660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 5e2d8a3 - [RISCV] Remove getCPUFeaturesExceptStdExt.

Author: Craig Topper Date: 2023-04-11T10:41:46-07:00 New Revision: 5e2d8a35288802f94df8c60513e7a835b27e621d URL: https://github.com/llvm/llvm-project/commit/5e2d8a35288802f94df8c60513e7a835b27e621d DIFF: https://github.com/llvm/llvm-project/commit/5e2d8a35288802f94df8c60513e7a835b27e621d.diff

[clang] 88d6311 - [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice versa.

Author: Craig Topper Date: 2023-04-11T10:41:50-07:00 New Revision: 88d6311982557acf2dd04ce101aca077ac311012 URL: https://github.com/llvm/llvm-project/commit/88d6311982557acf2dd04ce101aca077ac311012 DIFF: https://github.com/llvm/llvm-project/commit/88d6311982557acf2dd04ce101aca077ac311012.diff

[PATCH] D147986: [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice versa.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88d631198255: [RISCV] Print a better error message when a rv32 CPU is used on rv64 and vice… (authored by craig.topper). Repository: rG LLVM Githu

[PATCH] D147978: [RISCV] Remove getCPUFeaturesExceptStdExt.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e2d8a352888: [RISCV] Remove getCPUFeaturesExceptStdExt. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147978/new/ https://revie

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

ahatanak added a comment. In D143813#4257943 , @jonpa wrote: > I don't understand the first argument - I thought it was supposed to be just > an address... It's a statement expression. https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html The value

  1   2   >