[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir updated this revision to Diff 545410. schittir added a comment. Remove changes in CGObjCMac.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274 Files: clang/lib/AST/ItaniumMangle.cpp clang/lib/Sema/SemaCodeComplete.cpp Index: cl

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat added a comment. In D154576#4483919 , @lhtin wrote: > In D154576#4476300 , @4vtomat wrote: > >> In D154576#4476291 , @craig.topper >> wrote: >> >>> Does this only

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat marked 2 inline comments as done. 4vtomat added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3267 case CC_PreserveAll: + case CC_RISCVVectorCall: // FIXME: we should be mangling all of the above. aaron.ballman wrote: > Is it possi

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545411. 4vtomat marked 6 inline comments as done. 4vtomat added a comment. Resolved MaskRay's comments, thanks for reviewing!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545412. 4vtomat added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat updated this revision to Diff 545413. 4vtomat marked 2 inline comments as done. 4vtomat added a comment. Resolved Aaron's comments. Also group some code and refactoring some code to make it much clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D156608: [clang-tidy] Do not warn on macros starting with underscore and lowercase letter in bugprone-reserved-identifier

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes #64130 Rep

[PATCH] D156608: [clang-tidy] Do not warn on macros starting with underscore and lowercase letter in bugprone-reserved-identifier

carlosgalvezp updated this revision to Diff 545415. carlosgalvezp added a comment. Remove extra newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156608/new/ https://reviews.llvm.org/D156608 Files: clang-tools-extra/clang-tidy/bugprone/Reser

[PATCH] D156608: [clang-tidy] Do not warn on macros starting with underscore and lowercase letter in bugprone-reserved-identifier

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156608/new/ https://reviews.llvm.org/D156608 ___

[clang-tools-extra] 2992d08 - [clang-tidy] Do not warn on macros starting with underscore and lowercase letter in bugprone-reserved-identifier

Author: Carlos Galvez Date: 2023-07-30T12:10:48Z New Revision: 2992d084774f44e7626a7d640fe6c30163db450e URL: https://github.com/llvm/llvm-project/commit/2992d084774f44e7626a7d640fe6c30163db450e DIFF: https://github.com/llvm/llvm-project/commit/2992d084774f44e7626a7d640fe6c30163db450e.diff LOG:

[PATCH] D156608: [clang-tidy] Do not warn on macros starting with underscore and lowercase letter in bugprone-reserved-identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG2992d084774f: [clang-tidy] Do not warn on macros starting with underscore and lowercase… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

thakis added a comment. http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this something on my end? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org/D156363 ___

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

aaron.ballman added a comment. In D156363#4544782 , @thakis wrote: > http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this > something on my end? Nope, this same failure is happening in our build farm: https://lab.llvm.org/buildbot/

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Are you planning to work on the ObjC issues separately? (Not suggesting you have to! But if you don't intend to, can you file an issue in GitHub so we don't lose track of t

[clang-tools-extra] f27f22b - [clang-tidy] Added bugprone-inc-dec-in-conditions check

Author: Piotr Zegar Date: 2023-07-30T13:19:51Z New Revision: f27f22b34516dcb744077710c19d475367e3ef03 URL: https://github.com/llvm/llvm-project/commit/f27f22b34516dcb744077710c19d475367e3ef03 DIFF: https://github.com/llvm/llvm-project/commit/f27f22b34516dcb744077710c19d475367e3ef03.diff LOG: [

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

This revision was automatically updated to reflect the committed changes. Closed by commit rGf27f22b34516: [clang-tidy] Added bugprone-inc-dec-in-conditions check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ http

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. Fixing this was rather messier than I expected, but this solution does seem to work for the test cases. Here's my original commit message before I trimmed it, in case it provides any more insight. [clang-tidy] Fix c_str() removal and cast addition when re-ordering a

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe updated this revision to Diff 545446. mikecrowe added a comment. Rebase on top of D156616 and add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ https://reviews.llvm.org/D156616 Fi

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4544803 , @aaron.ballman wrote: > In D156363#4544782 , @thakis wrote: > >> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this >> something on my end? >

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter updated this revision to Diff 545450. ccotter marked 5 inline comments as done. ccotter added a comment. - Improve docs, check for null/empty Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter marked an inline comment as done. ccotter added a comment. > 3. What about boost enable_if ? Support it, or restrict check to std only. > 4. What about enable_if used as an function argument ? Support it, or add > some info to documentation that such construction is not supported. I adde

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp:61 + matchers::matchesAnyListedName(ValueMethods) + .bind("fun")), + hasType(qualType().bind("value-type"))); --

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp:61 + matchers::matchesAnyListedName(ValueMethods) + .bind("fun")), + hasType(qualType().bind("value-type")));

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

PiotrZSL added a comment. Good, just verify that documentation for this check is still proper, and add entry in release notes about this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ c

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list cfe-commi

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. hi @PiotrZSL, thanks for the review :) can you please land it for me? Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list cfe-com

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

carlosgalvezp added a comment. What about the use case of privately inheriting `std::array`, and overriding the `operator[]` there with bounds check? Would it be possible to check only _public_ inheritance? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL updated this revision to Diff 545464. PiotrZSL added a comment. Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. In D156624#4545107 , @PiotrZSL wrote: > Good, just verify that documentation for this check is still proper, and add > entry in release notes about this change. I missed those, I will sure ^^ In D156624#4545117

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

PiotrZSL added a comment. In D156624#4545170 , @sousajo wrote: > Good point, I cannot think of an _easy_ way to check it. I think you can do something like this: Finder->addMatcher( cxxOperatorCallExpr( hasOverloadedOperatorName("[]"),

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

PiotrZSL accepted this revision. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:42 +void UseConstraintsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + functionTemplateDecl( W

[clang-tools-extra] 893d53d - [clang-tidy] Implement modernize-use-constraints

Author: Chris Cotter Date: 2023-07-30T20:43:18Z New Revision: 893d53d11c0116718ecc816263f12d51c4612e1d URL: https://github.com/llvm/llvm-project/commit/893d53d11c0116718ecc816263f12d51c4612e1d DIFF: https://github.com/llvm/llvm-project/commit/893d53d11c0116718ecc816263f12d51c4612e1d.diff LOG:

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG893d53d11c01: [clang-tidy] Implement modernize-use-constraints (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. In D156363#4544803 , @aaron.ballman wrote: > In D156363#4544782 , @thakis wrote: > >> http://45.33.8.238/linux/113921/step_7.txt is failing due to this. Is this >> something on my end? > >

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

dyung added a comment. If you cannot reproduce this issue, I can take my buildbot offline and try to reproduce it to pinpoint which command is causing the problem, but I won’t be able to do so until Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D156636: [InstCombine] Deduce `align` and `nonnull` return attributes for `llvm.ptrmask`

goldstein.w.n created this revision. goldstein.w.n added reviewers: nikic, RKSimon. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. goldstein.w.n requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

phosek added a comment. We see 14 failing tests on our Linux and macOS builders, and 6 failing tests on Windows builders: - `Clang :: Driver/csky-toolchain.c` - `Clang :: Driver/env.c` - `Clang :: Driver/fsanitize.c` - `Clang :: Driver/gcc-install-dir.cpp` - `Clang :: Driver/gcc-toolchain.cpp` -

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 __

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4340 +} + } no blank line here Comment at: clang/test/Driver/print-supported-extensions.c:93 +// CHECK-NEXT: xventanacondops 1.0 +// +// CHECK:Experimental e

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4545410 , @phosek wrote: > We see 14 failing tests on our Linux and macOS builders, and 6 failing tests > on Windows builders: > > - `Clang :: Driver/csky-toolchain.c` > - `Clang :: Driver/env.c` > - `Clang :: Driver/f

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545499. 4vtomat marked 6 inline comments as done. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:290 + /// Output time trace profile. + unsigned TimeTrace : 1; + MaskRay wrote: > stray change? Oh, maybe it was added accidentally during rebase lol~ C

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545500. 4vtomat added a comment. Updated test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td clang/include/cla

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

MaskRay added a comment. In D156363#4545215 , @dyung wrote: > If you cannot reproduce this issue, I can take my buildbot offline and try to > reproduce it to pinpoint which command is causing the problem, but I won’t be > able to do so until Monday. Th

[PATCH] D156641: [Clang][Frontend] Change help text for --offload-host-device

AntonRydahl created this revision. AntonRydahl added a reviewer: jdoerfert. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. AntonRydahl requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. I believe the help text f

[clang] c31d6b4 - [ODRHash] Hash type-as-written

Author: Chuanqi Xu Date: 2023-07-31T11:05:47+08:00 New Revision: c31d6b4ef135098280b0ebb93e95b258a0d372ca URL: https://github.com/llvm/llvm-project/commit/c31d6b4ef135098280b0ebb93e95b258a0d372ca DIFF: https://github.com/llvm/llvm-project/commit/c31d6b4ef135098280b0ebb93e95b258a0d372ca.diff LO

[PATCH] D156210: [ODRHash] Hash type-as-written

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc31d6b4ef135: [ODRHash] Hash type-as-written (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposit

[clang] c652525 - [CodeGen] Remove unused declaration/function BlockCaptureManagedEntity

Author: Kazu Hirata Date: 2023-07-30T21:22:26-07:00 New Revision: c652525295f6b4eac0f4a38f16ca565b1187d17d URL: https://github.com/llvm/llvm-project/commit/c652525295f6b4eac0f4a38f16ca565b1187d17d DIFF: https://github.com/llvm/llvm-project/commit/c652525295f6b4eac0f4a38f16ca565b1187d17d.diff L

[PATCH] D156643: [clang-format][NFC] Remove superfluous code in UnwrappedLineParser

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15

[PATCH] D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff

paquette accepted this revision. paquette added a comment. LGTM too thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156515/new/ https://reviews.llvm.org/D156515 ___ cfe-commits mailing list cfe-com

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. Test failure seems unrelated to change. Driver/fsanitize.c lit test passes in my local testing. Restarting build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274 ___ cfe-co

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. In D156274#4544804 , @aaron.ballman wrote: > LGTM! Are you planning to work on the ObjC issues separately? (Not suggesting > you have to! But if you don't intend to, can you file an issue in GitHub so > we don't lose track of

[clang-tools-extra] 575900d - [clang-tidy] Add bugprone-optional-value-conversion check

Author: Piotr Zegar Date: 2023-07-31T06:22:39Z New Revision: 575900d0d98aafce9d534b6c1917861311f3cfaa URL: https://github.com/llvm/llvm-project/commit/575900d0d98aafce9d534b6c1917861311f3cfaa DIFF: https://github.com/llvm/llvm-project/commit/575900d0d98aafce9d534b6c1917861311f3cfaa.diff LOG: [

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

This revision was automatically updated to reflect the committed changes. Closed by commit rG575900d0d98a: [clang-tidy] Add bugprone-optional-value-conversion check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D147357?vs=545464&id=545510#toc Repository: rG LLVM G

[clang] 72450a7 - [clang][Interp] Implement __builtin_isinf

Author: Timm Bäder Date: 2023-07-31T08:49:22+02:00 New Revision: 72450a77937c3d47f144b20cf16b595955583a0c URL: https://github.com/llvm/llvm-project/commit/72450a77937c3d47f144b20cf16b595955583a0c DIFF: https://github.com/llvm/llvm-project/commit/72450a77937c3d47f144b20cf16b595955583a0c.diff LO

[PATCH] D155371: [clang][Interp] Implement __builtin_isinf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72450a77937c: [clang][Interp] Implement __builtin_isinf (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155371?vs=540693