[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 added a comment. >> Extend PointerAssignmentGadget and PointerInitGadget to generate fix-its for >> cases where the left-hand side >> has won't fix strategy and the right-hand side has std::span strategy. > > Hmm, is this intertwined with other changes, or is this completely separat

[PATCH] D157331: [clang] Implement C23

ZijunZhao added a comment. Another followup question: I check https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2683.pdf and I only add Core Proposal here. Do I need to add Supplemental Proposal, like some types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

tahonermann accepted this revision. tahonermann added a comment. Looks good to me. Thanks, Elizabeth! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157454/new/ https://reviews.llvm.org/D157454 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 added a comment. In D157394#4572777 , @giulianobelinassi wrote: > This patch do not address attributes in variables nor the __declspec case, as > D141714 do. His patch looks cleaner and I > can surely coordi

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: arphaman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows standard libraries to m

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 548862. evelez7 added a comment. Fix template arg identification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files: clang/include/clang/ExtractAPI/API.h clang

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add records, serialization for global function templates

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

wangpc created this revision. wangpc added reviewers: 4vtomat, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzhen

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 updated this revision to Diff 548873. fakepaper56 added a comment. Make asmprinter capable to print alias register name for ssload/sspopchk/c.sspush/c.sspopchk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152793/new/ https://reviews.

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 added reviewers: craig.topper, frasercrmck, rogfer01, reames, asb, luke. fakepaper56 marked an inline comment as done. fakepaper56 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:56 +let Predicates = [HasStdExtZicfiss] in { +def SSLo

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1330 AddPath(WritingModule->PresumedModuleMapFile.empty() -? Map.getModuleMapFileForUniquing(WritingModule)->getName() +? Map.getModuleMapFileForUniquing(Wri

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM - just see the very minor corrections inline. Thanks! Comment at: clang/test/Preprocessor/riscv-target-features.c:146 // RUN: %clang -target riscv32-unknown-linux-gnu -men

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:106 +int x3[__builtin_offsetof(struct X2, X2::static_a) == 0 ? 1 : -1]; // expected-error{{no member named 'static_a'}} +int x4[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // exp

[PATCH] D157568: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

owenpan updated this revision to Diff 548878. owenpan added a comment. Rebased and updated test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157568/new/ https://reviews.llvm.org/D157568 Files: clang/lib/Format/NamespaceEndCommentsFixer.cpp clang/unittests/Format/NamespaceEn

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

4vtomat accepted this revision. 4vtomat added a comment. LGTM, thanks~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157580/new/ https://reviews.llvm.org/D157580 ___ cfe-commits mailing list cfe-commits@

[PATCH] D157582: [Driver][DXC] Handle -Fo and -Fc flags

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added subscribers: Anastasia, hiraditya, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM

[clang] 6b7b45c - [test][asan] Disable new test from D157552 on Android

Author: Vitaly Buka Date: 2023-08-09T23:01:33-07:00 New Revision: 6b7b45c213d44cb49708e22fb31df524298495d2 URL: https://github.com/llvm/llvm-project/commit/6b7b45c213d44cb49708e22fb31df524298495d2 DIFF: https://github.com/llvm/llvm-project/commit/6b7b45c213d44cb49708e22fb31df524298495d2.diff L

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

asb accepted this revision. asb added a comment. I just wanted to say thank you for your work on the named arguments tablegen feature. This and D154067 are good showcases of the readability improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

cor3ntin added a comment. @hubert.reinterpretcast It does not, Unicode characters are only escaped in Diagnostics.cpp, and I think this is what we want. Currently, llvm assume UTF-8 terminal, except on Windows where we convert to UTF-16 and use the wide windows APIs (`raw_fd_ostream::write_impl`

[clang] 20e0116 - [Clang] Produce a warning instead of an error in unevaluated strings before C++26

Author: Corentin Jabot Date: 2023-08-10T08:32:42+02:00 New Revision: 20e01167b15aa17dac09e4742909a7138eca7afc URL: https://github.com/llvm/llvm-project/commit/20e01167b15aa17dac09e4742909a7138eca7afc DIFF: https://github.com/llvm/llvm-project/commit/20e01167b15aa17dac09e4742909a7138eca7afc.diff

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

This revision was automatically updated to reflect the committed changes. Closed by commit rG20e01167b15a: [Clang] Produce a warning instead of an error in unevaluated strings before… (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D157584: [clang][Sema] Skip access check on arrays of zero-length element

danix800 created this revision. danix800 added a project: clang. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. Bound check on array of zero-sized element isn't meaningful. Fixes https://github.com/llvm/llvm-project/issues/64564

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld added a comment. gentle ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156891/new/ https://reviews.llvm.org/D156891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

Hahnfeld added a comment. gentle ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ https://reviews.llvm.org/D156897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

v.g.vassilev added a comment. Looks reasonable to me. Let's give @rjmccall couple of more days to respond. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ https://reviews.llvm.org/D156897 ___ c

[clang] ab4e4a6 - Revert "[Clang] Produce a warning instead of an error in unevaluated strings before C++26"

Author: Corentin Jabot Date: 2023-08-10T08:47:57+02:00 New Revision: ab4e4a69854dd348014495921a6b3648f1ee1895 URL: https://github.com/llvm/llvm-project/commit/ab4e4a69854dd348014495921a6b3648f1ee1895 DIFF: https://github.com/llvm/llvm-project/commit/ab4e4a69854dd348014495921a6b3648f1ee1895.diff

[clang] 8065b1c - [clang][Interp] Basic support for bit fields

Author: Timm Bäder Date: 2023-08-10T08:50:10+02:00 New Revision: 8065b1cc133c9e4b6900d5c11220617180706b94 URL: https://github.com/llvm/llvm-project/commit/8065b1cc133c9e4b6900d5c11220617180706b94 DIFF: https://github.com/llvm/llvm-project/commit/8065b1cc133c9e4b6900d5c11220617180706b94.diff LO

[PATCH] D155270: [clang][Interp] Basic support for bit fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8065b1cc133c: [clang][Interp] Basic support for bit fields (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155270?vs=540

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548886. koops added a comment. Corrected git-clang-format errors. clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClause.cpp clang/lib/Parse/ParseOpenMP.cpp clang/lib/Sema/SemaOpenMP.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/

<    1   2   3