[clang] 2e603c6 - [clang] Construct SmallVector with iterator ranges (NFC)

Author: Kazu Hirata Date: 2022-06-10T22:45:26-07:00 New Revision: 2e603c67c204b6bc9d96bf090ef4fd3a5b04aa51 URL: https://github.com/llvm/llvm-project/commit/2e603c67c204b6bc9d96bf090ef4fd3a5b04aa51 DIFF: https://github.com/llvm/llvm-project/commit/2e603c67c204b6bc9d96bf090ef4fd3a5b04aa51.diff

[clang] f5ef2c5 - [clang] Convert for_each to range-based for loops (NFC)

Author: Kazu Hirata Date: 2022-06-10T22:39:45-07:00 New Revision: f5ef2c58381fb8056bf919c7a0862bb8d65e1e28 URL: https://github.com/llvm/llvm-project/commit/f5ef2c58381fb8056bf919c7a0862bb8d65e1e28 DIFF: https://github.com/llvm/llvm-project/commit/f5ef2c58381fb8056bf919c7a0862bb8d65e1e28.diff

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 436110. vaibhav.y marked 2 inline comments as done. vaibhav.y added a comment. Fix bug detected from ASAN run Passes `-fsanitize=address` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

dyung added a comment. Just another data point, but we noticed the same issue of clang++ missing after install on our internal Windows builds, and I bisected it to this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It seems that other docs are following the GitHub URLs as well. I wish we could do the relative document link instead of embedding the URL, but if that is not possible, then this makes

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[PATCH] D127484: [clang-format] Use tabs on GNU style

a4lg updated this revision to Diff 436087. a4lg added a comment. Thanks, suggestion by @owenpan is applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D127484 Files: clang/lib/Format/Format.cpp

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:34 + +static void expandKernelSanitizerMasks(SanitizerMask *Mask) { + if (*Mask & (SanitizerKind::Address | SanitizerKind::KernelAddress)) Prefer return value to output

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) Do we need

[PATCH] D127351: clang: fix early substitution of alias templates

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1872 QualType Result = getSema().Context.getTemplateTypeParmType( - T->getDepth() - TemplateArgs.getNumSubstitutedLevels(), T->getIndex(), - T->isParameterPack(), NewTTPDecl); +

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3574992 , @MyDeveloperDay wrote: > Oh gosh! It hard to make such changes and someone else not call them a > regression, I’m not sure how I feel. We do kind of have to be able to fix > bugs and if this gets closer to

[PATCH] D119367: [HWASan] Allow no_sanitize(..) and change metadata passing.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Deprecated by D127544 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119367/new/

[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. Oh gosh! It hard to make such changes and someone else not call them a regression, I’m not sure how I feel. We do kind of have to be able to fix bugs and if this gets closer to gnu style then I guess it’s better Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127545: Remove Itanium EH ABI workaround to allow modifying a pointer caught by-reference.

jyknight added a comment. (Note: if folks agree with this direction, I'll file a new bug for the newly broken behavior -- even though we probably cannot actually fix it -- and link it from the commit.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127545: Remove Itanium EH ABI workaround to allow modifying a pointer caught by-reference.

jyknight created this revision. jyknight added reviewers: rjmccall, nikic. Herald added a project: All. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pointers will now always be caught by-value. The workaround was originally

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim updated this revision to Diff 436059. hctim marked 2 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 Files:

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim marked 2 inline comments as done. hctim added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:767 + if (IsAArch64) { +Res |= SanitizerKind::MemtagGlobals; + } eugenis wrote: > Hmm why are all the other memtag* not here? Yeah, just

[PATCH] D127484: [clang-format] Use tabs on GNU style

curdeius added a comment. It seems like a breaking change that may be painful for users of GNU style. @mydeveloperday, wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D127484

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim created this revision. hctim added a reviewer: pcc. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Enna1. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits.

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

This revision was automatically updated to reflect the committed changes. Closed by commit rGff4abe755279: [scan-build-py] Fix exception on shutdown with sarif-html output format (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ff4abe7 - [scan-build-py] Fix exception on shutdown with sarif-html output format

Author: Anders Waldenborg Date: 2022-06-10T23:21:09+02:00 New Revision: ff4abe755279a3a47cc416ef80dbc900d9a98a19 URL: https://github.com/llvm/llvm-project/commit/ff4abe755279a3a47cc416ef80dbc900d9a98a19 DIFF:

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong added inline comments. Comment at: clang/test/CodeGen/attr-optimize.c:4 + +__attribute__((optimize("O0"))) void f1(void) {} +// O2: @f1{{.*}}[[ATTR_OPTNONE:#[0-9]+]] xbolva00 wrote: > No support for > ``` > __attribute__ ((__optimize__ (0))) > ``` > >

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added inline comments. Comment at: clang/test/CodeGen/attr-optimize.c:4 + +__attribute__((optimize("O0"))) void f1(void) {} +// O2: @f1{{.*}}[[ATTR_OPTNONE:#[0-9]+]] No support for ``` __attribute__ ((__optimize__ (0))) ``` ? GCC supports it

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added a comment. But where I think this feature could be very useful in following case from gcc test suite where there is some FP computation.. Imagine you compile you program with -ffast-math and then you have function: __attribute__ ((optimize ("no-associative-math"))) double fn3

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added a comment. >> Are you opposed to exposing #pragma optimize? >> (https://docs.microsoft.com/en-us/cpp/preprocessor/optimize?view=msvc-170) >> If yes, I think Stephen should run an RFC on Discourse to see if there's >> general agreement. No, I like it, seems more useful and

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 436032. philnik marked 3 inline comments as done. philnik added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files:

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 436030. vaibhav.y added a comment. Rebase on main branch from upstream git Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files:

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aeubanks added a comment. I can't speak for @xbolva00 but the only part I'm against is the user-visible feature of > - Added preliminary support for GCC's attribute `optimize`, which allows > functions to be compiled with different optimization options than what was > specified on the command

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbaa8b9ae5f3: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within… (authored by akyrtzi). Repository: rG LLVM Github

[clang] fbaa8b9 - [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

Author: Argyrios Kyrtzidis Date: 2022-06-10T13:32:19-07:00 New Revision: fbaa8b9ae5f3c6637be7d4dae6adaab4be811625 URL: https://github.com/llvm/llvm-project/commit/fbaa8b9ae5f3c6637be7d4dae6adaab4be811625 DIFF:

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi updated this revision to Diff 436024. akyrtzi added a comment. Remove `// clang-format off` annotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127251/new/ https://reviews.llvm.org/D127251 Files:

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added a comment. In D126984#3574445 , @xbolva00 wrote: > "The optimize attribute should be used for debugging purposes only. It is not > suitable in production code." > > Until they (users) start and any change in pipeline may surprise

[clang] 0fe88f9 - [PS4/PS5] Don't inherit base class alignment

Author: Paul Robinson Date: 2022-06-10T13:15:17-07:00 New Revision: 0fe88f9679ff6df5a7cce7e89038602c35a5e272 URL: https://github.com/llvm/llvm-project/commit/0fe88f9679ff6df5a7cce7e89038602c35a5e272 DIFF: https://github.com/llvm/llvm-project/commit/0fe88f9679ff6df5a7cce7e89038602c35a5e272.diff

[PATCH] D127532: [clang-format] Fix a bug in RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 435900. serge-sans-paille added a comment. Cleanup testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst

LLVM lab will be unavailable today starting 1:30 PM PST

Hello, LLVM lab will be unavailable for a few hours today starting 1:30 PM PST for maintenance. I will send an update when it is completed. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

dyung added a comment. In D126651#3574290 , @johannes wrote: > No idea why the conversion fails for the wide string. > First step is to reproduce the problem. I guess we should try in a Ubuntu VM. > Is there an easy way to see if other builders

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added a comment. "The optimize attribute should be used for debugging purposes only. It is not suitable in production code." Until they (users) start and any change in pipeline may surprise them. Personally I am bigger fan of more targeted attributes like we have noinline / noipa

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rG8db981d463ee: Add sanitizer-specific GlobalValue attributes. (authored by hctim). Repository: rG LLVM

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added a comment. In D126984#3574288 , @xbolva00 wrote: > [[gnu::optimize("O0")]] is okay but [[gnu::optimize("O3 > ")]] is not gonna work without > major changes. Not sure why we should deliver

[clang] 0bb317b - Revert "[cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore"

Author: John Ericson Date: 2022-06-10T19:26:12Z New Revision: 0bb317b7bff3d4f70bddd03a1f337c3f2a118943 URL: https://github.com/llvm/llvm-project/commit/0bb317b7bff3d4f70bddd03a1f337c3f2a118943 DIFF: https://github.com/llvm/llvm-project/commit/0bb317b7bff3d4f70bddd03a1f337c3f2a118943.diff LOG:

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

phosek added a comment. We ran into this in the Fuchsia toolchain where we only ship `libunwind.a` on Linux, but Clang is forcing the use of `libunwind.so` unless you explicitly set `-shared-libgcc`. With this change, the linker will choose whichever library is available by default.

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added a comment. In D126984#3574071 , @xbolva00 wrote: > I agree with @aeubanks , this feature requires major changes to pass manager > and I see no value to land this currently. > > I see that somebody may prefer “opt for size”, but this is

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

phosek created this revision. phosek added reviewers: saugustine, jkz. Herald added a subscriber: mstorsjo. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We shouldn't assume that libunwind.so

[clang] b3b08ad - [Clang] Added missing doc for minsize attribute

Author: Dávid Bolvanský Date: 2022-06-10T21:18:45+02:00 New Revision: b3b08ad6239ccf68bb725defde07edb7a471a9b2 URL: https://github.com/llvm/llvm-project/commit/b3b08ad6239ccf68bb725defde07edb7a471a9b2 DIFF:

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127502: [clang][dataflow] Don't `assert` full LHS coverage in `optional` model

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9ad689e352d: [clang][dataflow] Dont `assert` full LHS coverage in `optional` model (authored by samestep, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a9ad689 - [clang][dataflow] Don't `assert` full LHS coverage in `optional` model

Author: Sam Estep Date: 2022-06-10T19:10:20Z New Revision: a9ad689e352dd1037f947dacc7d01c091b67e00c URL: https://github.com/llvm/llvm-project/commit/a9ad689e352dd1037f947dacc7d01c091b67e00c DIFF: https://github.com/llvm/llvm-project/commit/a9ad689e352dd1037f947dacc7d01c091b67e00c.diff LOG:

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 ___ cfe-commits mailing list

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ezhulenev accepted this revision. ezhulenev added a comment. This revision is now accepted and ready to land. Yes, that's the correct MLIR way of passing attributes to LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

johannes added a comment. No idea why the conversion fails for the wide string. First step is to reproduce the problem. I guess we should try in a Ubuntu VM. Is there an easy way to see if other builders succeeded? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added a comment. [[gnu::optimize("O0")]] is okay but [[gnu::optimize("O3 ")]] is not gonna work without major changes. Not sure why we should deliver half-broken new attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

wanders updated this revision to Diff 435999. wanders added a comment. Updated patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 Files:

[PATCH] D127519: [clang-cl] Accept /FA[c][s][u], but ignore the arguments

steplong added reviewers: rnk, hans. steplong added a comment. I'm not sure which test file to modify and how to test this. I do see it generating the `.asm` file now when I pass `/FAsc`, not the `.codd` file though since we are ignoring the `c` argument. Repository: rG LLVM Github Monorepo

[PATCH] D127519: [clang-cl] Accept /FA[c][s][u], but ignore the arguments

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously, /FAsc would emit a warning. Now, it will just do what /FA does.

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:1-2 +// clang-format off + // RUN: %clang_cc1 -fsyntax-only -verify=pre-c2x-cpp2b %s akyrtzi wrote: > akyrtzi wrote: > > aaron.ballman wrote: > > > You can

[PATCH] D127408: [clang][driver] Introduce new -fdriver-only flag

dexonsmith accepted this revision. dexonsmith added a comment. LGTM with a minor comment on the test. Comment at: clang/test/Driver/driver-only.c:13 + +// Check that -fdriver-only respects -v. +// Should there be a `-check-epmty` or similar when `-v` is not

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta created this revision. xgupta added a reviewer: aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/52873. Don't warn in C++2A

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added a comment. In D126984#3574077 , @aeubanks wrote: > In D126984#3574046 , @aaron.ballman > wrote: > >> In D126984#3571573 , @aeubanks >> wrote: >> >>>

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

phosek added a comment. Would it be possible to reupload the diff with full context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 ___ cfe-commits mailing

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aeubanks added a comment. In D126984#3574091 , @steplong wrote: > In D126984#3574077 , @aeubanks > wrote: > >> In D126984#3574046 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3571511 , @njames93 wrote: > Search engines isn't really an issue, its more people who are using older > versions of llvm that try and go to the documentation which turns out is a > dead link. > Having

[PATCH] D127515: [Clang] Change host/device only compilation to a driver mode

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, JonChesterfield, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We use the flags `--offload-host-only` and

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong added a comment. In D126984#3574077 , @aeubanks wrote: > In D126984#3574046 , @aaron.ballman > wrote: > >> In D126984#3571573 , @aeubanks >> wrote: >> >>> IIRC

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. So from what I can tell, the problem is evaluating `Constraint` on `initiate`, and trying to find the 'right' argument from the `MultiLevelTemplateArgumentList` for `RawCompletionToken`. The problem is that the `RawCompletionToken`, as a template parameter, gets

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aeubanks added a comment. In D126984#3574046 , @aaron.ballman wrote: > In D126984#3571573 , @aeubanks > wrote: > >> IIRC in the past there was a strong preference to not have the pass manager >> support this

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

xbolva00 added a comment. I agree with @aeubanks , this feature requires major changes to pass manager and I see no value to land this currently. I see that somebody may prefer “opt for size”, but this is exposed via “minsize” attribute so I see no strong need for optimize(“-Os”) Repository:

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:645 if (getToolChain().getDriver().IsFlangMode() && Args.hasArg(options::OPT_flang_experimental_exec)) { addFortranRuntimeLibraryPath(getToolChain(), Args, CmdArgs);

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aeubanks added a comment. In D126984#3574033 , @steplong wrote: > In D126984#3571573 , @aeubanks > wrote: > >> IIRC in the past there was a strong preference to not have the pass manager >> support this sort of

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added a comment. In D126984#3571573 , @aeubanks wrote: > IIRC in the past there was a strong preference to not have the pass manager > support this sort of thing > if you want to support this, there should be an RFC for how the

[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

isthismyaccount accepted this revision. isthismyaccount added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong added a comment. In D126984#3571573 , @aeubanks wrote: > IIRC in the past there was a strong preference to not have the pass manager > support this sort of thing > if you want to support this, there should be an RFC for how the optimization >

[PATCH] D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5019ffc8efd: [SystemZ/z/OS] Set DWARF version to 4 for z/OS. (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127498/new/

[clang] b5019ff - [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

Author: Kai Nacke Date: 2022-06-10T13:38:58-04:00 New Revision: b5019ffc8efd472d18eb9ed55a004af8d713583d URL: https://github.com/llvm/llvm-project/commit/b5019ffc8efd472d18eb9ed55a004af8d713583d DIFF: https://github.com/llvm/llvm-project/commit/b5019ffc8efd472d18eb9ed55a004af8d713583d.diff

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2042 +!SemaRef.CheckConstraintExpression(TransConstraint.get())) { + assert(Trap.hasErrorOccurred() && "CheckConstraintExpression failed, but " +

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added a comment. Thank you for review! Committed in https://reviews.llvm.org/rGa01579ad0a1bde4d90f4fb656f07586c3097428a. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___ cfe-commits

[clang] a01579a - [NFC] Suggest Release mode in clang GettingStarted.html

Author: Shivam Gupta Date: 2022-06-10T11:00:05+05:30 New Revision: a01579ad0a1bde4d90f4fb656f07586c3097428a URL: https://github.com/llvm/llvm-project/commit/a01579ad0a1bde4d90f4fb656f07586c3097428a DIFF: https://github.com/llvm/llvm-project/commit/a01579ad0a1bde4d90f4fb656f07586c3097428a.diff

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf21187eb2d94: [clang][tablegen] adds human documentation to `WarningOption` (authored by cjdb). Changed prior to commit:

[clang] f21187e - [clang][tablegen] adds human documentation to `WarningOption`

Author: Christopher Di Bella Date: 2022-06-10T17:23:00Z New Revision: f21187eb2d943c1407ae764b87f73602177dcba8 URL: https://github.com/llvm/llvm-project/commit/f21187eb2d943c1407ae764b87f73602177dcba8 DIFF:

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Looks fine to me. Thanks for fixing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

sberg added a comment. There might be something fishy with this commit. My fresh from-scratch `cmake --build . && cmake --build . --target install` monorepo build now lacked e.g. the `bin/clang++` symlink in the installation dir, and locally reverting this commit fixed that. Repository:

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. In D126291#3573937 , @mmuetzel wrote: > Ah ok. So instead of having `! REQUIRES:` lines, those tests should add > `-target x86_64-windows-msvc` to the flang invocation? Exactly > On platforms that didn't build the necessary

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. In D126291#3573751 , @mstorsjo wrote: > Maybe, but keep in mind that those kinds of tests should be the exception, > not the rule. > > As clang (and flang too, I would presume) generally can be cross compiling, > one shouldn't

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a missing comma (that can be fixed when landing). But you should give @thieta a chance to chime in before landing. Comment at: clang/www/get_started.html:72 cd build -cmake

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2042 +!SemaRef.CheckConstraintExpression(TransConstraint.get())) { + assert(Trap.hasErrorOccurred() && "CheckConstraintExpression failed, but " +

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html === ---

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `getCurrentFile` here causes an assertion on some condition. `getCurrentFileOrBufferName` is preferrable instead.

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

aaron.ballman added a comment. Looks pretty close, just some minor nits from me. Comment at: clang/www/get_started.html:72-75 +This builds both LLVM and Clang for release mode. Alternatively if +you need a debug build, switch Release to Debug. See +

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/fpclamptosat_vec.ll:605 +; CHECK-NEXT:.cfi_def_cfa_offset 80 +; CHECK-NEXT:movss %xmm2, {{[-0-9]+}}(%r{{[sb]}}p) # 4-byte Spill +; CHECK-NEXT:movss %xmm1, {{[-0-9]+}}(%r{{[sb]}}p) # 4-byte Spill

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added inline comments. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build. cmake

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435947. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2257 + + F->setPrefixData(CreateKCFITypeId(FD->getType())); + F->addFnAttr("kcfi-target"); ychen wrote: > FYI: using prefix data may not work for the C++ coroutine. >

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. In D126291#3573742 , @mmuetzel wrote: > In D126291#3573607 , @mstorsjo > wrote: > >> FWIW, something very similar was added just a couple days ago in an lldb >> specific lit.cfg.py:

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. In D126291#3573607 , @mstorsjo wrote: > FWIW, something very similar was added just a couple days ago in an lldb > specific lit.cfg.py: https://reviews.llvm.org/D127048#change-KJ7QgKPHtN1S Thank you for pointing this out.

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:352 + [this](const Expr *AtomicExpr) -> ExprResult { +// We only do this to immitate lvalue-to-rvalue conversion. +return

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

erichkeane added a comment. In D127487#3573667 , @ilya-biryukov wrote: > I've checked that the change works fine on top of D126907 > . The bug is still there after D126907 > and gets

  1   2   3   >