[clang-tools-extra] [clangd] [HeuristicResolver] Protect against infinite recursion on DependentNameTypes (PR #83542)

2024-03-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thank you for the quick fix! While I think the patch looks generally good to me, it would be better to add some analysis of the bug. That said, I took a closer look at it, and I think I probably have another similar approach that doesn't

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-03-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/83660 >From 771c0740dcc438d99baf4ad9555bc57e963001df Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 1 Mar 2024 22:17:09 -0800 Subject: [PATCH] [clang][modules] Headers meant to be included multiple

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-03-01 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Thanks to @Bigcheese for helping with this patch. https://reviews.llvm.org/D26267 looks like the most recent significant update to this code that we could find. It had an additional allowance where clang headers that were _not_ marked `textual` could be re-entered. I

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 07317bbc66d1f2d7663af3c9f04d0f6c0487ac03 171d0e299dd676ce29583e16fdf8c3e6f3dd7925 --

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ian Anderson (ian-twilightcoder) Changes Once a file has been `#import`'ed, it gets stamped as if it was `#pragma once` and will not be re-entered, even on #include. This means that any errant #import of a file designed to be included

[clang] [clang][modules] Headers meant to be included multiple times can be completely invisible in clang module builds (PR #83660)

2024-03-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/83660 Once a file has been `#import`'ed, it gets stamped as if it was `#pragma once` and will not be re-entered, even on #include. This means that any errant #import of a file designed to be included

[clang] [clang][nullability] allow _Nonnull etc on nullable class types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/82705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-01 Thread Shafik Yaghmour via cfe-commits
@@ -100,6 +100,12 @@ void AttributePool::takePool(AttributePool ) { pool.Attrs.clear(); } +void AttributePool::takeFrom(ParsedAttributesView , AttributePool ) { + assert( != this && "AttributePool can't take attributes from itself"); + llvm::for_each(List.AttrList,

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-01 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Note, I opened an issue for this here: https://github.com/llvm/llvm-project/issues/83385 https://github.com/llvm/llvm-project/pull/83611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ExprEngineCXX] Fix crash on dereference invalid return value of getAdjustedParameterIndex() (PR #83585)

2024-03-01 Thread Ella Ma via cfe-commits
Snape3058 wrote: Add suggested reviewers for this PR. I am unfamiliar with the engine code. > mzyKi force-pushed the bugfix/crash-on-getAdjustedParameterIndex branch Please do not force push to your forked repo later after receiving suggestions from other reviewers. This will make previous

[clang] [clang][nullability] allow _Nonnull etc on nullable class types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/82705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][nullability] allow _Nonnull etc on gsl::Pointer types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/82705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIP] change compress level (PR #83605)

2024-03-01 Thread Yaxun Liu via cfe-commits
@@ -942,20 +942,28 @@ CompressedOffloadBundle::compress(const llvm::MemoryBuffer , Input.getBuffer().size()); llvm::compression::Format CompressionFormat; + int Level; - if (llvm::compression::zstd::isAvailable()) + if (llvm::compression::zstd::isAvailable()) {

[clang] [clang][nullability] allow _Nonnull etc on gsl::Pointer types (PR #82705)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Sam McCall (sam-mccall) Changes This enables external nullability checkers to make use of these annotations on smart pointer types. Existing static warnings for raw pointers are extended to smart pointers: - nullptr used as

[clang] [clang][nullability] allow _Nonnull etc on gsl::Pointer types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall ready_for_review https://github.com/llvm/llvm-project/pull/82705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][nullability] allow _Nonnull etc on gsl::Pointer types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/82705 >From eccc46840e343e7ba15200cd4b81316a51c46943 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Thu, 22 Feb 2024 16:00:44 +0100 Subject: [PATCH] [clang][nullability] allow _Nonnull etc on nullable class types

[clang] [clang][nullability] allow _Nonnull etc on gsl::Pointer types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/82705 >From 5df9923adddce2668322f4ae356f38fc50a11764 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Thu, 22 Feb 2024 16:00:44 +0100 Subject: [PATCH] [clang][nullability] allow _Nonnull etc on nullable class types

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-01 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/83641 >From c2445d426e374592522ac392254c9909ab52fc40 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Fri, 1 Mar 2024 17:18:20 -0800 Subject: [PATCH] [clang] Diagnose config_macros before building modules

[clang] [clang][nullability] allow _Nonnull etc on gsl::Pointer types (PR #82705)

2024-03-01 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/82705 >From 03fbcda73e9feef586f87e2a0a203636fa8ce172 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Thu, 22 Feb 2024 16:00:44 +0100 Subject: [PATCH] [clang][nullability] allow _Nonnull etc on nullable class types

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-03-01 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229 >From 234e301ab2721ddb2f4b43589785015a7d0aa304 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 19 Feb 2024 01:07:13 -0800 Subject: [PATCH 1/6] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-01 Thread Anton Korobeynikov via cfe-commits
asl wrote: I am ok with the changes. Though with pauth we'd probably need to rename `getRawPointerFromAddress` to indicate clearer that it has side effects (like `extractRawPointerFromAddress` or something like this) https://github.com/llvm/llvm-project/pull/67454

[clang] [llvm] [X86] Use generic CPU tuning when tune-cpu is empty (PR #83631)

2024-03-01 Thread via cfe-commits
AtariDreams wrote: > This doesn't change any tests? It does now. https://github.com/llvm/llvm-project/pull/83631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Use generic CPU tuning when tune-cpu is empty (PR #83631)

2024-03-01 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/83631 >From 740e20934922eca596b082f59f5d2252c9fa1d70 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 1 Mar 2024 17:52:58 -0500 Subject: [PATCH] [X86] Use generic CPU

[clang] [clang-format][NFC] Replace Style.isCpp() with IsCpp (PR #83533)

2024-03-01 Thread Owen Pan via cfe-commits
owenca wrote: > The question is: why? And why handle c++ different than all other languages? This is the preparation for fixing/extending `FormatToken::isSimpleTypeSpecifier()`, which I'll add a couple of parameters to, e.g. `isSimpleTypeSpecifier(bool IsCpp, const LangOptions )`. Also, this

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

2024-03-01 Thread Atousa Duprat via cfe-commits
Atousa wrote: please @AaronBallman https://github.com/llvm/llvm-project/pull/80939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixes of builtin definitions after PR #68324. (PR #81022)

2024-03-01 Thread via cfe-commits
michele-scandale wrote: @AaronBallman, ping. https://github.com/llvm/llvm-project/pull/81022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Michael Spencer (Bigcheese) Changes Before this patch, if a module fails to build because of a missing config_macro, the user will never see the config macro warning. This patch diagnoses this before building, and each subsequent

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Spencer (Bigcheese) Changes Before this patch, if a module fails to build because of a missing config_macro, the user will never see the config macro warning. This patch diagnoses this before building, and each subsequent time a

[clang] [clang] Diagnose config_macros before building modules (PR #83641)

2024-03-01 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese created https://github.com/llvm/llvm-project/pull/83641 Before this patch, if a module fails to build because of a missing config_macro, the user will never see the config macro warning. This patch diagnoses this before building, and each subsequent time a module

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -0,0 +1,84 @@ +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 < %s | FileCheck %s + +; Attribute not specified. +; CHECK-LABEL: {{^}}empty_no_attribute: +define amdgpu_kernel void @empty_no_attribute() { +entry: + ret void +} + +; Ignore if number of work groups for x

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -0,0 +1,84 @@ +; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 < %s | FileCheck %s + jwanggit86 wrote: Created a new test file to test various errors. https://github.com/llvm/llvm-project/pull/79035 ___

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -814,6 +814,15 @@ bool shouldEmitConstantsToTextSection(const Triple ); /// to integer. int getIntegerAttribute(const Function , StringRef Name, int Default); +/// \returns Unsigned Integer value requested using \p F's \p Name attribute. +/// +/// \returns \p Default if

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -194,3 +204,105 @@ __global__ void non_cexpr_waves_per_eu_2() {} // expected-error@+1{{'amdgpu_waves_per_eu' attribute requires parameter 1 to be an integer constant}} __attribute__((amdgpu_waves_per_eu(2, ipow2(2 __global__ void non_cexpr_waves_per_eu_2_4() {} + +//

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -139,6 +139,36 @@ kernel void reqd_work_group_size_32_2_1_flat_work_group_size_16_128() { // CHECK: define{{.*}} amdgpu_kernel void @reqd_work_group_size_32_2_1_flat_work_group_size_16_128() [[FLAT_WORK_GROUP_SIZE_16_128:#[0-9]+]] }

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -356,6 +356,24 @@ void AMDGPUTargetCodeGenInfo::setFunctionDeclAttributes( if (NumVGPR != 0) F->addFnAttr("amdgpu-num-vgpr", llvm::utostr(NumVGPR)); } + + if (const auto *Attr = FD->getAttr()) { +uint32_t X = Attr->getMaxNumWorkGroupsX() +

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-03-01 Thread Jun Wang via cfe-commits
@@ -137,6 +137,11 @@ Removed Compiler Flags Attribute Changes in Clang -- +- Introduced a new function attribute ``__attribute__((amdgpu_max_num_work_groups(x, y, z)))`` or + ``[[clang::amdgpu_max_num_work_groups(x, y, z)]]`` for the AMDGPU target.

[clang] 164c098 - [clang][deps] Implement move-conversion for `CowCompilerInvocation` (follow-up)

2024-03-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-03-01T16:53:12-08:00 New Revision: 164c0985681648cf18bef69d75ece2b327525737 URL: https://github.com/llvm/llvm-project/commit/164c0985681648cf18bef69d75ece2b327525737 DIFF: https://github.com/llvm/llvm-project/commit/164c0985681648cf18bef69d75ece2b327525737.diff

[clang] 864593b - [clang][api-notes] NFC: Upstream some documentation

2024-03-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-03-01T16:53:12-08:00 New Revision: 864593b91d289c57c64a0f12658b9ff415da1ad8 URL: https://github.com/llvm/llvm-project/commit/864593b91d289c57c64a0f12658b9ff415da1ad8 DIFF: https://github.com/llvm/llvm-project/commit/864593b91d289c57c64a0f12658b9ff415da1ad8.diff

[clang] 39b67c0 - [clang] NFC: Extract `CompilerInstance` function

2024-03-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-03-01T16:53:12-08:00 New Revision: 39b67c03214b24da103863abc77c625e71aadd34 URL: https://github.com/llvm/llvm-project/commit/39b67c03214b24da103863abc77c625e71aadd34 DIFF: https://github.com/llvm/llvm-project/commit/39b67c03214b24da103863abc77c625e71aadd34.diff

[clang] 5594d12 - [clang][driver] NFC: Upstream comment

2024-03-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-03-01T16:53:12-08:00 New Revision: 5594d12af540dfcc684a02a232484c2b4dd2f5b5 URL: https://github.com/llvm/llvm-project/commit/5594d12af540dfcc684a02a232484c2b4dd2f5b5 DIFF: https://github.com/llvm/llvm-project/commit/5594d12af540dfcc684a02a232484c2b4dd2f5b5.diff

[clang] 70467dd - [clang][index] NFC: Stylistic changes

2024-03-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-03-01T16:53:11-08:00 New Revision: 70467dd0ee0fee2877bf17a465ab975a84baa360 URL: https://github.com/llvm/llvm-project/commit/70467dd0ee0fee2877bf17a465ab975a84baa360 DIFF: https://github.com/llvm/llvm-project/commit/70467dd0ee0fee2877bf17a465ab975a84baa360.diff

[clang] ecd7fce - [clang][sema] NFC: Stylistic changes

2024-03-01 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-03-01T16:53:11-08:00 New Revision: ecd7fce0d4e14cbae7beb9b0b30966435f8ee851 URL: https://github.com/llvm/llvm-project/commit/ecd7fce0d4e14cbae7beb9b0b30966435f8ee851 DIFF: https://github.com/llvm/llvm-project/commit/ecd7fce0d4e14cbae7beb9b0b30966435f8ee851.diff

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-03-01 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229 >From 234e301ab2721ddb2f4b43589785015a7d0aa304 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 19 Feb 2024 01:07:13 -0800 Subject: [PATCH 1/5] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object

[clang] ed0aa34 - [Driver] Add BoolMOption to simplify boolean -m* options

2024-03-01 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-03-01T16:40:26-08:00 New Revision: ed0aa344a8aaab4d8eedbe800750b8dcd36b0bcd URL: https://github.com/llvm/llvm-project/commit/ed0aa344a8aaab4d8eedbe800750b8dcd36b0bcd DIFF: https://github.com/llvm/llvm-project/commit/ed0aa344a8aaab4d8eedbe800750b8dcd36b0bcd.diff

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

2024-03-01 Thread Atousa Duprat via cfe-commits
https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/7] [clang] Use separator for large numeric values in overflow

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

2024-03-01 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: ping https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 69b8372 - [clang][sema] consolidate diags for incompatible_vector_* (#83609)

2024-03-01 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-03-01T19:11:28-05:00 New Revision: 69b837203fb84774dbc4333ebd06654ab2249fe0 URL: https://github.com/llvm/llvm-project/commit/69b837203fb84774dbc4333ebd06654ab2249fe0 DIFF: https://github.com/llvm/llvm-project/commit/69b837203fb84774dbc4333ebd06654ab2249fe0.diff

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object references within trivial statements (PR #82229)

2024-03-01 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/82229 >From fd171b82d03b29926984b5b835ad9c0ccf197536 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 19 Feb 2024 01:07:13 -0800 Subject: [PATCH 1/5] [alpha.webkit.UncountedLocalVarsChecker] Allow uncounted object

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH 1/3] [Frontend] Add leaf constructs and association to

[clang] [llvm] [InstallAPI] Collect symbols from ObjC Ivars (PR #83632)

2024-03-01 Thread Cyndy Ishida via cfe-commits
@@ -27,12 +27,40 @@ __attribute__((objc_exception)) @interface Exception @end + +//--- Foo.framework/PrivateHeaders/Foo_Private.h +#import + +@interface ClassWithIvars : Visible { cyndyishida wrote: Something like ```

[clang] [llvm] [InstallAPI] Collect symbols from ObjC Ivars (PR #83632)

2024-03-01 Thread Juergen Ributzka via cfe-commits
@@ -27,12 +27,40 @@ __attribute__((objc_exception)) @interface Exception @end + +//--- Foo.framework/PrivateHeaders/Foo_Private.h +#import + +@interface ClassWithIvars : Visible { ributzka wrote: Please also add a test that has the reverse order of access

[clang] [llvm] [InstallAPI] Collect symbols from ObjC Ivars (PR #83632)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/83632.diff 7 Files Affected: - (modified) clang/include/clang/InstallAPI/Frontend.h (+35) - (modified)

[clang] [llvm] [InstallAPI] Collect symbols from ObjC Ivars (PR #83632)

2024-03-01 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/83632 None >From 30f1fb6e8afbc0f793c3276ffda03fc50505ec73 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Thu, 29 Feb 2024 20:52:02 -0800 Subject: [PATCH] [InstallAPI] Collect symbols from ObjC Ivars ---

[clang] [HLSL] Add HLSLRootSignatureAttr. (PR #83630)

2024-03-01 Thread Chris B via cfe-commits
https://github.com/llvm-beanz requested changes to this pull request. We need to discuss the design and implementation approach for this before we write any code for this feature. https://github.com/llvm/llvm-project/pull/83630 ___ cfe-commits

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Erich Keane via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [HLSL] Add HLSLRootSignatureAttr. (PR #83630)

2024-03-01 Thread Xiang Li via cfe-commits
https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/83630 >From 994a475a75ffe9c7b7db40f4d374b4a4eb63068e Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Fri, 1 Mar 2024 17:52:00 -0500 Subject: [PATCH 1/2] [HLSL] Add HLSLRootSignatureAttr. First PR for RootSignature

[clang] bcc6ca7 - [InstallAPI] Add missing link to clangLex

2024-03-01 Thread Cyndy Ishida via cfe-commits
Author: Cyndy Ishida Date: 2024-03-01T15:02:57-08:00 New Revision: bcc6ca7ff86518caa97c6f20735a4728e18caa78 URL: https://github.com/llvm/llvm-project/commit/bcc6ca7ff86518caa97c6f20735a4728e18caa78 DIFF: https://github.com/llvm/llvm-project/commit/bcc6ca7ff86518caa97c6f20735a4728e18caa78.diff

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Valentin Clement バレンタイン クレメン via cfe-commits
https://github.com/clementval approved this pull request. Looks good to me from the OpenACC point of view. Someone from OpenMP should approve as well. https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailing list

[clang] [HLSL] Add HLSLRootSignatureAttr. (PR #83630)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 113052b2b022c4ce45c8003057ae4297d48ed843 994a475a75ffe9c7b7db40f4d374b4a4eb63068e --

[clang] [HLSL] Add HLSLRootSignatureAttr. (PR #83630)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang Author: Xiang Li (python3kgae) Changes First PR for RootSignature support. HLSLRootSignatureAttr is added. It will save the original input string for rewrite and a fake variable for the parsed result. Parsing will be in

[clang] [HLSL] Add HLSLRootSignatureAttr. (PR #83630)

2024-03-01 Thread Xiang Li via cfe-commits
https://github.com/python3kgae created https://github.com/llvm/llvm-project/pull/83630 First PR for RootSignature support. HLSLRootSignatureAttr is added. It will save the original input string for rewrite and a fake variable for the parsed result. Parsing will be in the following PR. For

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/83378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 17ede03 - [InstallAPI] Collect frontend attributes & ObjCInterface decls (#83378)

2024-03-01 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-03-01T14:56:20-08:00 New Revision: 17ede03a926a8d8d35d887f1fe805b35e2078d5a URL: https://github.com/llvm/llvm-project/commit/17ede03a926a8d8d35d887f1fe805b35e2078d5a DIFF: https://github.com/llvm/llvm-project/commit/17ede03a926a8d8d35d887f1fe805b35e2078d5a.diff

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-03-01 Thread via cfe-commits
@@ -2022,6 +2022,19 @@ static void getTrivialDefaultFunctionAttributes( std::tie(Var, Value) = Attr.split('='); FuncAttrs.addAttribute(Var, Value); } + + TargetInfo::BranchProtectionInfo BPI(LangOpts); + DanielKristofKiss wrote: after #82819 lands,

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka approved this pull request. https://github.com/llvm/llvm-project/pull/83378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/83378 >From b3a2e850cbb7953902c6c64eb9c120422ec528bc Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 28 Feb 2024 14:15:48 -0800 Subject: [PATCH] [InstallAPI] Collect frontend attributes during &

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-03-01 Thread via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/82819 >From 9e844b9e61ad1c81983aafd7ac9b3fb9e1939787 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Mon, 22 Jan 2024 11:33:15 +0100 Subject: [PATCH] Emit attributes for functions always. Branch

[clang] [Clang] [Sema] Handle placeholders in '.*' expressions (PR #83103)

2024-03-01 Thread Andrew Kaster via cfe-commits
ADKaster wrote: @AaronBallman @Sirraide would this patch be reasonable to backport to the 18.x release branch? It fixes a problem with our application on the FreeBSD-CURRENT branch. https://github.com/SerenityOS/serenity/issues/23365 https://github.com/llvm/llvm-project/pull/83103

[clang] 24aec16 - [OpenACC] Implement no throw out of Compute construct

2024-03-01 Thread via cfe-commits
Author: erichkeane Date: 2024-03-01T14:23:27-08:00 New Revision: 24aec16ddad465cc1c2fce528bb3eca49ac9fcdb URL: https://github.com/llvm/llvm-project/commit/24aec16ddad465cc1c2fce528bb3eca49ac9fcdb DIFF: https://github.com/llvm/llvm-project/commit/24aec16ddad465cc1c2fce528bb3eca49ac9fcdb.diff

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83609 >From bfd8afd06400bc936c13d2138576bb0bb51960e9 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Fri, 1 Mar 2024 14:21:17 -0500 Subject: [PATCH 1/2] [clang][sema] consolidate diags ---

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -5218,15 +5218,15 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: type promotion is intended to be handeled via the intrinsics // and not the builtin itself. S->Diag(TheCall->getBeginLoc(), -

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -5241,8 +5241,8 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: if we get here one of the args is a scalar which // requires a VectorSplat on Arg0 or Arg1 - S->Diag(BuiltinLoc, diag::err_vec_builtin_non_vector_all) - <<

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I removed the check for `end do simd` with a comment that it can't appear in clang. I think you deleted that remark, let me know if I should bring the check back. https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH 1/2] [Frontend] Add leaf constructs and association to

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH] [Frontend] Add leaf constructs and association to

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind ==

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Juergen Ributzka via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d01576bb6033865c20a4c0da581939dcae5b30be 544b309d77a7094d35794e574a1a1d12438021cd --

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes Add members "leafs" and "association" to .td describing OpenMP/ACC directives: "leafs" are the leaf constructs for composite/combined constructs, and "association" is the source language construct

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Andy Kaylor via cfe-commits
@@ -1847,19 +1847,50 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. +.. option:: -fcomplex-arithmetic=: + + This option specifies the

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Andy Kaylor via cfe-commits
@@ -283,9 +283,46 @@ class ComplexExprEmitter ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName, const BinOpInfo ); - QualType getPromotionType(QualType Ty) { + QualType HigherPrecisionTypeForComplexArithmetic(QualType

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/83625 Add members "leafs" and "association" to .td describing OpenMP/ACC directives: "leafs" are the leaf constructs for composite/combined constructs, and "association" is the source language construct to which the

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: Endilll wrote: > I have added tests to other files what are relevant for the DR too. Should I > move them here? I trust your judgement

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Andy Kaylor via cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. -.. option:: -fcx-limited-range: - - This option enables the naive

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-03-01 Thread Pavel Kosov via cfe-commits
kpdev wrote: > Should we add a release note to `clang/docs/ReleaseNotes.rst` so users know > about the changes? Seems reasonable ) Should I add it somewhere to [`Sanitizers`](https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst#sanitizers) ?

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @pow2clk force doesn't seem necessary b\c squash merge is the default behavior for this project. I did it because i tend to rebase my branches when I put out revisions. I'll stop doing that. https://github.com/llvm/llvm-project/pull/83609

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-03-01 Thread Pavel Kosov via cfe-commits
@@ -3443,11 +3443,28 @@ void CodeGenFunction::EmitCfiSlowPathCheck( void CodeGenFunction::EmitCfiCheckStub() { llvm::Module *M = (); auto = M->getContext(); + auto = getContext(); kpdev wrote: Changed, please review

[clang] d01576b - [TargetParser][AArch64] Add alias for FEAT_RDM. (#80540)

2024-03-01 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-03-01T21:06:08Z New Revision: d01576bb6033865c20a4c0da581939dcae5b30be URL: https://github.com/llvm/llvm-project/commit/d01576bb6033865c20a4c0da581939dcae5b30be DIFF:

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-03-01 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/80540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >