[PATCH] D59118: creduce script for clang crashes

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a script that calls C-Reduce on an input file and given the clang crash script, which is used to g

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190126. akhuang marked 15 inline comments as done. akhuang added a comment. Addressed readability comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index:

[PATCH] D59118: creduce script for clang crashes

akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:43 + # Get crash output + p = subprocess.Popen(build_script, + stdout=subprocess.PIPE, george.burgess.iv wrote: > nit: can replace with `subprocess.check_output`

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190164. akhuang added a comment. fixed diff with style edits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: .arcconfig clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.p

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190189. akhuang added a comment. add interestingness test sanity check; revive ctrl-c hack CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/cred

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190285. akhuang marked 6 inline comments as done. akhuang added a comment. style edits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. -try to preprocess the file before reducing -try to remove some command line arguments -now requires a

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 190929. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py ==

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191128. akhuang added a comment. fix some typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191192. akhuang added a comment. Modify interestingness test to take file as input CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clan

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191199. akhuang marked an inline comment as done. akhuang added a comment. fixed array copy mistake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/u

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191217. akhuang marked 2 inline comments as done. akhuang added a comment. Fixed typo where it was writing the abspath of the file to the interestingness test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:106-117 + # Check that an empty file is not interesting + # file_to_reduce is hardcoded into the test, so this is a roundabout + # way to run it on an empty

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191409. akhuang added a comment. style things CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py ==

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191598. akhuang added a comment. style nits, fixed thing in getting path to clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang added a comment. @arichardson Will add you next time, sorry I didn't do so on this one! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 ___ cfe-commits mailing list cf

[PATCH] D59725: Additions to creduce script

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv, arichardson. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some more additions to the script - mainly reducing the clang args after the creduce run

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192145. akhuang added a comment. Fix some typos, pass --tidy flag to creduce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-cras

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192149. akhuang added a comment. reuploaded diff with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py =

[PATCH] D59725: Additions to creduce script

akhuang marked 15 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:137 + +# If no message was found, use the top five stack trace functions, +# ignoring some common functions george.burgess.iv wrote: >

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192218. akhuang marked an inline comment as done. akhuang added a comment. Style nits, added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang

[PATCH] D59725: Additions to creduce script

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:223 + if len(x) > 0 and x[-1].startswith('-') and not y.startswith('-'): +x[-1] += ' ' + y +return x george.burgess.iv wro

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192230. akhuang added a comment. fix issue with grouping two command line args together CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce

[PATCH] D59725: Additions to creduce script

akhuang marked 8 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:145 + matches = re.findall(stacktrace_re, crash_output) + result = filter(lambda x: x and x.strip() not in filters, matches)[:5] + for msg in res

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192350. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: jdoerfert. added to error message regexes and command line flags CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192499. akhuang marked 3 inline comments as done. akhuang added a comment. change `mkstemp` to `NamedTemporaryFile` and add `decode(utf-8)` so it works on python3.5 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D

[PATCH] D59725: Additions to creduce script

akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:198 +# Instead of modifying the filename in the test file, just run the command +fd, empty_file = tempfile.mkstemp() +if self.check_expected_output(filename=empty_file): geo

[PATCH] D59725: Additions to creduce script

akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:212 + +cmd = self.get_crash_cmd() + ['-E', '-P'] +try: arichardson wrote: > Some crash messages might include the line numbers, do you think it makes > sense to fall back to ru

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192669. akhuang marked 3 inline comments as done. akhuang added a comment. Add preprocessing with clang -E only; use `with` for opening files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/ut

[PATCH] D59725: Additions to creduce script

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:208 +print("\nTrying to preprocess the source file...") +# use delete=False in case the tmpfile flag causes problems when copying +with tempfile.Nam

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192846. akhuang marked an inline comment as done. akhuang added a comment. Tmpfile was not being removed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 Files: clang/utils/creduce-clang-crash.py Index: cl

[PATCH] D60236: add periods

akhuang created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. emit metadata for __declspec(allocator) add tests for heapallocsite metadata Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60236 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Emit !heapallocsite in the metadata for calls to functions marked with __declspec(allocator). Eventually this will be emitted as S_HEAPALLOCSITE debug info in co

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691 } else { -// Build new lvalue for temp address +// Build new lvalue for temp address. Address Ptr = Atomics.materializeRValue(OldRVal); ---

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 193751. akhuang marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h c

[PATCH] D60236: add periods

akhuang abandoned this revision. akhuang added a comment. test commit with incorrect diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60236/new/ https://reviews.llvm.org/D60236 ___ cfe-commits mailin

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 193792. akhuang marked 3 inline comments as done. akhuang added a comment. -added struct case to test -style fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp clan

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 194164. akhuang marked 2 inline comments as done. akhuang added a comment. Fixes to test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebug

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

This revision was automatically updated to reflect the committed changes. Closed by commit rL357928: [MS] Add metadata for __declspec(allocator) (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

akhuang added a comment. Looks good- if we remove `not` there are a few other things that should be removed Comment at: clang/utils/creduce-clang-crash.py:138 if "fatal error:" in msg_re: self.is_crash = False break also wouldn't n

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang created this revision. akhuang added reviewers: hans, rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug info in codeview. Currently only changes FastISel,

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195475. akhuang added a comment. remove comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-in

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195478. akhuang added a comment. more typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-c

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195480. akhuang added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-inf

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195783. akhuang marked 4 inline comments as done. akhuang added a comment. Removed extraneous information from test; changed type to DIType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://revie

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy, getOrCreateFile(Loc)); + CI->setMetadata("heapallocsite", DI); hans wrote

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195818. akhuang marked 2 inline comments as done. akhuang added a comment. - Pass void metadata as null DIType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files:

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195821. akhuang marked 2 inline comments as done. akhuang added a comment. - Changed test case back to original Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files:

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: llvm/test/CodeGen/X86/label-heapallocsite.ll:1 +; RUN: llc -O0 < %s | FileCheck %s +; FIXME: Add test for llc with optimizations once it is implemented. hans wrote: > Does llc ha

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195877. akhuang added a comment. whitespace fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/CodeGen/M

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL358783: [MS] Emit S_HEAPALLOCSITE debug info (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D60800?vs=195877&id=195909#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug info in codeview. Currently only changes FastISel, so em

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

akhuang updated this revision to Diff 196496. akhuang added a comment. - remove added whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61083/new/ https://reviews.llvm.org/D61083 Files: llvm/include/llvm/CodeGen/MachineFunction.h llvm/i

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

akhuang updated this revision to Diff 196525. akhuang added a comment. - Add test case and comment for undefined labels Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61083/new/ https://reviews.llvm.org/D61083 Files: llvm/include/llvm/CodeGen/Mac

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

This revision was automatically updated to reflect the committed changes. Closed by commit rL359149: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with… (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D61083?vs=196525&id=196540#t

[PATCH] D59725: Additions to creduce script

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + lebedev.ri wrote: > >>! In D597

[PATCH] D59725: Additions to creduce script

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + lebedev.ri wrote: > akhuang wro

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197651. akhuang added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/te

[PATCH] D61455: Change the metadata for heapallocsite calls when the type is cast.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang abandoned this revision. akhuang added a comment. accidentally created a new revision Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61455 Files: clang/lib/CodeGen/C

[PATCH] D61455: Change the metadata for heapallocsite calls when the type is cast.

akhuang abandoned this revision. akhuang added a comment. accidentally created a new revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61455/new/ https://reviews.llvm.org/D61455 ___ cfe-commits ma

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197830. akhuang marked an inline comment as done. akhuang added a comment. - Add test case for multiple casts - Remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang marked 2 inline comments as done. akhuang added a comment. Reverted `getCompleteTypeIndex` change, to be fixed elsewhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 ___

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197851. akhuang added a comment. Change dyn_cast to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExpr

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang closed this revision. akhuang added a comment. Committed in r359823 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 ___ cfe-commits mailing list cfe-com

[PATCH] D62635: Add enums as global variables in the IR metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362166: Add enums as global variables in the IR metadata. (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D62635?vs=202079&id=202312#toc Repository: rL LLVM C

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

akhuang updated this revision to Diff 204137. akhuang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change to not emit DIGlobalVariable for enums when they are defined in a class, which matches MSVC's behavior and gets around the issue of having to create

[PATCH] D63012: Use fully qualified name when printing S_CONSTANT records

This revision was automatically updated to reflect the committed changes. Closed by commit rL363335: Use fully qualified name when printing S_CONSTANT records (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D63012?vs=204137&id=204649#toc Repository: rL

[PATCH] D63361: Pretend NRVO variables are references so that CodeView can get their value

akhuang created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63361 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDecl.cpp debuginfo-tests/nrv

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 204878. akhuang added a comment. - fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63361/new/ https://reviews.llvm.org/D63361 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDecl.c

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang added a comment. I think the main issue was keeping track of which enums are used? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/ https://reviews.llvm.org/D62635 ___ cfe-commits mailing list cfe-comm

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang added a comment. They should all be there, but emitting the unused enums makes the binary sizes larger. (I think around 6% increase? I forget the size difference for only emitting used enums) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/ https

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 205382. akhuang marked 2 inline comments as done. akhuang added a comment. Now creates a pointer to the return location in the function prolog, whenever sret is being used. Also addressed some other comments. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1145-1149 +bool Deref = false; +if (VI.Expr) { + if (!VI.Expr->extractIfOffset(ExprOffset, Deref)) continue; +} rnk wrote: > I see. I thought this c

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 205385. akhuang added a comment. - add semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63361/new/ https://reviews.llvm.org/D63361 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDecl.c

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3946 + // the address of the variable. + if (VD->isNRVOVariable()) +Expr.push_back(llvm::dwarf::DW_OP_deref); rnk wrote: > I think we shou

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 205649. akhuang added a comment. - Add clang and llvm tests, and windows debuginfo test - Use GEP as returnValuePointer in inalloca case - Add bool parameter for EmitDeclare when pointer is being used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:908 --EI; llvm::Value *Addr = Builder.CreateStructGEP(nullptr, &*EI, Idx); Addr = Builder.CreateAlignedLoad(Addr, getPointerAlign(), "agg.resu

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang updated this revision to Diff 205712. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: javed.absar. - fix alignment of pointer in inalloca case - make existing tests stop failing by changing some and adding a check for existing return value all

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:908 --EI; llvm::Value *Addr = Builder.CreateStructGEP(nullptr, &*EI, Idx); Addr = Builder.CreateAlignedLoad(Addr, getPointerAlign(), "agg.result"); rnk wrote: > akhuan

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363952: Store a pointer to the return value in a static alloca and let the debugger use… (authored by akhuang, committed b

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. The llvm-dev discussion is here http://lists.llvm.org/pipermail/llvm-dev/2019-July/134035.html I think the consensus is that it should be fine to change the data layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/n

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. For some reason the tests were failing before without the datalayout change? I'm not sure why, but I changed them back and they're fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang updated this revision to Diff 214202. akhuang added a comment. Remove test case changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Basi

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. @lebedev.ri The test case datalayout strings were changed because somewhere llvm asserts that the string in the IR matches the backend datalayout. I don't know why I wasn't getting the assert error now, but I think they'll all have to be changed if we change the X86 dat

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. > Can you post a reproducer? Turns out I just didn't have assertions enabled. With assertions the changed test cases should fail. > I think this is precisely what was discussed in replies to RFC - this > hardcodes these address spaces, and thus either makes them unaval

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. > Address space have backend defined semantics, and aren’t really reserved for > front end use. I think the fact that non-0 address spaces on X86 codegen the > same as address space 0 and could be used for something by a front end is an > accident of how SelectionDAG is

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang added a comment. Looks good, alternatively I think we can just change `%result.ptr` into a variable match? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D63625

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang added a comment. > Why isn't this using FileCheck variable matching in the first place? That's > the least fragile solution. No reason, just something I overlooked when I wrote it- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D63625 _

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, aprantl. Herald added projects: clang, LLVM. Add static data members to IR debug info's list of global variables so that they are emitted as S_CONSTANT records. Related to https://bu

[PATCH] D62214: Remove extra if case.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62214 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index: clang/lib/CodeGen/CGDebugInfo.cpp ==

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added a subscriber: dblaikie. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().g

[PATCH] D62214: Remove extra if case.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361400: Combine two if cases because the second one is never reached. (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang updated this revision to Diff 201004. akhuang added a comment. Add llvm IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/D62167 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/de

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU);

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU);

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang updated this revision to Diff 202027. akhuang added a comment. Herald added a subscriber: hiraditya. Append class name to static data member debug info name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/

[PATCH] D62167: CodeView - add static data members to global variable debug info.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362038: CodeView - add static data members to global variable debug info. (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D62167?vs=202027&id=202063#toc Reposito

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, aprantl. Herald added projects: clang, LLVM. Keeps track of the enums that were used by saving them as DIGlobalVariables, since CodeView emits debug info for global constants. Repos

  1   2   3   4   5   >