[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

MyDeveloperDay added a comment. I tend to agree mainly given that StringRef is used without const elsewhere. I'll bow to better judgement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 ___ cfe-com

[PATCH] D68896: PR43080: Do not build context-sensitive expressions during name classification.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e8fe67f0e26: PR43080: Do not build context-sensitive expressions during name classification. (authored by Richard Smith ). Changed prior to commit: https://reviews.llvm.org

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, klimek, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: mgorny. Address review comments from D68554: [clang-format] Proposal for clang-format to give compiler style warni

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Some benchmarks, running the python performance suite from recompiled cpython build, one built with `-O2` (baseline) and one built with `-O2 -fstack-clash-protection` (protection). Surprisingly enough, the stack protection makes the code faster in various scen

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. > For maintenance reasons, I'd really prefer it if we could find a way to reuse > the existing code that calls an external stack probe function. What do you > think about taking a look at X86RetpolineThunks.cpp and doing something > similar to that? Basically,

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Another test run on an x264 encoder (source: https://openbenchmarking.org/test/pts/x264) Compiled with -O2 and with or without -fstack-clash-protection; Run without threads (`x265 --pools 1 -F 1 ./Bosphorus_1920x1080_120fps_420_8bit_YUV.y4m /dev/null`) **Cla

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225049. serge-sans-paille added a comment. Get rid of static mapping + update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/R

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1709316 , @sylvestre.ledru wrote: > @MyDeveloperDay I think it should be added to the release notes. it is a > great new changes for clang format (it would have made my life at Mozilla > much easier ;) I agree

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1709321 , @klimek wrote: > My intuitive solution would have been to get the char* for the start and > end-location and then search forward and backwards for \n. I may need to, it feels slow for large files which

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1955 + /// \endcode + bool SpacesInConditionalStatement; + Nitpick: this

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser created this revision. junparser added reviewers: modocache, GorNishanov. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. The assertion of CoroutineParameterMoves happens when build coroutine function with arguments multiple time while fails to build promi

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Herald added a subscriber: wuzish. Ping! Am I correct in that basically everything's done here and this has been lingering ever since? It would be great if the change could make it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.o

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a subscriber: hans. MyDeveloperDay added a comment. In D68554#1709316 , @sylvestre.ledru wrote: > @MyDeveloperDay I think it should be added to the release notes. it is a > great new changes for clang format (it would have made my li

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225320. MyDeveloperDay added a comment. Remove need to split lines or search for `\n` General Algorithm 1. take Location of Replacement line and column 2. make a new SourceLocation of line and column =0 (beginning of that replacement line) 3. make a

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. The now that constexpr destructors are legal. The code in this patch need to be adapted, I have question about the following code. struct A { constexpr ~A() {} }; consteval A f() { return A{}; } void test() { A a; a = f(); // <-- here

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Comment at: clang/tools/clang-format/ClangFormat.cpp:345 if (WarnFormat && !NoWarnFormat) { +ArrayRef> Ranges; for (const auto &R : Replaces) { klimek wrote: > Looks u

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:351 + SourceLocation LineBegin = Sources.translateFileLineCol( + FileEntryPtr.get(), PLoc.getLine() - 1, 0); + SourceLoca

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar accepted this revision. mitchell-stellar added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits mailing list cfe

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225455. MyDeveloperDay added a comment. Update out by one errors and unused variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 Files: clang/tools/clang-format/CMakeLists.txt clang/tools/cla

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1712863 , @hans wrote: > > I can't wait for @hans next Windows Snapshot, this is my gate for rolling > > into our builds and CI system, after that, I'm gonna catch every single > > person who tries to build/check

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225462. serge-sans-paille added a comment. Moved the implementation to a specialization of `emitStackProbeInline` that used to be Windows-centric. Provide a generic implementation that generates inline assembly instead. that way we don't clutter ex

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Extra note: an older version of the patch has been tested by the firefox team without much performance impact, (and no test failure), see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/test/Format/dry-run-alias.cpp:1-2 +// RUN: clang-format -style=LLVM -i -n %s 2> %t.stderr +// RUN: grep -E "*code should be clang-formatted*" %t.stderr + hlia

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked an inline comment as done. Daniel599 added a comment. Hi, any updates regarding my patch? issues to fix? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 __

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225580. serge-sans-paille added a comment. Explicilty prefer existing mechanism for windows. Split loop/block allocation strategy to different functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

MyDeveloperDay added a comment. LGTM, thanks for the patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69164/new/ https://reviews.llvm.org/D69164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added a comment. Thank you for the patch. If you plan to continue to submit patches I think it would be worthwhile if you applied for commit access, This is not the first revision from you and we need more people who are willing to help with clang-format to fix bug and do code r

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

MyDeveloperDay added a comment. rC373922: [clang-format] [PR27004] omits leading space for noexcept when formatting… was to fix https://bugs.llvm.org/show_bug.cgi?id=27004 which wasn't just related to `delete` it occurred in other cases. (operator++) and ther

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

MyDeveloperDay updated this revision to Diff 225779. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. I think we agree it should be (StringRef ), no const,no reference CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D6891

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. gental ping~ @modocache @GorNishanov Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:356 + + StringRef Line(StartBuf, (EndBuf - StartBuf) - 1); + klimek wrote: > - 1 is to exclude the \n I'd assume? corr

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 226002. serge-sans-paille added a comment. Better integration with MachineInstr description Handle stacks with multiple stack objects More test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 226043. serge-sans-paille added a comment. Update documentation as suggested by @sylvestre.ledru Corner case when a write was touching memory beyond the allocated stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Some benchmark / instrumentation report: due to the way memory moves are ordered in the entry block, there tend to be relatively few free probes between two stack growth within a function, and a large number after the last stack growth. When recompiling llc,

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 226109. serge-sans-paille added a comment. Temporarily comment out call support as free probe, everything else passes validation but a call may have some stack effect I don't handle (yet). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6872

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. You know that feeling when you are doing a review and you think... I'm just not a compiler... I feel given the previous discussion and the level of extra tests maybe this is just worth going ahead with as long as you are prepared to support it in the interim.

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9635 +if (IsExpr) { + Base = APValue::LValueBase(ReadExpr(F), CallIndex, Version); + ElemTy = Base.get()->getType(); T

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: shafik. Herald added a project: clang. this patch refactor representation of materialized temporaries to prevent an issue raised

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-com

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

MyDeveloperDay requested changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. This revision now requires changes to proceed. I think fundamentally this seems like a reasonable idea, for those that don't need they don't need to use it. =

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

MyDeveloperDay added a comment. Thank you for the patch, I wrote this checker originally and this LGTM. I'm not sure if others have any objections to using "using clang::attr::WarnUnusedResult" in the body of the function, I couldn't see this pattern used elsewhere in clang-tidy, all I've seen

[PATCH] D68969: [clang-format] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rGec66603ac7ea: [clang-format] Remove the dependency on frontend (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa5e98fd191: [clang-format] Remove duplciate code from Invalid BOM detection (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D689

[PATCH] D31574: [clang-format] update documentation

MyDeveloperDay added a comment. When I land this change, I'll include the ClangFormatStyleOptions.rst to match (plus some minor NFC) in Format.h that are preventing dump_format_style.py from being rerun in a later commit I'll try and bring the Format.h and ClangFormaatStyleOptions.rst back in

[PATCH] D31574: [clang-format] update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG23b78364150c: [clang-format] update documentation (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D31574?vs=223443&id=226316#toc Repository: rG LLVM Github Monorepo C

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

MyDeveloperDay added a comment. ClangFormatStyleOptions.rst and Format.h are inconsistent which means when clang/doc/tools/dump_format_style.py is run the rst file being generated is in danger of overwriting your changes (which I think you might have made by hand). I'm happy to try and fix this

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan. MyDeveloperDay added projects: clang-format, clang. Running dump_format_style.py on the tip of the trunk causes ClangFormatStyleOptions.rst to have changes, which I think ideally it shouldn't.

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:187 /// expressions. - /// - /// Specifically, this aligns operands of a single expression that needs to be - /// split over multiple lines, e.g.: - /// \code - /// int aaa =

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 226403. Daniel599 added a comment. removed curly braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/readability/IdentifierNa

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I've read back through the previous comments, and I'm slightly struggling to understand the reason for the objections. (other than the normal public style) I'd tend to be wary

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69404/new/ https://reviews.llvm.org/D69404 _

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6df7ef0d8baa: [clang-format] [NFC] update the documentation in Format.h to allow… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. a change D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1971 + /// be affected. /// \code ///true: false: my assumption here was that the te

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay added a comment. For help for the reviewers...here is the before and after Before: F10399858: image.png After: F10399852: image.png Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D68296: [clang-format] Add ability to wrap braces after multi-line control statements

MyDeveloperDay added inline comments. Comment at: cfe/trunk/docs/ClangFormatStyleOptions.rst:812 + Always wrap braces after a control statement. + + .. code-block:: c++ This text cannot be generated by dump_format_style.py in clang/docs/tools from the

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): This seems quite flimsy to me, as it depends on an undocumented comment sty

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a subscriber: rjmccall. junparser added a comment. In D69022#1720645 , @rjmccall wrote: > Despite generally knowing about coroutines and generally knowing about Clang, > I actually don't know the Clang coroutine code and can't review this

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): mitchell-stellar wrote: > Th

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): MyDeveloperDay wrote: > mitchell-stellar wrote: > > This seems quite flimsy

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): mitchell-stellar wrote: > My

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:175 +val = line.replace(',', '') +pos = val.find(" // ") +if (pos != -1): MyDeveloperDay wrote: > mitc

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay added a comment. In D69433#1722463 , @mrexodia wrote: > I don't really have a say in this, but I was trying to run the python script > to generate the rst file and it didn't work. I tried fixing it, but it's > definitely very hacky. Perhap

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1723629 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf? Yes I would like to. Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

MyDeveloperDay added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:50 varDecl(hasType(hasUnqualifiedDesugaredType(recordType( hasDeclaration(cxxRecordDecl(hasName("basic_string")),

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

MyDeveloperDay added a comment. Thanks you so much for this patch, I obviously like it! So many of us who write our own string classes we tend to make them have similar interfaces to std::string anyway for obvious reasons (some of us actually add decent startWith,endsWith and contains functions

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity created this revision. whisperity added reviewers: aaron.ballman, alexfh, Eugene.Zelenko, JonasToth, NoQ, Szelethus, xazax.hun, baloghadamsoftware, Charusso. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, ormris, kbarton, mgorny, nemanjai. Herald a

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. Herald added a subscriber: wuzish. A few interesting "true positive" findings: - F10568770: AnalysisDeclContext.cpp_9aaed563ddd9ebd73fdd228c2883b8e7.plist.html (Such cases with many `bool`s are being discussed on enhancing type s

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

mitchell-stellar added a comment. Sounds like you know what you're doing. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69433/new/ https://reviews.llvm.org/D69433 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added reviewers: Szelethus, baloghadamsoftware. whisperity edited subscribers, added: baloghadamsoftware, NoQ; removed: Szelethus. whisperity added a comment. @Szelethus and @baloghadamsoftware are colleagues to me whom are far more knowledgeable about check development and I want the

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2343 Use C++14-compatible syntax. +``Cpp11``: deprecated alias for ``Latest`` sammccall wrote: > sammccall wrote:

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, owenpan, sammccall. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=36294 Addressing bug related to returning after

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan, sammccall. MyDeveloperDay added projects: clang-format, clang-tools-extra. Herald added a project: clang. see https://bugs.llvm.org/show_bug.cgi?id=35518 clang-format removes spaces around ded

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80176/new/ https://reviews.llvm.org/D80176 ___ cfe-commits mailing list cfe-com

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

This revision was automatically updated to reflect the committed changes. Closed by commit rGe71c537a487c: [clang-format] Fix line lengths w/ comments in align (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ ht

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

This revision was automatically updated to reflect the committed changes. Closed by commit rG807ab2cd0db3: [clang-format] [PR42164] Add Option to Break before While (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D79325?vs=264235&id=265153#toc Repository: rG L

[PATCH] D80176: [clang-format][PR45816] Add AlignConsecutiveBitFields

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99bf0e08be4: [clang-format][PR45816] Add AlignConsecutiveBitFields (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D80176?vs=265048&id=265152#toc Repository: rG LLVM

[PATCH] D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc918e90c048: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1566 Current.Type = TT_TrailingReturnArrow; - +} else if (Current.is(tok::arrow) && C

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. In D75791#2045986 , @MarcusJohnson91 wrote: > In D75791#2044492 , @MyDeveloperDay > wrote: > > > If you want me to land this for you, I'd feel more comfortable landing it > > if: >

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 265216. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added reviewers: miscco, JakeMerdichAMD. MyDeveloperDay added a comment. Add new `AlwaysBreakBeforeConceptDeclarations` Better handling of requires expressions vs constraint expres

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked 7 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2281 + if (FormatTok->Tok.is(tok::kw_requires)) +parseRequires(); +} miscco wrote: > I believe this should be `parseCo

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. In D79773#2046565 , @miscco wrote: > Question: Should I add my wip work as a child revision or what would you > suggest Certainly your revision on github was useful for me

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. In D79773#2046833 , @miscco wrote: > It seems the spacing of the binary operator is not yet stable. This test is > breaking for me: > > verifyFormat("template \nconcept someConcept = Constraint1 > && Constraint2;"); >

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay updated this revision to Diff 265331. MyDeveloperDay added a comment. Adding WebKitStyle() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/ https://reviews.llvm.org/D80214 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.c

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay added a comment. I think we should take these tests now once they are landed, and we can begin to flesh them out with for() , do(), while() if() conditions so we always know we are not breaking the default style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80214/new/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ef45b0426a8: [clang-format] Added new option IndentExternBlock (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D75791?vs=264916&id=265337#toc Repository: rG LLVM Gith

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1531 +/// \endcode +/// +/// \code @MarcusJohnson91 I had to make a couple of minor changes before committing 1) it needed rebasing (because of changes from this m

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay added a comment. > As @MyDeveloperDay said, I'd like it mean C++ only. I find it confusing that > it means C++ or ObjC (even if the latter is a superset of the former). I'd > rather see it spelt as `isCppOrObjC()` even if it's verbose but at least > removes all confusion IMO.

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. I feel like there might something of a concencus forming.. If I take the time to redo following the suggestions @sammccall do you think you could live with it? Comment at: clang/include/clang/For

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

nagart created this revision. nagart added a reviewer: ebevhan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80412 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Lex/LiteralS

[PATCH] D79980: [PS4] Enable relaxed relocations by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d23b5025d5f: [PS4] Enable relaxed relocations by default (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to c

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. In D69764#2050226 , @steveire wrote: > I like the approach of using clang-format to implement this. It's much faster > than a `clang-tidy` approach. > > The broader C++ community has already chosen `East`/`West` and it ha

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay updated this revision to Diff 265684. MyDeveloperDay added a comment. Switch to new function name suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h clang/lib/Format/Breakabl

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. I get the point about Opt In, and if we are going to add an option it needs to go in ASAP otherwise too many people will then start complaining it was on by default before. To be honest I think the question is do we consider this a bug or a feature, because we D

<    26   27   28   29   30   31   32   33   34   35   >