[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd added subscribers: dexonsmith, doug.gregor. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2179 +def SwiftNewType : InheritableAttr { + let Spellings = [GNU<"swift_newtype">, GNU<"swift_wrapper">]; + let Args = [EnumArgument<"NewtypeKind"

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292368. compnerd added a comment. Change diagnostics for conflicting `swift_name`, add a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: clang/inclu

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292369. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/Di

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 11 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3977 +// Swift attributes. +def warn_attr_swift_name_function aaron.ballman wrote: > I want to make sure we're clear with th

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292548. compnerd marked 2 inline comments as done. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: clang/include/cl

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 8 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3579-3580 + let Content = [{ +The ``swift_name`` attribute provides the spelling for the transformed name when +the interface is imported into the Swift

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. compnerd marked 4 inline comments as done. Closed by commit rG9bb5ecf1f760: Sema: introduce `__attribute__((__swift_name__))` (authored by compnerd). Changed prior to

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd updated this revision to Diff 293574. compnerd marked 6 inline comments as done. compnerd added a comment. Update for feedback from @aaron.ballman The `ParseAttrCommonArgs` refactoring still needs to be looked at, but this should address the feedback, and doesn't need to be predicated o

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2172 +def SwiftNewType : InheritableAttr { + // `swift_wrapper` is a "deprecated" alias and kept for compatibility with + // shipped toolchains. New users should prefer the `swift_newtype` spelling.

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd updated this revision to Diff 293763. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87652/new/ https://reviews.llvm.org/D87652 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Parse/Pa

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG296d8832a3b5: Sema: add support for `__attribute__((__swift_newtype__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2189 + let Subjects = + SubjectList<[Enum, Function, Struct, TypedefName, + ObjCClassMethod, ObjCInstanceMethod, ObjCInterface, ObjCPr

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd updated this revision to Diff 294124. compnerd marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd updated this revision to Diff 294140. compnerd added a comment. add more tests to cover the confusing case of attribute merge handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720 Files: clang

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2613-2614 SNA->getName(), AMK == Sema::AMK_Override); + else if (isa(Attr) && AMK == Sema::AMK_Override) +NewAttr = nullptr;

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd updated this revision to Diff 294167. compnerd marked an inline comment as done. compnerd added a comment. - address all feedback, add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720

[PATCH] D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI)

compnerd created this revision. compnerd added reviewers: aaron.ballman, gribozavr2. Herald added a project: clang. compnerd requested review of this revision. This code never actually did anything in the implementation. `mergeDeclAttribute` is declared as `static`, and referenced exactly once in

[PATCH] D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rG76eb163259c4: Sema: remove unnecessary parameter for SwiftName handling (NFCI) (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88263/ne

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG58cdbf518b6e: Sema: add support for `__attribute__((__swift_private__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87720?vs=294167&id=294443#toc Repository: rG LLVM G

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

compnerd added a comment. The change itself is fine, but what about downstream projects which define the option? Will that trigger a warning? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243 __

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Introduce a new attribute that is used to indicate the error handling convention used by a function. This is use

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290601. compnerd added a comment. - correct typos - apply clang-format changes - `const` correct a few declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Fi

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. This adds the `__swift_objc_members__` attribute to the semantic analysis. It allows for annotating ObjC interfa

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Extend the semantic attributes that clang processes for Swift to include `swift_typedef_bridged`. This attribute

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd marked 10 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2122 +def SwiftError : InheritableAttr { + let Spellings = [GCC<"swift_error">]; + let Args = [ aaron.ballman wrote: > Is this attribute al

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290767. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Files

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3394 +parameter. Currently, the error parameter is always the last parameter of type +``NSError**`` or ``CFErrorRef*``. Swift will remove the error parameter from +the imported API. When calling th

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/test/SemaObjC/attr-swift-error.m:55 + +// This is unconventional and very odd but we do process it. +- (int)q0:(const NSError **)error __attribute__((__swift_error__(nonzero_result))); -

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290990. compnerd added a comment. Address @gribozavr2's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3394 +parameter. Currently, the error parameter is always the last parameter of type +``NSError**`` or ``CFErrorRef*``. Swift will remove the error parameter from +the imported API. When calling th

[PATCH] D91997: APINotes: add bitcode format schema definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb13f74151137: APINotes: add bitcode format schema definitions (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D91997?vs=

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCall.cpp:3824 +// that may have type parameters in its signature. +static bool isObjCMethodWithTypeParams(const ObjCMethodDecl *method

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

compnerd added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2326 + + if (CGF.CGM.getCodeGenOpts().OptimizationLevel != 0 && + CGF.CGM.getTarget().getTriple().isAArch64() && Nit: I think that `> 0` is easier to read. Comment a

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

compnerd added a comment. There is nothing particularly special about that. The reason for the funclet handling there is that in the case of an outlined block for exception handling (i.e. a funclet), we need to ensure that the assembly marker received the funclet token as failure to do so woul

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

compnerd added a comment. Hmm, I think that the function is marked as `noexcept`, so the the funclet shouldn't be invoked and should get DCE'd, but that seems unrelated to ARC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://revie

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added inline comments. Comment at: clang/include/clang/APINotes/APINotesWriter.h:1 +//===-- APINotesWriter.h - API Notes Writer -*- C++ -*-===// +// martong wrote: > How are we going to use this class? I mean what are the use cases t

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. Thanks for the reviews! I'll reformat the rest of the code before merging. Im going to be working on merging this downstream first before merging this upstream, so it will take a couple of days still. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82f86ae01a54: APINotes: add APINotesYAMLCompiler (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D88859?vs=302298&id=303

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. @thakis, thanks for the heads up, I've disabled the test on Windows - I should've disabled it on Windows in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 __

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd created this revision. compnerd added reviewers: martong, MForster, gribozavr2. Herald added subscribers: rnkovacs, mgorny. Herald added a project: clang. compnerd requested review of this revision. This adds internal representation of the attributes in a more usable form. This is meant

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added a comment. @martong since you hard expressed interest in the "user-visible" version of the data types for the notes, I opted to get them out first. This set of data types are user-facing rather than the previous one that were mistook for them. Subsequent changes will actually a

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added a comment. Ping; I'd let to get this sorted out so I can continue to make progress towards serialization and deserialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:60 + /// Whether SwiftPrivate was specified. + unsigned SwiftPrivateSpecified : 1; + martong wrote: > I was wondering whether Swift speci

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd updated this revision to Diff 306487. compnerd marked 5 inline comments as done. compnerd added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104 Files: clang/inc

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:529 + /// Adds the return type info. + void addReturnTypeInfo(NullabilityKind kind) { addTypeInfo(0, kind); } + compnerd wrote: > martong wrote: > > Do we document somewhere that t

[PATCH] D88446: docs: add documentation describing API Notes

compnerd created this revision. compnerd added reviewers: MForster, gribozavr2, rsmith. Herald added a subscriber: jfb. Herald added a project: clang. compnerd requested review of this revision. API Notes are a feature which allows annotation of headers by an auxiliary file that contains metadata

[PATCH] D88446: docs: add documentation describing API Notes

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/docs/APINotes.rst:45 +Clang will search for API notes files next to module maps only when passed the +``-fapinotes-modules`` option. + rsmith wrote: > Can we add a hyphen

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd created this revision. compnerd added a reviewer: amccarth. Herald added a project: clang. compnerd requested review of this revision. This implements the directory watcher on Windows. It does the most naive thing for simplicity. ReadDirectoryChangesW is used to monitor the changes. Ho

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:95 + CreateEvent(NULL, /*bManualReset=*/TRUE, /*bInitialState=*/FALSE, NULL); + assert(ovlIO.hEvent); + plotfi wrote: > Can this be an assert with so

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:87 +DWORD dwLength = GetFinalPathNameByHandleW(hDirectory, NULL, 0, 0); +std::unique_ptr buffer{new WCHAR[dwLength + 1]}; +(void)GetFinalPathNameByHandleW(hDire

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. @aaron.ballman - I completely agree with you about the testing. The interfaces are tested via https://github.com/llvm/llvm-project/blob/master/clang/unittests/DirectoryWatcher/CMakeLists.txt, which now that I look at again, seems to need an additional case for system

[PATCH] D88446: docs: add documentation describing API Notes

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/docs/APINotes.rst:216 +Due to a compiler bug, 'NullabilityOfRet' may change nullability of the +parameters as well (rdar://30544062). Avoid using it and instead use +'ResultTy

[PATCH] D88446: docs: add documentation describing API Notes

compnerd updated this revision to Diff 295835. compnerd added a comment. Update text based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88446/new/ https://reviews.llvm.org/D88446 Files: clang/docs/APINotes.rst clang/test/APINote

[PATCH] D88446: docs: add documentation describing API Notes

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/docs/APINotes.rst:233-235 + Note that the type is *not* parsed in the context where it will be used, + which means that macros are not available and nullability must be applied + expli

[PATCH] D88446: docs: add documentation describing API Notes

compnerd updated this revision to Diff 295924. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88446/new/ https://reviews.llvm.org/D88446 Files: cla

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 14 inline comments as done. compnerd added a comment. There already is testing coverage for this - I just missed the CMake changes. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:36 + alignas(DWORD) + CHAR Buffer[4 * (sizeof(FILE_N

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:87 +DWORD dwLength = GetFinalPathNameByHandleW(hDirectory, NULL, 0, 0); +std::unique_ptr buffer{new WCHAR[dwLength + 1]}; +(void)GetFinalPathNameByHandleW(hDire

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 296092. compnerd added a comment. Herald added a subscriber: mgorny. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 Files: clang/lib/DirectoryWatch

[PATCH] D88446: docs: add documentation describing API Notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85d506400081: docs: add documentation describing API Notes (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D88446?vs=295

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd created this revision. compnerd added reviewers: gribozavr2, MForster. Herald added subscribers: jfb, mgorny. Herald added a project: clang. compnerd requested review of this revision. This adds the skeleton of the YAML Compiler for APINotes. This change only adds the YAML IO model for t

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. The reason that I added the overlapped event was specifically for the cancellation and overlooked the fact that it will be used by the kernel side as well, thanks for catching that! Comment at: clang/unittests/DirectoryWatcher/CMakeLists.txt:1 -if(AP

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:82 +DirectoryWatcherCallback Receiver) +: Callback(Receiver) { + // Pre-compute the real location as we will be handing

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

compnerd created this revision. compnerd added reviewers: vsk, rnk. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya. Herald added projects: clang, LLVM. compnerd requested review of this revision. In order for the hot/cold splitting pass to graduate out of experimental status,

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:92 +Length = GetFinalPathNameByHandleW(DirectoryHandle, Buffer.data(), + Buffer.capacit

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 297079. compnerd marked an inline comment as done. compnerd added a comment. address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 Files: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-win

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:15 +#include "llvm/Support/Windows/WindowsSupport.h" #include #include amccarth wrote: > I don't see a reaso

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 297324. compnerd marked an inline comment as done. compnerd added a comment. Herald added a subscriber: jfb. Remove unnecessary include, fix an incorrect wait (verified that unit tests now pass!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d74c4351175: DirectoryWatcher: add an implementation for Windows (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89177: [cmake] Add support for multiple distributions

compnerd added a comment. I've not taken a thorough look at the changes, but I am definitely in favour of this change (conceptually). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 ___

[PATCH] D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O

compnerd abandoned this revision. compnerd added a comment. Sure, I think I can do that instead. Thanks for pointing me to that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89078/new/ https://reviews.llvm.org/D89078

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

compnerd updated this revision to Diff 297983. compnerd added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Herald added a project: clang. Rebase; there are a 4 more test failures to go through Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

compnerd updated this revision to Diff 298425. compnerd added a comment. Herald added a subscriber: arichardson. Passes locally now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 Files: clang/include/cla

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG273c299d5d64: [PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting (authored by vsk, committed by compnerd). Repository: rG LLVM Git

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked 3 inline comments as done. compnerd added a comment. Thanks for the feedback! Comment at: clang/include/clang/APINotes/Types.h:1 +//===-- Types.h - API Notes Data Types --*- C++ -*-===// +// martong wrote: > So we are ma

[PATCH] D91104: APINotes: add property models for YAML attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b02ecd027a: APINotes: add property models for YAML attributes (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91997: APINotes: add bitcode format schema definitions

compnerd created this revision. compnerd added reviewers: martong, gribozavr2, MForster. compnerd added a project: clang. Herald added a subscriber: rnkovacs. compnerd requested review of this revision. This adds the bitcode format schema required for serialization of the YAML data to a binary for

[PATCH] D91997: APINotes: add bitcode format schema definitions

compnerd added a comment. Gentle post-holiday reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91997/new/ https://reviews.llvm.org/D91997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd created this revision. compnerd added reviewers: martong, gribozavr2, MForster. Herald added subscribers: mgrang, rnkovacs, mgorny. compnerd requested review of this revision. Herald added a project: clang. This adds the skeleton for serializing out the APINotes data from the APINotes. T

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesWriter.cpp:35 + bool SwiftImportAsMember = false; +#endif + Please ignore this `#if`-defed portion, it is not intended for upstream, but I need to keep this working downstream. I will remov

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

compnerd added a comment. Is there a reason to not use the existing `-mlinker-version=` option and expanding that beyond just Darwin targets? I feel like having the same option would be much nicer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

compnerd added a comment. In D85474#2343393 , @MaskRay wrote: > In D85474#2343356 , @dexonsmith > wrote: > >> In D85474#2343326 , @MaskRay wrote: >> >>> In D85474#2342365

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked 3 inline comments as done. compnerd added a comment. In D88859#2339159 , @martong wrote: > I value that you guys have a prototype on a fork that is being used in > production. But, upstreaming and these reviews give us the chance to evolve

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesYAMLCompiler.cpp:439 + static void enumeration(IO &IO, EnumExtensibilityKind &EEK) { +IO.enumCase(EEK, "none", EnumExtensibilityKind::None); +IO.enumCase(E

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd updated this revision to Diff 300796. compnerd added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 Files: clang/include/clang/APINotes/APINotesYAMLCompiler.h

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd updated this revision to Diff 300815. compnerd added a comment. Add more testing coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 Files: clang/include/clang/APINotes/APINotesYAMLCompiler.

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:25 +/// auditing. +enum class EnumExtensibilityKind { + None, martong wrote: > This seems a bit redundant to `Attrs.td`. I'd prefer to hav

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked an inline comment as done. compnerd added a comment. > I'd like to have maximum flexibility from the submitter by willing to change > the details of the implementation I don't think that is a fair expectation - there are plenty of times where this is technical disagreement on fu

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:25 +/// auditing. +enum class EnumExtensibilityKind { + None, martong wrote: > compnerd wrote: > > martong wrote: > > > compnerd wrote: > > > > martong wrote: > > > > > This seems a

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesYAMLCompiler.cpp:33 +namespace yaml { +template <> +struct ScalarEnumerationTraits { martong wrote: > Could you please clang-format the code? The `Lint: Pre-merge checks` are all > over the c

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd updated this revision to Diff 302298. compnerd added a comment. rebase, clang-format, add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859 Files: clang/include/clang/APINotes/APINotesYAML

[PATCH] D96130: Correct swift_bridge duplicate attribute warning logic

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96130/new/ https://reviews.llvm.org/D96130 __

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. I was able to play around with this further yesterday evening. You are correct - the issue is the load preventing the watcher thread from spinning up. I was able to reproduce this issue and resolve it by adding in a synchronization point (boolean + mutex + condition

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. Interesting, are the logs from the runs available? I have run the test ~1 times locally and its been stable. Perhaps the logs can show what is going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd created this revision. compnerd added reviewers: dgoldman, rsmith, aaron.ballman. Herald added subscribers: usaxena95, kadircet, kbarton, nemanjai. compnerd requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Allow a preprocessor obs

[PATCH] D105368: Lex: add a callback for `#pragma mark`

compnerd updated this revision to Diff 356273. compnerd added a comment. Correct lifetime of data in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105368/new/ https://reviews.llvm.org/D105368 Files: clang/include/clang/Lex/PPCallbacks

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105049/new/ https://reviews.llvm.org/D105049

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd created this revision. compnerd added a reviewer: craig.topper. Herald added subscribers: luke957, luismarques, s.egerton, PkmX, simoncook, kristof.beyls, mgorny. compnerd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This split

<    1   2   3   4   5   6   7   >