Re: [PATCH] D23167: emit_DW_AT_noreturn flag

2016-08-17 Thread Victor via cfe-commits
vleschuk added a comment. Could somebody commit this, please? https://reviews.llvm.org/D23167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23293: Some place that could using TargetParser in clang

2016-08-17 Thread jojo.ma via cfe-commits
jojo closed this revision. jojo added a comment. Committed r278890. https://reviews.llvm.org/D23293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-17 Thread Will Dietz via cfe-commits
s for me (since llvm's config.h isn't installed). > > Would using "llvm/Config/llvm-config.h" suffice instead? I'm trying that > now... > > ~Will > > On Wed, Aug 17, 2016 at 8:36 AM Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > &

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-17 Thread Will Dietz via cfe-commits
Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Tue Aug 16 20:05:07 2016 > > New Revision: 278882 > > > > URL: http://llvm.org/vi

Re: [PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

2016-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278937: [analyzer] Add LocationContext information to SymbolMetadata. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D21978?vs=62696=68368#toc Repository: rL LLVM

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278949: [Include-fixer] Install executables and support scripts (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23045?vs=66414=68384#toc Repository: rL LLVM

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

2016-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278941: [analyzer] Add a checker for loss of sign or precision in integral casts. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D13126?vs=67817=68372#toc Repository: rL

problem when using scan-build

2017-02-20 Thread ????x???? via cfe-commits
With --use-c=gcc and --use-analyzer=clang when run "scan-build" it will use include<...> of clang , but we need include<...> of gcc. How can I define the default include path of gcc when I run "scan-build --use-c=gcc --use-analyzer=clang make" ?___

Re: [PATCH] D29944: libclang: Print namespaces for typedefs and type aliases

2017-02-14 Thread Michael via cfe-commits
As an explanation for this patch my original mail to cfe-dev: I'm using libclang to parse header files and generate code from them. I found that clang_getTypeSpelling() usually includes the namespace(s) a type was declared in. However with the exception being typedefs (and same for "using A =

Re: [PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

2016-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279151: [CMake] Get libcxx building under LLVM/runtimes (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23696?vs=68610=68613#toc Repository: rL LLVM

Re: [PATCH] D23078: ObjC: Use a new type for ObjC type parameter (Patch 1 out of 3)

2016-08-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279351: [NFC] Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23078?vs=66526=68750#toc Repository: rL

Re: [PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

2016-08-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279366: [analyzer] Make CloneDetector consider template arguments. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23555?vs=68683=68770#toc Repository: rL LLVM

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

2016-08-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279367: [analyzer] Make CloneDetector consider macro expansions. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23316?vs=68684=68771#toc Repository: rL LLVM

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-08-20 Thread WuZhao via cfe-commits
WuZhao added a comment. I wan to point to some issues, because I am also doing AIX support based on your patch and I tested and verified. Firstly, in the lib/Driver/ToolChains.cpp line 3756 case llvm::Triple::ppc64: addPathIfExists(D, getDriver().SysRoot + getDriver().Dir + "/../lib64",

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

2016-08-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279378: [analyzer] Use faster hashing (MD5) in CloneDetector. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D22515?vs=68778=68784#toc Repository: rL LLVM

Re: [PATCH] D23753: [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix

2016-08-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279392: [X86][AVX512F] minor fix of the parameter names (authored by abadouh). Changed prior to commit: https://reviews.llvm.org/D23753?vs=68801=68805#toc Repository: rL LLVM

[PATCH] D23767: DebugInfo: use llvm::di_flags_t for debug info flags

2016-08-22 Thread Victor via cfe-commits
vleschuk created this revision. vleschuk added reviewers: echristo, aprantl. vleschuk added subscribers: llvm-commits, cfe-commits. Herald added a subscriber: mehdi_amini. Use llvm::di_flags_t type for debug flags instead of unsigned int to avoid problems on platforms with sizeof(int) < 4: we

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

2016-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278988: [Darwin] Stop linking libclang_rt.eprintf.a (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23531?vs=68102=68429#toc Repository: rL LLVM

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

2016-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279096: Module: add -fprebuilt-module-path to support loading prebuilt modules. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23125?vs=68456=68570#toc Repository: rL LLVM

Re: Record ranges skipped by the preprocessor and expose them with libclang.

2016-08-18 Thread Cameron via cfe-commits
Ah, is that why! My fault, sorry. I couldn't figure out why it wouldn't link on the build machines when it worked fine for me locally (on Windows)... Thank you, I will fix this shortly. On Thu, Aug 18, 2016 at 12:52 PM, Will Dietz via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

[PATCH] D23168: emit_DW_AT_noreturn flag

2016-08-04 Thread Victor via cfe-commits
vleschuk created this revision. vleschuk added a reviewer: asl. vleschuk added a subscriber: cfe-commits. Emit DWARF DW_AT_noreturn for C++ [[ noreturn ]] and C _Noreturn specifiers. Corresponding LLVM patch: https://reviews.llvm.org/D23167 https://reviews.llvm.org/D23168 Files:

Re: [PATCH] D15227: [analyzer] Valist checkers.

2016-08-22 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279427: Reapply "[analyzer] Added valist related checkers." (authored by xazax). Repository: rL LLVM https://reviews.llvm.org/D15227 Files:

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

2016-08-22 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279425: [analyzer] Correctly add assumptions based on array bounds. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D23112?vs=68023=68840#toc Repository: rL LLVM

Re: [PATCH] D23780: [analyzer] Fixed crash in StmtDataCollector when analyzing methods of template classes.

2016-08-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279529: [analyzer] Fix CloneDetector crash on calling methods of class templates. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23780?vs=68883=69007#toc Repository: rL

Re: [PATCH] D23699: [CMake] Be more consistent about naming targets and components

2016-08-24 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279675: [CMake] Be more consistent about naming targets and components (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23699?vs=68637=69177#toc Repository: rL LLVM

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-08-25 Thread Andi via cfe-commits
Abpostelnicu updated this revision to Diff 69205. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -2861,8 +2861,19 @@

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-08-25 Thread Andi via cfe-commits
Abpostelnicu marked 4 inline comments as done. Abpostelnicu added a comment. I've added also support for pure in case CXXOperatorCallExprClass::isAssignmentOperator is true. https://reviews.llvm.org/D22910 ___ cfe-commits mailing list

Re: [PATCH] D23767: DebugInfo: use llvm::DINode::DIFlags type for debug info flags

2016-09-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280701: DebugInfo: use llvm::DINode::DIFlags type for debug info flags (authored by lkholodov). Changed prior to commit: https://reviews.llvm.org/D23767?vs=69755=70375#toc Repository: rL LLVM

Re: [PATCH] D24201: [Clang-tools-extra] Fix links in release notes

2016-09-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280725: [Release notes] Fix links. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24201?vs=70229=70433#toc Repository: rL LLVM https://reviews.llvm.org/D24201

Re: [PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

2016-09-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280741: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24179?vs=70121=70459#toc

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

2016-08-30 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280142: [test] Add libLTO as a clang test dependency on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D24042?vs=69723=69743#toc Repository: rL LLVM

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-03 Thread Andi via cfe-commits
Abpostelnicu added inline comments. Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ +OverloadedOperatorKind Op = cast(this)->getOperator(); +if (CXXOperatorCallExpr::isAssignmentOp(Op)) { + const Decl *FD = cast(this)->getCalleeDecl(); aaron.ballman

Re: [PATCH] D24007: [CMake] Use -std=c++11 if supported

2016-08-29 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280021: [CMake] Use -std=c++11 if supported (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D24007?vs=69619=69624#toc Repository: rL LLVM https://reviews.llvm.org/D24007

Re: [PATCH] D24015: [CMake] Copy headers relative to LLVM_BINARY_DIR

2016-08-30 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280108: [CMake] Copy headers relative to LLVM_BINARY_DIR (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D24015?vs=69637=69716#toc Repository: rL LLVM

Re: [PATCH] D24115: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

2016-09-07 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280870: Fix some Clang-tidy modernize-use-using and Include What You Use warnings… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24115?vs=69937=70606#toc Repository:

Re: [PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

2016-09-07 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280828: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24165?vs=70084=70564#toc Repository:

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

2016-09-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281179: [libcxx] Introduce an externally-threaded libc++ variant. (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D21968?vs=70840=70969#toc Repository: rL LLVM

Re: [PATCH] D24059: NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared.

2016-09-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281353: ObjectiveC: Refactor applyObjCProtocolQualifiers. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D24059?vs=69766=71194#toc Repository: rL LLVM

Re: [PATCH] D23080: ObjC: Use a new type for ObjC type parameter (patch 3 out of 3)

2016-09-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281358: ObjectiveC Generics: Start using ObjCTypeParamType. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23080?vs=69765=71205#toc Repository: rL LLVM

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

2016-09-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281510: [Release notes] Mention readability-container-size-empty improvements. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24526?vs=71250=71394#toc Repository: rL

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

2016-09-08 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280998: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64 (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23643?vs=68747=70761#toc Repository: rL LLVM

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

2016-09-13 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281355: ObjectiveC generics: Add ObjCTypeParamType in the type system. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23079?vs=69764=71197#toc Repository: rL LLVM

Re: r281351 - Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.

2016-09-13 Thread Manman via cfe-commits
I checked in r281404. Hopefully it will fix the issue. Let me know if it does not. Thanks, Manman > On Sep 13, 2016, at 3:03 PM, Artem Belevich via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Manman, > > FYI, It appears that some of your ObjC commits

Re: [PATCH] D23272: [analyzer][Rewrite] Fix boxes and shadows in HTML rewrites in Firefox.

2016-09-15 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281625: [analyzer] Fix HTMLRewriter style sheets to support non-webkit browsers. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23272?vs=67182=71517#toc Repository: rL

Re: [PATCH] D24820: Add -stats-stats option

2016-09-26 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282426: CC1: Add -save-stats option (authored by matze). Changed prior to commit: https://reviews.llvm.org/D24820?vs=72376=72532#toc Repository: rL LLVM https://reviews.llvm.org/D24820 Files:

[PATCH] D25092: [analyzer] Add "Assuming..." diagnostic pieces for short-circuit logical operators.

2016-10-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283302: [analyzer] Improve "Assuming..." diagnostic pieces for logical operators. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D25092?vs=73472=73601#toc Repository: rL

[PATCH] D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.

2016-10-05 Thread Matan via cfe-commits
mharoush updated this revision to Diff 73602. Repository: rL LLVM https://reviews.llvm.org/D25012 Files: lib/AST/Stmt.cpp test/CodeGen/x86_inlineasm_curly_bracket_escape.c Index: lib/AST/Stmt.cpp === --- lib/AST/Stmt.cpp

[PATCH] D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage

2016-10-05 Thread Matan via cfe-commits
mharoush added a comment. This patch is a part of a larger support for k constraints, its main purpose is to add the option to choose the specific kN register while using basic inline assembly, the constraint support for extended inline assembly is being supported by another patch D25062

[PATCH] D21021: [Clang][AVX512][BuiltIn]Adding intrinsics move_{sd|ss} to clang

2016-10-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283314: [Clang][AVX512][BuiltIn]Adding missing intrinsics move_{sd|ss} to clang (authored by mzuckerm). Changed prior to commit: https://reviews.llvm.org/D21021?vs=59720=73638#toc Repository: rL

[PATCH] D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.

2016-10-05 Thread Matan via cfe-commits
mharoush marked an inline comment as done. mharoush added a comment. Done Repository: rL LLVM https://reviews.llvm.org/D25012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-10-06 Thread Cameron via cfe-commits
cameron314 added a comment. I'll commit this in a few days, when I have some time to reintegrate it to the trunk. Thanks! https://reviews.llvm.org/D19063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-10-06 Thread Andi via cfe-commits
Abpostelnicu updated this revision to Diff 73766. Abpostelnicu marked 3 inline comments as done. https://reviews.llvm.org/D22910 Files: lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

2016-10-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283249: [ubsan] Disable bounds-check for flexible array ivars (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D7?vs=73508=73547#toc Repository: rL LLVM

[PATCH] D24278: [analyzer] Extend bug reports with extra notes.

2016-10-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283092: [analyzer] Extend bug reports with extra notes (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D24278?vs=72519=73406#toc Repository: rL LLVM

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

2016-10-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283094: [analyzer] Improve CloneChecker diagnostics (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D24916?vs=72991=73408#toc Repository: rL LLVM

[PATCH] D24915: [analyzer] Extend bug reports with extra notes - ObjCDeallocChecker

2016-10-04 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283093: [analyzer] Add extra notes to ObjCDeallocChecker (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D24915?vs=72520=73407#toc Repository: rL LLVM

[PATCH] D25004: [x86][inline-asm][clang] accept 'v' constraint

2016-10-09 Thread coby via cfe-commits
coby removed rL LLVM as the repository for this revision. coby updated this revision to Diff 74060. https://reviews.llvm.org/D25004 Files: lib/Basic/Targets.cpp test/CodeGen/x86-inline-asm-v-constraint.c Index: lib/Basic/Targets.cpp

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-21 Thread Andi via cfe-commits
Abpostelnicu updated this revision to Diff 72026. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp === --- lib/AST/Expr.cpp +++ lib/AST/Expr.cpp @@ -2863,8 +2863,20 @@

Re: Submodule semantics with macro guard

2016-09-19 Thread Manman via cfe-commits
> On Sep 19, 2016, at 5:55 PM, Richard Smith via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Your c.h is not correct. It would introduce a definition of c in every file > where it's included, so it's not a modular header. Hi Richard, What do you mean

Re: [PATCH] D21506: [analyzer] Block in critical section

2016-09-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282011: [analyzer] Add a checker that detects blocks in critical sections (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D21506?vs=71375=71977#toc Repository: rL LLVM

Re: Modules: Suggestion on how to fix a regression caused by r259901

2016-09-20 Thread Manman via cfe-commits
Hi Richard, Any suggestion on this? Thanks, Manman > On Sep 7, 2016, at 12:40 PM, Manman wrote: > > Hi Richard, > > We noticed a regression for this simple testing case: > rm -rf tmp3 > clang -cc1 -fimplicit-module-maps -x objective-c -fmodules > -fmodules-cache-path=tmp3

Re: [PATCH] D24307: calculate extent size for memory regions allocated by C++ new expression

2016-09-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281934: [analyzer] Calculate extent size for memory regions allocated by new expression. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D24307?vs=70821=71874#toc Repository:

Submodule semantics with macro guard

2016-09-19 Thread Manman via cfe-commits
Hi Richard & Ben, Given a simple testing case, where we have two submodules X.A (A.h) and X.B (B.h, it includes C.h, and C.h is guarded with a macro), when we import X.A and then textually include a header C.h, we get redefinition error. This is because the macro guard is owned by module X.B

Modules: Suggestion on how to fix a regression caused by r259901

2016-09-07 Thread Manman via cfe-commits
Hi Richard, We noticed a regression for this simple testing case: rm -rf tmp3 clang -cc1 -fimplicit-module-maps -x objective-c -fmodules -fmodules-cache-path=tmp3 -emit-obj standalone.c -I Inputs/ —> standalone.c:4:6: error: variable has incomplete type 'void' void foo __P(()); ^

Re: [PATCH] D23596: [Documentation] Remove duplicated checks groups descriptions form clang-tidy/index.rst

2016-08-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279006: [Documentation] Remove duplicated checks groups descriptions from clang… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23596?vs=68447=68449#toc Repository:

Re: [PATCH] D23550: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes.

2016-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279037: [analyzer] Small cleanups when checkers retrieving statements from exploded (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D23550?vs=68166=68492#toc Repository: rL

Re: [PATCH] D15227: [analyzer] Valist checkers.

2016-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279041: [analyzer] Added valist related checkers. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D15227?vs=68157=68497#toc Repository: rL LLVM

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-08-18 Thread Andi via cfe-commits
Abpostelnicu marked 2 inline comments as done. Comment at: lib/AST/Expr.cpp:2868 @@ +2867,3 @@ +OverloadedOperatorKind binOp = cast(this)->getOperator(); +if (binOp == OO_Equal || (binOp >= OO_PlusEqual && binOp <= OO_PipeEqual)) { + return true;

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-08-18 Thread Andi via cfe-commits
Abpostelnicu removed rL LLVM as the repository for this revision. Abpostelnicu updated this revision to Diff 68507. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ===

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

2016-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279056: [analyzer] Teach CloneDetector to find clones that look like copy-paste errors. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23314?vs=68422=68518#toc Repository:

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-08-18 Thread Cameron via cfe-commits
cameron314 added inline comments. Comment at: unittests/libclang/LibclangTest.cpp:16-20 @@ -15,4 +15,7 @@ #include "gtest/gtest.h" #include #include +#include +#include +#include #define DEBUG_TYPE "libclang-test" rsmith wrote: > Please put these in

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

2016-08-18 Thread Cameron via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279076: [libclang] Add clang_getAllSkippedRanges function (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D20132?vs=56964=68548#toc Repository: rL LLVM

Re: Record ranges skipped by the preprocessor and expose them with libclang.

2016-08-18 Thread Will Dietz via cfe-commits
(Sending again, somehow the uiuc.edu mailing list address was in my reply-all! Sorry for the duplicates :)) This breaks things for me, I think an entry in 'libclang.exports' is needed for clang_getAllSkippedRanges ? If that sounds right, can someone commit the fix? Thanks! :) ~Will,

Re: [PATCH] D23767: DebugInfo: use llvm::DIFlagsUnderlying type for debug info flags

2016-08-26 Thread Victor via cfe-commits
vleschuk retitled this revision from "DebugInfo: use llvm::di_flags_t for debug info flags" to "DebugInfo: use llvm::DIFlagsUnderlying type for debug info flags". vleschuk updated the summary for this revision. vleschuk updated this revision to Diff 69332. vleschuk added a comment. Chnaged

Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

2016-08-26 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279838: Don't diagnose non-modular includes when we are not compiling a module. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23858?vs=69183=69397#toc Repository: rL LLVM

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279494: Fix style in some Clang-tidy checks documentation. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23728?vs=68933=68941#toc Repository: rL LLVM

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279559: driver: Support checking for rlimits via cmake (when bootstrapping) (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23744?vs=68775=69028#toc Repository: rL LLVM

Re: [PATCH] D23828: Make InitListExpr::isExplicit const

2016-08-24 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279613: [AST] Make InitListExpr::isExplicit const (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23828?vs=69083=69084#toc Repository: rL LLVM

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

2016-08-24 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279659: Clang-tidy documentation style. Two Google checks are aliases. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23815?vs=69138=69161#toc Repository: rL LLVM

Re: [PATCH] D24984: [libunwind] Add support for a single-threaded libunwind build

2016-09-28 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282575: [libunwind] Add support for a single-threaded libunwind build (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D24984?vs=72698=72798#toc Repository: rL LLVM

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-28 Thread Andi via cfe-commits
Abpostelnicu updated this revision to Diff 72806. Abpostelnicu marked an inline comment as done. Abpostelnicu added a comment. corrected typo https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-28 Thread Andi via cfe-commits
Abpostelnicu updated this revision to Diff 72790. Abpostelnicu marked 2 inline comments as done. Abpostelnicu added a comment. i will add the unit tests in the next patch. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp

[PATCH] D25012: [x86][inline-asm] Add support for curly brackets escape using "%" in extended inline asm.

2016-09-28 Thread Matan via cfe-commits
mharoush created this revision. mharoush added reviewers: rnk, myatsina. mharoush added a subscriber: cfe-commits. mharoush set the repository for this revision to rL LLVM. This patch is a compatibility fix for clang, matching GCC support for charter escape when using extended in-line assembly

[PATCH] D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage

2016-09-28 Thread Matan via cfe-commits
mharoush created this revision. mharoush added reviewers: delena, myatsina, rnk, echristo. mharoush added a subscriber: cfe-commits. mharoush set the repository for this revision to rL LLVM. Herald added a subscriber: mehdi_amini. This patch enables usage of k registers in inline assembly syntax.

[PATCH] D25004: [x86][inline-asm][clang] accept 'v' constraint

2016-09-28 Thread coby via cfe-commits
coby created this revision. coby added reviewers: echristo, delena. coby added a subscriber: cfe-commits. coby set the repository for this revision to rL LLVM. Herald added a subscriber: mehdi_amini. 1. 'v' constraint for (x86) non-avx arch imitates the already implemented 'x' constraint, i.e.

Re: [PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

2016-09-28 Thread will via cfe-commits
wrmsr added a comment. I just lost a few days diagnosing what wound up being this :( In https://reviews.llvm.org/D23662#519445, @john.brawn wrote: > Surely the fix then is to make sure CrashRecoveryContext::Disable //does// > reinstall the right signal handler? The fix is to not do this by

Re: [PATCH] D25004: [x86][inline-asm][clang] accept 'v' constraint

2016-09-29 Thread coby via cfe-commits
coby updated this revision to Diff 72961. coby marked an inline comment as done. coby added a comment. Addressing comments: Added a check for KNL as well Repository: rL LLVM https://reviews.llvm.org/D25004 Files: x86-inline-asm-v-constraint.c Index: x86-inline-asm-v-constraint.c

[PATCH] D26024: [Xray] Don't generate output for xray tests

2016-10-27 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285276: [Xray] Don't generate output for xray tests (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D26024?vs=75991=75994#toc Repository: rL LLVM

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

2016-10-26 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285253: [analyzer] Report CFNumberGetValue API misuse (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D25876?vs=75488=75961#toc Repository: rL LLVM

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

2016-10-25 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285175: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask. (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D25902?vs=75557=75830#toc Repository:

Re: r285341 - Add documentation describing the components of a complete toolchain including Clang.

2016-10-29 Thread Will Dietz via cfe-commits
(Agreed, thanks!) ~Will On Sat, Oct 29, 2016 at 5:50 PM, Sean Silva via cfe-commits <cfe-commits@lists.llvm.org> wrote: > This is awesome Richard. Thanks! > > -- Sean Silva > > On Thu, Oct 27, 2016 at 1:55 PM, Richard Smith via cfe-commits > <cfe-commits@lists.ll

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

2016-10-28 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285457: [Sema] Delay partial availability diagnostics, just like deprecated (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D25284?vs=74738=76250#toc Repository: rL LLVM

[PATCH] D22770: [Sema, NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo

2016-11-09 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286409: [Sema][NFC] Reset HasFallthroughStmt when clearing FunctionScopeInfo (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D22770?vs=65380=77399#toc Repository: rL LLVM

[PATCH] D25448: [ubsan] Use the object pointer's type info for devirtualized calls

2016-10-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284636: [ubsan] Use the object pointer's type info for devirtualized calls (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D25448?vs=75168=75211#toc Repository: rL LLVM

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-10-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284579: [Sema] Gcc compatibility of vector shift (authored by asbokhan). Changed prior to commit: https://reviews.llvm.org/D24669?vs=74269=75130#toc Repository: rL LLVM

[PATCH] D22968: [analyzer] A checker for macOS-specific bool- and number-like objects.

2016-10-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284473: [analyzer] Add NumberObjectConversion checker. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D22968?vs=74969=74979#toc Repository: rL LLVM

[PATCH] D25760: [AVX512][Clang] Adding missing instructions' variations

2016-10-19 Thread coby via cfe-commits
coby created this revision. coby added reviewers: m_zuckerman, igorb, AsafBadouh, craig.topper. coby added a subscriber: cfe-commits. coby set the repository for this revision to rL LLVM. The following patch introduces the following alternations: 1. correcting the 'vpmulshiftqb' instruction,

[PATCH] D25011: [x86][inline-asm] Introducing (AVX512) k0-k7 registers for inline-asm usage

2016-10-20 Thread Matan via cfe-commits
mharoush added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D25011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25062: [x86][inline-asm][AVX512][llvm][PART-2] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

2016-10-20 Thread Matan via cfe-commits
mharoush removed rL LLVM as the repository for this revision. mharoush updated this revision to Diff 75278. mharoush added a comment. Added LLVM_FALLTHROUGH https://reviews.llvm.org/D25062 Files: lib/Target/X86/X86ISelLowering.cpp Index: lib/Target/X86/X86ISelLowering.cpp

[PATCH] D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

2016-10-20 Thread Matan via cfe-commits
mharoush removed rL LLVM as the repository for this revision. mharoush updated this revision to Diff 75277. mharoush added a comment. Herald added a subscriber: mehdi_amini. I renamed the test file to be more informative, added LLVM_FALLTHROUGH, removed check of {z} and changed the test to check

<    2   3   4   5   6   7   8   9   10   11   >