This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG19b29b1ed1ba: [PowerPC] Provide XL-compatible builtins in
altivec.h (authored by nemanjai).
Changed prior to commit:
nemanjai added inline comments.
Comment at: clang/lib/Headers/altivec.h:3055
+#ifdef __XL_COMPAT_ALTIVEC__
+/* vec_ctf */
jsji wrote:
> This only affects __VSX__ version right? If so, can we move `#ifdef
> __XL_COMPAT_ALTIVEC__` into `#ifdef __VSX__`？
> Or
jsji added inline comments.
Comment at: clang/lib/Headers/altivec.h:3065
+ (__b)),
\
+ vector unsigned long long
\
+ :
jsji added inline comments.
Comment at: clang/lib/Headers/altivec.h:3055
+#ifdef __XL_COMPAT_ALTIVEC__
+/* vec_ctf */
This only affects __VSX__ version right? If so, can we move `#ifdef
__XL_COMPAT_ALTIVEC__` into `#ifdef __VSX__`？
Or even better only into
bmahjour added a comment.
LGTM
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat.c:6
+// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx \
+ // RUN: -triple powerpc64le-unknown-unknown -emit-llvm %s -o - \
+// RUN: -D__XL_COMPAT_ALTIVEC__ | FileCheck %s
cebowleratibm accepted this revision.
cebowleratibm added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat.c:2
+// REQUIRES: powerpc-registered-target
+// RUN: %clang_cc1 -target-feature +altivec
nemanjai created this revision.
nemanjai added reviewers: cebowleratibm, hubert.reinterpretcast, bmahjour,
PowerPC.
Herald added subscribers: shchenz, kbarton.
nemanjai requested review of this revision.
Herald added a project: clang.
There are some interfaces in altivec.h that are not
