Re: [Chicken-hackers] [PATCH] Drop module namespace from struct type in `##sys#make-structure' specialisation

2018-08-24 Thread Peter Bex
On Fri, Aug 24, 2018 at 09:01:18AM +1200, Evan Hanson wrote: > Hello hackers, > > Here's a fix for #1513. This does the simple thing and just avoids > including module namespaces in `struct' type tags. Thanks for making this patch! Pushed. Cheers, Peter signature.asc Description: PGP

Re: [Chicken-hackers] [PATCH] Drop module namespace from struct type in `##sys#make-structure' specialisation

2018-08-24 Thread Peter Bex
On Fri, Aug 24, 2018 at 07:32:52PM +1200, Evan Hanson wrote: > On 2018-08-24 9:27, Peter Bex wrote: > > I'd prefer to add the current module to struct type declarations, instead. > > This should be equally simple; I think we can add this to validate-type's > > handling of struct: if the struct is

Re: [Chicken-hackers] [PATCH] Drop module namespace from struct type in `##sys#make-structure' specialisation

2018-08-24 Thread Evan Hanson
On 2018-08-24 9:27, Peter Bex wrote: > I'd prefer to add the current module to struct type declarations, instead. > This should be equally simple; I think we can add this to validate-type's > handling of struct: if the struct is not qualified, add the current > module (if any). That approach has

Re: [Chicken-hackers] [PATCH] Drop module namespace from struct type in `##sys#make-structure' specialisation

2018-08-24 Thread Peter Bex
On Fri, Aug 24, 2018 at 09:01:18AM +1200, Evan Hanson wrote: > Hello hackers, > > Here's a fix for #1513. This does the simple thing and just avoids > including module namespaces in `struct' type tags. > > After 5.0 we can revisit this behaviour and maybe make the compiler a > bit smarter

[Chicken-hackers] [PATCH] Drop module namespace from struct type in `##sys#make-structure' specialisation

2018-08-23 Thread Evan Hanson
Hello hackers, Here's a fix for #1513. This does the simple thing and just avoids including module namespaces in `struct' type tags. After 5.0 we can revisit this behaviour and maybe make the compiler a bit smarter regarding types inside modules, but for right now let's keep the changes small.