[chromium-dev] Re: PSA: Review mail best practices

2008-10-08 Thread Mark Larson (Google)
On Wed, Oct 8, 2008 at 19:31, Marshall Greenblatt <[EMAIL PROTECTED]>wrote: > Hi Peter, > > On Wed, Oct 8, 2008 at 8:06 PM, Peter Kasting <[EMAIL PROTECTED]>wrote: > >> Two recommendations for folks participating in code reviews using Rietveld >> (codereview.chromium.org): >> (2) When reviewing a

[chromium-dev] Re: PSA: Review mail best practices

2008-10-08 Thread Marshall Greenblatt
Hi Peter, On Wed, Oct 8, 2008 at 8:06 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > Two recommendations for folks participating in code reviews using Rietveld > (codereview.chromium.org): > (2) When reviewing a patch or responding to review comments, use the same > Publish+Mail Comments link to

[chromium-dev] Re: Chrome Bookmarks/Passcards

2008-10-08 Thread Chris G
Peter, For a bookmark management UI design just look at the manage subscriptions page in Google Reader! I would code a cross between that and the existing history page! Chris On Oct 8, 5:15 pm, Chris G <[EMAIL PROTECTED]> wrote: > Thanks Ben, > > How will I find the mock ups? > > A couple of f

[chromium-dev] PSA: Review mail best practices

2008-10-08 Thread Peter Kasting
Two recommendations for folks participating in code reviews using Rietveld ( codereview.chromium.org): (1) When uploading a patch, make sure you Edit Issue and add at least one review email; then use the Publish+Mail Comments link (with a blank body, usually) to send out the review request. When u

[chromium-dev] Mac build is (sea foam) green again - let's keep it that way

2008-10-08 Thread Mark Mentovai
After a few days of hard work, we've gotten the Mac build back in shape following the recent WebKit merge. A special thanks to Jeremy, Amanda, and Mike, who worked with me to get this done. This puts us back where we were last week, but with an updated WebKit snapshot. We're currently building

[chromium-dev] Re: Chrome Bookmarks/Passcards

2008-10-08 Thread Chris G
Thanks Ben, How will I find the mock ups? A couple of features that I missed from my list above: * Ability to select passcards, like a bookmark. Selecting will goto the page, fill the form, and submit with not further user intervention. * When on a page with a form, show all matching (based on

[chromium-dev] Re: Chrome Bookmarks/Passcards

2008-10-08 Thread towo
On Oct 7, 10:55 pm, "Ben Goodger (Google)" <[EMAIL PROTECTED]> wrote: > Scott Violet is probably going to begin doing work on a new Bookmark > Manager in the next few weeks. We'll have mocks soon. You should look > at this work and see if it meets your needs. Great to hear this. About your previ