On Wed, Apr 8, 2009 at 7:48 PM, Nick Baum wrote:
> Hi all,
>
> I fleshed out a few more APIs. I've put them in separate documents since the
> API pattern doc was getting a bit long. Below are some notes, feedback
> appreciated.
>
> In particular, I'd love feedback from Scott on history and from P
On Wed, Apr 8, 2009 at 11:55 PM, Tim Steele wrote:
> Nice stuff. I think this question primarily applies to bookmarks, but how
> does the API deal with keeping states consistent? By the time a getBookmarks
> callback or an event reaches the listener (in a separate process), the
> bookmarks referr
Very nice, according to bookmarks, it would be nice to have
showInShelf(bool) or something like that. Can we have helper classes such as
moving the bookmarks around? Since the tree storage algorithm is there,
would be nice to just use it instead of implementing it ourselves.
On Thu, Apr 9, 2009 a
Thanks to Ojan for this, the release testers are considerably faster now.
As for debug, while we wait for this change to take effect there too, I
added some more hardware. Windows, Mac and Linux are now running the webkit
dbg layout tests in parallel on 3 machines each.
Nicolas
On Mon, Apr 6, 20
I sync'd my tree this morning and all i have to do is click a page off
NTP to get a stream of:
[9905:2055:10870232140893:FATAL:/Users/pinkerton/src/trunk/src/chrome/common/ipc_channel_proxy.cc(158)]
Check failed: false. filter to be removed not found
[9905:2055:10870232140893:FATAL:/Users/pinkert
On Mon, Apr 6, 2009 at 6:57 PM, David Levin wrote:
>
>
> On Mon, Apr 6, 2009 at 6:24 PM, Ojan Vafai wrote:
>
>> run_webkit_test.sh now runs cpus+1 test_shells for Release builds. Please
>> keep an eye out over the next couple days for test flakyness that may have
>> resulted from this.
>>
>
> Ni
fyi -Some failures will happen on the Macs because test_shell sets/restores
user settings on startup/shutdown, so having more then one running can cause
things to fail as one exits changing state on another that's running. It's
on my list to move into a helper app so it can be done around the whol
This would only affect pixel tests, which are still off by default on
mac, right?
On Thu, Apr 9, 2009 at 9:11 AM, Thomas Van Lenten wrote:
> fyi -Some failures will happen on the Macs because test_shell sets/restores
> user settings on startup/shutdown, so having more then one running can cause
>
On Mon, Apr 6, 2009 at 1:45 PM, Evan Martin wrote:
> Is anyone working on official distro packages (rpms, ebuilds, etc.)
> for Chromium?
>
> It'd be nice to hear from you -- occasionally there are issues of
> interest to packagers and so far we've only been talking with Ubuntu,
> since they're al
On Thu, Apr 9, 2009 at 9:06 AM, Pam Greene wrote:
> On that note, though, it would be amazing if someone wanted to figure out
> the interdependencies. We have three run_webkit_tests otpions available to
> help: --randomize-order, which runs the tests in a random
> order;--run-singly, which launc
On Thu, Apr 9, 2009 at 12:37 PM, Ojan Vafai wrote:
> This would only affect pixel tests, which are still off by default on
> mac, right?
It also includes prefs about font sizes, smoothing, etc, which has shown in
the past to change the layout and hence the text dumps.
TVL
>
> On Thu, Apr 9,
(Resend - ugh)
On Wed, Apr 8, 2009 at 11:52 PM, Aaron Boodman wrote:
>> Should changes to the contents of a folder trigger eventbookmarkupdated for
>> that folder? How about the folders above it?
>
> This is a meta question for the entire system. My current thinking is
> that changes you make sh
[resending from right email...]
On Thu, Apr 9, 2009 at 12:53 AM, Aaron Boodman wrote:
> On Wed, Apr 8, 2009 at 11:55 PM, Tim Steele wrote:
> > Nice stuff. I think this question primarily applies to bookmarks, but how
> > does the API deal with keeping states consistent? By the time a
> getBookm
On Thu, Apr 9, 2009 at 9:11 AM, Thomas Van Lenten wrote:
> fyi -Some failures will happen on the Macs because test_shell sets/restores
> user settings on startup/shutdown, so having more then one running can cause
> things to fail as one exits changing state on another that's running. It's
> on m
On Wed, Apr 8, 2009 at 7:11 PM, Aaron Boodman wrote:
>
> Argh, resending from right adress this time.
>
> On Wed, Apr 8, 2009 at 7:10 PM, Aaron Boodman wrote:
>> Thanks for forking this. I had started a reply, then forgot to send it.
>>
>> On Wed, Apr 8, 2009 at 4:57 PM, Nick Baum wrote:
>>> [f
On Wed, Apr 8, 2009 at 7:11 PM, Aaron Boodman wrote:
>
> Argh, resending from right adress this time.
>
> On Wed, Apr 8, 2009 at 7:10 PM, Aaron Boodman wrote:
> > Thanks for forking this. I had started a reply, then forgot to send it.
> >
> > On Wed, Apr 8, 2009 at 4:57 PM, Nick Baum wrote:
> >
FYI:
This was resolved earlier this morning. I guess I got unlucky and
sync'd at a bad time. It was an issue with the devtools_agent_filter.
On Thu, Apr 9, 2009 at 11:24 AM, Mike Pinkerton wrote:
> I sync'd my tree this morning and all i have to do is click a page off
> NTP to get a stream of:
On Thu, Apr 9, 2009 at 10:28 AM, Erik Kay wrote:
> On Wed, Apr 8, 2009 at 11:52 PM, Aaron Boodman wrote:
>>> Should changes to the contents of a folder trigger eventbookmarkupdated for
>>> that folder? How about the folders above it?
>>
>> This is a meta question for the entire system. My curren
On Thu, Apr 9, 2009 at 12:01 AM, Brett Wilson wrote:
> On Wed, Apr 8, 2009 at 7:48 PM, Nick Baum wrote:
> > Hi all,
> >
> > I fleshed out a few more APIs. I've put them in separate documents since
> the
> > API pattern doc was getting a bit long. Below are some notes, feedback
> > appreciated.
>
Moving a bookmark should be as simple as changing it's parentId.
-Nick
On Thu, Apr 9, 2009 at 5:01 AM, Mohamed Mansour wrote:
> Very nice, according to bookmarks, it would be nice to have
> showInShelf(bool) or something like that. Can we have helper classes such as
> moving the bookmarks around?
On Thu, Apr 9, 2009 at 11:22 AM, Aaron Boodman wrote:
> On Thu, Apr 9, 2009 at 10:28 AM, Erik Kay wrote:
> > On Wed, Apr 8, 2009 at 11:52 PM, Aaron Boodman wrote:
> >>> Should changes to the contents of a folder trigger eventbookmarkupdated
> for
> >>> that folder? How about the folders above i
On Thu, Apr 9, 2009 at 11:55 AM, Nick Baum wrote:
> So if a bookmark gets added to a folder:
>
> we should send an update event for the bookmark
> but we should NOT send an update event for that folder
We would send events about both things to all extensions except the
one that caused it. That w
Does the "other bookmarks" node need special handling like the Bookmarks
Bar? Since the title of this permanent node is an internationalized string,
there needs to be another way to identify it. Note that in our existing
BookmarkModel, the other bookmarks node is not a child of the bookmark node,
There's one other bookmark notification you don't have, BookmarkNodeMoved.
Other interesting bookmark related methods:
GetBookmarks(URL)
GetMostRecentlyModifiedGroups
GetMostRecentlyAddedEntries
If you want to enable folks to replace the ntp, then shouldn't you
provide a way to get the items dis
Given that we have developer tools like the debugger that are intended for
web developers there is some confusion over the Area-DevTools label. We
have replaced that with Area-Infrastructure. This area is for things
related to the internal systems like buildbots, tests, etc.
There is a new label
Well that begs the question: if the folder gets updated, what about the
folder it's contained in? Is it updates all the way up? I think it'd be
simpler to not send updates for the folders when the bookmarks change.
-Nick
On Thu, Apr 9, 2009 at 11:58 AM, Aaron Boodman wrote:
> On Thu, Apr 9, 2009
On Thu, Apr 9, 2009 at 12:41 PM, Scott Violet wrote:
> There's one other bookmark notification you don't have, BookmarkNodeMoved.
A bookmark update when the parentID changes should cover this.
>
>
> Other interesting bookmark related methods:
> GetBookmarks(URL)
> GetMostRecentlyModifiedGroups
On Thu, Apr 9, 2009 at 1:29 PM, Nick Baum wrote:
> Well that begs the question: if the folder gets updated, what about the
> folder it's contained in? Is it updates all the way up? I think it'd be
> simpler to not send updates for the folders when the bookmarks change.
Why would adding a bookmar
On Thu, Apr 9, 2009 at 1:40 PM, Aaron Boodman wrote:
> On Thu, Apr 9, 2009 at 1:29 PM, Nick Baum wrote:
> > Well that begs the question: if the folder gets updated, what about the
> > folder it's contained in? Is it updates all the way up? I think it'd be
> > simpler to not send updates for the
On Thu, Apr 9, 2009 at 12:17 PM, Nick Carter wrote:
> Does the "other bookmarks" node need special handling like the Bookmarks
> Bar? Since the title of this permanent node is an internationalized string,
> there needs to be another way to identify it. Note that in our existing
> BookmarkModel,
>> If you want to enable folks to replace the ntp, then shouldn't you
>> provide a way to get the items displayed by the ntp? If someone is
>> writing their own history sniffer or history page replacement that'll
>> need to know when a new visit is added.
>
> We do have events for that, I believe.
On Wed, Apr 8, 2009 at 7:48 PM, Nick Baum wrote:
> Hi all,
>
> I fleshed out a few more APIs. I've put them in separate documents since
> the API pattern doc was getting a bit long. Below are some notes, feedback
> appreciated.
>
> In particular, I'd love feedback from Scott on history and from P
There's a ton of work that to be done to make running webkit tests
considerably faster. I think we could still get >2x faster. I'm doing some
of it, but could definitely use some help. I've compiled a list of bugs for
the tasks that need doing (gave them the label WebkitTestsPerf). Please take
a lo
Howdy all:
The tree has been incredibly green of late thanks to continued
dedication to stability and test fixing, but there are those times
when you might still get bitten by non-green revs costing you time as
you try to figure out why a build failed only to discover it's not
your fault. To avoi
After a bit of digging and coding I have a working workaround for the
problem.
Read about it here:
http://blog.insanegenius.com/2009/04/broken-symbol-proxy.html
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, c
Does this use the latest version that works on windows, linux and mac? ...
or, only windows?
-Darin
On Thu, Apr 9, 2009 at 4:45 PM, Alex Russell wrote:
>
> Howdy all:
>
> The tree has been incredibly green of late thanks to continued
> dedication to stability and test fixing, but there are th
Not sure what our build-bots report. M-A?
Regards
On Thu, Apr 9, 2009 at 5:03 PM, Darin Fisher wrote:
> Does this use the latest version that works on windows, linux and mac? ...
> or, only windows?
> -Darin
>
>
>
> On Thu, Apr 9, 2009 at 4:45 PM, Alex Russell wrote:
>>
>> Howdy all:
>>
>> Th
Would http://build.chromium.org/buildbot/continuous/LATEST/REVISION work
here as well?
On Thu, Apr 9, 2009 at 5:29 PM, Alex Russell wrote:
>
> Not sure what our build-bots report. M-A?
>
> Regards
>
> On Thu, Apr 9, 2009 at 5:03 PM, Darin Fisher wrote:
> > Does this use the latest version that
I think it contains the last revision that compiles on mac, linux and
windows and also that passed the unit_tests on these 3 platforms.
Nicolas
On Thu, Apr 9, 2009 at 5:29 PM, Alex Russell wrote:
>
> Not sure what our build-bots report. M-A?
>
> Regards
>
> On Thu, Apr 9, 2009 at 5:03 PM, Darin
At a quick glance, this looks great. I didn't look over every bug, but the
ones I did look at look good.
It would be great to check in a version of this script that we could run
when a number of tests fail (e.g. when doing a bad webkit merge). That way,
we can add them all to the local test_expecta
40 matches
Mail list logo
