[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread Mark Larson (Google)
On Fri, May 29, 2009 at 16:16, Evan Stade wrote: > > On Fri, May 29, 2009 at 4:07 PM, Mohamed Mansour > wrote: > > Let me clarify. Try typing this: > > > > Hasn't the dog ate his food. > > hopefully we'll soon have grammar checking as well :) I hope the grammar checker will catch incorrect cap

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Peter Kasting
On Fri, May 29, 2009 at 10:40 PM, Mark Larson (Google) wrote: > ...these issues are filed as bugs so we can fix them, right? I think maybe some of them are. I file enough bugs that you can cut me slack when I don't :). After all someone else has to notice the little things and be bugged by the

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Mark Larson (Google)
...these issues are filed as bugs so we can fix them, right? On Fri, May 29, 2009 at 22:23, Peter Kasting wrote: > On Fri, May 29, 2009 at 7:45 PM, Evan Stade wrote: > >> I'll also take this opportunity to complain that the dangerous >> downloads dialog warning icon is way off center on windows

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Peter Kasting
On Fri, May 29, 2009 at 7:45 PM, Evan Stade wrote: > I'll also take this opportunity to complain that the dangerous > downloads dialog warning icon is way off center on windows. (see > attachment. for comparison purposes, I've also attached linux ;) > The entire download bar UI has serious align

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread nakro
Greg and Evan, thanx a lot Greg your solution is perfect, and it works! Evan, i of course never applied anyone else's patch, and i have to say i never saw in your online documentation about how to get the code any mention of this cygwin setup i needed to do, i must have missed it, sorry i will lo

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Evan Stade
Is anyone planning to do a UI review of linux and/or mac? We copy windows where we can (for padding and hard-coded sizes and whatnot), but there are tons of places where that's not possible. Also, padding numbers don't really translate 1 for 1 all the time. I've been choosing numbers based on my o

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Evan Stade
how do you apply other people's diffs if you don't have patch? Run cygwin's setup.exe and select the 'patch' package. -- Evan Stade On Fri, May 29, 2009 at 6:43 PM, nakro wrote: > > Evan, i have cygwin in my path > > and i know that when you build chrome it registers cygwin via some > regist

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread nakro
Evan, i have cygwin in my path and i know that when you build chrome it registers cygwin via some registry mounting hack as a prof if i enter pwd it indeed works like in unix still, none of your solutions works can you really run this on your windows OS ? for example, in my cygwin/bin direc

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Greg Spencer
Try using Tortise SVN, it has built-in visual diff and explorer shell integration (and it's free). http://tortoisesvn.tigris.org You might even be able to set the diff program it uses, I'm not sure (I'm on my Mac right now, but I use Tortise on my Windows machine). Note that this is only the SVN

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Evan Stade
use cygwin -- Evan Stade On Fri, May 29, 2009 at 6:29 PM, nakro wrote: > > thanx evan, just to be clear i use *windows* (hence the windiff > thing) > and i have svn 1.6.1 (the normal env i hope, i did not modify it) > > 1- svn diff `find . -name "*.cc"` > returns: > svn.exe: invalid option ch

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread nakro
thanx evan, just to be clear i use *windows* (hence the windiff thing) and i have svn 1.6.1 (the normal env i hope, i did not modify it) 1- svn diff `find . -name "*.cc"` returns: svn.exe: invalid option character: n 2- 'patch' is not recognized as an internal or external command operable progra

[chromium-dev] Re: Mac History Menu Implementation

2009-05-29 Thread Evan Stade
I like firefox's approach with the recently closed in a submenu of the history menu. Honestly though I can't say I use it very frequently. I just feel safer knowing it's there. -- Evan Stade On Thu, May 28, 2009 at 1:14 PM, Ben Goodger (Google) wrote: > > I would say try as a replacement. i.e

[chromium-dev] Re: chrome://downloads/ behaviour (some suggestions and a bug, i think)

2009-05-29 Thread Evan Stade
> (also, having read the source code that handles downloads, i didn't > really get why you first create a temp >  file only to transfer it at the end to the real name. i am sure > you have reasons but i was just curious) to parallelize the process of choosing the download location and actuall

[chromium-dev] Re: 2 questions about SVN

2009-05-29 Thread Evan Stade
2009/5/29 nakro : > > Hi, > > 1- > if i want to see ONLY the .cc files i changed in a folder i type > svn diff *.cc       <-works > but say i do the same in ...\src\chrome > i get this : > > svn: Can't open file '*.cc\.svn\entries': ??T? ,-.?, T? ,`"~%, ?. ,?╪? > %~ T? ?..% > ? ??-'% ,?╪`.? T,.%%?

[chromium-dev] 2 questions about SVN

2009-05-29 Thread nakro
Hi, 1- if i want to see ONLY the .cc files i changed in a folder i type svn diff *.cc <-works but say i do the same in ...\src\chrome i get this : svn: Can't open file '*.cc\.svn\entries': ??T? ,-.?, T? ,`"~%, ?. ,?╪? %~ T? ?..% ? ??-'% ,?╪`.? T,.%%?. which i need to find all the changes

[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread Evan Stade
On Fri, May 29, 2009 at 4:07 PM, Mohamed Mansour wrote: > Let me clarify. Try typing this: > > Hasn't the dog ate his food. hopefully we'll soon have grammar checking as well :) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com

[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread sidchat
> *Hasn't* the dog ate his food. Yes - this is due to the bug http://code.google.com/p/chromium/issues/detail?id=11897 - it seems that bug has reappeared. -Sid > > -- Mohamed Mansour > > On Fri, May 29, 2009 at 7:02 PM, Mohamed Mansour > wrote: > > > > > Okay I found > > a couple of errors. Bee

[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread Mohamed Mansour
Let me clarify. Try typing this: *Hasn't* the dog ate his food. -- Mohamed Mansour On Fri, May 29, 2009 at 7:02 PM, Mohamed Mansour wrote: > Okay I found > a couple of errors. Been testing it since you guys have committed it. > You cannot do contractions. Try typing has not, will not, does n

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-29 Thread Evan Stade
> I wonder if we were at fault for that? I've never seen that happen otherwise. I only had like 15 X clients according to xlsclients (max is 255). I saved the stack trace but it's worthless as it's just a standard GetScreenInfo ViewHost msg that we attempt to execute with the 2ndary x connection

[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread Mohamed Mansour
Okay I found a couple of errors. Been testing it since you guys have committed it. You cannot do contractions. Try typing has not, will not, does not, etc. You can't do it. Try making the first letter capitalized. -- Mohamed Mansour On Fri, May 29, 2009 at 2:09 PM, Mohamed Mansour wrote: > I h

[chromium-dev] Re: Historgram in V8 compilation cache

2009-05-29 Thread Mads Sig Ager
It is purely for gathering statistics on our use of the cache and has no influence on the generated code. -- Mads On Fri, May 29, 2009 at 3:32 PM, Lucius Fox wrote: > > Hi, > > In V8 compilation cache code v8/src/compilation-cache.cc, it create a > histogram. > > StatsTable::CreateHistogram > >

[chromium-dev] Historgram in V8 compilation cache

2009-05-29 Thread Lucius Fox
Hi, In V8 compilation cache code v8/src/compilation-cache.cc, it create a histogram. StatsTable::CreateHistogram Can you please tell me what is that for? Is it for debugging/profiling purpose? Or it is for JIT compilation? Thank you. --~--~-~--~~~---~--~~ Chrom

[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread Mohamed Mansour
I hope it "isn't a bug. Because people might need them :) Just type 'believe', and use your arrow keys to goto the 'i', and delete that. And add the 'i' after the 'e' . And you will properly have the erroneous word. -- Mohamed Mansour On Fri, May 29, 2009 at 12:50 PM, Nick Baum wrote: > Wait

[chromium-dev] Re: Auto Spelling Correction

2009-05-29 Thread Nick Baum
Wait wait, how did you manage to write those?? :) -Nick On Thu, May 28, 2009 at 6:12 PM, Mohamed Mansour wrote: > Great job! I now can't be embarrassed when I write beleive or recieve :) > Thanks :) > > -- Mohamed Mansour > > > > On Thu, May 28, 2009 at 7:25 PM, Nick Baum wrote: > >> Great to se

[chromium-dev] Re: Clobber if you get V8 linker errors in the next sync

2009-05-29 Thread Scott Violet
I saw a link error in v8 land this morning that was fixed by clobber build. -Scott On Fri, May 29, 2009 at 9:15 AM, Brett Wilson wrote: > > When I landed the WebKIt integration this morning a bunch of the bots > needed clobbering due to linker errors. The errors were missing V8 > handles whil

[chromium-dev] Re: Clobber if you get V8 linker errors in the next sync

2009-05-29 Thread Jeremy Orlow
Does it make sense to try and fix/add dependencies in the gyp whenever we run into problems like this? I don't know the details of why these dependencies aren't catched already, but it seems like over time we could stop hitting these problems? On Fri, May 29, 2009 at 9:15 AM, Brett Wilson wrote:

[chromium-dev] Re: Problem with building in rlz

2009-05-29 Thread Evan Martin
On Fri, May 29, 2009 at 8:51 AM, Berend-Jan Wever wrote: > 2>Copying binaries/rlz_dll.pdb to I:\trunk\src\chrome\Debug\rlz_dll.pdb > 2>The system cannot find the path specified. Looks like you're missing a file. --~--~-~--~~~---~--~~ Chromium Developers mailing l

[chromium-dev] Clobber if you get V8 linker errors in the next sync

2009-05-29 Thread Brett Wilson
When I landed the WebKIt integration this morning a bunch of the bots needed clobbering due to linker errors. The errors were missing V8 handles while linking generate_profile. I haven't seen any of the commonly-compiled projects fail because of this, so it's possible you don't have to clobber si

[chromium-dev] Problem with building in rlz

2009-05-29 Thread Berend-Jan Wever
Hi all, I recently started getting this error while building Chromium: 2>-- Build started: Project: rlz, Configuration: Debug Win32 -- 2>Copying binaries/rlz_dll.pdb to I:\trunk\src\chrome\Debug\rlz_dll.pdb 2>The system cannot find the path specified. 2>Project : error PRJ0019: A tool ret

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-29 Thread Evan Martin
On Thu, May 28, 2009 at 6:55 PM, Evan Stade wrote: > I was hitting a CHECK() today in x11_util::GetSecondaryXConnection() > (or w.e it's called). But that's because X somehow ran out of > available connections, or something, and I couldn't launch any other > programs either. At that point there's

[chromium-dev] Re: Where is the integration point betwee chromium and V8

2009-05-29 Thread Amanda Walker
Xcode can have problems properly setting breakpoints in subprojects. There are two ways to work around this: - Uncheck the "Load *symbols lazily" option in Xcode's debugging preferences.* - Open up the gdb console window and set breakpoints from the gdb command line --Amanda 2009/5/29 Lucius Fo

[chromium-dev] Re: Two tools for automatically getting a recent build of Chromium

2009-05-29 Thread Marc-Antoine Ruel
Have you seen http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/chrome-update.py?view=markup ? On Fri, May 29, 2009 at 4:37 AM, Berend-Jan Wever wrote: > Hey all, > > If you want to have up-to-date builds of Chromium on multiple VMs for > testing, you'll want to automate syncing sour

[chromium-dev] Re: Where is the integration point betwee chromium and V8

2009-05-29 Thread Dean McNamee
I just re-read your post and realized you were using test_shell, which is single process. In that case, I am not sure what the problem is, and have no experience with xcode. Sorry, good luck On Fri, May 29, 2009 at 11:06 AM, Dean McNamee wrote: > My spidey sense would guess that you set the bre

[chromium-dev] Re: Where is the integration point betwee chromium and V8

2009-05-29 Thread Dean McNamee
My spidey sense would guess that you set the breakpoint in the Browser process, when V8 and WebKit run in the Renderer process. Good luck -- dean 2009/5/29 Lucius Fox : > > Thank you. > > I tried your suggestion on XCode on MacOS. But it still does not break for me. > > I set a break point at: >

[chromium-dev] Re: reminder: don't use CHECK()

2009-05-29 Thread Dean McNamee
On Fri, May 29, 2009 at 3:55 AM, Evan Stade wrote: > > I was hitting a CHECK() today in x11_util::GetSecondaryXConnection() > (or w.e it's called). But that's because X somehow ran out of > available connections, or something, and I couldn't launch any other > programs either. At that point there'

[chromium-dev] Two tools for automatically getting a recent build of Chromium

2009-05-29 Thread Berend-Jan Wever
Hey all, If you want to have up-to-date builds of Chromium on multiple VMs for testing, you'll want to automate syncing source, building Chromium from source or downloading the "last know good" build and symbols from the build server. To do this, I created two scripts "build.py" and "download.py",