Re: [chromium-dev] Replicated State among tabs in Chromium

2010-01-04 Thread Charles Reis
Peter's right: as far as I understand, parsing, rendering, and script execution are all expected to take place on a single thread of execution. This includes any calls across multiple pages, which is why we place "connected" same-site pages (those in the same unit of related browsing contexts) in

Re: [chromium-dev] Unit test in chromium which test javascript alert

2010-01-04 Thread Charles Reis
There's also a few in-process browser tests in chrome/browser/browser_browsertest.cc that call alert and dismiss the dialog as part of testing something else, though they don't explicitly test aspects of alert's behavior. Just search for "alert" in that file to see how to use ui_test_utils::WaitFo

Re: [chromium-dev] Re: Different or same cookies storage in different tabs?

2009-12-18 Thread Charles Reis
Hi Sergio-- There are certainly some good use cases for having multiple sets of cookies at once. As Peter mentioned, though, there are challenges to providing a good user experience for this. For example, suppose you're viewing a page like Amazon where you're logged in, and you open a link to

Re: [chromium-dev] Recovering from browser crashes

2009-12-18 Thread Charles Reis
I'd love to see this happen, but I wouldn't be surprised if there's lots of state that's hard to restore. For example, how would the new browser process know which renderers are waiting for responses to some request, in order to return failures to them? I suppose we could just send a "re-parented

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Charles Reis
See the "Reducing the size of your checkout" section of this page for a place to mention it: http://dev.chromium.org/developers/how-tos/get-the-code (gclient config lean would also be nice) Charlie On Thu, Nov 5, 2009 at 11:44 AM, Ben Goodger (Google) wrote: > > it'd be nice to have a gclient c

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Charles Reis
On Wed, Oct 7, 2009 at 12:25 PM, Jeremy Orlow wrote: > On Wed, Oct 7, 2009 at 11:45 AM, Charles Reis wrote: > >> >> >> On Wed, Oct 7, 2009 at 11:13 AM, Andrew Scherkus >> wrote: >> >>> It'd be nice to have a non-distracting visual indicator

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Charles Reis
On Wed, Oct 7, 2009 at 11:13 AM, Andrew Scherkus wrote: > It'd be nice to have a non-distracting visual indicator, but to play the > devil's advocate... > What about intentionally CPU intensive sites that use , , > WebGL? > > What about scenarios where it's a plugin that's gone haywire? > > Could

[chromium-dev] Re: Chromium 1 process per tab architecture

2009-05-27 Thread Charles Reis
Those documents are certainly the best place to go to understand the process architecture (since it's not strictly process-per-tab, but that is an easy way to think about it). I think the answers to your specific questions are (1) yes, Chromium will prompt you if a rendering engine process becomes

[chromium-dev] Re: [extensions] Extension Process Model Draft

2009-02-04 Thread Charles Reis
This seems good-- I like the fact that the "chrome" parts of each extension are isolated from page content and have to use message passing. That will make it easier to understand which extensions actually need to access page content. One small wording question, just be sure I'm clear: "Process se

[chromium-dev] Re: Modal dialogs in Chrome

2008-12-18 Thread Charles Reis
On Thu, Dec 18, 2008 at 11:30 AM, Peter Kasting wrote: > On Thu, Dec 18, 2008 at 11:25 AM, Darin Fisher wrote: >> >> This idea is similar to what happens today when one tab runs a synchronous >> XMLHttpRequest that takes a long time to complete. The other tabs in the >> same renderer become mys

[chromium-dev] Re: Modal dialogs in Chrome

2008-12-18 Thread Charles Reis
Sorry to jump in late here, but I can contribute a few thoughts. (For those interested, I've been working on how pages are divided into different renderer processes / tab groups.) First, Darin's right that some groups of pages would have to be suspended together, since they can access each other o