Interesting. So if an extension has a background page, the idea is that as
soon as we open an incognito page every extension with a background page
would load up a second instance, which would remain running even after the
incognito window has closed?
One of the things I'm looking at is allowing e
Are you adding application-custom context menus, or is this a static context
menu provided by the browser? I ask, because I'm looking at adding custom
context-menu functionality for extension systray UI, and I'd like to see
what kind of API you came up with.
-atw
On Mon, Jan 11, 2010 at 11:55 AM,
Do you find that you have time to figure out if rebaselining a test is the
right thing to do while you're actively gardening? Maybe I just work too
slowly, but I often find that if I'm trying to rebaseline on the fly, it
requires that I do at least *some* investigation of the test failure to make
s
r my test.
-atw
On Sat, Dec 19, 2009 at 11:06 AM, Darin Fisher wrote:
> It seems like TabProxy::NeedsAuth could (should) be modified to just return
> true if the corresponding TabContents is showing a login prompt.
>
> -Darin
>
>
> On Fri, Dec 18, 2009 at 5:25 PM, Drew Wil
ing).
Is there another way to do it? Perhaps ui_test should register its own
NotificationObserver with the AutomationProvider framework? Or is that a
bogus approach?
-atw
On Thu, Dec 17, 2009 at 10:56 AM, Drew Wilson wrote:
> Thanks - turns out that just removing the #ifdef from the fi
2009 at 03:22, Drew Wilson wrote:
> > The closest thing I found to what I want is the LoginPromptTest ui_tests,
> > but these seem only to work on Windows because the automation framework
> > doesn't yet support NotificationType::AUTH_NEEDED on anything but
> wi
Hi all,
I'm developing on the Mac, and I'm trying to write a ui_test to verify HTTP
auth behavior for shared workers (specifically, I want to make sure that if
you have two parent documents for a shared worker, and the first one closes,
http auth requests from the worker still trigger the appropri
OK, thanks for the clarification. I'll starting whinging at people who
disable tests without a comment pointing at an associated bug.
-atw
On Mon, Dec 14, 2009 at 10:52 AM, Darin Fisher wrote:
> On Mon, Dec 14, 2009 at 10:42 AM, Drew Wilson wrote:
>
>> They'll sometim
ests.
> Perhaps that is not sufficient?
>
> -Darin
>
>
>
> On Mon, Dec 14, 2009 at 8:54 AM, Drew Wilson wrote:
>
>> I spent a few hours last week and this weekend trying to untangle the mess
>> that was the worker ui_tests. The problem is that the tests have
I spent a few hours last week and this weekend trying to untangle the mess
that was the worker ui_tests. The problem is that the tests have been
sporadically flakey due to various causes, and so various sheriffs/good
samaritans have disabled them to keep the trees green. Some of the tests
were disa
I'm seeing errors like this sporadically on the buildbots:
[15369:15369:1212/155951:124047683694:FATAL:/b/slave/chromium-rel-linux/build/src/chrome/test/chrome_process_util_linux.cc(33)]
Expected exactly 1 process to have socket open: 15770 16033
I'm not really certain from code inspection what'
ase of a
> > SharedWorker, the attacker doesn't get nearly as much leverage.
> >
> > Adam
> >
> >
> > On Wed, Dec 9, 2009 at 1:47 PM, Drew Wilson
> wrote:
> >> I'm trying to get my head around how our HTTPS status display (lock
> icon)
>
I'm trying to get my head around how our HTTPS status display (lock icon)
should work now that we support cross-window/cross-domain communication and
SharedWorkers.
Currently, if an HTTPS page loads a worker and that worker subsequently does
a non-HTTPS network operation, the parent window's UI up
Hi all,
I'm trying to understand the current (and future) state of Profile support.
Currently, SharedWorkers are shared by all windows in the system - any two
windows under the same domain can do "new SharedWorker(url)" and get a
reference to the same SharedWorker, and can use that worker to shar
It looks like this had some negative perf issues:
http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf%281%29/builds/6289/steps/page_cycler_intl2/logs/stdio
http://build.chromium.org/buildbot/perf/mac-release-10.5/intl2/report.html?history=150
(my DEPS roll was 33776)
I'm going
Hi Jeremy,
My next roll will be to 51642 (in progress). I'll ping you when it lands so
you can keep an eye on it too.
-atw
2009/12/3 Jeremy Moskovich
> Hi Drew & Albert,
>
> I picked your names off the WebKit sheriff calendar.
>
> I've landed a change to switch the Mac port over from ATSUI->Co
e
epilogue:
if (type == V8Index::MESSAGE_PORT && !(wrapper.IsWeak() ||
wrapper.IsNearDeath()) {
// Make the port weak again (undo the ClearWeak() in GcPrologue)
wrapper.MakeWeak();
}
On Sat, Nov 21, 2009 at 12:08 PM, Jens Alfke wrote:
>
> On Nov 21, 2009, at 10:40 AM, Drew W
it to make isolated worlds possible.
> I don't understand the MessagePorts lifetime issues in detail,
> however.
>
> Adam
>
>
> On Fri, Nov 20, 2009 at 7:02 PM, Drew Wilson
> wrote:
> > So I looked into the problem further - the issue was that calling close()
> >
"p").
Any thoughts from someone more familiar with this code?
-atw
On Thu, Nov 19, 2009 at 11:07 PM, Mads Ager wrote:
> Let us know what you find Drew. I'll be happy to help figure this out as
> well.
>
> -- Mads
>
> On Thu, Nov 19, 2009 at 11:46 PM, Drew Wil
shko wrote:
> On Fri, Nov 20, 2009 at 1:20 AM, Drew Wilson
> wrote:
> > I'm investigating a leak in the MessagePort/MessageChannel code.
> Basically,
> > if I have a page that looks like this:
> >
> > new MessageChannel();
> >
> > We leak two Me
I'm investigating a leak in the MessagePort/MessageChannel code. Basically,
if I have a page that looks like this:
new MessageChannel();
We leak two MessagePorts every time we reload the page.
The WebCore::MessageChannel impl object has two RefPtrs to two MessagePort
objects. When I reload the
gt;>>> On Fri, Oct 30, 2009 at 3:57 PM, Marcos Aruj wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> Quick question, how is the Notifications API going for the release of
>>>>>> 4.0? Are there any new
ceptions/console messages in any significant quantity.
-atw
On Sun, Nov 8, 2009 at 5:13 PM, John Abd-El-Malek wrote:
>
>
> On Sun, Nov 8, 2009 at 12:04 PM, Drew Wilson wrote:
>
>> In base webkit (i.e. the default, single-process implementation of
>> SharedWorkers), I route
I ask because we do have that shadow frame in the worker process that we
could potentially use, if there's some way to bring up devtools for these
types of pages.
-atw
On Sun, Nov 8, 2009 at 12:38 PM, Drew Wilson wrote:
> I'm assuming that there's not currently any way for a
oolsFrontend for any RenderViewHost using the schema I
> described. (They are opened in a separate devtools window).
>
>
> On Sun, Nov 8, 2009 at 11:23 PM, Drew Wilson wrote:
>
>> OK, I understand better now. Thanks.
>>
>> BTW, what happens to exceptions, etc gener
Looking over the code, it's not hard to forward messages from RenderViewHost
back to the RenderView, and from there off to the console, so perhaps that's
the right short-term solution for shared workers.
-atw
On Sun, Nov 8, 2009 at 12:23 PM, Drew Wilson wrote:
> OK, I understa
; maximum of the WebKit code both on the agent side and on the frontend.
>
> Pavel
>
>
> On Sun, Nov 8, 2009 at 11:04 PM, Drew Wilson wrote:
>
>> In base webkit (i.e. the default, single-process implementation of
>> SharedWorkers), I route all of these errors back to the i
process to call the ScriptExecutionContext
APIs, only to have that renderer process immediately bounce it back up to
the browser process).
-atw
On Sun, Nov 8, 2009 at 11:54 AM, Pavel Feldman wrote:
>
>
> On Sun, Nov 8, 2009 at 10:41 PM, Drew Wilson wrote:
>
>> That makes sense
r. There are increasingly more and more pages we have that don't
>> > have a page visible to the developer (sharedworkers, extensions
>> background
>> > pages, etc.). I can't think of any good solutions off the top of my head
>> > though.
>> > O
I'm trying to figure out the best way to report exceptions/console messages
from shared workers. Currently, dedicated workers just send their messages
back to their parent frame, where they are reported like any other
frame-level exception. SharedWorkers don't have a specific parent window
(they ma
cswiki.org/emacs/EmacsForMacOS
> http://www.emacswiki.org/emacs/CarbonEmacsPackage
>
> -Ken
>
> On Tue, Nov 3, 2009 at 10:08 AM, Drew Wilson
> wrote:
> > I've been using Aquamacs, although I don't like the fact that it has *so
> > many* modes built-in and turned-
Do the trybots build the release version? Because I had a build break last
week that passed the 3 basic trybots, but failed to compile on the release
buildbots because of a missing include which was apparently pulled in
through other means in the debug version.
-atw
On Tue, Nov 3, 2009 at 7:30 PM
org/emacs/EmacsForMacOS
> > http://www.emacswiki.org/emacs/CarbonEmacsPackage
> >
> > -Ken
> >
> > On Tue, Nov 3, 2009 at 10:08 AM, Drew Wilson
> wrote:
> >> I've been using Aquamacs, although I don't like the fact that it has *so
> >> many* modes built
between them is too different; (2)
> >> the Rietveld uploader isn't synthesizing Subversion renames well
> >> enough. (2) is a bug that I (or realistically, you) can fix, while
> >> (1) frequently means that tracking that history doesn't really matter
> >
I've been using Aquamacs, although I don't like the fact that it has *so
many* modes built-in and turned-on by default, and I also don't like the
fact that it doesn't lend itself well to customization (it has its own set
of initialization files it keeps hidden off). It's decent, though (but
again,
Hi all,
I'm doing some refactoring in the chromium worker code, and I got the
following review feedback:
"small request: can the files that were branched from existing files be "svn
copy'd" instead of copying manually and "svn added"? This will preserve
history
and will make it easier to see wha
Gah. Need to read my mail first.
On Thu, Oct 29, 2009 at 5:42 PM, Drew Wilson wrote:
> Hi all,
>
> John pointed out to me in a recent review that my new files didn't have
> svn:eol-style LF set on them. When setting up my git enlistment, turns out I
> didn't setup t
Hi all,
John pointed out to me in a recent review that my new files didn't have
svn:eol-style LF set on them. When setting up my git enlistment, turns out I
didn't setup the various svn properties described in the git setup docs (the
documentation may have been added after I setup git, or maybe I
To be clear - our priority is to support HTML notifications on all platforms
*before* investigating support for native notification platforms (like
Growl/libnotify).
-atw
On Mon, Oct 19, 2009 at 11:25 AM, Ian Fette wrote:
> We're trying to come up with a way to display html notifications on thes
I've been thinking quite a bit about this - I agree with Dmitri that the
current Sisyphean approach is unsustainable.
I don't think the right path is to ask the sheriffs to do the cleanup
themselves - for example, a webkit roll that breaks workers in some obscure
way is almost certainly beyond the
Are some pixel tests currently disabled on the linux release buildbots? I'm
trying to rebaseline some tests that are currently marked as FAIL in
test_expectations, but I can't grab linux images because the .png files
don't exist in the archive grabbed by the rebaseline tool.
As an example, I'm look
I'm trying to follow these suggestions, but I'm getting a ton of errors when
trying to do a gclient sync when third_party/WebKit is a clone of
git.webkit.org.
For example:
svn: '/Users/atwilson/chrome.git/src/third_party/WebKit/WebKitLibraries' is
not a working copy
Error: Can't update/checkout
'/
for other people.
-atw
On Thu, Sep 24, 2009 at 2:20 PM, Marc-Antoine Ruel wrote:
> Thanks for proposing yourself in improving gcl.py and trychange.py.
>
> On Thu, Sep 24, 2009 at 5:18 PM, Drew Wilson
> wrote:
> > Before we start enforcing penalties for people who screw this up, we
Before we start enforcing penalties for people who screw this up, we need to
do some tools work to make this less error prone/manual-hackery, I think.
-atw
On Thu, Sep 24, 2009 at 1:56 PM, Steve Vandebogart wrote:
>
> On Thu, Sep 24, 2009 at 1:49 PM, Yaar Schnitman wrote:
>
>> Yes.
>>
>> With gi
o 1.6 for all the
> speed improvements. Official package:
> http://www.open.collab.net/downloads/community/
> (Which installs it in the strange place of /opt/subversion/bin.)
>
> -eric
>
> On Mon, Sep 21, 2009 at 9:12 PM, Mark Mentovai wrote:
> >
> > Drew Wilson wr
Hi all,
I'm trying to do a gcl try on my mac, but getting this error:
svn checkout --depth empty
svn://svn.chromium.org/chrome-try/try/var/folders/zz/zzzivhrRnAmviuee++2D3++-1lE/-Tmp-/tmpMRXSrL
--username
atwil...@google.com
Ouput:
svn: invalid option: --depth
Type 'svn help' for usage.
Sorry, Tr
On Mon, Sep 21, 2009 at 5:41 PM, Jeremy Orlow wrote:
> On Mon, Sep 21, 2009 at 5:32 PM, Drew Wilson wrote:
>
>> Ooops, sorry. Got bit by reply vs reply-all. See my notes below regarding
>> implementation details.
>> -atw
>>
>> -- Forwarded message
Ooops, sorry. Got bit by reply vs reply-all. See my notes below regarding
implementation details.
-atw
-- Forwarded message --
From: Drew Wilson
Date: Mon, Sep 21, 2009 at 5:03 PM
Subject: Re: [chromium-dev] Shipping features behind a run-time flag can
sometimes still be
ave a shim, or we're pulling in
> something we've been able to avoid in the past.
> TVL
>
>
> On Sun, Sep 20, 2009 at 12:47 PM, Drew Wilson wrote:
>
>> Hi all,
>> I'm trying to fix up some of the worker layout tests. worker_uitests is
>> currently disab
Hi all,
I'm trying to fix up some of the worker layout tests. worker_uitests is
currently disabled on the mac, and when I enable it in chrome.gyp (it's
currently added to the !sources line for the mac version of ui_tests due to
broken tests), I get the following link error:
Undefined symbols:
".
Hi all,
I've put together a design doc for my upcoming SharedWorker implementation.
The original lives here:
http://docs.google.com/a/chromium.org/Doc?id=dgfs7fcc_0f32q7xdd
and I'll migrate it to dev.chromium.org once it's less draft-y.
I'd appreciate any feedback - there are a few highlighted o
How will V8 bindings be handled - is it our intention that the burden of
creating/maintaining V8 bindings will be shouldered by the WebKit community?
Or is it expected that the Chromium port buildbot will just go red and
chromium team members will step up to write bindings? Or perhaps the
Chromium
I have a utility routine that I want to call from various v8 bindings. This
utility routine does some validation on the passed-in v8::value, and if it
doesn't match certain criteria, throws an exception. I'd like the callers to
be able to tell if the utility routine threw an exception or not, so th
ink I see how to move forward now.
-atw
On Thu, Aug 20, 2009 at 11:22 PM, Darin Fisher wrote:
> It would be easier to recommend advice if I could see / review the code.
> Can you provide a link to the in-progress CL?
> -Darin
>
>
>
> On Thu, Aug 20, 2009 at 9:46 PM, Drew W
On Thu, Aug 20, 2009 at 8:39 PM, Darin Fisher wrote:
> On Thu, Aug 20, 2009 at 8:37 PM, Darin Fisher wrote:
>
>> On Thu, Aug 20, 2009 at 6:17 PM, Drew Wilson wrote:
>>
>>> I have to admit I'm somewhat fuzzy on the motivation behind our webkit
>>> API, al
ecommended approach is to use
non-WebKit classes elsewhere and convert as needed when calling WebKit API.
Thanks for the help!
-atw
On Thu, Aug 20, 2009 at 6:35 PM, Jeremy Orlow wrote:
> On Thu, Aug 20, 2009 at 6:17 PM, Drew Wilson wrote:
>
>> I have to admit I'm somewhat fuzzy o
I have to admit I'm somewhat fuzzy on the motivation behind our webkit API,
although I gather the plan is to eventually upstream it to WebKit, and use
it as our abstraction layer instead of using the (more mutable) WebCore
APIs? Or is there another motivation?
I'm just curious because it seems like
shared workers that no longer are connected
> to any active pages, right?
>
> J
>
>
> On Wed, Aug 12, 2009 at 3:25 PM, Darin Fisher wrote:
>
>> I assume we will just kill the slow worker without prompting the user,
>> right? Please no slow script dialogs.
>&
, 2009 at 12:58 PM, Drew Wilson
> wrote:
> > Hi all,
> > It appears from looking at the worker code that if worker script enters
> into
> > an infinite loop, the associated worker thread/process will never exit.
> The
> > JavaScriptCore implementation uses the JSC &qu
Hi all,
It appears from looking at the worker code that if worker script enters into
an infinite loop, the associated worker thread/process will never exit. The
JavaScriptCore implementation uses the JSC "timeoutChecker" mechanism to
halt script execution. Is there an analog we can use for V8?
I d
One caveat for Colloquy is that the default highlight for "someone sent you
a PM" is "bounce once" rather than "bounce lots of times", so it's really
easy to miss PMs if you don't change the default.
-atw
On Thu, Aug 6, 2009 at 8:57 AM, Pam Greene wrote:
> For Colloquy, enter your nick in Prefer
I recall that the SQL Storage API allows developers to declare up front how
much quota they want. Perhaps you should ask Hixie if we want to make this
an option for local storage as well?
BTW, I can't find the HTML5 sql storage spec anymore - google is totally
failing me. Anyone have a link?
-atw
I've been starting to lean in this direction as well. The problem is that
extensions are currently not cross-platform and would require separate
implementations for each platform. And in many cases the extension delivery
mechanism is under the control of an arbitrary third party (i.e. Google,
Mozil
SGTM. Note that we're essentially duplicating (assumedly intentionally so)
the window.postMessage() APIs which require specifying a target domain and
whose connect event has a "source" and "origin" attribute specifying the
window that sent the message. It might be valuable to just explicitly adopt
lls a pointer
value out of kDOMWrapperObjectIndex (the passed-in type is essentially
ignored except for some runtime debugging) so we could probably just
generate calls to convertDOMWrapperToNative() instead.
-atw
On Wed, Jul 22, 2009 at 12:59 PM, Drew Wilson wrote:
> I think this may n
s in the V8Index file.
>
> Cheers,-- Mads
>
> On Tue, Jul 21, 2009 at 6:13 PM, Drew Wilson wrote:
> > The other unanswered question is whether it's useful to define the base
> > "type" in V8Index.h.
> > If a wrapper of the base type (WRAPPERCONTEXT)
Nodes, etc.
>
> Adam
>
>
> On Tue, Jul 21, 2009 at 10:32 AM, Jeremy Orlow wrote:
> > On Tue, Jul 21, 2009 at 10:19 AM, Drew Wilson
> wrote:
> >>
> >> It seems like that would have some undesirable side-effects, aside from
> >> the fact that WebKi
wrapper
(DOCUMENT, SVGDOCUMENT, etc) based on that. I suspect that I'll be able to
get rid of WORKERCONTEXT ultimately since it's not directly instantiable
(never have a wrapper of that concrete type).
-atw
On Tue, Jul 21, 2009 at 10:42 AM, Drew Wilson wrote:
> Yes, there's polym
ption);
attribute EventListener onmessage;
};
The JSC bindings reflect this nicely, because there's a class hierarchy in
JSC that matches the hierarchy in the IDL files.
-atw
On Tue, Jul 21, 2009 at 10:32 AM, Jeremy Orlow wrote:
> On Tue, Jul 21, 2009 at 10:19 AM, Drew
n the base class and the rest can be purely
>> virtual with implementations in the sub classes.
>>
>> J
>>
>> On Mon, Jul 20, 2009 at 3:21 PM, Drew Wilson wrote:
>>
>>> Following up on this. Let's imagine that I don't define a V8ClassIndex
>>
or checking currently, so I guess what I should use instead is
convertDOMWrapperToNative()?:
WorkerContext* workerContext =
V8DOMWrapper::convertDOMWrapperToNative(info.Holder());
Is that the general pattern people use for cases like this?
-atw
On Mon, Jul 20, 2009 at 3:21 PM, Drew Wilson wrote
:
Currently, Web Workers have a class (WorkerContext) which represents the
global scope for a worker. The custom V8 bindings for this class are defined
in V8WorkerContextCustom, and we also define V8ClassIndex::WORKERCONTEXT for
the wrapper object.
I'm refactoring the WebCore impl class, so Worker
On Tue, Jul 14, 2009 at 5:48 PM, Drew Wilson wrote:
> I would actually have expected the normal (non-worker) MessagePort tests to
> pass/not-crash, as I don't think that jam has gotten far enough into the
> implementation to break the non-cross-process versions :)
> I have
y with the rest of my questions to avoid
either boring the rest of the list :)
-atw
On Thu, Jul 9, 2009 at 3:46 PM, Drew Wilson wrote:
> Sorry, I stupidly put the wrong example in:
> parent page:
>
> function getImage() {
> return new *parent.window.*Image();
> }
>
>
Hi all,
I've been poking around quite a bit recently in the WebKit JS
bindings/constructor code, trying to make some sense of their widespread use
of the lexicalGlobalObject() - basically, it seems like looking at the
lexicalGlobalObject() is seldom what they actually want, because it means
that if
d-El-Malek
>
>
> 2009/6/24 Drew Wilson
>
> I'm looking at the code in webworker_impl.cc and webworkerclient_impl.cpp,
>> vs the code in WebCore/workers/WorkerMessagingProxy.cpp.
>> As an example:
>>
>> Chrome version:
>> void WebWorkerClientImpl::postM
BTW, I checked in with IanH - it sounds like WebSockets are also on the
Worker roadmap, so that's something to keep in mind while you iterate on
your design.
+1 to avoiding WebCore/loader, but also +1 to refactoring to enable as much
common code as possible cross-platform - I'm looking at the Chrom
I've seen quite a few instances of these idioms:
1)
if (ec)
throwError(ec);
2)
if (ec)
throwError(ec);
return v8::Undefined()
It's not obvious from the documentation, but throwError() always returns
v8::Undefined(), and it does nothing if ec == 0. So the code above could be
rewritten as
On Thu, May 21, 2009 at 10:41 AM, Mike Beltzner wrote:
>
> On 21-May-09, at 12:51 PM, Nick Baum wrote:
>
> > Re:standardizing APIs, we're relying on HTML5 as much as possible.
> > For example, we'll provide HTML5 LocalStorage and Databases instead
> > of rolling our own storage API. The
>
> That's
79 matches
Mail list logo
