[chromium-dev] Re: [Memory] low memory callback

On Thu, Oct 1, 2009 at 6:17 AM, Anton Muhin wrote: > Dear chromers! > > Do we have some notification mechanism for low memory event? > > If not, are you fine if I add it? It would be completely optional and > I would only implement it for tcmalloc (most probably invoking before > TCMalloc_System

[chromium-dev] Re: Extracting Webkit Test Shell and its dependencies

On Wed, Sep 30, 2009 at 4:06 AM, plafayette wrote: > Is there a good, and less painful, way to extract test_shell into its > own project? I don't understand. test_shell already is its own project (.vcproj). PK --~--~-~--~~~---~--~~ Chromium Developers mailing l

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

On Wed, Sep 30, 2009 at 11:05 AM, Anton Muhin wrote: > Mike, I am completely agree that we should reduce memory usage. On > the other hand speed was always one of Chrome trademarks. My feeling > is more committed pages in free list make us faster (but yes, there is > paging etc.). That's exact

[chromium-dev] Re: Kiosk Mode for Chrome

On Tue, Sep 29, 2009 at 5:38 PM, Mohamed Mansour wrote: > How about in kiosk mode, we only hide the "status bubble", > I don't see why we even hide the status bubble. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

On Tue, Sep 29, 2009 at 3:35 PM, Marc-Antoine Ruel wrote: > If I understand correctly, you're asking for a webkit try server? And > in particular a apple windows builder/tester. I think so, something that builds the Apple Windows port and runs its layout tests. Or else comments about how to acc

[chromium-dev] Green tree task force: How to try upstream Windows layout tests?

I figure this question is most suited for the Green Tree folks. Ojan told me today that he had a patch to fix one of my pet peeve bugs in WebKit, but he hadn't committed it because it would affect the results of the Windows layout tests and he didn't have an easy way to test and rebaseline them. I

[chromium-dev] Re: Chrome Keyboard Access, opinions?

On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet wrote: > On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting > wrote:> It seems like when these bars are open, their contents should be in > the tab > > order. You should be able to tab through the contents of a page, into >

[chromium-dev] Re: Chrome Keyboard Access, opinions?

On Mon, Sep 28, 2009 at 10:51 PM, Mohamed Mansour wrote: > CTRL+SHIFT+T --- Main Toolbar > CTRL+SHIFT+B --- Main Bookmarks bar > CTRL+SHIFT+E --- Extension bar > I really don't like this. These are hard to discover and use. Besides, you can't use two of these three: ctrl-shift-t is reopen clo

[chromium-dev] Re: Is that unimpossible to add a progress bar of page loading with webkit?

On Mon, Sep 28, 2009 at 9:48 AM, Mike Pinkerton wrote: > On Mon, Sep 28, 2009 at 12:21 PM, PhistucK wrote: >> Yeah, but some indication will be helpful, even the one IE has been giving - >> Do you not agree? > > I do not agree. I agree with pinkerton. This is useless detail. The thing I think

[chromium-dev] Re: Add "Jank" to appropriate bugs

On Sat, Sep 26, 2009 at 5:17 PM, Jacob Mandelson wrote: > When I find web pages which demonstrate an exceptional amount of chrome > jank, is there a particular bug I should add them to? Or should we wait > for the general jank-tagged issues to get resolved? That's too generic a question. The r

[chromium-dev] Re: FYI, project cruft

Thanks Mark-Antoine. It has been a very long time since I fixed the dependencies years ago to not be so crazy. Not surprising that it is once again goofed up. It would be nice to have some of this stuff auto-calculated by GYP if that is feasible... PK --~--~-~--~~~--

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

On Fri, Sep 25, 2009 at 12:44 PM, Ben Goodger (Google) wrote: > We should only allow this UI to be invoked from a user gesture. How does Gmail trigger this today? Do they have a button in the Settings you have to click? PK --~--~-~--~~~---~--~~ Chromium Develop

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

On Fri, Sep 25, 2009 at 12:08 PM, Jeremy Orlow wrote: > If you click no on an info bar, then how would you later change your mind? I don't know. Maybe at that point the icon appears in the address bar. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API

On Fri, Sep 25, 2009 at 11:33 AM, Brian Rakowski wrote: > I'm concerned that the page actions style Omnibox icon is not sufficient > notification for users that this capability exists. I'll add this to the > list of features for UI team to create mocks for. I agree, I think I'd prefer an infoba

[chromium-dev] Re: Build time doubled since May - what gives?

On Fri, Sep 25, 2009 at 11:09 AM, Nick Carter wrote: > I'll volunteer to fix any build issues created as a result of sync. > Building the protobuf compiler (protoc.exe) emits a bunch of warnings -- > the bulk are signed/unsigned warnings. I'll put together a change to > suppress those. > It wou

[chromium-dev] Re: Question about UI and "classic views"

On Fri, Sep 25, 2009 at 7:16 AM, Thomas Van Lenten wrote: > At times, we seem to forget the impact of our silent updates. They are > great for bug/security fixes, but when we do roll out something like NNTP, > it can lead to a 'WTF' moment. For future changes like this, it might make > sense to

[chromium-dev] Re: Problem with gyp every time v8 updates their branch

On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek wrote: > Every time v8 team updates which branch is the one that's used in Chrome, > gclient sync fails on Windows. The error is below. > That's weird. I haven't seen this on my machine. PK --~--~-~--~~~---~--~---

[chromium-dev] Re: Search engine settings backup

On Wed, Sep 23, 2009 at 11:44 AM, m.f wrote: > That post suggested the entire User Data folder. I knew about this > file long ago. However, the nature of the bug I was trying to > overcome had to do with something that was not quite kosher within > that folder. So I didn't want to just blindly

[chromium-dev] Re: Webkit merges and tree closures

On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain wrote: > If this is an issue, I am proposing that Webkit merges be done outside peak > hours (11am-5pm pacific). > > If we implement this, it can cause problems for cases where we need to do a merge/land/merge pattern to coordinate landing a local a

[chromium-dev] Re: Chromium isn't shutting down cleanly

On Tue, Sep 22, 2009 at 10:39 AM, Daniel Cowx wrote: > Can someone please provide a bit of insight into how to solve the > following problem: > > 1. Open Chromium > Options > Show saved passwords > 2. Click the "Remove All button" > > Now, *before* you click "Yes" or "No", close the main browser

[chromium-dev] Re: [linux] user feedback one month in

On Mon, Sep 21, 2009 at 10:20 AM, Robert Sesek wrote: > At least on Mac, in the bookmark menu/bar we use the generic globe favicon > for sites that don't have their own icon. Perhaps we should switch this to > be a star icon? That way there'd be a subtle suggestion to the user that > star=bookmar

[chromium-dev] Re: [linux] user feedback one month in

On Sun, Sep 20, 2009 at 9:33 PM, Evan Martin wrote: > > While we're on vague bug reports, I often have images partially load > > and then stop, never to complete. It doesn't happen all the time, but > > I have seen it often enough to suspect something is up. Is there a > > way to see what's goi

[chromium-dev] You help make Eric Schmidt's favorite product

http://searchengineland.com/eric-schmidts-favorite-google-product-chrome-26198 Congrats, all you folks who contribute to Chrome in any way. Of all the products Google makes, Chrome is apparently Eric Schmidt's current favorite, surpassing ones that bring in billions of dollars of revenue. High pr

[chromium-dev] Re: [linux] computing cpu usage

On Thu, Sep 17, 2009 at 4:18 PM, Evan Martin wrote: > While within the law, I'd prefer to respect the spirit of the author's > intention. > Your call. Generally I would prioritize users' benefit (which they get both from libgtop being "better" and from our Linux devs not wasting their time reim

[chromium-dev] Re: [linux] computing cpu usage

On Thu, Sep 17, 2009 at 4:06 PM, Evan Martin wrote: > For the task manager we want to show CPU usage. Here's a summary of > options. > > 1) Use libgtop, which was designed for this. But nixed because it's > GPL, explicitly to prevent apps like us from using it. Bummer. Ship a small, complete

[chromium-dev] Re: "Clear Strict-Transport-Security state" checkbox added

On Thu, Sep 17, 2009 at 3:31 PM, Adam Langley wrote: > I'm more bothered that people who care about their privacy have the > ability to control the information we store about them. > At the bottom of "Under the Hood" is a button called "Reset to Defaults". This is what we hook to all of the tin

[chromium-dev] "Clear Strict-Transport-Security state" checkbox added

http://src.chromium.org/viewvc/chrome?view=rev&revision=25955 added a "Clear Strict-Transport-Security state" checkbox to the "Clear browsing data" dialog. It's disappointing to me that this change was made without any bug in the bug database linked, and without any input from a member of the UI te

[chromium-dev] Re: custom built chromium *much* slower than chrome

On Thu, Sep 17, 2009 at 2:04 AM, Rozenkraft wrote: > This is my problem, I build chromium (yes, in release) and when I > benchmark it in sunspider I consistently get worse performance than in > chrome. With chrome I always get 700 ms and with my freshly built > chromium I always get 1200 ms. >

[chromium-dev] JSNES: A NES emulator that runs well in Chrome

http://benfirshman.com/projects/jsnes/ "I highly recommend you use Google Chrome to play JSNES. ... it just about runs on Firefox 3.5 or Safari 4, but it's hardly playable." I wonder if we can get this guy to throw this into chromeexperiments.com ? PK --~--~-~--~~~---

[chromium-dev] Re: Verdict: Menu string casing

On Wed, Sep 16, 2009 at 2:30 PM, krtulmay wrote: > Sentence case is terrible. Can't understand why Vista HIG would choose > that. After all, why use Sentence case on all these things that are > *not* sentences? > > Definitely should use Title Case, even for Windows. After all, they > are titles

[chromium-dev] Re: Chrome Library for tweaking Windows Network Settings

On Tue, Sep 15, 2009 at 1:54 PM, TJ Shah wrote: > Hi, > > I am trying to automate few test cases that requires me to simulate > certain scenarios like 'Network is down' or 'Sync server not > reachable' etc.. I am not sure about the Chrome Library that I can use > to play with Windows Network Sett

[chromium-dev] Re: Linux views trybot

On Wed, Sep 16, 2009 at 6:56 AM, Marc-Antoine Ruel wrote: > I created a builder for that. It is not in the default pool since I > connected only one slave to it. I support anything that gets this builder into the default pool. PK --~--~-~--~~~---~--~~ Chromium D

[chromium-dev] Linux views trybot

We need one. I have broken the Linux views build three times in the past three days. This is wasting my time and the sheriffs' both. Is someone working on making this happen? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com

[chromium-dev] Add "Jank" to appropriate bugs

Tomorrow afternoon a couple of us will be triaging all bugs with the "Jank" label. Jankiness is sluggishness in the UI, so things like slow startup or shutdown, tabs taking a while to paint or to close, keyboard accelerators and button clicks being unresponsive, and other similar "Chrome doesn't d

[chromium-dev] Re: Are we now using Visual Studio 2008?

2009/9/14 Jungshik Shin (신정식, 申政湜) > I just got a z600 box and I was wondering about Webkit on Windows and VS > 2008. According to the docs at webkit.org, VS 2008 is not supported, yet. > I wonder how others deal with this issue. Do they have both 2005 and 2008 on > z600 or is there a hidden tri

[chromium-dev] Re: Please stop hardcoding URLs everywhere

2009/9/13 Jói Sigurðsson > A nice trick for finding if a constant string you're about to add > already exists in the codebase is to use > http://codesearch.google.com/. Another way, if you're running Visual Studio, is to click on the "search" button in the toolbar (IIRC it looks like a folder;

[chromium-dev] Re: How do you perform tab traversal?

On Fri, Sep 11, 2009 at 6:53 PM, Daniel Cowx wrote: > I've added 2 views::Textfields to WindowView, but I can't seem to tab > between them. When I press the tab key, it simply inserts a tab into > the editbox. > Jay is the most knowledgable person here, CCing him. PK --~--~-~--~~--

[chromium-dev] Re: economist reevaluates chrome; startup still weak

On Fri, Sep 11, 2009 at 6:51 PM, Evan Martin wrote: > That is: cold startup = ~12sec; warm startup = ~5sec. > What could be taking so long? > > > http://www.economist.com/sciencetechnology/displaystory.cfm?story_id=14437676 > > We can take that long when there is heavy I/O contention. Despite t

[chromium-dev] Re: Announcing "view-net-internal:"

On Thu, Sep 10, 2009 at 3:00 PM, Adam Barth wrote: > On Thu, Sep 10, 2009 at 2:56 PM, Eric Roman wrote: > > In the chromium trunk builds later than r25926, there is a new info page, > > "view-net-internal:" > > Can we move this to chrome://net-internal/ ? Proliferating random > schemes adds up

[chromium-dev] Re: Argh: Rebuilding installer_util on every F5

On Wed, Sep 9, 2009 at 8:42 PM, Finnur Thorarinsson wrote: > This sounds like exactly the problem I was having a few days ago, except > that it was fixed in: > http://src.chromium.org/viewvc/chrome?view=rev&revision=25290 > > I wonder

[chromium-dev] Re: Are we going to support active FTP?

On Wed, Sep 9, 2009 at 10:01 PM, Darin Fisher wrote: > For reference, this is https://bugzilla.mozilla.org/show_bug.cgi?id=465. > A 3 digit Mozilla bug! > Personally, I don't think we should spend much time on active mode FTP. It > doesn't seem that valuable given that it is not supported by Fi

[chromium-dev] Re: Chromium core principles and multiplatform development?

On Thu, Sep 10, 2009 at 10:20 AM, Nico Weber wrote: > > While you're on it, could you add something like > > "In general, be consistent with the platform. We believe that users > switch between applications more often than between operating systems, so it > is more important to be consistent w

[chromium-dev] Re: found corrupted db

On Wed, Sep 9, 2009 at 9:21 PM, Scott Hess wrote: > What's puzzling is how I know this, but we still see the crash. I'm > pretty sure we fixed something or other around this. That was a year > or more back, though, so maybe I'm not remembering right. Regardless, > best-case scenario for someth

[chromium-dev] Argh: Rebuilding installer_util on every F5

Somehow, starting today, I'm now rebuilding installer_util (recompiling a half dozen files, which then causes me to relink chrome.dll) every time I hit F5. Deleting chrome.{ncb,suo} and rm -rfing Debug/ and Release/ do not help. Did someone goof with these recently? Did the ICU change somehow tou

[chromium-dev] Help needed reproducing a crash

I'm trying to track down a crash (bug 20511) which no one on the team has been able to figure out how to reproduce. If you ever have the browser crash on you right when you hit enter in the address bar, or when you hover the Go button, and can remember anything about what you were doing at the time

[chromium-dev] Re: Are we going to support active FTP?

On Wed, Sep 9, 2009 at 10:53 AM, Paweł Hajdan Jr. wrote: > This is http://code.google.com/p/chromium/issues/detail?id=3073 . I think > it's not so hard to implement it (and probably not so high priority either), > but are there any potential security (or other) problems? > I can't think of any.

[chromium-dev] Re: Linux HTML5, List of Libraries

On Tue, Sep 8, 2009 at 5:29 AM, Luis Canaval wrote: > HMLT5 Video and audio tags Note that only Google Chrome builds ship the decoders for h.264, so if you're using Chromium and trying to test, say, the YouTube HTML5 demo site, it won't work. PK --~--~-~--~~~---~--~

[chromium-dev] Re: Rubber stamping layout test rebaselines considered harmful

On Thu, Sep 3, 2009 at 5:30 PM, Julie Parent wrote: > When I found these I went back and looked at the initial check in and saw > that most of them had already been fixed (presumably by you). I only found 3 > remaining (http://codereview.chromium.org/190019). > Ah. Very sorry to have missed the

[chromium-dev] Re: Rubber stamping layout test rebaselines considered harmful

On Thu, Sep 3, 2009 at 4:40 PM, Julie Parent wrote: > Real examples I ran into in the past 2 days: > >- Failing tests because the baseline checked in is for an error page, >and we generate real results. Glancing at the diff should have caught >this: http://codereview.chromium.org/113

[chromium-dev] Re: layout test dashboard

On Wed, Sep 2, 2009 at 6:52 PM, Ojan Vafai wrote: > Done. Have I mentioned recently how much you rock for doing this? I just want to make sure I say it a few times since it's awesome. Thanks Ojan! PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chr

[chromium-dev] Re: Launching from Java

On Wed, Sep 2, 2009 at 1:07 AM, Daniel Wagner-Hall wrote: > On Tue, Sep 1, 2009 at 11:26 PM, Nico Weber wrote: > > This is probably because of the launcher changes that Mark made. When > > I start Chromium from a terminal, it opens in the background too. > > `osascript -e 'tell app "Chromium" to a

[chromium-dev] Re: Platform parity

On Tue, Sep 1, 2009 at 8:04 PM, Tim Steele wrote: > I don't think all[platforms]-or-nothing would have really fair to insist on > :\ I don't think any person who wants to contribute to chromium should be > required to have either a machine and/or skills required for each platform > to test things

[chromium-dev] Re: layout test dashboard

On Tue, Sep 1, 2009 at 5:15 PM, Ojan Vafai wrote: > I lied. Another update worth spamming about. > The dashboard now by default hides both WONTFIX tests and tests that match > their expectations. This way, the dashboard represents a concrete list of > work to make tests match their expectations.

[chromium-dev] Re: Chromium 64 bits MAC OS X - Snow Leopard

On Mon, Aug 31, 2009 at 10:10 AM, Evan Martin wrote: > I think a better question is: why are we targeting outdated 64-bit > technology? > > > http://news.cnet.com/8618-30685_3-10314452.html?communityId=2140&targetCommunityId=2140&blogId=264&messageId=8322371&tag=mncol;tback That sure opened my

[chromium-dev] Re: Platform parity

On Sun, Aug 30, 2009 at 8:57 PM, Nico Weber wrote: > I happened to look at a CL today that adds a "Really delete all > passwords?" dialog on Windows ( http://codereview.chromium.org/155291 > ). The patch was done by someone relatively new to the project (which > is of course great). Sadly, neithe

[chromium-dev] Re: Chrome has started crashing like CRAZY since 4.0.203.2

On Sat, Aug 29, 2009 at 2:58 PM, Gobbledegook wrote: > every 10 minutes i'm getting one crash. It was rock solid till earlier > today. > Don't send this to chromium-dev. File bugs at crbug.com. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium

[chromium-dev] Re: Copying of profiles across systems

On Wed, Aug 26, 2009 at 7:48 PM, PhistucK wrote: > Bearing the upcoming Chrome OS in mind, this should be taken into account > quite strongly. > I don't think it's appropriate to speculate on what will and will not be useful for Chrome OS until more details about it are made public. PK --~--~-

[chromium-dev] Re: layout test dashboard

On Wed, Aug 26, 2009 at 5:12 PM, Ojan Vafai wrote: > The only work I still plan to do on it is to make it perform a bit better. > Please file bugs if there are other additions that would be useful to you. > This is super-minor, but it might be nice to indicate, for the "flakiness" column, that t

[chromium-dev] Re: Copy/Paste suddenly not working?

On Mon, Aug 24, 2009 at 4:48 PM, Andrew Herrgott wrote: > I'm using Chrome on Ubuntu Hardy. Yesterday, my copy/paste > functionality seemed to disappear from Chrome. I can copy/paste to > and from other applications. I can also select text and drag it from > Chrome to textpad. > > However, ctrl

[chromium-dev] Re: Copying of profiles across systems

On Wed, Aug 26, 2009 at 2:37 PM, Avi Drissman wrote: > On Wed, Aug 26, 2009 at 2:31 PM, Ben Goodger (Google) > wrote: > >> Note that even upgrading Windows OS from XP to Vista involves changing >> paths: >> >> c:\Documents and Settings -> c:\Users >> >> Do we ever write paths such as this? >> >

[chromium-dev] Re: Splitting up chrome.dll

On Tue, Aug 25, 2009 at 8:25 AM, Nicolas Sylvain wrote: > Eventually we would like to be able to split webkit in it's own dll too. I > heard to it's not possible right now due to some inter-dependency problems, > but people are working on that. Webkit was designed to be in its own dll, > so it sho

[chromium-dev] Re: layout test dashboard

On Mon, Aug 24, 2009 at 6:42 PM, Ojan Vafai wrote: > A first version of the layout test flakiness dashboard is up. > > http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html > AWESOME O RAMA Seriously, this has been critically needed, thanks tons. PK

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Sun, Aug 23, 2009 at 11:14 PM, zeniko wrote: > Then again: Is accessibility one of the goals for Chrome at all? Or is > it just not tested for for lack of manpower? As it currently stands, > it can get quite frustrating to use without a mouse (double accesskeys > in menus, no accesskeys at all

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Sat, Aug 22, 2009 at 11:57 PM, zeniko wrote: > In that case, the issue is that the menu shortcuts won't work > reliably, which (1) can get quite frustrating because you never really > know what a shortcut will do and (2) leads to the menus or other core > functionality remaining inaccessible i

[chromium-dev] Re: Handling layout test expectations for failing tests

On Sat, Aug 22, 2009 at 7:49 PM, Jeremy Orlow wrote: > On Sat, Aug 22, 2009 at 5:54 PM, Peter Kasting wrote: > >> Notes in test_expectations.txt are like comments in source code: A great >> boon. >> > > I've herd differing opinions, but you're the defi

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Fri, Aug 21, 2009 at 11:05 PM, zeniko wrote: > On Aug 21, 10:20 pm, Peter Kasting wrote: > > Windows native behavior is that hitting alt+accesskey opens the menu in > > question. > > Websites > use Alt+accesskey as well, and every combo you reserve for Chrome > wo

[chromium-dev] Re: Need information about when Chrome rerenders content

On Sat, Aug 22, 2009 at 8:39 AM, Stefan Blanke wrote: > Hello, > 1. i need information if Chrome rerenders content, even if a style > attribute set via javascript does not change the layout. > 2. is it safe to say, that all changes made inside a positioned > element (absolute & fixed ), will neve

[chromium-dev] Re: Handling layout test expectations for failing tests

On Sat, Aug 22, 2009 at 4:29 PM, Jeremy Orlow wrote: > On Sat, Aug 22, 2009 at 4:00 PM, Peter Kasting wrote: > >> If you somehow managed to not see any comments in this file, I think >> you're an outlier. >> > > I was talking about the rebaselining teams, not

[chromium-dev] Re: Handling layout test expectations for failing tests

On Fri, Aug 21, 2009 at 8:07 PM, Jeremy Orlow wrote: > >> 1) We don't have notes on why tests are failing. => Why not annotate >> the tests in test_lists? That's what I've always done. > > > Once again, we don't want to add more state to the test_expectations. How > may people looked up the t

[chromium-dev] Re: Handling layout test expectations for failing tests

On Fri, Aug 21, 2009 at 4:50 PM, Dirk Pranke wrote: > This is all good feedback, thanks! To clarify, though: what do you > think the cost will be? Perhaps you are assuming things about how I > would implement this that are different than what I had in mind. > Some amount of your time, and some a

[chromium-dev] Re: Handling layout test expectations for failing tests

On Fri, Aug 21, 2009 at 2:33 PM, Pam Greene wrote: > I'm not convinced that passing tests we used to fail, or failing tests > differently, happens often enough to warrant the extra work of producing, > storing, and using expected-bad results. Of course, I may be completely > wrong. What did other

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

As others have said, this thread has been beaten into the ground, and before it we had 15 other threads get beaten into the ground. Various relevant stakeholders such as beng, glen, pinkerton, etc. have been conversed with, and while we are interested in getting more data (see the bug I filed) and

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Fri, Aug 21, 2009 at 11:41 AM, Mohamed Mansour wrote: > Let me summarize what you all have stated: > >- ALT: Highlight App menu button >- ALT-P: Show Page menu >- ALT-A: Show App menu > > or.. > >- ALT: Highlight App menu button >- ALT-P: Highlight Page menu button >- A

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Fri, Aug 21, 2009 at 1:17 PM, Mohamed Mansour wrote: > I really want to name it tools as Peter stated, If anyone has any > objections, please let me know, it will now be: > ALT-T = Tools Menu (previously known as App menu) > ALT-P = Page Menu. > > The only difference within

[chromium-dev] Re: WebKit API guidance?

On Thu, Aug 20, 2009 at 9:46 PM, Drew Wilson wrote: > Speaking of which, how do we capture the idea of passing ownership of a > pointer? If this were in WebCore, I'd use WTF::OwnPtr/PassOwnPtr to signify > that I was passing off ownership of a pointer. Is there an analogous idiom > in the Chrome

[chromium-dev] Re: bugs.webkit.org dataloss

On Thu, Aug 20, 2009 at 10:53 PM, Ryosuke Niwa wrote: > In particular, *you need to resubmit all patches you've submitted in the > past 17 hours.* > Clarity: That means "all patches you attached to bugs". Patches that you committed to the SVN repository don't need to be re-landed; the SVN repos

[chromium-dev] Re: Overloading operator<< for TimeDelta

On Thu, Aug 20, 2009 at 3:33 PM, Andrew Scherkus wrote: > Any opposition to globally declaring an operator<< ostream overload for > TimeDelta in base/time.h? > This will pull the stream headers into all files that use time.h. Is that going to bloat any code or cost compile time? Is there anothe

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

On Thu, Aug 20, 2009 at 2:57 PM, James Hawkins wrote: > Will you accept opinions of the opposite? I love our current behavior > and can't stand having to triple-click in Firefox. > > Consider the following cases. > > a) The user is trying to completely change the contents of the omnibox. > - Cur

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

On Thu, Aug 20, 2009 at 2:24 PM, JT Olds wrote: > Oh yikes. Hmm. No, I'm not okay with that. > > Three solutions > 1) don't select the autocomplete. Do it like Firefox (autocompletions > are in the dropdown, don't mess with what the user is typing) The entire omnibox hinges on this behavioral d

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

On Thu, Aug 20, 2009 at 2:02 PM, JT Olds wrote: > None of the below Linux browsers select the entire URL on the first click: > Firefox > Epiphany > Seamonkey > Galeon > Midori > Konqueror > Dillo > > In fact, I can't find a single browser that does what you claim on Linux. I am on record ( http

[chromium-dev] Re: Omnibox highlighting and PRIMARY selection concerns

On Thu, Aug 20, 2009 at 1:36 PM, Adam Barth wrote: > On Thu, Aug 20, 2009 at 12:07 PM, JT Olds wrote: > > 1) on a single click to the omnibox, the cursor should be placed. The > > contents of the omnibox should not be selected. > > We violate this convention on Windows too. Yep, and so does ev

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Wed, Aug 19, 2009 at 4:30 PM, Glen Murphy wrote: > > Highlighting the Tools menu is important for a similar reason that > hooking > > it to alt-f instead of alt-t is: people have ingrained key combos like > > alt-f, x or alt, enter, x that they expect to work. > > Or alt-f+s, or alt-f+p > > Oh

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Wed, Aug 19, 2009 at 4:31 PM, Mohamed Mansour wrote: > Are you guys referring to "alt" alone or "alt-f, alt-e" to highlight the > menu item?. > "alt-f" if triggered appropriately brings up full screen which is another > problem ... > Alt alone. Fullscreen is F11 on Windows, not alt-f. (We

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Tue, Aug 18, 2009 at 9:40 PM, Evan Stade wrote: > Also, I don't really care which one alt highlights, but it seems to me > that alt just highlights the leftmost menu. This happens to always be > File. If the File menu is not leftmost, then it's unclear which should > be highlighted. Highligh

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

On Tue, Aug 18, 2009 at 9:20 PM, Mohamed Mansour wrote: > Would be nice if a user presses just "alt" and it would bring up the > default "main" menu. The page menu is used more than the app menu. Would be > nice to incorporate that into Chromium. What do you all think? > Please copy Windows nati

[chromium-dev] Re: about:extensions?

On Tue, Aug 18, 2009 at 1:32 PM, Robert Dailey wrote: > Hello, I'm asking here and not in the chromium-discuss list because > I'm using the very latest CI build and I am not confident anyone is > going to be able to answer this except for the devs. You should have asked in chromium-discuss. Is

[chromium-dev] Flakiness and you: A set of tasks

A couple weeks ago, I wrote an email emphasizing the need to fix flakiness/crashes/etc. Since you might be having trouble figuring out how to bite off a piece of that problem, here are concrete ways you can help: * 20 people needed to fix failing LayoutTests. src/webkit/tools/layout_tests/test_ex

[chromium-dev] Re: url_request document

On Fri, Aug 14, 2009 at 1:49 PM, Marshall Greenblatt wrote: > Hi All, > > I've been using url_request for a while now, Random drive-by note: Most consumers of URLRequest would be much happier using URLFetcher (which layers atop it to provide a much simpler interface, including abstracting away

[chromium-dev] Re: Plugin control flow and race conditions

Explicitly adding jam to make him notice this. (I don't know the answer to your question. As far as I know we try to avoid implementing things with synchronous messages as much as possible.) PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@g

[chromium-dev] Re: Mac keyboard shortcut

On Sat, Aug 15, 2009 at 7:06 AM, Harrison Powers wrote: > I love keyboard shortcuts and I noticed that the 'command + num > (1,2,3,4)' shortcut for tab selection is missing from the Mac build of > Chromium. Please file bugs at crbug.com for this sort of thing, rather than emailing chromium-dev.

[chromium-dev] Re: Can't edit others' codereviews?

On Sat, Aug 15, 2009 at 11:22 PM, John Abd-El-Malek wrote: > What is the preferred behavior? > I really need the ability to edit others' issues, including closing them. I don't really care up or down on the close button issue, but please restore my ability to edit and close others' changes. PK

[chromium-dev] Can't edit others' codereviews?

I noticed yesterday and today the codereviews I'm looking at sent by other people) no longer give me the option to "Edit". Is this an intentional change? Now I can't assign reviewers when appropriate. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chro

[chromium-dev] Re: Tree hygiene

On Fri, Aug 14, 2009 at 8:00 AM, Marc-Antoine Ruel wrote: > - The reliability test has been red for so long that a bad regression > hasn't been noticed before it was way too late. > > - There was multiple webkit linux regressions that haven't been fixed. > (+ valgrind) > I'm pretty frustrated wit

[chromium-dev] Re: Proposal: per-tab open/save dialogs

On Fri, Aug 14, 2009 at 10:51 AM, Paul Wicks wrote: > Maybe there could also be some visual > indication on tabs as to whether they currently have a save/open > dialog Too fiddly. I like the original idea as long as it doesn't run into problems with blocking script execution within the page.

[chromium-dev] Re: Star of the day

On Thu, Aug 13, 2009 at 3:02 PM, Dimitri Glazkov wrote: > I thought this is something I should mention here: > > This change: http://src.chromium.org/viewvc/chrome?view=rev&revision=23244 > reduced the number of crashes on Mac from 13-15 with high degree of > flakiness to a very consistent 2. > S

[chromium-dev] Re: Chrome "Core Product Principles"

On Thu, Aug 13, 2009 at 11:22 AM, Mike Beltzner wrote: > This is great, Ben. I hope you don't mind if I let this inspire me to > update the Firefox Charter that you wrote back in 2004 with something > similar :) > I wholeheartedly support anything that makes Firefox better! To Ben, nitpicky note

[chromium-dev] problem of flashplayer

today I downloaded a chromium ,by the way , my os is linux of ubuntu 9.04 , it work ok but can't play flash .who can help me --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

On Wed, Aug 12, 2009 at 7:08 AM, Avi Drissman wrote: > On Wed, Aug 12, 2009 at 9:41 AM, Meok wrote: > >> I guess it shouldn't be >> too hard then to pass that info onto the gallery page and keep >> everything online. > > > I think that would be a bad idea even if it weren't too hard. What theme

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

On Tue, Aug 11, 2009 at 4:03 PM, Meok wrote: > Just to add my two cents worth. Even though there is a full resource, > I still see a need for users to be able to keep their favorites easily > accessible. It;s the same philosophy of having a New Tab Page even > though you can pull back your most v

[chromium-dev] Re: Why does Chromium on mac have a theme switch UI in the preferences?

On Mon, Aug 10, 2009 at 10:31 AM, Aaron Boodman wrote: > I think that building this into the gallery makes a lot of sense. And > I realized that by "preview" you all might mean "a picture of what > this looks like", before you click anything. Similar to what is on the > current gallery pages. P

<    1   2   3   4   5   6   >