Re: [chromium-dev] Date of M5 drop?

2010-01-14 Thread Robert Sesek
On Thu, Jan 14, 2010 at 4:21 PM, Peter Kasting wrote: > On Thu, Jan 14, 2010 at 4:48 AM, OwenCM wrote: > >> Hi, I've been scouring the groups and can't find the answer anywhere, >> what time scale are we looking at until the dev branch hits m5? > > > If you're looking for a branch date for versi

[chromium-dev] Red Tree 2010/1/6

2010-01-06 Thread Robert Sesek
Good evening, At 9pm ET, the tree was significantly red and Erik Kay closed the tree: Win browser_tests, Win & Mac perf, Linux views, and Win Webkit all were red. I cleaned up the Win browser_tests, Linux Views, and Win WebKit redness, but the Win & Mac perf regressions are still in play. mpcompet

Re: [chromium-dev] Core Principles: A refresher (especially for newer contributors/team members)

2010-01-06 Thread Robert Sesek
I was actually thinking about these principles today, and I think we need to do a better job of conveying some of them to our users. Frequently I see requests such as "can't you just add an option for X?" in bug reports. The answer is most often "No," but it'd be great if we could point users to so

Re: [chromium-dev] How does make determine which files to compile in chromium

2009-12-30 Thread Robert Sesek
Project files (Make, Visual Studios, and Xcode) are all generated from GYP (Generate Your Projects). These are the .gyp and .gypi files in the source directories. For chrome/browser/, look at chrome/browser/chrome_browser.gypi. rsesek / @chromium.org On Wed, Dec 30, 2009 at 8:55 PM, hap 497 wrot

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

2009-12-26 Thread Robert Sesek
proxy_uitest > make: *** No rule to make target `out/Debug/automation_proxy_uitest'. > Stop. > > > > On Fri, Dec 25, 2009 at 2:15 PM, Robert Sesek wrote: > >> The --gtest_filter switch should do what you want: ./test_binary >> --gtest_filter='TestClass

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

2009-12-25 Thread Robert Sesek
The --gtest_filter switch should do what you want: ./test_binary --gtest_filter='TestClassName.*'. You can replace the ".*" with a specific test case name. The quotes are necessary if your shell expands the asterisk. Find out more with the --help flag. Also, I don't think TabSwitchingUITest is in b

Re: [chromium-dev] Command Line switches persisted in Preferences

2009-12-24 Thread Robert Sesek
This would be nice for Mac users as they cannot create shortcuts with command line options, unlike in Windows. Instead, they have to be passed to the application every time, which means always opening Chromium through Terminal. If this is implemented, though, should we not persist some flags (like

Re: [chromium-dev] Can't build on Snow Leopard anymore

2009-12-06 Thread Robert Sesek
#x27;d > be curious to figure out what value you're getting for ARCHS at line > 58 of that script. > > You should file a bug and assign it to me, and you can put the answer > to this question there. > > Mark > > Robert Sesek wrote: > > I've tried to build on S

[chromium-dev] Can't build on Snow Leopard anymore

2009-12-06 Thread Robert Sesek
I've tried to build on Snow Leopard twice. I've tried both an incremental and a clobber, but both times I get this error: === BUILD AGGREGATE TARGET webkit_system_interface Support OF PROJECT WebCore WITH THE DEFAULT CONFIGURATION (Debug) === Check dependencies PhaseScriptExecution "Action \"Adjus

Re: [chromium-dev] workflow for cross-platform development

2009-11-22 Thread Robert Sesek
On Sat, Nov 21, 2009 at 1:52 PM, Chris Bentzel wrote: > Do you mostly rely on the try-bots, or do you also patch the diffs to your > different dev environments and build and test locally? > > If you do the patching, do you tend to do a gcl upload and grab the diffs > from there, or do you copy th

Re: Uber Page Info Window (Was: Re: [chromium-dev] Re: [DESIGN DOC] registerProtocolHandler HTML5 API)

2009-09-28 Thread Robert Sesek
For reference: http://code.google.com/p/chromium/issues/detail?id=5973 I'd be interested in helping out with this on the Mac side. I filed a Camino bug a couple of years ago about something similar. Safari has a helpful tool in Window --> Activ

[chromium-dev] Make CL summary prefix tags a formal convention?

2009-09-21 Thread Robert Sesek
It seems to be an informal convention amongst some Mac developers to prefix their changes with "[Mac]" in the CL subject line. This is extremely helpful for quickly picking out changes that only affect the single platform, especially if that information is not clear from the CL's description. I was

[chromium-dev] Re: [linux] user feedback one month in

2009-09-21 Thread Robert Sesek
On Sun, Sep 20, 2009 at 10:43 PM, Evan Martin wrote: > - He's bookmarking by pasting urls into "add page" dialog found via > the bookmark manager(!). Maybe he doesn't realize the star is the add > bookmark button? > My response: I'm no UI designer, but I wonder if it'd help to put the > bookmark

[chromium-dev] Re: Git questions

2009-09-18 Thread Robert Sesek
>From IRC, so it's on-list: rsesek: thakis: are you on SL [Snow Leopard]? thakis: rsesek: nope rsesek: thakis: your Xcode problem will likely go away if you upgrade to SL bc Xcode indexing is handled via GCD [Grand Central Dispatch] rather than it's horridness in 10.5.x (that tends to block the UI

[chromium-dev] Re: Git questions

2009-09-18 Thread Robert Sesek
On Fri, Sep 18, 2009 at 11:27 AM, Nico Weber wrote: > 2.) I often have 3-5 feature branches. When one of them is of them is > getting ready to submit, I usually rebase it on ToT before sending it > to the try servers. I do this thusly: > > git checkout trunk > git pull > git checkout myfeat

[chromium-dev] Re: "Clear Strict-Transport-Security state" checkbox added

2009-09-17 Thread Robert Sesek
It clears the list of hosts in StrictTransportSecurityState: // StrictTransportSecurityState // // Tracks which hosts have enabled StrictTransportSecurityState. After a host // enables StrictTransportSecurityState, then we refuse to talk to the host // over HTTP, treat all certificate errors as f

[chromium-dev] Re: Is there any good tool on Linux to browser and cross reference chromium source code?

2009-09-17 Thread Robert Sesek
+1 for an LXR-like tool. Codesearch is decent if you're just trying to find something, but symbols and .h files aren't hyperlinked, which makes it a lot less useful. OpenGrok seems pretty cool, but it requires a Java serverlet container (I'm not sur

[chromium-dev] Re: Mac resources and bundles

2009-08-19 Thread Robert Sesek
On Tue, Aug 18, 2009 at 12:38 PM, Thomas Van Lenten wrote: > Anyone adding more resources (xibs, etc.) to the Mac, please remember > always fetch them from mac_util::MainAppBundle() (base/mac_util.h) and do > *not* use any Cocoa apis that assume [NSBundle mainBundle]. As part of the > l10n, packa

[chromium-dev] Re: Mac History Menu

2009-08-13 Thread Robert Sesek
On Thu, Aug 13, 2009 at 11:08, Julian Harris wrote: > What about Cmd-Opt-H? > Cmd+Opt+H is also bound by the system for Hide Others. 2. Currently, items in the history menu open in the current foreground tab. >> I'm currently working on a CL to make it so that if you hold down the Cmd >> modif

[chromium-dev] Re: Mac History Menu

2009-08-12 Thread Robert Sesek
On Wed, Aug 12, 2009 at 15:33, Scott Violet wrote: > I would suggest you create something like browser/views/event_utils on > the Mac (and Linux) side. Any place you're opening a URL from a user > gesture you map the event to a WindowOpenDisposition. This way the UI > is consistent with regards t

[chromium-dev] Mac History Menu

2009-08-12 Thread Robert Sesek
Two things about the Mac history menu that I'd like people to weigh in on: 1. The "Show All History" command should have a keyboard shortcut. We can't use the logical Cmd+H because it's bound by the system. Stuart suggested Cmd+Y, as that's what Camino uses. Firefox and Safari both lack keyboard sh

[chromium-dev] Re: PSA: irc awareness [Was: Trick question: Who is "responsible" for repairing a red tree?]

2009-08-06 Thread Robert Sesek
Dirk, Adium should automatically do it for your full IRC nick. You can also go into Adium --> Preferences --> Advanced --> Mention to have it watch for other things. Also, you can go into the Events preference and change the "You are mentioned (Group Chat)" notification options. - Robert On Aug

[chromium-dev] Re: chrome always break in debugger when run under XCode

2009-06-07 Thread Robert Sesek
der, the breakpoint turns fatal and terminates the app. I've just commented out the two asm() lines in my tree because I find the breakpoints more annoying than helpful. I think it would be better if DebugUtil's features were enabled with a build or runtime flag, rather than having to res

[chromium-dev] chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting

2009-06-05 Thread Robert Sesek
should work on Linux, for the most part) because it uses `unzip` and `open` commands via os.system (). Patches are welcome to make it more cross-platform. You can clone the git repository it lives in here: http://www.bluestatic.org/git/Toolchain.git - Robert Sesek

[chromium-dev] Re: Mac History Menu Implementation

2009-05-28 Thread Robert Sesek
On Tue, May 26, 2009 at 00:59, Ben Goodger (Google) wrote: > I think we had discussed adding most visited/recently closed items > here, sort of like a NTP without the NTP. > I think this is an interesting idea, particularly the most recently closed items. Are you thinking this is supplemental to

[chromium-dev] Mac History Menu Implementation

2009-05-22 Thread Robert Sesek
I was in IRC today and asked around if anybody had started the History menu on the Mac and Mike Pinkerton said he didn't think anybody had. If that's the case, then I'd like to investigate it (and I'll open an issue that states such). But since there is no corresponding menu in either the Windows