Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Wan-Teh Chang
On Wed, Jan 13, 2010 at 9:42 AM, Evan Martin wrote: > > With that in mind I think we should explicitly use > -fno-strict-aliasing until someone is willing to take the time to run > buildbots, track down regressions, etc. for the other configuration. I tend to agree. Many programmers, including m

[chromium-dev] http://build.chromium.org/buildbot/continuous/LATEST/REVISION has changed

2009-12-14 Thread Wan-Teh Chang
If you're using the safesync URL http://build.chromium.org/buildbot/continuous/LATEST/REVISION in your .gclient file, your "gclient sync" command should be failing now. This is because the URL has been replaced by three platform-specific URLs: http://build.chromium.org/buildbot/continuous/linux/LA

Re: [chromium-dev] Compiler version used for official Windows builds?

2009-11-25 Thread Wan-Teh Chang
On Wed, Nov 25, 2009 at 4:22 AM, Ted Mielczarek wrote: > Hi, > > I couldn't find this info anywhere on the dev site (maybe I just > wasn't looking hard enough), but I'm curious as to what version of > Visual C++ you're using for the official Chrome builds. It's Visual C++ 2005. (The official bui

Re: [chromium-dev] Any interest in command line tools for network stack?

2009-11-13 Thread Wan-Teh Chang
On Fri, Nov 13, 2009 at 11:58 AM, Chris Bentzel wrote: > I'm using them as a learning exercise for the network stack - and I'm > guessing that they will help debug behavior in the future as well. > > I don't intend to add additional functionality over the standard tools > - in fact, I promise you

[chromium-dev] Re: url request failing on unix with os_error = -7

2009-10-01 Thread Wan-Teh Chang
On Thu, Oct 1, 2009 at 5:44 PM, Tim Steele wrote: > I think those are defined in net_error_list.h and that means timed out? Yes, -7 means net::ERR_TIMED_OUT. Wan-Teh --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View arch

[chromium-dev] Re: RWX sections in the binary

2009-09-01 Thread Wan-Teh Chang
On Tue, Sep 1, 2009 at 4:09 PM, Adam Langley wrote: > > I've noticed some WX sections in memory, but only on modern Ubuntus. I > meant to track down the issue today, but I've been hung up on a stack > corruption bug. > > However, the binary doesn't contain any such sections for me. See > objdump -

[chromium-dev] Re: FreeBSD port, take 2

2009-08-27 Thread Wan-Teh Chang
On Thu, Aug 27, 2009 at 3:02 AM, Ben Laurie wrote: > > I forgot to mention - there's a single file that may not be complete, > base/crypto/signature_verifier_nss.cc - this is because the FreeBSD > port of NSS is too old and doesn't have a function it needs. I'll get > to that at some point soon, b

[chromium-dev] Re: linux dev channel crashing on first login to gmail today?

2009-08-19 Thread Wan-Teh Chang
On Wed, Aug 19, 2009 at 12:20 PM, Evan Martin wrote: > > I got a crash on an SSL site today. > It was http://code.google.com/p/chromium/issues/detail?id=18907 Fumitoshi Ukai just fixed that crash in r23696 last night. Wan-Teh --~--~-~--~~~---~--~~ Chromium Develo

[chromium-dev] Re: url_request document

2009-08-18 Thread Wan-Teh Chang
On Fri, Aug 14, 2009 at 1:49 PM, Marshall Greenblatt wrote: > Hi All, > > I've been using url_request for a while now, and I find myself consistently > forgetting the relationship between the various managers/handlers and order > in which the asynchronous calls take place.  Does anyone currently h

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

2009-08-03 Thread Wan-Teh Chang
On Sat, Aug 1, 2009 at 2:54 PM, Dan Kegel wrote: > > http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1671/steps/valgrind%20test:%20unit/logs/stdio > introduces 26 new unintialized memory references and two leaks. > That's a big enough batch that it might

[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux

2009-07-30 Thread Wan-Teh Chang
On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares wrote: > > >  Hi, > >  I'm running Debian, with GCC 4.3.3 and am current getting a > compilation error while compiling Chromium: > > cc1plus: warnings being treated as errors > chromium/src/net/base/net_util.cc: In function > 'bool::IsIDNComponentSafe(

[chromium-dev] Re: Compiler warnings?

2009-07-23 Thread Wan-Teh Chang
Ben, I believe the GCC warning you want is -Wreturn-type, which is enabled if we specify -Wall: http://gcc.gnu.org/onlinedocs/gcc-4.3.3/gcc/Warning-Options.html#Warning-Options Are we not compiling with -Wall? Wan-Teh --~--~-~--~~~---~--~~ Chromium Developers ma

[chromium-dev] Re: bug flag for flakiness-related bugs

2009-07-16 Thread Wan-Teh Chang
Thanks for creating the FlakyTest label. One question: if a test *always* fails under a particular configuration, for example, on a particular platform or when running under Purify, it isn't a flaky test, right? I assume "flaky" means intermittent failure. Wan-Teh --~--~-~--~~-

[chromium-dev] Re: HTTP POST via net package?

2009-06-08 Thread Wan-Teh Chang
On Mon, Jun 8, 2009 at 2:02 PM, Daniel Cowx wrote: > > How can I upload multipart form data (including a file) via HTTP POST? > Is there something already written in the net package (or elsewhere) > for this task? If so, can someone please point me to what class to > use. You can use the URLReque

[chromium-dev] Re: Where is the code which chromium display the loading status

2009-06-01 Thread Wan-Teh Chang
On Mon, Jun 1, 2009 at 9:12 AM, Mike Pinkerton wrote: > > src/chrome/browser/cocoa/status_bubble_mac.mm is the UI that displays > the message. The message itself comes from the cross-platform code, > but you can probably trace that by setting some breakpoints in the UI > code. Yes, also set a br

[chromium-dev] Re: UI_test.exe fails to complete (please help)

2009-05-26 Thread Wan-Teh Chang
On Mon, May 25, 2009 at 7:18 PM, nakro wrote: > > but still this is what i get : (in hebrew it gets stuck, so this is an > improvement) > > [  FAILED  ] UnloadTest.BrowserCloseTabWhenOtherTabHasListener > [  FAILED  ] LoginPromptTest.TestBasicAuth > [  FAILED  ] LoginPromptTest.TestDigestAuth > [

[chromium-dev] Re: cryptoht.h not found

2009-05-18 Thread Wan-Teh Chang
On Sat, May 16, 2009 at 12:13 AM, Mohamed Mansour wrote: > Weird, > > I just received this error while compiling a "fresh" build on linux. > Downloaded the tarball, and hammer (clean). The first error I saw on the > screen was: > cd: 1: can't cd to > /auto/filer28.mtvvolmtvhome51/chrome-svn/tarba

[chromium-dev] Re: Unexpected PDB error; ACCESS_DENIED (15) while building browser_tests_launcher

2009-05-08 Thread Wan-Teh Chang
On Fri, May 8, 2009 at 11:06 AM, Marc-Antoine Ruel wrote: > /MP ? If so, that's normal. Make sure you also kill mspdbsrv.exe. No, I didn't add /MP to essential.vsprops because I know it doesn't work well with Visual Studio 2005. I did a web search for the linker error message LINK : fatal

[chromium-dev] Unexpected PDB error; ACCESS_DENIED (15) while building browser_tests_launcher

2009-05-08 Thread Wan-Teh Chang
I am using Visual Studio 2005 SP1 with hotfix 935225 on Windows XP SP3. I checked out a chromium source tree from scrash, using http://build.chromium.org/buildbot/continuous/LATEST/REVISION as the safesync_url, and did a Release build. I got the following link error while building browser_tests_

[chromium-dev] Re: Fwd: Friend who works on Chrome

2009-05-06 Thread Wan-Teh Chang
On Wed, May 6, 2009 at 1:26 PM, Nick Baum wrote: > -- Forwarded message -- > > Kirill - thanks for the intro. > > Nick - I just wanted to follow up on that strange issue with Chrome I > mentioned when we last talked. When I load Chrome, the favorites boxes load > instantly, though

[chromium-dev] Re: BUG= formatting

2009-04-30 Thread Wan-Teh Chang
On Thu, Apr 30, 2009 at 1:50 PM, Ben Goodger (Google) wrote: > > Hint: > > If you write your changelist bug line like this: > > http://crbug.com/7991 > > instead of like this: > > BUG=7991 > > your bug line will be linkified and clickable in numerous places (like > the buildbot pages, Rietveld, t

[chromium-dev] Re: GSoC: Network Stack in Chromium

2009-04-23 Thread Wan-Teh Chang
On Wed, Apr 22, 2009 at 7:20 PM, Smita wrote: > > Hello, > > I am not sure if this is the correct forum to put in this question, > but I was just curious to know where my application lacked, and why it > did not qualify. > Your feedback is greatly appreciated! Hi Smita, Our product manager Bria

[chromium-dev] Re: Need help with URL processing

2009-04-20 Thread Wan-Teh Chang
You can look at url_request.{h,cc}, which is in the net module. You can also look at the next layer up, which has two sets of files: 1. resource_dispatcher_host.{h,cc}: I think this is exactly what you wanted, but it doesn't cover the network traffic generated by the next set of files. 2. url_fet

[chromium-dev] Re: GSoC: Providing Client Certificate using PKCS#11

2009-03-24 Thread Wan-Teh Chang
On Tue, Mar 24, 2009 at 3:21 PM, Smita wrote: > > Hello, > > I am putting forth the problem of client authentication handling in > Chrome, as I understand it. Kindly correct me if this isn't correct. > > I understand that SSL handshake fails when a server asks for the > client certificate. Curren

[chromium-dev] Network stack roadmap

2009-03-16 Thread Wan-Teh Chang
Chromium's network stack has been undergoing a rewrite to make it more portable. The new HTTP stack is now being used in the 2.0 Dev channel releases. I put together a network stack roadmap document to describe the remaining work in the rewrite and the future work we're considering: http://dev.c

[chromium-dev] Re: NSS and NSPR

2009-02-27 Thread Wan-Teh Chang
On Fri, Feb 27, 2009 at 5:38 PM, Mark Mentovai wrote: > Wan-Teh Chang wrote: >> Another idea is to work harder with Ubuntu to provide the "ia32" >> NSPR/NSS libs for x86_64 in Ubuntu 8.04 LTS.  That'd be the best >> solution but require a lot of red tape. &g

[chromium-dev] Re: NSS and NSPR

2009-02-26 Thread Wan-Teh Chang
On Thu, Feb 26, 2009 at 9:48 AM, Dean McNamee wrote: > > I don't understand why we need to import all of this code just so we > can build an .so. > > Why don't we just take the .so's from the 32-bit package we're already > using, and stick them into our .deb?  We can check them into svn if > don'

[chromium-dev] Re: Reviewing commit messages

2009-02-03 Thread Wan-Teh Chang
Dean, I agree with all your suggestions. Re: typos/spelling errors: I recently started to fix typos/spelling errors in the description of a CL I'm reviewing by clicking "Edit Issue". (Rietveld allows a reviewer to edit the description of a CL.) Wan-Teh --~--~-~--~~~

[chromium-dev] Re: Windows SDK requirement change : v6.1 is required

2009-01-07 Thread Wan-Teh Chang
On Wed, Jan 7, 2009 at 2:12 PM, Jungshik Shin (신정식, 申政湜) wrote: > Therefore, the > only thing necessary to do is to download Windows SDK 6.1 > at > http://www.microsoft.com/downloads/details.aspx?FamilyID=e6e1c3df-a74f-4207-8586-711ebe331cdc&DisplayLang=en > and install it (and integrate it with

[chromium-dev] Re: HTTP BASIC/DIGEST BUG - Has it been fixed yet?

2009-01-05 Thread Wan-Teh Chang
hromium will only send a HTTP Authorization header after receiving a 401 Authorization Required response to the first attempt of the request. Wan-Teh Chang --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, chan

[chromium-dev] Re: using scoped_refptr in standard library containers

2008-11-25 Thread Wan-Teh Chang
On Tue, Nov 25, 2008 at 6:43 AM, Marshall Greenblatt <[EMAIL PROTECTED]> wrote: > > It appears that scoped_refptr meets the CopyConstructible requirement but > not the Assignable requirement. Are you sure scoped_refptr is not assignable? It should be. We have used scoped_refptr in standard libr

[chromium-dev] Re: Fwd: [chromium-dev] Re: OS X IPC Design doc

2008-11-07 Thread Wan-Teh Chang
On Thu, Nov 6, 2008 at 2:05 PM, Amanda Walker <[EMAIL PROTECTED]> wrote: > > Linux and Darwin are only superficially similar, and the differences get > larger the closer to the kernel we get. I realize I'm being repetitious > here :-), but generally speaking, starting with the assumption that one

[chromium-dev] Re: Creating thread using _beginthreadex

2008-11-06 Thread Wan-Teh Chang
On Thu, Nov 6, 2008 at 12:33 AM, Ibrar Ahmed <[EMAIL PROTECTED]> wrote: > > Hi, > > I am currently working on (Issue 4152: Porting directory_lister to > POSIX.). While looking at the code a question bumped into my mind that > why we are creating thread using > > unsigned thread_id; > t

[chromium-dev] Re: OS X IPC Design doc

2008-11-05 Thread Wan-Teh Chang
On Wed, Nov 5, 2008 at 5:26 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > Sorry to be so persistent, but I don't understand why you need those things. > Can you provide some specific examples? > As far as I know, we need the ability to have shared memory. It seems like > we can do that with mmap

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-19 Thread Wan-Teh Chang
On Thu, Sep 18, 2008 at 2:55 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > I bet you five bucks we can layer SSLClientSocket on top of > TCPClientSocket by creating a little nspr i/o layer that > talks to a memory buffer. I did this with OpenSSL some time > ago, I figure I can do it with nss, too.

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-19 Thread Wan-Teh Chang
On Thu, Sep 18, 2008 at 11:46 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > > I think it will be very valuable to us to maintain our own layering > here. It sounds like Dan and you have an idea of how to do it. > > Perhaps in parallel--or when time permits--we should work to add the > APIs to NSS

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-18 Thread Wan-Teh Chang
On Thu, Sep 18, 2008 at 3:34 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > On Thu, Sep 18, 2008 at 3:26 PM, Wan-Teh Chang <[EMAIL PROTECTED]> wrote: >> I found that I documented the 'poll' method of PRFileDesc >> http://developer.mozilla.org/en/NSPR_Poll_Met

[chromium-dev] Re: Will Chrome use OCSP?

2008-09-18 Thread Wan-Teh Chang
On Thu, Sep 18, 2008 at 3:04 PM, Rick Andrews <[EMAIL PROTECTED]> wrote: > > Chrome appears to use CRLs for SSL cert status checking. Are there any > plans to use OCSP instead, or primarily use OCSP with a fallback to > CRLs? We should primarily use OCSP with a fallback to CRLs. If we aren't doi

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-18 Thread Wan-Teh Chang
On Thu, Sep 18, 2008 at 2:55 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > I bet you five bucks we can layer SSLClientSocket on top of > TCPClientSocket by creating a little nspr i/o layer that > talks to a memory buffer. I did this with OpenSSL some time > ago, I figure I can do it with nss, too.

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-18 Thread Wan-Teh Chang
On Wed, Sep 17, 2008 at 3:12 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > >> In previous discussion with Darin, it seemed we >> wanted to use epoll rather than poll. This >> implies that we want to not use NSPR for our >> network I/O, and thus implies that we want to >> write an NSPR I/O layer

[chromium-dev] Re: Unit tests for x509_certificate

2008-09-18 Thread Wan-Teh Chang
On Thu, Sep 18, 2008 at 11:32 AM, Avi Drissman <[EMAIL PROTECTED]> wrote: > I'm going to land some preliminary work on the x509 support for the Mac (see > http://codereview.chromium.org/2963). I want to do some refactoring of the > common parts, but there are no unit tests. Amanda and I are going

[chromium-dev] Re: SSLClientSocket, TCPClientSocket design choices on linux

2008-09-16 Thread Wan-Teh Chang
I agree that we should use nonblocking I/O instead of one-thread-per-connection. On Tue, Sep 16, 2008 at 9:42 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > There's another design choice to make: > whether to write an NSPR I/O layer so we can use > our own TCPClientSocket for all network I/O, > or

[chromium-dev] Re: Extended Validation SSL Certificates

2008-09-11 Thread Wan-Teh Chang
On Thu, Sep 11, 2008 at 5:14 AM, Rob Stradling <[EMAIL PROTECTED]> wrote: > > If you do remove Chrome's own list of EV Policy OIDs and use the > Windows list instead... > What will the Linux and Mac versions do, given that Mozilla's list of > EV Policy OIDs is in PSM, not NSS ? You are right. We

[chromium-dev] Re: "ssl_client_socket" Windows Security API Vs NSS

2008-09-10 Thread Wan-Teh Chang
On Wed, Sep 10, 2008 at 2:53 AM, Ibrar Ahmed <[EMAIL PROTECTED]> wrote: > Hi, > > I am currently working on porting "ssl_client_socket" to Linux. The current > implementation of "ssl_client_socket" uses Windows Security API. I wonder > why we have not used NSS library to implement SSL socket in Wi

[chromium-dev] Re: Extended Validation SSL Certificates

2008-09-10 Thread Wan-Teh Chang
Hi Rob, Ian has answered all of your questions. I'll just add a supplemental answer to question 3. On Wed, Sep 10, 2008 at 4:48 AM, Rob Stradling <[EMAIL PROTECTED]> wrote: > > 3. Chrome on Windows appears to rely on the certificates found in the > Microsoft Trusted Root Certificate Store, but