[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-30 Thread Evan Stade
> From your screenshots, I agree the Windows one is off-centered but the > Linux one feels unbalanced to me in its padding.  (The spacing between > the lines of text is larger than the spacing around them; the button Y > padding is larger than the button X padding.) yea, that's why I hope someone

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-30 Thread Evan Martin
On Fri, May 29, 2009 at 7:45 PM, Evan Stade wrote: > Is anyone planning to do a UI review of linux and/or mac? We've had one in the past but it was more high level. My understanding was that more would follow in the future. > We copy > windows where we can (for padding and hard-coded sizes and

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Peter Kasting
On Fri, May 29, 2009 at 10:40 PM, Mark Larson (Google) wrote: > ...these issues are filed as bugs so we can fix them, right? I think maybe some of them are. I file enough bugs that you can cut me slack when I don't :). After all someone else has to notice the little things and be bugged by the

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Mark Larson (Google)
...these issues are filed as bugs so we can fix them, right? On Fri, May 29, 2009 at 22:23, Peter Kasting wrote: > On Fri, May 29, 2009 at 7:45 PM, Evan Stade wrote: > >> I'll also take this opportunity to complain that the dangerous >> downloads dialog warning icon is way off center on windows

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Peter Kasting
On Fri, May 29, 2009 at 7:45 PM, Evan Stade wrote: > I'll also take this opportunity to complain that the dangerous > downloads dialog warning icon is way off center on windows. (see > attachment. for comparison purposes, I've also attached linux ;) > The entire download bar UI has serious align

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-29 Thread Evan Stade
Is anyone planning to do a UI review of linux and/or mac? We copy windows where we can (for padding and hard-coded sizes and whatnot), but there are tons of places where that's not possible. Also, padding numbers don't really translate 1 for 1 all the time. I've been choosing numbers based on my o

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-27 Thread Ben Goodger (Google)
I want to stress this point. It's always best to discuss any change in Chrome code with others before you invest a lot of time on it. You will doubtless get helpful feedback and there's a high likelihood you'll save a lot of time. -Ben On Wed, May 27, 2009 at 2:23 PM, Glen Murphy wrote: > > It

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-27 Thread Glen Murphy
It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers). On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansour wrote: > So do we send a CL to all of you guys or

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-27 Thread Mohamed Mansour
So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) wrote: > > Also FYI, > > If you're just porting existing UI to a different platform, no need to > discuss with us. Same thing if it's a plat

[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk

2009-05-27 Thread Ben Goodger (Google)
Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any