[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-10-29 Thread Dirk Pranke
That might explain some weirdness I've seen with that theme. I'll take a look at it tomorrow ... thanks! -- Dirk On Thu, Oct 29, 2009 at 8:46 PM, TAMURA, Kent wrote: > Hi Dirk, > I found a problem of the generic theme. > Some of controls in the generic theme are drawn in sizes larger than > spe

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-10-29 Thread TAMURA, Kent
Hi Dirk, I found a problem of the generic theme. Some of controls in the generic theme are drawn in sizes larger than specified sizes. For example, if you command to draw kDownArrow_Type at (0, 0) in 10x10 size, the generic theme updates (0,0) - (10,10), of which size is 11x11. LayoutTests/fast/o

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-09-15 Thread Dirk Pranke
Hi Hironori, That's not a stupid question at all. I haven't actually tried using XP mode, or Win 7 at all yet. I will be installing Win 7 as soon as I can get my hands on a copy, and then we should get some Win 7 baselines. Once we have those, and can get some Win 7 build bots configured, then yo

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-09-15 Thread 坊野 博典
Hi Dirk, Thank you so much for your great work! By the way, I have been using XP Mode of Windows 7 (*1) to run layout tests since I changed my development PC to Windows 7. (It's not so fast, but it's OK.) Does this "Win7 baselines" mean we don't need to use XP Mode? (I assume yes.) (*1) http://w

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-09-15 Thread Ojan Vafai
On Tue, Sep 15, 2009 at 2:24 PM, Dirk Pranke wrote: > Well, practically, there's very little difference between XP and Vista > (about 10 baselines). I see. Looking at your rebaseline checkin, it looks like it's entirely complex font tests as well. I think given that, it will be very rare that w

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-09-15 Thread Dirk Pranke
On Tue, Sep 15, 2009 at 2:15 PM, Ojan Vafai wrote: > On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke wrote: >> >> I have just landed a patch that enables us to run layout tests on >> Vista as well as XP. > > Thanks for doing this! Needing to run the tests on a 32bit XP machine sucks. > I don't thin

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-09-15 Thread Ojan Vafai
On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke wrote: > I have just landed a patch that enables us to run layout tests on > Vista as well as XP. > Thanks for doing this! Needing to run the tests on a 32bit XP machine sucks. I don't think we can call running the tests on Vista supported until the

[chromium-dev] Re: Layout tests can now be run on both XP and Vista

2009-09-15 Thread Brett Wilson
On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke wrote: > > Hi all, > > I have just landed a patch that enables us to run layout tests on > Vista as well as XP. > > In theory, you should continue to use the tools just as you have in > the past, and everything will work transparently. In practice, I m