[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Thomas Van Lenten
One thing the mozilla waterfall has (or did have at one time) is the ability to add comments to any build column/step. I've seen it used so someone can hang a quick comment of "reverting " or "### pushed with fix". That way right next to a specific problem you can have any extra info, and unl

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Amanda Walker
Very much agreed. If anything is red, and it's not immediately clear that someone's on it, close the tree. The burden should be on whoever is explaining why the tree is open but red, not why it's closed, especially for the sheriff. --Amanda On Wednesday, August 5, 2009, Peter Kasting wrote: >

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Tim Steele
On Wed, Aug 5, 2009 at 2:49 PM, Peter Kasting wrote: > On Wed, Aug 5, 2009 at 2:45 PM, Tim Steele wrote: > >> A constant place to go looking for this would make it easier, at least in >> my opinion. Like right now I don't know what's up with Chromium Mac >> (valgrind) or Webkit dbg (1&2) to nam

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Dan Kegel
On Wed, Aug 5, 2009 at 2:49 PM, Peter Kasting wrote: >> Like right now I don't know what's up with Chromium Mac >> (valgrind) or Webkit dbg (1&2) to name a few; they're red but the tree is >> open. > > If you ever see a case like this, go ahead and close the tree yourself until > you get an explan

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Peter Kasting
On Wed, Aug 5, 2009 at 2:45 PM, Tim Steele wrote: > A constant place to go looking for this would make it easier, at least in > my opinion. Like right now I don't know what's up with Chromium Mac > (valgrind) or Webkit dbg (1&2) to name a few; they're red but the tree is > open. If you ever se

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Dan Kegel
On Wed, Aug 5, 2009 at 2:45 PM, Tim Steele wrote: > you have to keep asking, unless you're always on IRC and can cleverly search > the window contents.  A constant place to go looking for this would make it > easier, at least in my opinion.  Like right now I don't know what's up with > Chromium Ma

[chromium-dev] Re: Trick question: Who is "responsible" for repairing a red tree?

2009-08-05 Thread Tim Steele
I agree.. reading this as someone slated for duty tomorrow got me thinking about one pseudo-related question / point. I know lots of time people cram stuff into the tree status to explain who is working on which red bit, and what tests are flaky today and we (sheriffs or someone watching the tree)