[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Mark Larson (Google)
On Thu, Apr 2, 2009 at 09:10, Steven Knight wrote: > Excellent idea re: qual script. What I'd like to do is turn these items > into sanity-check tests for a buildbot slave that specifically tests and > times issues about the build itself: build time stats, size of dependency > > graphs, verify

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Steven Knight
Hi Craig-- Just committed the CL to fix this. Let me know if your mileage varies. --SK On Thu, Apr 2, 2009 at 8:52 AM, Craig Schlenter wrote: > On Thu, Apr 2, 2009 at 5:43 PM, Mark Mentovai wrote: > > Craig Schlenter wrote: > >> When I add -Wl,--start-group and -Wl,--end-group to that (manual

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Steven Knight
Excellent idea re: qual script. What I'd like to do is turn these items into sanity-check tests for a buildbot slave that specifically tests and times issues about the build itself: build time stats, size of dependency graphs, verify presence of symbols in Debug, etc. Hopefully it'll be a while

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Craig Schlenter
On Thu, Apr 2, 2009 at 5:43 PM, Mark Mentovai wrote: > Craig Schlenter wrote: >> When I add -Wl,--start-group and -Wl,--end-group to that (manually >> since haven't figured out how to make gyp do it), then the missing >> symbol problem goes away (at least when loading chrome and navigating >> to

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Mark Mentovai
Craig Schlenter wrote: > When I add -Wl,--start-group and -Wl,--end-group to that (manually > since haven't figured out how to make gyp do it), then the missing > symbol problem goes away (at least when loading chrome and navigating > to mail.google which is where I was seeing the problem). I don

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Craig Schlenter
On Thu, Apr 2, 2009 at 4:47 PM, Craig Schlenter wrote: > Just a wild guess but I think it's missing the circular linker magic > start/end stuff when compiling the plugin. Will try to confirm when I'm near > a pc again ... Confirmed. Here's the line it's using to generate the plugin on my machine

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread John Grabowski
Dean, sounds like you have the seeds of a qual script. Perhaps you could itemize them into a form which sgk can use as a proof test before the next switch-over (assuming this gets reverted)? jrg On Thu, Apr 2, 2009 at 6:48 AM, Dean McNamee wrote: > > I confirmed the debug build line has no -g.

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Craig Schlenter
Just a wild guess but I think it's missing the circular linker magic start/end stuff when compiling the plugin. Will try to confirm when I'm near a pc again ... --Craig On 02 Apr 2009, at 15:48, Dean McNamee wrote: > > I confirmed the debug build line has no -g. > > Also, all of the buildb

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dean McNamee
I confirmed the debug build line has no -g. Also, all of the buildbots are red because of ICU issues: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)/builds/6601/steps/test_shell_tests/logs/MimeTypeTests On Thu, Apr 2, 2009 at 3:46 PM, Dan Kegel wrote: > And it se

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dan Kegel
And it seems to be built without debugging flags in debug mode. At least, I can't single-step through code on Linux. On Thu, Apr 2, 2009 at 4:18 AM, Dean McNamee wrote: > (this isn't just V8, all of chromium is built without optimization in > release).  There are lots of other issues all over th

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dean McNamee
(this isn't just V8, all of chromium is built without optimization in release). There are lots of other issues all over the place. On Thu, Apr 2, 2009 at 1:14 PM, Dean McNamee wrote: > Notice the lack of -O2, etc.  This also broke SYMBOLS= PROFILE=, COVERAGE=, > etc. > > I am tempted to revert

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dean McNamee
Notice the lack of -O2, etc. This also broke SYMBOLS= PROFILE=, COVERAGE=, etc. I am tempted to revert it all. de...@trex:build$ hammer -j6 --mode=Release SYMBOLS=1 --verbose v8_shell scons: Reading SConscript files ... scons: done reading SConscript files. scons: Building targets ... g++ -o /

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dean McNamee
-lX11 -lXrender -lXext (at least) was dropped in the switch to gyp. I tried to understand how gyp worked or where these were coming from, but no luck. On Thu, Apr 2, 2009 at 12:35 PM, Dean McNamee wrote: > I can't actually get it to build (trying Release for now), I am > getting linker errors f

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dean McNamee
I can't actually get it to build (trying Release for now), I am getting linker errors for X calls, we are probably not linking correctly. I will debug it :\ On Thu, Apr 2, 2009 at 12:11 PM, Dean McNamee wrote: > Word on the street is that the ccflags are all wrong, and that release > builds are

[chromium-dev] Re: gyp build on Linux

2009-04-02 Thread Dean McNamee
Word on the street is that the ccflags are all wrong, and that release builds aren't being built release properly. On Thu, Apr 2, 2009 at 7:23 AM, Mark Mentovai wrote: > > Awesome.  This is seriously good news.  Thanks! > > Mark > > Steven Knight wrote: >> Linux builds have been converted to gyp

[chromium-dev] Re: gyp build on Linux

2009-04-01 Thread Mark Mentovai
Awesome. This is seriously good news. Thanks! Mark Steven Knight wrote: > Linux builds have been converted to gyp-generated SCons files. > > I'm in the process of updating the wiki pages to reflect the change.  Here's > the executive summary of the most important points (or the ones I can > re

[chromium-dev] Re: gyp build on Linux

2009-04-01 Thread Bradley Nelson
Congrats! Excellent work. -bradn On Apr 1, 2009 5:17 PM, "Mohamed Mansour" wrote: Great work! thanks so much for making gyp for linux! On Wed, Apr 1, 2009 at 7:32 PM, Steven Knight wrote: > > Linux builds have bee... --~--~-~--~~~---~--~~ Chromium Developers ma

[chromium-dev] Re: gyp build on Linux

2009-04-01 Thread Mohamed Mansour
Great work! thanks so much for making gyp for linux! On Wed, Apr 1, 2009 at 7:32 PM, Steven Knight wrote: > Linux builds have been converted to gyp-generated SCons files. > > I'm in the process of updating the wiki pages to reflect the change. > Here's > the executive summary of the most import