[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Tim Steele
Yaaay! Setting LF on the file from a separate checkout and committing, then updating the other checkout seems to have fixed the problem! Thank you! On Wed, Oct 14, 2009 at 10:07 AM, Marc-Antoine Ruel wrote: > I banned using "svn revert". It's totally broken. > Use "rm && svn up --revision BASE"

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Tim Steele
The snips were two different files 'cause the actual output was about two different files :) The presubmit check doesn't complain about line endings with spaces for merge_and_sync.html So from cpu's original email in this thread (I just searched my mail for the error), I thought it had to do with

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Marc-Antoine Ruel
I banned using "svn revert". It's totally broken. Use "rm && svn up --revision BASE" instead. "svn cat chrome/browser/sync/resources/merge_and_sync.html" throws an error here so the file is broken in the repository so you need to fix that first. M-A On Wed, Oct 14, 2009 at 1:04 PM, Tim Steele

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Thomas Van Lenten
Not really sure since the snips you list are two different files, but the warning is not about eol-style, it's about lines ending with spaces, looks on the lines listed for things like: [space][space][real_code][space][space][LF] [space][space][LF] And take the spaces at the *end* of those lin

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-10-14 Thread Tim Steele
I'm getting such an error message for 'chrome/browser/sync/resources/merge_and_sync.html' come up after the presubmit checks have run (output shows ** Presubmit Warnings ** Found line ending with white spaces in ... chrome\browser\sync\resources\gaia_login.html, line 353 P

[chromium-dev] Re: if you get gcl error ['svn', 'cat', ]

2009-06-10 Thread Marc-Antoine Ruel
No, Marc-Antoine will enable a presubmit check today (tentative) so it won't happen anymore. And if you are a git user, ya better not break anything. M-A On Wed, Jun 10, 2009 at 12:32 PM, cpu wrote: > > I spent a ton of time tracking this so for the record: > > If you made a change to some files