Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-10 Thread Brett Wilson
On Mon, Dec 7, 2009 at 1:43 PM, Bradley Nelson bradnel...@google.com wrote: Hello All, Last week I re-landed a change to split off parts of chrome.gyp into .gypi's in the same directory. I had done something similar a couple weeks back, but took it out because concern was raised about merge

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-10 Thread oshima
I have similar concern about our build, in a way we handle different configurations. There are several ways to specify a set of files for different configurations, such as suffic (_gtk/_mac), source!, exclude/include, concat file lists, and I'm worrying that it's getting out of control. I'm

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-10 Thread Evan Martin
On Thu, Dec 10, 2009 at 1:02 PM, oshima osh...@chromium.org wrote: I have similar concern about our build, in a way we handle different configurations. There are several ways to specify a set of files for different configurations, such as suffic (_gtk/_mac), source!, exclude/include, concat

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
I had talked about this with mmentovai and some others. Concern was raised about the complexity this would introduce into gyp. I do have a gut feeling we'll eventually go there. What Greg is currently doing at least works with gyp as it now stands, but it isn't pretty. Mark, does what's happened

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Mark Mentovai
I think that the stripped-down NaCl-specific 64-bit targets are the right thing to have happened to base, at least for now. Mark Brad Nelson wrote: I had talked about this with mmentovai and some others. Concern was raised about the complexity this would introduce into gyp. I do have a gut

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
You mean as 'base' currently is, or duplicating the file lists? -BradN On Tue, Dec 8, 2009 at 11:19 AM, Mark Mentovai m...@chromium.org wrote: I think that the stripped-down NaCl-specific 64-bit targets are the right thing to have happened to base, at least for now. Mark Brad Nelson

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Mark Mentovai
Bradley Nelson wrote: You mean as 'base' currently is, or duplicating the file lists? I mean I have no problem with base_nacl_win64 existing as a target, and with adding files that are needed in that target to that target. Mark -- Chromium Developers mailing list:

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
Even if those files are largely a duplicate of those in base? -BradN On Tue, Dec 8, 2009 at 11:22 AM, Mark Mentovai m...@chromium.org wrote: Bradley Nelson wrote: You mean as 'base' currently is, or duplicating the file lists? I mean I have no problem with base_nacl_win64 existing as a

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Mark Mentovai
Bradley Nelson wrote: Even if those files are largely a duplicate of those in base? If it gets to that point, we can maintain the sources list, or the shared sources list, in a variable. Then we could do explicit additions to the targets that need it, or explicit excludes if that winds up

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
Greg, will this work for you? -BradN On Tue, Dec 8, 2009 at 11:28 AM, Mark Mentovai m...@chromium.org wrote: Bradley Nelson wrote: Even if those files are largely a duplicate of those in base? If it gets to that point, we can maintain the sources list, or the shared sources list, in a