Re: bug in java.util.Map

2004-01-21 Thread Matthias Pfisterer
David Holmes wrote: I found a minor bug in java.util.Map: the inner class Entry has to be public. Diff is attached. All interface members are implicitly public. The preferred style is to not explicitly define them as public. Well, I prefer to be explicit. But this goes beyond a matter of taste.

Proposed patch: gnu.java.net.protocol.file.Handler

2004-01-21 Thread Jeroen Frijters
Hi, Attached is a proposed patch to fix relative file urls (file:foodir). I would appreciate it, if someone could review it. Thanks. Regards, Jeroen Handler.diff Description: Handler.diff ___ Classpath mailing list [EMAIL PROTECTED]

Re: Proposed patch: gnu.java.net.protocol.file.Handler

2004-01-21 Thread Michael Koch
On Wed, Jan 21, 2004 at 11:23:25AM +0100, Jeroen Frijters wrote: Hi, Attached is a proposed patch to fix relative file urls (file:foodir). I would appreciate it, if someone could review it. Do you have special testcase for this ? Michael^

RE: Proposed patch: gnu.java.net.protocol.file.Handler

2004-01-21 Thread Jeroen Frijters
Michael Koch wrote: On Wed, Jan 21, 2004 at 11:23:25AM +0100, Jeroen Frijters wrote: Hi, Attached is a proposed patch to fix relative file urls (file:foodir). I would appreciate it, if someone could review it. Do you have special testcase for this ? The following code failed

Small patch for java/text/AttributedString.java

2004-01-21 Thread Dalibor Topic
Hi all, the attached patch fixes a small problem in AttributedString that prevented FOP from working with it on kaffe. OK to check in? 2004-01-21 Dalibor Topic [EMAIL PROTECTED] * libraries/javalib/java/text/AttributedString.java

Re: Small patch for java/text/AttributedString.java

2004-01-21 Thread Michael Koch
On Wed, Jan 21, 2004 at 02:14:01PM +0100, Dalibor Topic wrote: Hi all, the attached patch fixes a small problem in AttributedString that prevented FOP from working with it on kaffe. OK to check in? Some questions: Does a mauve testcase exist for this ? Wouldnt it be good to get rid of

Re: Small fix for the copyright notice in java/text/DateFormatSymbols.java

2004-01-21 Thread Michael Koch
On Wed, Jan 21, 2004 at 02:18:33PM +0100, Dalibor Topic wrote: Hi all, I'm flushing my patch queue, before I resync with GNU Classpath again, so I found this small patch. OK to check in? I think, thats obvious and needs no special okay. Michael

Re: bug in java.util.Map

2004-01-21 Thread Tom Tromey
Matthias == Matthias Pfisterer [EMAIL PROTECTED] writes: Matthias Building with kjc, I get the following errors: Matthias ../java/beans/PropertyChangeSupport.java:1: error:Unaccessible class Matthias java/util/Map/Entry can not be imported [JLS 7.5.1] If it isn't fixable in the compiler we can

enum variables (patch)

2004-01-21 Thread Matthias Pfisterer
Hi, in Java 1.5, enum is a keyword. Therefore it can no longer be used for variable names. I've made a patch that changes all variables enum. Matthias -- Matthias Pfisterer mailto:[EMAIL PROTECTED] Reuchlinstrasse 28 phone ++49-711-62 87 12 D-70176 Stuttgart (in Deutschland

Re: more diffs

2004-01-21 Thread Matthias Pfisterer
Matthias Pfisterer wrote: Hi, another couple of fixes (attached). Matthias Index: javax/swing/text/Position.java === RCS file:

Re: bug in java.util.Map

2004-01-21 Thread Matthias Pfisterer
Dalibor Topic wrote: Tom Tromey wrote: Matthias == Matthias Pfisterer [EMAIL PROTECTED] writes: Matthias Building with kjc, I get the following errors: Matthias ../java/beans/PropertyChangeSupport.java:1: error:Unaccessible class Matthias java/util/Map/Entry can not be imported [JLS 7.5.1]

Re: enum variables (patch)

2004-01-21 Thread Michael Koch
On Wed, Jan 21, 2004 at 06:31:18PM +0100, Matthias Pfisterer wrote: Hi, in Java 1.5, enum is a keyword. Therefore it can no longer be used for variable names. I've made a patch that changes all variables enum. Matthias -- Matthias Pfisterermailto:[EMAIL PROTECTED]