[cp-patches] FYI: Fixlet for BasicTreeUI

2005-07-07 Thread Roman Kennke
I noticed some jikes warnings in BasicTreeUI. The static fields in javax.swing.tree.TreeSelectionModel were accessed via an instance of this class. I changed this so it is accessed via the class itself. 2005-07-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTreeUI.j

[cp-patches] FYI: fixed JProgressBar constructors

2005-07-07 Thread David Gilbert
The parameters in the JProgressBar(int, int, int) were in the wrong order. I committed this patch to fix the problem: 2005-07-07 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JProgressBar.java (JProgressBar(int, int, int)): fix order of parameters, (JProgressBar()): r

[cp-patches] FYI: Reworked Swing FocusManager

2005-07-07 Thread Roman Kennke
I have finally gotten to fix the javax.swing.FocusManager. This class is officially obsoleted, and replaced by the new java.awt.KeyboardFocusManager stuff. We should support it nevertheless. (at least I have an app here that uses the old API). In order to achieve this we actually have to use t

[cp-patches] FYI: update caret position when Document changes

2005-07-07 Thread Roman Kennke
Hi, when the document of a JTextComponent changes, the caret position must be updated accordingly so that it stays in sync. This is fixed with the attached patch. 2005-07-07 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTextUI.java (DocumentHandler.insertUpda

Re: [cp-patches] FYI: Reworked Swing FocusManager

2005-07-07 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Roman, > In order to achieve this we actually have to use the Swing FocusManager > in AWT instead of the DefaultKeyboardFocusManager > (javax.swing.FocusManager is a subclass of the > DefaultKeyboardFocusManager). In order to not add dependencies i

Re: [cp-patches] FYI: Reworked Swing FocusManager

2005-07-07 Thread Roman Kennke
Hi Robert, In order to achieve this we actually have to use the Swing FocusManager in AWT instead of the DefaultKeyboardFocusManager (javax.swing.FocusManager is a subclass of the DefaultKeyboardFocusManager). In order to not add dependencies into Swing in AWT, I created a subclass of javax.swin

[cp-patches] Patch: BasicTreeUI more formatting

2005-07-07 Thread Lillian Angel
put else's on new line. ecf was set to do otherwise. 2005-07-07 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTreeUI.java Formatted code so else's are on new lines Index: javax/swing/plaf/basic/BasicTreeUI.java ==

Re: [cp-patches] Re: Absolute URL parsing bug

2005-07-07 Thread Andrew Haley
I think this is the right fix. Tested with Mauve, no regressions. Fixes the testcase context = "jar:file://www.example.com/test.jar!/foo/bar.txt", spec = "jar:file://www.example.com/test.jar!/foo/test.txt" which previously caused a NullPointerException. Andrew. 2005-07-07 Andrew Haley

[cp-patches] Please Review: Patch for BasicPopupMenuUI.java

2005-07-07 Thread Anthony Balkissoon
I submitted bug report #13658 yesterday. https://savannah.gnu.org/bugs/?func=detailitem&item_id=13658 This patch fixes the problem but needs review. Rather than calling popopWillBeMadeInvisible I could also just manually disable the mouseListener, but I didn't want to copy the code. Patch is atta

Re: [cp-patches] Re: Patch: dependency tracking with gcj

2005-07-07 Thread Mark Wielaard
On Wed, 2005-07-06 at 15:59 -0600, Tom Tromey wrote: > > "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: > > Tom> This patch adds real dependency tracking when compiling with gcj. > > I am checking this in. This seems to break builddir != srcdir (and make distcheck). For builddir != srcdir

[cp-patches] [RFA] update to eclipse formatter settings

2005-07-07 Thread Aaron Luchko
I've found a couple issues with the style formatter included in .settings/org.eclipse.jdt.core.prefs I'm still investigating how to handle a few anomalies (it looks like there might be some bugs in some of the eclipse formatting code) but I've been able to fix one setting where a "throws" clause w

[cp-patches] Patch: BasicTreeUI

2005-07-07 Thread Lillian Angel
2005-07-07 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTreeUI.java (getRowCount): Implemented (getPreferredSize): Implemented (getMinimumSize): Implemented (getMaximumSize): Implemented (getCellBounds): checked if parameter is n

Re: [cp-patches] [RFA] update to eclipse formatter settings

2005-07-07 Thread Aaron Luchko
On Thu, 2005-07-07 at 16:13 -0400, Aaron Luchko wrote: > I've found a couple issues with the style formatter included > in .settings/org.eclipse.jdt.core.prefs > > I'm still investigating how to handle a few anomalies (it looks like > there might be some bugs in some of the eclipse formatting code

[cp-patches] Re: [RFA/JDWP] ReferenceTypeCommandSet.java

2005-07-07 Thread Aaron Luchko
On Wed, 2005-07-06 at 16:01 -0400, Bryce McKinlay wrote: > Aaron Luchko wrote: > > >2005-07-05 Aaron Luchko <[EMAIL PROTECTED]> > > > >* gnu/classpath/jdwp/processor/ReferenceTypeCommandSet.java:New > >file. > > > > > Aaron, > > This is OK with the formatting fixes that we discussed.

[cp-patches] FYI: Patch committed - JTable deselection

2005-07-07 Thread Anthony Balkissoon
Holding control while clicking on an already selected cell deselects it. 2005-07-07 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTableUI.java: (MouseInputHandler.mousePressed): Added check for control being pressed and mouse clicked on already selected cell. In this cas

[cp-patches] FYI: DefaultListSelectionModel multiple selection updated

2005-07-07 Thread Anthony Balkissoon
Updated multiple selection in JLists. Now after a remove operation, the next add operation works in accordance with the reference implementations. Patch attached. 2005-07-07 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/DefaultListSelectionModel.java: (addSelect

[cp-patches] [RFA] broken links in hacking.texinfo

2005-07-07 Thread Aaron Luchko
I found three broken links in the classpath hacking page http://www.gnu.org/software/classpath/docs/hacking.html All three were pointing to the page for the "GNU Coding Standards" The first two pointed to http://www.fsf.org/prep/standards_toc.html and the third http://www.gnu.org/prep/standards_2

[cp-patches] FYI: JTable clearSelection fixlet

2005-07-07 Thread Anthony Balkissoon
Added one line that clears the columns in a table as well as the rows. This is important if row selection is disabled, the JTable wouldn't clear properly. Patch attached. 2005-07-07 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/JTable.java: (clearSelection): Added clearing of columns as

Re: [cp-patches] FYI: Reworked Swing FocusManager

2005-07-07 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hehe, I dont know texinfo either. Just copied the structure of the surrounding elements and tested whether "make doc" displayed no errors. Post the text and I put it in for you. :) cu Robert Roman Kennke wrote: > Hi Robert, > >>> In order to achiev

[cp-patches] [FYI/JDWP] added method to Signature.java

2005-07-07 Thread Aaron Luchko
I added a computeFieldSignature method to Signature.java. Well actually Tromey gave me the single line of code which comprises of the method body :) Aaron 2005-07-07 Aaron Luchko <[EMAIL PROTECTED]> * gnu/classpath/jdwp/util/Signature.java (computeFieldSignature): New Method.

[cp-patches] FYI: Fix for #13636

2005-07-07 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, this patch will prevent opening a JMenu's popup when it is disabled. However the behavior of the JDK for JMenu is not fully matched. I file bug reports for this. 2005-07-07 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JMenu.java (s

[cp-patches] PATCH: logfile rotation, native methods

2005-07-07 Thread Casey Marshall
Hi, The attached patch implements log file rotation in the java.util.logging.FileHandler class. One feature this implementation requires, in order to function properly, are file locks, which to my dismay are still not implemented. On that point, I'd like to ask what the requirements on