Re: [cp-patches] Patch: FYI: implement NumericShaper

2006-03-21 Thread Tom Tromey
> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: > "Stuart" == Stuart Ballard <[EMAIL PROTECTED]> writes: Stuart> I believe Classpath already has an unchecked NotImplementedException Stuart> so that's what I used. Any method marked as "throws Stuart> NotImplementedException" will be repo

Re: [cp-patches] Patch: FYI: implement NumericShaper

2006-03-21 Thread Tom Tromey
> "Andrew" == Andrew John Hughes <[EMAIL PROTECTED]> writes: Andrew> I had no idea that it was this close actually. My naive Andrew> impression was that the license would still be troublesome, Andrew> but I guess GCC being under a GPL+exception (IIRC) solves Andrew> this... Actually it is ju

Re: [cp-patches] FYI: FormView mouse listener

2006-03-21 Thread Tom Tromey
Roman> 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> Roman> * javax/swing/text/html/FormView.java Roman> (MouseEventListener): New inner class. This broke the build: String data = getImageData(ev.getPoint()); There's no visible 'getImageData' method. Plug: with Eclipse bui

Re: [cp-patches] [generics] FYI: Getting ready for concurrency

2006-03-21 Thread Tom Tromey
> "Jeroen" == Jeroen Frijters <[EMAIL PROTECTED]> writes: Jeroen> +public class Unsafe Jeroen> Unsafe should be final, otherwise you can create an instance by Jeroen> subclassing and capturing the this in the finalize method. Thanks. I'm checking in the appended. Note that this class was m

[cp-patches] FYI: FormView mouse listener

2006-03-21 Thread Roman Kennke
I added the missing MouseEventListener class to the html FormView class. However, like most of the HTML stuff, this still lacks all the wiring-together. 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/html/FormView.java (MouseEventListener): New inner class. /Rom

Re: [cp-patches] FYI: HTML ListView

2006-03-21 Thread Roman Kennke
Sorry, I forgot the patch. Here it comes now. /Roman Am Dienstag, den 21.03.2006, 22:33 +0100 schrieb Roman Kennke: > I implemented the HTML ListView. It's a fairly trivial class given that > the bulk work is performed by the StyleSheet (which unfortunately isn't > fully implemented). > > 2006-

[cp-patches] FYI: HTML ListView

2006-03-21 Thread Roman Kennke
I implemented the HTML ListView. It's a fairly trivial class given that the bulk work is performed by the StyleSheet (which unfortunately isn't fully implemented). 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/html/ListView.java: New file. /Roman

Re: [cp-patches] RFC: ObjectStreamOutput setDefaultProtocolVersion() removal

2006-03-21 Thread Tom Tromey
> "Wolfgang" == Wolfgang Baer <[EMAIL PROTECTED]> writes: Wolfgang> looking at the reverse japi results I noticed that we Wolfgang> provide a static setDefaultProtocolVersion() method which is Wolfgang> not part of the API. I think we don't want such api Wolfgang> additions, right ? That's ri

[cp-patches] RFC: ObjectStreamOutput setDefaultProtocolVersion() removal

2006-03-21 Thread Wolfgang Baer
Hi all, looking at the reverse japi results I noticed that we provide a static setDefaultProtocolVersion() method which is not part of the API. I think we don't want such api additions, right ? This patch removes this method, documents the non-static useProtocolVersion() public API method a bit m

[cp-patches] Patch: FYI: java.text.Bidi

2006-03-21 Thread Tom Tromey
I'm checking this in. This implements java.text.Bidi. It has not been extensively tested, but it does pass the few tests I wrote. These are in Mauve. Tom 2006-03-21 Tom Tromey <[EMAIL PROTECTED]> * java/text/Bidi.java: Completed. Index: java/text/Bidi.java =

[cp-patches] RFC: system clipboard integration

2006-03-21 Thread Robert Schuster
Hi, this patch adds some code to an internal FocusListener implementation in BasicTextUI that copies the current selection into the system clipboard and fixes PR 26736[0]. Together with my focus change patch this completes the integration of the system clipboard in Free Swing. The code contains s

[cp-patches] FYI: JTable fixlet

2006-03-21 Thread Anthony Balkissoon
While testing Mauve exception handling I tried to generate a NPE using JTable.columnAtPoint but found that Classpath was gracefully ignoring null argument while Sun was throwing the NPE I wanted. So I removed the != null check. 2006-03-21 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/

[cp-patches] RFC: focus change fixes for text components

2006-03-21 Thread Robert Schuster
Hi, as described in PR 26737[0] the focus change behavior for text components is a bit different than for other swing components. I implemented that behavior by adjusting DefaultCaret a bit. However the patch relies on a change in Component.dispatchEventImpl() too, which someone with more AWT/Swin

[cp-patches] FYI: flexible highlight painting

2006-03-21 Thread Robert Schuster
Hi, this patch makes the highlight painting flexible enough to handle lines of different sizes. It is an adaption of the code in BasicTextUI.damageRange(). 2006-03-02 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/text/DefaultHighlighter.java: (DefaultHighlighter.DefaultHighl

[cp-patches] Re: FYI: only allow a single Free Swing text selection

2006-03-21 Thread Robert Schuster
Hi, posted a wrong ChangeLog entry, here is the right one: 2006-03-21 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/text/DefaultCaret.java: Added class variable denoting the textcomponent having a selection. (clearSelection): Clear 'componentWithSelection' variable.

[cp-patches] FYI: only allow a single Free Swing text selection

2006-03-21 Thread Robert Schuster
Hi, this patch prevents that multiple Swing components have a text selection. The approach and patch was approved by Roman on IRC. 2006-03-21 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/text/DefaultCaret.java: Added class variable denoting the textcomponent having a selec

[cp-patches] FYI: MetalTabbedPaneUI content borders

2006-03-21 Thread Roman Kennke
I implemented the painting of the content borders for the MetalTabbedPaneUI. 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalTabbedPaneUI.java (paintContentBorderTopEdge): Implemented. (paintContentBorderBottomEdge): Implemented. (paintC

[cp-patches] FYI: JTabbedPane fixlet

2006-03-21 Thread Roman Kennke
Just like with the background, the JTabbedPane.Page.getForeground() should fall back to returning the tabbed pane's foreground if no foreground has been explicitly set. 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java (Page.getForeground): Fall back to

[cp-patches] FYI: ComboBox color fix

2006-03-21 Thread Roman Kennke
This fixes colored ComboBoxes. We were not setting/updating the colors of the ComboBox button and list correctly. 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalComboBoxButton.java (setEnabled): Update colors of button correctly. * javax/swing/

[cp-patches] FYI: BasicButtonUI fix

2006-03-21 Thread Roman Kennke
In BasicButtonUI we may only clear background and foreground colors if they are UIResource instances. This is so that application defined colors are not overridden when changing the theme or L&F. 2006-03-21 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicButtonUI.java

Re: [cp-patches] RFC: Checking file resource validity by walking path components

2006-03-21 Thread Mark Wielaard
Hi Olivier, On Mon, 2006-03-20 at 20:27 +0100, Olivier Jolly wrote: > here is attached another version of the patch rewrote with > StringTokenizer and an iterative algorithm. It still passes all the > mauve test about resources and looks more efficient. Yes. Thanks please do check this in wit

Re: [cp-patches] Patch: FYI: implement NumericShaper

2006-03-21 Thread Andrew John Hughes
On 20 Mar 2006 11:47:34 -0700 Tom Tromey <[EMAIL PROTECTED]> wrote: > > "Stuart" == Stuart Ballard <[EMAIL PROTECTED]> writes: > > Stuart> What's the status on the whole ecj-as-gcc-frontend thing? > > It is still being discussed by the GCC Steering Committee. I'm > hopeful that we'll get th

Re: [cp-patches] Fix for classification of XML characters

2006-03-21 Thread Chris Burdess
Andrew Pinski wrote: Chris Burdess wrote: During development of the XML parser I prevented U+fffd from being classified as an XML Char. Since the introduction of the UnicodeReader class this hack is no longer required. I committed this patch to re-classify U+fffd as a Char and permit the pa

AW: Re: [cp-patches] [Patch] locale data update - part 2

2006-03-21 Thread michael-privat
>Hi Michael, > >On Sun, 2006-03-19 at 22:40 +, Michael Koch wrote: >> I just commited another update for the locale data update to CLDR 1.3. >> The only things still missing is the update of the currency formats and >> the new locales. > >Could you take a quick look at the following regressions