Re: [cp-patches] FYI: appletviewer

2006-05-08 Thread Tom Tromey
> "Tom" == Thomas Fitzsimmons <[EMAIL PROTECTED]> writes: Tom> I committed the attached patch to add an appletviewer to GNU Classpath. Awesome! Tom> * resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties: Tom> New file. Tom> * resource/gnu/classpath/tools/appletviewer/Messages

[cp-patches] Patch: FYI: jar updates

2006-05-08 Thread Tom Tromey
I'm checking this in. This fixes some bugs in the jar code. Among other things it adds manifest generation and updates NEWS. I filed a PR for the other known bugs with jar. In particular the -i feature is missing and requires something like ASM or another bytecode library -- like some of the ot

Re: [cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Thomas Fitzsimmons
Lillian Angel wrote: On Mon, 2006-05-08 at 14:17 -0600, Tom Tromey wrote: "Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes: Lillian> A fixed a small bug in the last patch I committed. Lillian> Unfortunately, this is the best way to load all the jars listed in Lillian> INDEX.LIST. This p

Re: [cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Lillian Angel
On Mon, 2006-05-08 at 14:17 -0600, Tom Tromey wrote: > > "Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes: > > Lillian> A fixed a small bug in the last patch I committed. > Lillian> Unfortunately, this is the best way to load all the jars listed in > Lillian> INDEX.LIST. > > This patch

[cp-patches] FYI: AccessibleJComboBox missing methods

2006-05-08 Thread Roman Kennke
I implemented the remaining missing methods in AccessibleJComboBox. 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JComboBox.java (AccessibleJComboBox.getAccessibleChildrenCount): Implemented. (AccessibleJComboBox.getAccessibleChild): Implemented. (Acce

[cp-patches] FYI: appletviewer

2006-05-08 Thread Thomas Fitzsimmons
Hi, I committed the attached patch to add an appletviewer to GNU Classpath. Tom 2006-05-08 Thomas Fitzsimmons <[EMAIL PROTECTED]> * configure.ac: Add support for building appletviewer. * resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties: New file.

Re: [cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Tom Tromey
> "Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes: Lillian> A fixed a small bug in the last patch I committed. Lillian> Unfortunately, this is the best way to load all the jars listed in Lillian> INDEX.LIST. This patch has a problem and a missing feature. The problem is that it doesn'

Re: [cp-patches] FYI: ButtonGroup fixlet

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 16:09 +0200, Roman Kennke wrote: > In ButtonGroup.add() we need to check if the added button is already > selected, and if this is the case, deselect all the other buttons. This > is fixed by the attached patch. > > 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> > > PR

Re: [cp-patches] Re: [Bug swing/27486] setValueAt() doesn't work on non-editable cells

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 15:25 +0200, Roman Kennke wrote: > Committed as follows: > > 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> > > PR 27486 > * javax/swing/JTable.java > (setValueAt): Allow setting values even when table is editable. > > > /Roman > > Am Montag, den 08.05.200

Re: [cp-patches] FYI: JRootPane fixlet

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 16:22 +0200, Roman Kennke wrote: > The content pane in a JRootPane must have its background color set to > null, so that it inherits the background from the surround containers > (whichever is the first to have a non-null background, usually the > JFrame or JInternalFrame cont

Re: [cp-patches] Re: [Bug swing/27485] ArrayOutOfBoundsException with setValueAt on DefaultTableModel

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 15:39 +0200, Roman Kennke wrote: > The attached patch fixes Bug#27485 by checking and adjusting the size of > the table model. Thanks Yvan for reporting and proposing a patch. > > 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> > > PR 27485 > * javax/swing/table

Re: [cp-patches] FYI: JTable icon rendering fixlet

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 15:59 +0200, Roman Kennke wrote: > As reported in bug#27482 the icon in the IconCellRenderer must be set to > null when the cell value is null. Fixed by the attached patch. > > 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> > > PR 27482 > * javax/swing/JTable.j

Re: [cp-patches] FYI: ImageIcon URL constructor

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 16:03 +0200, Roman Kennke wrote: > In the ImageIcon(URL) constructor the icon's description should be set > to url.toString() instead of null. Fixed by the attached patch. > > 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> > > PR 27461 > * javax/swing/ImageIcon

Re: [cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Andrew John Hughes
On Mon, 2006-05-08 at 10:06 -0400, Lillian Angel wrote: > Added handling for the META-INF/INDEX.LIST file. > > 2006-05-08 Lillian Angel <[EMAIL PROTECTED]> > > PR 27444 > * java/net/URLClassLoader.java > (JarURLLoader): Added code to go through > META-INF/INDEX.L

[cp-patches] Patch: #27503

2006-05-08 Thread Yvan Norsa
Hi, Another bug crashing the JVM if we try do read an ImageIcon from a file which isn't there : this bug happens when the Icon is on a disabled JButton. Here is a fix preventing this. Regards, Yvan GtkImage.java.patch Description: Binary data

Re: [cp-patches] Patch: RFC: argument parsing and 'jar' utility

2006-05-08 Thread Thomas Fitzsimmons
Hi, Tom Tromey wrote: This weekend I wrote an argument parsing utility. It looked easy and I figured it would be better to simply have our own -- one in the correct namespace, that we can easily hack, and that doesn't have any legal baggage at all. It is reasonably straightforward to use and f

Re: [cp-patches] Patch: RFC: argument parsing and 'jar' utility

2006-05-08 Thread Chris Burdess
Tom Tromey wrote: This weekend I wrote an argument parsing utility. It looked easy and I figured it would be better to simply have our own -- one in the correct namespace, that we can easily hack, and that doesn't have any legal baggage at all. It is reasonably straightforward to use and fully

Re: [cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Lillian Angel
A fixed a small bug in the last patch I committed. Unfortunately, this is the best way to load all the jars listed in INDEX.LIST. This fixes the case where INDEX.LIST exists and Class-Path does not appear in the MANIFEST. We first check for INDEX.LIST and if it does not exist we check for Class-P

[cp-patches] FYI: Java2D-clipping

2006-05-08 Thread Roman Kennke
Hi there, (I CC classpath@gnu.org because this contains a summary of the state of the Java-based Java2D rendering pipeline, which might also be interesting to people not reading cp-patches). I added support for clipping against arbitrary shapes to my AbstractGraphics2D renderer. This makes the re

Re: [cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Thomas Fitzsimmons
Lillian Angel wrote: Added handling for the META-INF/INDEX.LIST file. I don't think this patch is correct -- it is likely working around another problem. The class loader should refer to INDEX.LIST, if it exists, when trying to resolve a class external to the jar file to which INDEX.LIST bel

[cp-patches] FYI: JRootPane fixlet

2006-05-08 Thread Roman Kennke
The content pane in a JRootPane must have its background color set to null, so that it inherits the background from the surround containers (whichever is the first to have a non-null background, usually the JFrame or JInternalFrame containing the JRootPane). 2006-05-08 Roman Kennke <[EMAIL PROTEC

[cp-patches] FYI: ButtonGroup fixlet

2006-05-08 Thread Roman Kennke
In ButtonGroup.add() we need to check if the added button is already selected, and if this is the case, deselect all the other buttons. This is fixed by the attached patch. 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> PR 27480 * javax/swing/ButtonGroup.java (add): Check if

[cp-patches] Patch: URLClassLoader fix

2006-05-08 Thread Lillian Angel
Added handling for the META-INF/INDEX.LIST file. 2006-05-08 Lillian Angel <[EMAIL PROTECTED]> PR 27444 * java/net/URLClassLoader.java (JarURLLoader): Added code to go through META-INF/INDEX.LIST file to load all jars listed. Index: java/net/URLClassLoader.java =

[cp-patches] FYI: ImageIcon URL constructor

2006-05-08 Thread Roman Kennke
In the ImageIcon(URL) constructor the icon's description should be set to url.toString() instead of null. Fixed by the attached patch. 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> PR 27461 * javax/swing/ImageIcon.java (ImageIcon(URL)): Set description to URL.toString(). /

[cp-patches] FYI: JTable icon rendering fixlet

2006-05-08 Thread Roman Kennke
As reported in bug#27482 the icon in the IconCellRenderer must be set to null when the cell value is null. Fixed by the attached patch. 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> PR 27482 * javax/swing/JTable.java (IconCellRenderer.getTableCellRendererComponent): Set ico

[cp-patches] FYI: DefaultDesktopManager fixlet

2006-05-08 Thread Roman Kennke
The attached patch fixes Bug#27484 by removing the doDefaultCloseAction() call in DefaultDesktopManager.closeFrame(). This should prevent the endless loop reported in the bug. 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> PR 27484 * javax/swing/DefaultDesktopManager.java (c

[cp-patches] Re: [Bug swing/27485] ArrayOutOfBoundsException with setValueAt on DefaultTableModel

2006-05-08 Thread Roman Kennke
The attached patch fixes Bug#27485 by checking and adjusting the size of the table model. Thanks Yvan for reporting and proposing a patch. 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> PR 27485 * javax/swing/table/DefaultTableModel.java (addExtraRows): New helper method.

[cp-patches] Re: [Bug swing/27486] setValueAt() doesn't work on non-editable cells

2006-05-08 Thread Roman Kennke
Committed as follows: 2006-05-08 Roman Kennke <[EMAIL PROTECTED]> PR 27486 * javax/swing/JTable.java (setValueAt): Allow setting values even when table is editable. /Roman Am Montag, den 08.05.2006, 12:58 + schrieb yvan dot norsa at gmail dot com: > > --- Comm

[cp-patches] Patch: FYI: exception message fix

2006-05-08 Thread Tom Tromey
I'm checking this in. This fixes an exception message to add a missing space. Tom 2006-05-08 Tom Tromey <[EMAIL PROTECTED]> * java/text/SimpleDateFormat.java (compileFormat): Added missing space to error message. Index: java/text/SimpleDateFormat.java

[cp-patches] Re: RFC: patch for #27485

2006-05-08 Thread Yvan Norsa
Sorry, here is the rest of my sentence : In doing so, I had to write a method which duplicated some existing code, so I refactored it. Regards, Yvan

[cp-patches] RFC: patch for #27485

2006-05-08 Thread Yvan Norsa
Hi, Although I am not sure what the intended effect of the test case should be, I have written this little fix which prevents the ArrayIndexOutOfBoundsException. In doing so, I had to write DefaultTableModel.java.patch Description: Binary data

[cp-patches] FYI: AbstractButton.java - comment typos fixed

2006-05-08 Thread David Gilbert
This patch (committed) fixes a few comment typos I spotted for AbstractButton.java: 2006-05-08 David Gilbert <[EMAIL PROTECTED]> * javax/swing/AbstractButton.java: Fixed comment typos. Regards, Dave Index: javax/swing/AbstractButton.java =

[cp-patches] Patch: bug #27480

2006-05-08 Thread Yvan Norsa
Hi, Here is a small patch verifying that there isn't already a selected Button when adding another selected one. Regards, Yvan ButtonGroup.java.patch Description: Binary data