Re: [cp-patches] RFA: CairoGraphics2D.java fixlet

2006-06-14 Thread Sven de Marothy
On Wed, 14 Jun 2006, David Gilbert wrote: > I'm requesting approval for this patch, just in case I'm missing something > important. > > As I understand the getPathIterator(AffineTransform) method defined in the > Shape interface, if you want the path returned without transformation, you can > pas

[cp-patches] RFA: CairoGraphics2D.java fixlet

2006-06-14 Thread David Gilbert
I'm requesting approval for this patch, just in case I'm missing something important. As I understand the getPathIterator(AffineTransform) method defined in the Shape interface, if you want the path returned without transformation, you can pass in null for the AffineTransform. So it is wastef

[cp-patches] FYI: BasicComboBoxUI

2006-06-14 Thread Roman Kennke
Again, this will make JAPI a little bit more happy. 2006-06-14 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicComboBoxUI.java (getAccessibleChildrenCount): Implemented. (getAccessibleChild): Implemented. (isNavigationKey): Implemented. (Ke

[cp-patches] FYI: [generics] Fix JAPI bugs

2006-06-14 Thread Andrew John Hughes
This patch fixes a few missing genericy stuff in javax.naming. Changelog: 2006-06-14 Andrew John Hughes <[EMAIL PROTECTED]> * javax/naming/InitialContext.java: (list(javax.naming.Name)): Fixed generic type. (list(String)): Likewise. (listBindings(javax.naming.Na

[cp-patches] FYI: Fix JAPI bugs in management classes

2006-06-14 Thread Andrew John Hughes
The attached patch fixes a couple of bugs spotted by JAPI: serialization UIDs mainly, as well as a couple of classes where I forgot to change the superclass. Changelog: 2006-06-14 Andrew John Hughes <[EMAIL PROTECTED]> * java/lang/management/ManagementPermission.java: Added ser

Re: [cp-patches] FYI: Component and TextComponent fix.

2006-06-14 Thread Lillian Angel
Small fix. All these functions should be static. 2006-06-14 Lillian Angel <[EMAIL PROTECTED]> * java/awt/Component.java (ignoreOldMouseEvents): Made static. (translateEvent): Made static. * java/awt/TextComponent.java (ignoreOldMouseEvents): Made static.

Re: [cp-patches] FYI: CairoGraphics2D speedup

2006-06-14 Thread Sven de Marothy
On Wed, 14 Jun 2006, Mark Wielaard wrote: > Nice, but unfortunately that doesn't work for ComponentGraphics which > manipulate the X state. In that case we need locking before drawing. We > used to get that for free since ComponentGraphics overrides draw(Shape) > and fill(Shape). So we need to ove

Re: [cp-patches] FYI: CairoGraphics2D speedup

2006-06-14 Thread Mark Wielaard
Hi Roman, On Wed, 2006-06-14 at 15:51 +0200, Roman Kennke wrote: > Here comes a slight optimization for CairoGraphics2D efficiency wrt JNI > calls. It adds special methods for 3 common graphics operations > (drawLine, drawRect and fillRect), so that unnecessary JNI calls and > object creations are

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-14 Thread Roman Kennke
Hi Francis, Am Mittwoch, den 14.06.2006, 12:05 -0400 schrieb Francis Kung: > Thanks Roman; I didn't know that would work - the MenuSelectionManager > is smarter than I thought! =) > > Attached is a patch to finish it up; I'll commit it if there are no > objections. Yes, please go ahead! /Roman

[cp-patches] Patch: Component and TextComponent fix.

2006-06-14 Thread Lillian Angel
The JDK TextComponent ignores all old mouse events. I fixed our implementation to do this by creating a package-private function in Component and TextComponent. This also fixes: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27695 I have committed a mauve test for this as well. 2006-06-14 Lillian

[cp-patches] FYI: RepaintManager fix

2006-06-14 Thread Roman Kennke
In the RepaintManager we used to merge regions of different components to one when blitting the buffer on the screen. However, this proves to cause painting artifacts. This happens when different distinct regions of the screen get updated simultanously (especially when using Timers and/or multiple

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-14 Thread Francis Kung
Thanks Roman; I didn't know that would work - the MenuSelectionManager is smarter than I thought! =) Attached is a patch to finish it up; I'll commit it if there are no objections. Francis 2006-06-14 Francis Kung <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicArrowButton.java:

[cp-patches] FYI: AWT Graphics benchmark

2006-06-14 Thread Roman Kennke
I'm glad to contribute a small AWT Graphics benchmark prog in the name of Aicas. This has been used for quite some time now to test and benchmark Graphics performance on all kinds of target platforms. As there has been some discussion about the performance and benchmarking of the new Java2D impl, w

Re: [cp-patches] FYI: CairoGraphics2D speedup

2006-06-14 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> drawRect: 316 vs 255 Roman> drawLine: 364 vs 309 Roman> fillRect: 255 vs 95 Nice work. Tom

[cp-patches] Patch: FYI: javadoc fix

2006-06-14 Thread Tom Tromey
I'm checking this in. I found a sentence in the javadoc in File which ended in the middle. Tom 2006-06-14 Tom Tromey <[EMAIL PROTECTED]> * java/io/File.java (getParent): Javadoc fix. Index: java/io/File.java === RCS file

[cp-patches] Patch: FYI: fix class loading regression

2006-06-14 Thread Tom Tromey
I'm checking this in. Lillian and others have run into problems with our URLClassLoader not handling the Class-Path attribute correctly. I caused this regression when I implemented index.list handling. I tracked the problem down to 2 bugs. One is that we weren't clearing the index map if we did

Re: [cp-patches] RFC: AbstractButton

2006-06-14 Thread Tania Bento
Again, thanks Tom. Its been committed. On Tue, 2006-06-13 at 12:09 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Hey, > > > > In the constructor, focusable should be set to false and not true. > > Could someone please approve and commit this for me. Thanks a bunch. > > > > 2006-06-

Re: [cp-patches] Re: [cp-pathes] RFC: JMenuItem

2006-06-14 Thread Tania Bento
Thanks Tom. It's been committed. On Tue, 2006-06-13 at 12:07 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Sorry... wrong patch. Here's the right one. > > > > On Tue, 2006-06-13 at 11:52 -0400, Tania Bento wrote: > >> Hey, > >> > >> Changed the horizontal alignment from JButton.LEFT

Re: [cp-patches] Patch: PixelGrabber fix

2006-06-14 Thread Lillian Angel
On Tue, 2006-06-13 at 21:13 +0100, David Gilbert wrote: > Lillian Angel wrote: > > >On Tue, 2006-06-13 at 12:16 -0600, Tom Tromey wrote: > > > > > >> > >>In cases like this it is nice to have a comment, either in the > >>javadoc or in the code, explaining what happens when ip==null. > >>That way

Re: [cp-patches] RFC: JCheckBoxMenuItem

2006-06-14 Thread Tania Bento
Thanks Tom. I've just committed it. On Tue, 2006-06-13 at 12:07 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Hey, > > > > Before setting the value of the button's selected property to true, i > > added a check that ensures that state first be set to true. > > > > 2006-06-13 Tania B

[cp-patches] FYI: CairoGraphics2D speedup

2006-06-14 Thread Roman Kennke
Here comes a slight optimization for CairoGraphics2D efficiency wrt JNI calls. It adds special methods for 3 common graphics operations (drawLine, drawRect and fillRect), so that unnecessary JNI calls and object creations are avoided. Here are some numbers, measured with a benchmark (to be added s

[cp-patches] FYI: Don't crash in GtkImage when out of memory

2006-06-14 Thread Mark Wielaard
Hi, We would crash and burn in GtkImage when we would run out of memory. This patch just returns from native code (throwing an OutOfMemoryException) when we couldn't allocate the int array needed. 2006-06-14 Mark Wielaard <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkI

[cp-patches] Patch: FYI: PR 28024

2006-06-14 Thread Tom Tromey
I'm checking this in. PR 28024 points out a place where we have unportable sh code in configure. I fixed the other instance I found as well. Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> PR java/28024: * m4/acinclude.m4 (REGEN_WITH_JAY): Use backquote, not $(...).

[cp-patches] FYI: Swing painting for AWT components

2006-06-14 Thread Roman Kennke
Hi, this should fix the Swing painting code to handle (heavyweight) AWT components properly. Basically it changes two things: 1. Heavyweights are no longer triggered with paint() during JComponent.paintChildren(). Heavyweight components must take care of their painting themselves. 2. When a Swing

[cp-patches] FYI: ConfigFileParser fix

2006-06-14 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes a typo, and replaces writing to System.out with logging statements conditioned by Configuration.DEBUG. 2006-06-14 Raif S. Naffah <[EMAIL PROTECTED]> * gnu/javax/security/auth/login/ConfigFileTokenizer.java: Fixed a typo.

[cp-patches] [generic] RFQ: java.util.concurrent.locks

2006-06-14 Thread Maciej Piechotka
2006-06-13 Maciej Piechotka [EMAIL PROTECTED] * java/util/concurrent/lock/* : Add java.util.concurrent.locks patches diff -ruN java.old/util/concurrent/locks/AbstractQueuedSynchronizer.java java/util/concurrent/locks/AbstractQueuedSynchronizer.java --- java.old/util/concurrent/locks/Abstr