[cp-patches] RFC: RMI Class loading patch

2006-08-13 Thread Jeroen Frijters
Hi, I did some RMI debugging and I found that we're using the wrong class loader in a couple of cases. The attached patch cleans up the code a little and uses the caller's class loader instead of the thread's context class loader in a couple of places. I would appreciate it if someone with more

[cp-patches] FYI: BasicTextUI fixlet

2006-08-13 Thread Roman Kennke
In BasicTextUI we need to unregister the document handler in order to clean up correctly on UI change. 2006-08-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (uninstallListeners): Unregister document listener. /Roman Index:

[cp-patches] FYI: PlainView optimization

2006-08-13 Thread Roman Kennke
This optimizes PlainView to only paint the lines that are necessary, wrt to the current clip and allocation. This makes JTextArea more snappy with scrolling. I tested this by copy+pasting Component.java into a JTextArea (which has around 7000 lines) and once it got around to parse all the

[cp-patches] FYI: BasicScrollBarUI fixlet

2006-08-13 Thread Roman Kennke
The BasicScrollBarUI should scroll by -block or -unit (fetched from the Scrollable impl) when the direction is not positive, and +unit or +block otherwise. So far we expected the Scrollable impl to return a negative value for up-scrolling and a positive value for down scrolling. Which is wrong

[cp-patches] FYI: JList scrolling fixes

2006-08-13 Thread Roman Kennke
This fixes the JList Scrollable impl wrt to my latest BasicScrollBarUI patch. It also implements horizontal scrolling and improves the overall usability (like, when block-scrolling, the first item will still be visible as last item or vice-versa). 2006-08-13 Roman Kennke [EMAIL PROTECTED]

[cp-patches] FYI: JTable scrolling fix

2006-08-13 Thread Roman Kennke
This fixes the JTable wrt to the BasicScrollBarUI fix. 2006-08-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTable.java (getScrollableUnitIncrement): Fixed direction. Make it behave like the RI. (getScrollableBlockIncrement): Fixed direction. Make it behave

[cp-patches] FYI: JTree scrolling fix

2006-08-13 Thread Roman Kennke
This fixes unit-scrolling and implements block scrolling for JTree. It also fixes a minor glitch in VariableHeightLayoutCache. 2006-08-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTree.java (getScrollableUnitIncrement): Fixed direction.

[cp-patches] FYI: JMenu fixlet

2006-08-13 Thread Roman Kennke
This fixes a problem pointed out by JAPI which is that JMenu shadows a protected field from AbstractButton and makes it private. 2006-08-13 Roman Kennke [EMAIL PROTECTED] * javax/swing/JMenu.java (changeListener): Renamed to menuChangeListener to avoid shadowing

[cp-patches] FYI: JToolTip HTML support

2006-08-13 Thread Roman Kennke
This implements HTML support for tooltip. This is pretty barebones atm, but good enough to not have HTML tags displaying in ToolTips. As with all other Swing components, this will improve automagically as soon as javax.swing.text.html is fixed. I am working on this atm and hope to get it right

[cp-patches] FYI: JScrollPane.setViewportBorder() support

2006-08-13 Thread Roman Kennke
This implements support for JScrollPane.setViewportBorder(). Interestingly, this _doesn't_ simply set the border on the viewport (you can still set another border on this). Instead, I implemented this to paint this border in BasicScrollPaneUI.paint() and consider this specially in the

[cp-patches] FYI: BasicTableHeaderUI stubs

2006-08-13 Thread Roman Kennke
I unmarked 2 stubs in BasicTableHeaderUI. Accordings to some simple tests that I did, the RI never installs any keyboard actions on the JTableHeader component, but the UI provides these methods anyway, presumably as hooks for subclasses. 2006-08-13 Roman Kennke [EMAIL PROTECTED] *