Re: [cp-patches] [Fwd: Re: KerberosPrincipal class]

2005-11-20 Thread Casey Marshall
I'll slowly chew through the rest of this over the next little bit. Yes I think so. You might want to CC Casey Marshall <[EMAIL PROTECTED]> who knows most about the rest of our security framework. The idea seems sound to me. The only issue I'm concerned about is having t

Re: [cp-patches] Patch: Implementing non-abstract members on abstract X509Certificate and correcting GeneralName OtherName parsing

2005-12-01 Thread Casey Marshall
On Dec 1, 2005, at 8:05 AM, Rafael Teixeira wrote: 2005-12-01 Rafael Teixeira <[EMAIL PROTECTED]> * gnu/java/security/der/DERValue.java Clearer information returned by toString() to help debugging * gnu/java/security/x509/ext/GeneralNames.java Fix the parsing of the OtherName choic

[cp-patches] [generics] RFC: fix generics branch compilation on Darwin

2005-12-04 Thread Casey Marshall
java_lang_VMSystem.c references 'extern char **environ,' which isn't defined on Darwin. java_lang_VMProcess.c has a little #if that defines this to a special function (_NSGetEnviron) for Darwin; the attached patch does the same for VMSystem. Does this look OK? I haven't tested this yet (I'm

Re: [cp-patches] [generics] RFC: fix generics branch compilation on Darwin

2005-12-05 Thread Casey Marshall
On Dec 5, 2005, at 7:48 AM, Tom Tromey wrote: "Casey" == Casey Marshall <[EMAIL PROTECTED]> writes: Casey> java_lang_VMSystem.c references 'extern char **environ,' which isn't Casey> defined on Darwin. java_lang_VMProcess.c has a little #if that Case

Re: [cp-patches] [generics] RFC: fix generics branch compilation on Darwin

2005-12-05 Thread Casey Marshall
Checked in as: 2005-12-05 Casey Marshall <[EMAIL PROTECTED]> * native/jni/classpath/jcl.h (environ): define, or declare 'extern.' * native/jni/java-lang/java_lang_VMProcess.c: include . Remove 'extern' define. * native/jni/java

[cp-patches] PATCH: fix PrivateKeyUsagePeriod parsing

2005-04-17 Thread Casey Marshall
ils because the type of the value field can't be determined at that point. Ok to commit? 2005-04-17 Casey Marshall <[EMAIL PROTECTED]> * gnu/java/security/der/DERValue.java (getValueAs): new method. * gnu/java/security/x509/ext/PrivateKeyUsagePeriod.java

Re: [cp-patches] PATCH: fix PrivateKeyUsagePeriod parsing

2005-04-21 Thread Casey Marshall
>>>>> "Michael" == Michael Koch <[EMAIL PROTECTED]> writes: Michael> On Sun, Apr 17, 2005 at 07:51:51PM -0700, Casey Marshall wrote: >> Hi list; >> >> Tom Fitzsimmons pointed out a flaw in the X.509 parsing code that >> handles the '

[cp-patches] PATCH: debug logging

2005-06-04 Thread Casey Marshall
Hi, Attached is an initial implementation of a component-level logging system, like I mentioned earlier on the Classpath list. Comments are welcome. /* Component.java -- a component log level. Copyright (C) 2005 Free Software Foundation, Inc. This file is a part of GNU Classpath. GNU Classpa

Re: [cp-patches] PATCH: debug logging

2005-06-04 Thread Casey Marshall
Casey Marshall wrote: > Hi, > > Attached is an initial implementation of a component-level logging > system, like I mentioned earlier on the Classpath list. Comments are > welcome. > Forgot the ChangeLog: 2005-06-04 Casey Marshall <[EMAIL PROTECTED]>

[cp-patches] PATCH: DiffieHellman and RSA cipher support

2005-06-04 Thread Casey Marshall
is not approved. 2005-06-04 Casey Marshall <[EMAIL PROTECTED]> * gnu/java/security/provider/Gnu.java (): add Diffie-Hellman key agreement and RSA cipher entries. * gnu/javax/crypto/DiffieHellmanImpl.java: new file. * gnu/javax/crypto/GnuDHPrivateKey.java: ne

Re: [cp-patches] PATCH: debug logging

2005-06-05 Thread Casey Marshall
Jeroen Frijters wrote: > Casey Marshall wrote: >> String defaults = (String) AccessController.doPrivileged >> (new GetPropertyAction ("gnu.classpath.debug.components")); > > > You can directly access gnu.classpath.SystemProperties, instead of going > thr

[cp-patches] PATCH: logfile rotation, native methods

2005-07-07 Thread Casey Marshall
les) use one of these? Or would it be acceptable to simply write the JNI code directly, surrounded by appropriate #ifdef's? Ok? 2005-07-07 Casey Marshall <[EMAIL PROTECTED]> * java/util/logging/FileHandler.java (written): new field. (logFiles): new field. (): i

[cp-patches] Re: PATCH: logfile rotation, native methods

2005-07-09 Thread Casey Marshall
On Jul 7, 2005, at 11:17 PM, Casey Marshall wrote: 2005-07-07 Casey Marshall <[EMAIL PROTECTED]> * java/util/logging/FileHandler.java (written): new field. (logFiles): new field. (): initialize the OutputStream last. (createFileStream): made non-static; append &#

[cp-patches] PATCH: logging, small fix to X509 parsing

2005-07-10 Thread Casey Marshall
ll of the PKITS test suite that I have implemented. 2005-07-10 Casey Marshall <[EMAIL PROTECTED]> * gnu/classpath/debug/Component.java: new file. * gnu/classpath/debug/PreciseFilter.java: new file. * gnu/classpath/debug/SystemLogger.java: new file. * gnu/java/se

[cp-patches] FYI: file locks

2005-07-10 Thread Casey Marshall
Hi, I'm checking in this little patch that implements file locks in gnu.java.nio.channels.FileChannelImpl. This just uses straight C in the gnu_java_nio_channels_FileChannelImpl.c file, protected by appropriate #ifdefs. 2005-07-10 Casey Marshall <[EMAIL PROTECTED]> * c

Re: [cp-patches] FYI: file locks

2005-07-11 Thread Casey Marshall
On Jul 11, 2005, at 5:14 PM, Robert Schuster wrote: Hi, should that patch allow me to run Eclipse without "- Dosgi.locking=none"? It might. I don't know what Eclipse does internally, but if it uses FileChannel.lock and you are running on a platform that supports the 'fcntl' function, th

[cp-patches] RFC: misc NIO fixes

2005-07-19 Thread Casey Marshall
. Ok? I might be too busy to get to this until next weekend. (Apologies if the patch is 'application/octet-stream.' If anyone knows how to convince Mail.app that '.patch' is text/plain or text/x- patch, I'd like to hear how.) 2005-07-18 Casey Marshall

Re: [cp-patches] RFC: misc NIO fixes

2005-07-21 Thread Casey Marshall
On Jul 21, 2005, at 3:04 PM, Mark Wielaard wrote: Hi, On Tue, 2005-07-19 at 09:12 -0500, Archie Cobbs wrote: Casey Marshall wrote: Attached is a patch I'd like to get some comments on, before I check it in, especially if anyone can spot holes in my C. This patch + /* FIXME

Re: [cp-patches] RFC: misc NIO fixes

2005-07-23 Thread Casey Marshall
e' does not work properly if the mapped region is only one page in size. This appears to work fine on GNU/Linux, however, so I'm putting it down to problems with Darwin. On Jul 18, 2005, at 11:58 PM, Casey Marshall wrote: Hi, Attached is a patch I'd like to get some comments o

Re: [cp-patches] RFC: misc NIO fixes

2005-07-26 Thread Casey Marshall
On Jul 26, 2005, at 12:42 AM, Mark Wielaard wrote: Hi, On Sat, 2005-07-23 at 20:37 -0700, Casey Marshall wrote: Committed. I changed a few minor things, such as using Mark's suggestion to use 'madvise' to load the file into core. I can't get this to work with Jamv

Re: [cp-patches] RFC: misc NIO fixes

2005-07-26 Thread Casey Marshall
Attached is a patch that fixes the warnings in the NIO files I changed, and fixes the problem on Darwin (adding the 'volatile' keyword to the MappedByteBufferImpl instance we create and return appears to fix this). A bug in GCC 4.0 on that platform, perhaps? I can't test this properly becau

[cp-patches] FYI: fix warnings in NIO JNI

2005-07-30 Thread Casey Marshall
This patch fixes the warnings I introduced into the java-nio JNI library with my recent changes, and fixes the crash I was seeing on OS X 10.4. 2005-07-30 Casey Marshall <[EMAIL PROTECTED]> * native/jni/java-nio/gnu_java_nio_channels_FileChannel

Re: [cp-patches] FYI: fix warnings in NIO JNI

2005-07-30 Thread Casey Marshall
Hm. Ok. 'mincore' is declared to take an 'unsigned char *' on GNU, but a 'char *' on Darwin. pinskia suggested on IRC that casting the argument to 'void *' would be a good enough workaround, so I'm checking this little change in.

[cp-patches] FYI: fix various problems with X500Principal

2005-08-07 Thread Casey Marshall
really do need more attention and testing than I can provide. 2005-08-07 Casey Marshall <[EMAIL PROTECTED]> * javax/security/auth/x500/X500Principal.java (encodeDer): use the right iterator for the inner loop. (parseString): test for end of input. (readAttributeType)

[cp-patches] FYI: fix PolicyFile property handling

2005-08-08 Thread Casey Marshall
Committed. 2005-08-08 Casey Marshall <[EMAIL PROTECTED]> Fixes bug #22914 * gnu/classpath/debug/Component.java (POLICY): new constant. * gnu/java/security/PolicyFile.java (logger): new constant. (DEBUG,debug,debug): removed. (DEFAULT_POLICY): use 'SystemProper

[cp-patches] Patch: FYI: KeyPairGenerator problems

2005-08-08 Thread Casey Marshall
hould be reformatted, but isn't here; I'll follow up sometime with a patch to fix this, and some of the rest of the fugly code in gnu.java.security. 2005-08-08 Casey Marshall <[EMAIL PROTECTED]> PR classpath/23120 * gnu/java/security/provider/DSAKeyPairGenerator.jav

[cp-patches] FYI: little bugs in DSAKeyPairGenerator

2005-08-14 Thread Casey Marshall
Hi, This fixes a copy-and-paste bug I introduced in my previous change to this class, and fixes the return values for 'getDefaults' for 768 and 1024 bit keys. Committed. 2005-08-14 Casey Marshall <[EMAIL PROTECTED]> * gnu/java/security/provider/DSAKeyPa

[cp-patches] PATCH: RFC: default policy file

2005-08-14 Thread Casey Marshall
Hi, Attached is an initial implementation of a "policy file," and the changes needed to hook it in as the default security policy, and to install it in the correct location. This policy mainly allows untrusted code read access to the system properties listed in the documentation for 'Syst

[cp-patches] PATCH: bugs in Subject, SubjectDomainCombiner

2005-09-12 Thread Casey Marshall
Hi, I'm checking in some fixes for bugs 23819 and 23822. 2005-09-12 Casey Marshall <[EMAIL PROTECTED]> PR 23819 * javax/security/auth/Subject.java (SecureSet.): rename input paremeter to 'inElements.' (SecureSet.contains): return 'elements.contains,

[cp-patches] [RFC] JSSE 1.5 classes and methods

2005-09-12 Thread Casey Marshall
urrently inherit from the superclass. My reason for doing this is to introduce NIO support in Jessie (http://jessie.nongnu.org/), and to eventually see projects like gumdrop (http://gumdrop.nongnu.org/) have SSL support through Jessie, on existing Classpath runtimes. 2005-09-12 C

[cp-patches] DiffieHellman and RSA

2005-09-13 Thread Casey Marshall
y.SecureRandom; +import java.security.spec.AlgorithmParameterSpec; + +import javax.crypto.KeyAgreementSpi; +import javax.crypto.SecretKey; +import javax.crypto.interfaces.DHPrivateKey; +import javax.crypto.interfaces.DHPublicKey; +import javax.crypto.spec.DHParameterSpec; +import javax.crypto.spec.SecretKeySpec;

Re: [cp-patches] DiffieHellman and RSA

2005-09-22 Thread Casey Marshall
On Sep 14, 2005, at 2:36 PM, Thomas Fitzsimmons wrote: On Tue, 2005-09-13 at 15:10 -0700, Casey Marshall wrote: I've checked these in. I put an RFC for these out some time ago [1], but didn't see Tromey's reply until now. This adds DiffieHellman key exchange and RSA ciphe

Re: [cp-patches] Patch: RFA: javax.security.sasl -vs- 1.5

2005-09-22 Thread Casey Marshall
On Sep 16, 2005, at 1:07 AM, Chris Burdess wrote: Tom Tromey wrote: I wanted some feedback on this one before checking it in. This updates javax.security.sasl to be 1.5 compliant. However, this is odd because this package is (afaik) new in 1.5... was it written against some earlier version of

[cp-patches] FYI: Diffie Hellman key algorithms

2005-09-25 Thread Casey Marshall
This adds KeyFactory and KeyPairGenerator implementations for DiffieHellman. These should help get things like jsch closer to working, but I haven't had much luck so far (there appears to be a bug in our RSA signature impl). Committed, 2005-09-25 Casey Marshall <[EMAIL P

[cp-patches] FYI: fix for PR 23916

2005-09-25 Thread Casey Marshall
mainCombiner to 'doPrivileged,' and subvert proper access control checks. Committed, 2005-09-25 Casey Marshall <[EMAIL PROTECTED]> Fixes PR classpath/23916. Fix suggested by Santiago Gala <[EMAIL PROTECTED]>. * java/security/AccessControlContext.java (): upd

Re: [cp-patches] DiffieHellman and RSA

2005-09-27 Thread Casey Marshall
On Sep 27, 2005, at 5:44 PM, Thomas Fitzsimmons wrote: OK, your latest fixes get Eclipse a little farther. Now I'm seeing this: org.eclipse.team.internal.ccvs.ssh2.CVSSSH2ServerConnection $SSH2IOException: verify: false [...] Any idea? Yeah, and this is where I could get to trying to run

Re: [cp-patches] DiffieHellman and RSA

2005-09-28 Thread Casey Marshall
On Sep 28, 2005, at 11:03 AM, Thomas Fitzsimmons wrote: On Tue, 2005-09-27 at 19:37 -0700, Casey Marshall wrote: On Sep 27, 2005, at 5:44 PM, Thomas Fitzsimmons wrote: OK, your latest fixes get Eclipse a little farther. Now I'm seeing this: org.eclipse.team.internal.ccvs

[cp-patches] FYI: fix Diffie Hellman

2005-10-02 Thread Casey Marshall
ulti-party DH correctly, but two-party is what everyone uses. Committed, 2005-10-02 Casey Marshall <[EMAIL PROTECTED]> * gnu/javax/crypto/DiffieHellmanImpl.java (random): removed. (): removed 'random' initialization. (engineDoPhase): use params from the

Re: [cp-patches] [RFC] JSSE 1.5 classes and methods

2005-10-27 Thread Casey Marshall
d new abstract methods to a few classes and interfaces (boo Sun! Booo!) existing Jessie releases won't compile against them. On Mon, 2005-09-12 at 22:33 -0700, Casey Marshall wrote: Attached is a patch to implement most of the javax.net.ssl methods and classes introduced in J2SE 1.5.