Re: [cp-patches] FYI: Fix for PR34991

2009-01-07 Thread Robert Schuster
Hi, thanks for the hint I will rework it that way. Regards Robert David Gilbert schrieb: > Robert Schuster wrote: > > -draw(new Polygon(xPoints, yPoints, nPoints)); > +for (int i = 1; i < nPoints; i++) > + draw(new Line2D.Double(xPoints[i -

[cp-patches] FYI: Fix for PR34991

2009-01-06 Thread Robert Schuster
Hi, it was already asked whether this patch has been applied. Now it is. :) Regards Robert 2009-01-05 Robert Schuster * gnu/java/awt/peer/gtk/CairoGraphics2D.java: (drawPolyline): Rewritten. Index: gnu/java/awt/peer/gtk/CairoGraphics2D.java

[cp-patches] FYI: fix for DecimalFormat

2008-09-05 Thread Robert Schuster
Hi, the attached patch fixes a problem when you numberformat pattern contains the currency replacement character (/u00a4). I suggest that this patch should be added to GCJ as well, as it fixes an annoying issue. Regards Robert ChangeLog: 2008-09-04 Robert Schuster <[EMAIL PROTEC

[cp-patches] FYI: Fix unmappable case in ByteDecodeLoopHelper/ByteEncodeLoopHelper

2008-09-03 Thread Robert Schuster
CoderResult.UNDERFLOW or CoderResult.OVERFLOW. I found and debugged this problem while using mysql connector/j. Regards Robert ChangeLog: 2008-09-04 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/nio/charset/ByteDecodeLoopHelper: (arrayDecodeLoop): Added new break label, escape t

[cp-patches] FYI: fix access out of array bounds

2008-08-12 Thread Robert Schuster
compile classpath with newer GCCs (~4.3) and --enable-local-sockets. ChangeLog: 2008-08-12 Robert Schuster <[EMAIL PROTECTED]> * native/jni/java-net/local.c (local_bind): Removed fprintf call, fixed access outside of array bounds. Regards Robert Index: native/jni/java-net/l

Re: [cp-patches] RFC: @file support for gjavah & gjar

2008-06-06 Thread Robert Schuster
lasspath/tools/common/ClasspathToolParser.java: > Fixed indentation and changed to use OptionException. > * tools/gnu/classpath/tools/getopt/OptionException.java: > (OptionException(String,Throwable)): Added. > > 2008-06-03 Robert Schuster <[EMAIL PROTECTED]> &g

Re: [cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-04 Thread Robert Schuster
Hi. Andrew Haley schrieb: >> What is the public equivalent for GetPropertyAction? > > There isn't any need, is there? That depends. :) > It's just a wrapper for > (String) AccessController.doPrivileged(new PrivilegedAction() { > public java.lang.Object run() { >

[cp-patches] RFC: move from gnu.java.security.action.GetPropertyAction to sun.security.action.GetPropertyAction

2008-06-04 Thread Robert Schuster
you I also think that with OpenJDK being available under the GPL it is equally bad to have gnu.java.security.action.GetPropertyAction or sun.security.action.GetPropertyAction But what I think what is even worse is having both. :) 2008-06-04 Robert Schuster <[EMAIL PROTECTED]> * gnu/java

Re: [cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-04 Thread Robert Schuster
Hi, Andrew John Hughes schrieb: >> 2008-06-03 Robert Schuster <[EMAIL PROTECTED]> >> >> * sun/security/action/GetPropertyAction.java: Functional copy >> of gnu/java/security/action/GetPropertyAction.java. >> >> Regards >> Robert >> &

[cp-patches] RFC: @file support for gjavah & gjar

2008-06-03 Thread Robert Schuster
x27; field protected - was private). I originally wanted to use StreamTokenizer or StringTokenizer but I think those are to complex for the task. 2008-06-03 Robert Schuster <[EMAIL PROTECTED]> * tools/gnu/classpath/tools/jar/Main.java: (run): Call different ClasspathToolParser.parse() varia

Re: [cp-patches] RFC: changes to java.lang.Integer, Long...

2008-06-03 Thread Robert Schuster
Hi, Andrew John Hughes schrieb: > I'd second that. Are there clear performance benefits to justify > creating 256 objects ahead of time? > Not only does that introduce an overhead in initialising the Long > class, but it also results in increased > memory usage for all applications. > > I'd als

Re: [cp-patches] FYI: gjar @file fix

2008-06-03 Thread Robert Schuster
Hi Tom, > I am less sure about adding java-specific file name parsing to the > generic command-line parser code. That code is not supposed to be > specific to java tooling (at least frysk uses it, fwiw). I will implement the @file handling ClasspathToolParser now. That way only our Classpath tool

Re: [cp-patches] FYI: gjar @file fix

2008-06-02 Thread Robert Schuster
Hi Andrew, >> I was trying to get Classpath to build PhoneME today and that requires >> our javah to support @-style arguments as well. From my work for MIDPath >> I know that we also lack that functionality in gjar that is why I tried >> an implementation that can be used in all getopt using

[cp-patches] RFC: add a copy of gnu/java/security/action/GetPropertyAction into sun/security/action

2008-06-02 Thread Robert Schuster
riant and remove the gnu/java/security one. Opinions? 2008-06-03 Robert Schuster <[EMAIL PROTECTED]> * sun/security/action/GetPropertyAction.java: Functional copy of gnu/java/security/action/GetPropertyAction.java. Regards Robert Index: sun/security/action/GetProperty

Re: [cp-patches] FYI: gjar @file fix

2008-06-02 Thread Robert Schuster
2008 12:01:11 -0000 1.9623 +++ ChangeLog 2 Jun 2008 22:40:10 - @@ -1,3 +1,10 @@ +2008-06-03 Robert Schuster <[EMAIL PROTECTED]> + + * tools/gnu/classpath/tools/getopt/Parser.java: + (parse): Added twos checks for '@' character and calls to parseFileList. + (parseFileList): New

Re: [cp-patches] [release] FYI: Allow native-only build #06: Regenerate headers by default only when necessary

2008-06-01 Thread Robert Schuster
Hi, thank you very much for this change! Regards Robert Andrew John Hughes schrieb: > This changes the default behaviour for a source tree > which already contains the header files. It now won't > regenerate them unless asked. Generating them by default > for a development (CVS) tree remains th

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-05-15 Thread Robert Schuster
Hi, I committed this today. 2008-05-15 Robert Schuster <[EMAIL PROTECTED]> * java/net/NetworkInterface.java: (isUp): New method. (isPointToPoint): Dito. (isLoopback): Dito. (supportsMulticast): Dito. * vm/reference/java/net/VMNetworkInterface.java: (isUp): New

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-22 Thread Robert Schuster
Hi. Robert Schuster schrieb: > Hi, > I fixed the copy and paste error and another flaw. Casting to jboolean > did not alway returned the correct result. I made the if-flag-set then > JNI_TRUE otherwise JNI_FALSE explicit. Now it works correctly. If no one objects I would like to commi

Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-21 Thread Robert Schuster
Hi, I fixed the copy and paste error and another flaw. Casting to jboolean did not alway returned the correct result. I made the if-flag-set then JNI_TRUE otherwise JNI_FALSE explicit. Now it works correctly. Christian Thalinger schrieb: > I wonder if it would be simpler to only have one native me

[cp-patches] RFC: NetworkInterface - implement some 1.6 methods

2008-04-21 Thread Robert Schuster
Hi, people using Jalimo asked for those methods and I found them simple to implement. Since I am lousy non-Java hacker I appreciate comments on the code in java_net_VMNetworkInterface.c. Regards Robert 2008-04-21 Robert Schuster <[EMAIL PROTECTED]> * java/net/NetworkInterface.java:

[cp-patches] FYI: fix StAX API incompatibility

2008-03-04 Thread Robert Schuster
Hi, while trying to compile woodstox 2.0.6 on classpath I stumbled across an incompatibility in out StAX API. The attached patch fixes the interface and adjust all implementations within classpath. Regards Robert 2008-03-04 Robert Schuster <[EMAIL PROTECTED]> * gnu/xml/

Re: [cp-patches] RFC: Abstract StringBuilder and StringBuffer

2008-02-17 Thread Robert Schuster
Hi Andrew, > public final class StringBuilder > + extends AbstractStringBuffer StringBuffer and StringBuilder have Object as their superclass. I think we are not allowed to break that. If so you should change your implementation to follow a delegation pattern and make as many methods 'final' as p

Re: [cp-patches] [PATCH] libjava: java.net.URI.relativize method results inconsistent with other Java VMs

2008-01-09 Thread Robert Schuster
Hi, > The second change involved removing a leading '/' from the returned > relative path to make it consistent with results from other Java VMs. > > This patch corrects two issues found in URI.relativize() method in > libjava/classpath/java/net/URI.java. It applies from gcc 4.1.2 through latest

Re: [cp-patches] FYI: add myself to THANKYOU

2007-12-11 Thread Robert Schuster
Hi. Mark Wielaard schrieb: > But... > People with active commit rights should be in the AUTHORS file. Really! Done! :) Regards Robert signature.asc Description: OpenPGP digital signature

[cp-patches] FYI: added myself to AUTHORS

2007-12-11 Thread Robert Schuster
Hi, as expressed by Mark I add myself to the AUTHORS file. 2007-12-11 Robert Schuster <[EMAIL PROTECTED]> * AUTHORS: Added my name to the list. Index: AUTHORS === RCS file: /sources/classpath/classpath/AUTHORS,v retr

[cp-patches] FYI: add myself to THANKYOU

2007-12-10 Thread Robert Schuster
Hi, I added myself to the thankyou file. :) Thank you, too, GNU Classpath and friends. Working on the project has always been fulfilling for me! 2007-12-10 Robert Schuster <[EMAIL PROTECTED]> * THANKYOU: Added my name to the list. Index: TH

Re: [cp-patches] RFC: fix for 32516

2007-12-10 Thread Robert Schuster
Hi. Robert Schuster schrieb: > Hi, > the attached patch removes the dreaded dot - file separator prefixes >>from files which should be added to zip (jar) archives. This fixes > 32516[0] for me. > > ChangeLog: > > 2007-12-10 Robert Schuster <[EMAIL PROTECTED]>

[cp-patches] RFC: fix for 32516

2007-12-10 Thread Robert Schuster
Hi, the attached patch removes the dreaded dot - file separator prefixes from files which should be added to zip (jar) archives. This fixes 32516[0] for me. ChangeLog: 2007-12-10 Robert Schuster <[EMAIL PROTECTED]> PR classpath/32516: * tools/gnu/classpath/tools/jar/Entr

[cp-patches] FYI: mark arguments as possibly unused

2007-12-10 Thread Robert Schuster
Hi, sorry for the delay. Some weeks ago I got a compile problem with -Wall and unsued arguments in cpio_df. This patch fixes that: 2007-12-10 Robert Schuster <[EMAIL PROTECTED]> * native/jni/native-lib/cpio.c: (cpio_df): Mark arguments as possibly unused. Index: native/jni/nati

[cp-patches] FYI: remove debug output from GlyphView::paint()

2007-12-10 Thread Robert Schuster
Hi, this little patch removes some debug output from GlyphView::paint(). 2007-12-10 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/text/GlyphView.java: (paint): Removed debug output. Index: javax/swing/text/GlyphVie

Re: [cp-patches] RFC: fix warning in cpio_df

2007-11-08 Thread Robert Schuster
Hi. Mario Torre schrieb: > Il giorno gio, 08/11/2007 alle 13.06 +0100, Mark Wielaard ha scritto: >> Hi Robert, >> >> On Wed, 2007-11-07 at 22:13 +0100, Robert Schuster wrote: >>> this patch marks the parameters of cpio_df as possibly unused and >>> silents t

[cp-patches] RFC: fix warning in cpio_df

2007-11-07 Thread Robert Schuster
Hi, this patch marks the parameters of cpio_df as possibly unused and silents the warning/lets the build continue with -Wall. Ok to commit? 2007-11-06 Robert Schuster <[EMAIL PROTECTED]> * native/jni/native-lib/cpio.c: (cpio_df): Mark parameters as (possibly) unused. Regards

[cp-patches] Re: Still Problem with GNU-Classpath 0.96.1 on StrongARM

2007-10-23 Thread Robert Schuster
Hi, Robert Lougher schrieb: > Hi Vladimir, > > On 10/23/07, Vladimir Nikolov <[EMAIL PROTECTED]> wrote: >> Hi, >> >> I have still problems to compile the GNU-Classpath 0.96.1 on the >> StrongARM machine. >> Once again, I would like to use it together with the JamVM 1.4.5, since >> both support no

[cp-patches] FIY: build fix for localsockets

2007-09-12 Thread Robert Schuster
Hi, a C file from the local sockets implementation unconditionally defined _GNU_SOURCE causing trouble in builds where this is already defined. Thanks go to Dalibor who helped me to track this down. Regards Robert 2007-09-12 Robert Schuster <[EMAIL PROTECTED]> * native/jni/ja

Re: [cp-patches] RFC: Gstreamer audio backend configure patch

2007-06-02 Thread Robert Schuster
Hi Mario, > DIST_SUBDIRS = classpath java-io java-lang java-net java-nio java-util \ > - gtk-peer gconf-peer qt-peer xmlj midi-alsa midi-dssi \ > + gtk-peer gconf-peer gstreamer-peer qt-peer xmlj midi-alsa > midi-dssi \ > native-lib I am not so happy a

[cp-patches] FYI: Added translation to XGraphics

2007-05-25 Thread Robert Schuster
Hi, the following patch adds adding the translation to rawFillRect() and rawDrawLine() in XGraphics2D. This fixes painting the gradient and backgrounds for Swing components. 2007-05-25 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/awt/peer/x/XGraphics2D.java: (rawDr

[cp-patches] FYI: NPE fix for OpenTypeFont

2007-05-25 Thread Robert Schuster
Hi, I applied this little patch to prevent a NPE when using a JTextField with the X peers. Regards Robert 2007-05-25 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/awt/font/opentype/OpenTypeFont.java: (getGlyphIndex): Call getGlyphCharMap() instead of accessin

[cp-patches] FYI: mouse event modifiers fix for the X peers

2007-05-22 Thread Robert Schuster
Hi, the attached patch fixes the modifiers for the X peers. Changes since my last RFC are: Removed a superfluous import, changed all number literals to constant names and mentioned the button clipping in the changelog. 2007-05-22 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/aw

[cp-patches] RFC: calculate button modifiers for X peers

2007-05-22 Thread Robert Schuster
Hi, the attached patch properly calculates the modifiers for mouse press and release events. Ok, to commit? 2007-05-22 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/awt/peer/x/XEventQueue.java: (handleEvent): Calculate modifier value for mouse presse and r

[cp-patches] FYI: fix key events for X peers

2007-05-22 Thread Robert Schuster
Hi, I was missing the keyboard part in my last patch. Here it is. 2007-05-22 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/awt/peer/x/XEventQueue.java: (handleEvent): Use Input.event_window_id for key presses/releases. Regards Robert Index: gnu/java/awt/

Re: [cp-patches] FYI: XEventPump fix

2007-05-22 Thread Robert Schuster
Hi, actually the changelog should read: 2007-05-22 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/awt/peer/x/XEventQueue.java: (handleEvent): Use Input.event_window_id instead of Input.child_window_id for mouse presses/releases & movement. Sor

Re: [cp-patches] FYI: X Peers enhancement

2007-05-22 Thread Robert Schuster
Hi, you forgot to commit the changelog entry. Did that for you. Regards Robert Roman Kennke schrieb: > This brings the X peers up to the recent enhancement of the rasterizer. > > 2007-05-22 Roman Kennke <[EMAIL PROTECTED]> > > * gnu/java/awt/peer/x/XFontPeer2.java > (XFontMetr

[cp-patches] FYI: XEventPump fix

2007-05-22 Thread Robert Schuster
Hi, the attached patch makes mouse events work again for the X peers (and prevent a NPE later). Regards Robert 2007-05-22 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/awt/peer/x/XEventQueue.java: (handleEvent): Use Input.event_window_id inst

[cp-patches] FYI: add offset to memcpy operation - getpeername

2006-11-09 Thread Robert Schuster
Hi, gnu_java_nio_VMChannel.c::getpeername() the memcpy operation in the IPv6 case is missing an offset when copying the port value in. This patch fixes that. ChangeLog: 2006-11-09 Robert Schuster <[EMAIL PROTECTED]> * native/jni/java-nio/gnu_java_nio_VMChannel.c: (getpe

[cp-patches] FYI: add offset to memcpy operation

2006-11-09 Thread Robert Schuster
Hi, the memcpy operation in gnu_java_nio_VMChannel.c::getsockname() for the IPv6 case was copying the port value into the same space as the IPv6 address. I fixed this by adding an offset (like its done in the IPv4 case). ChangeLog: 2006-11-09 Robert Schuster <[EMAIL PROTEC

[cp-patches] FYI: MulticastSocket.setNetworkInterface fix

2006-10-24 Thread Robert Schuster
with mixed IP versions. ChangeLog: 2006-10-25 Robert Schuster <[EMAIL PROTECTED]> * java/net/MulticastSocket.java: (setNetworkInterface): Rewritten. cya Robert Index: java/net/MulticastSocket.java === RC

[cp-patches] FYI: make _javanet_create_inetaddress accessable

2006-10-24 Thread Robert Schuster
Hi, my last patch need _javanet_create_inetaddress from javanet.c to be accessable from another compilation unit. This patch does that. ChangeLog: 2006-10-25 Robert Schuster <[EMAIL PROTECTED]> * native/jni/java-net/javanet.h: Added declaration for _javanet_create_ineta

[cp-patches] FYI: Java NIO/NET/Socket fixes

2006-10-24 Thread Robert Schuster
the bigger changes and think that the minor fixes are just ok. ChangeLog: 2006-10-25 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/net/PlainDatagramSocketImpl.java: (connect): Use VMChannel instance for connect call. (getTimeToLive): Call VM

Re: [cp-patches] FYI: final fix for PR29576

2006-10-24 Thread Robert Schuster
Ahem, and here is the patch. Robert Schuster wrote: > Hi, > with this small change to MulticastSocket a proper instance is returned when > the > socket's multicast interface results to any. > > I know: Test would be nice. I am working on it. :) > > ChangeLog:

[cp-patches] FYI: Inet6Address fix

2006-10-24 Thread Robert Schuster
Hi, byte value comparisons in Java are evil. Adding a cast to a byte of the right value fixes the Inet6Address.isMulticastAddress method. ChangeLog: 2006-10-25 Robert Schuster <[EMAIL PROTECTED]> * java/net/Inet6Address.java: (isMulticastAddress): Fixed check. cya

[cp-patches] FYI: final fix for PR29576

2006-10-24 Thread Robert Schuster
Hi, with this small change to MulticastSocket a proper instance is returned when the socket's multicast interface results to any. I know: Test would be nice. I am working on it. :) ChangeLog: 2006-10-25 Robert Schuster <[EMAIL PROTECTED]> Fixes PR29576

[cp-patches] FYI: Fix for PR29576

2006-10-24 Thread Robert Schuster
learned to deal with the field name of an VMNetworkInterface instance being null. ChangeLog: 2006-10-25 Robert Schuster <[EMAIL PROTECTED]> Fixes PR29576 * java/net/NetworkInterface.java: (createAnyInterface): New method. (equals): Added if-statement to

[cp-patches] RFC/Need help: java-net/java-nio update

2006-10-09 Thread Robert Schuster
tuff? I am feeling lost here :| Here is the how the ChangeLog would look like: 2006-10-09 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/net/PlainDatagramSocketImpl.java: (connect): Use VMChannel instance for connect call. (getTimeToLive): Call VMPlainSocketIm

[cp-patches] FYI: fix for wrong JNI code in gnu_java_net_VMPlainSocketImpl.c

2006-10-09 Thread Robert Schuster
Hi, somehow conversion of a jstring into a char * was missing in the JNI code below making the those functions unusuable. ChangeLog: 2006-10-09 Robert Schuster <[EMAIL PROTECTED]> * native/jni/java-net/gnu_java_net/VMPlainSocket

[cp-patches] RFC: VMPlainDatagramImpl removal

2006-10-08 Thread Robert Schuster
crucial for the porting of Classpath' IO system to GCJ which I am currently doing. ChangeLog: 2006-10-09 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/net/PlainSocketImpl.java: (connect): Use VMChannel instance for connect call. (getTimeTo

[cp-patches] FYI: KqueueSelectorImpl field rename

2006-10-08 Thread Robert Schuster
Hi, this renames a field in KqueueSelectorImpl to make GCJ happy. ChangeLog: 2006-10-03 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/nio/KqueueSelectorImpl.java: Renamed field sizeof_struct_kevent to _sizeof_struct_kevent. cya Robert Index: gnu/ja

[cp-patches] Re: preparation of VMPlainDatagramSocketImpl removal

2006-10-08 Thread Robert Schuster
Hi Casey, thanks for the quick reply! Casey Marshall wrote: >>Should it simply be added? >> > > > Yeah. What the setOption method tries to do now is put "integer" methods > (those that set an integer or a boolean value) in one method (in > VMPlainSocketImpl), and to get/set other values with ded

[cp-patches] RFC: renamed method in KqueueSelectorImpl and removed IP_TTL field

2006-10-03 Thread Robert Schuster
change is ok? ChangeLog: 2006-10-03 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/nio/KqueueSelectorImpl.java: Renamed method sizeof_struct_kevent to get_sizeof_struct_kevent. * include/gnu_java_nio_KqueueSelectorImpl.h: Dito. * native/jni/ja

[cp-patches] FYI: remove unneeded imports

2006-09-27 Thread Robert Schuster
Hi, another small patch in preparation of the epoll work on gcj. 2006-09-27 Robert Schuster <[EMAIL PROTECTED]> * gnu/java/nio/VMChannelOwner.java: Removed unneeded imports. cya Robert Index: gnu/java/nio/VMChannelOwne

[cp-patches] FYI: some NIO implementation cleanups

2006-09-27 Thread Robert Schuster
Hi, this small patch cleans some imports and 'new Integer' invocations to 'Integer.valueOf'. This is in preparation of getting the latest Classpath changes in the NIO area to gcj. ChangeLog: 2006-09-27 Robert Schuster <[EMAIL PROTECTED]> * vm/reference/g

Re: [cp-patches] FYI: Updated INSTALL and configure.ac

2006-09-27 Thread Robert Schuster
Hi, there where other changes in this file which I made earlier and forgot to tell about in the first ChangeLog. I applied the same patch but with this ChangeLog entry: 2006-09-27 Robert Schuster <[EMAIL PROTECTED]> * INSTALL: Added information about grmic being built wh

[cp-patches] FYI: Updated INSTALL and configure.ac

2006-09-27 Thread Robert Schuster
Hi, I updated INSTALL and configure.ac with infos about grmic being built when asm.jar is specified. ChangeLog: 2006-09-27 Robert Schuster <[EMAIL PROTECTED]> * INSTALL: Added information about grmic being built when ASM is available. * configure.ac: Dito.

[cp-patches] FYI: DefaultTableMode fix

2006-09-01 Thread Robert Schuster
Hi, the attached patch fixes a NullPointerException for me. ChangeLog: 2006-09-01 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/table/DefaultTableModel.java: (checkSize): Added null check for dataVector. cya Robert Index: javax/swing/table/DefaultTableMode

[cp-patches] FYI: BasicSplitPaneUI fix endless recursion

2006-09-01 Thread Robert Schuster
Hi, the attached patch fixes an endless recursion happening with JSplitPanes. ChangeLog: 2006-09-01 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicSplitPaneUI.java: (BasicHorizontalLayout.getAlignmentX): Return fixed

[cp-patches] FYI: MetalCheckBoxUI fix

2006-09-01 Thread Robert Schuster
Hi, in order to call the isChecked() method it is not needed to cast a component to a JCheckBox - an AbstractButton is enough. I dont think this costs us anything and makes the class more flexible for all the possible misuses out there. :) ChangeLog: 2006-09-01 Robert Schuster <[EM

[cp-patches] FYI: BasicLookAndFeel properties corrected

2006-09-01 Thread Robert Schuster
Hi, the attached patch fixes some properties of the tabbed panes in BasicLookAndFeel. ChangeLog: 2006-09-01 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicLookAndFeel.java: (initComponentDefaults): Added, changed and removed some tabbe

[cp-patches] FYI: small tab pane demo change

2006-09-01 Thread Robert Schuster
Hi, this fixes the naming in the tabbed pane demo a bit. ChangeLog: 2006-09-01 Robert Schuster <[EMAIL PROTECTED]> * examples/gnu/classpath/examples/swing/TabbedPaneDemo.java: (createContent): Changed menu item name and tab naming. cya Robert Index: examples/gnu/cla

[cp-patches] FYI: BasicTabbedPaneUI fix

2006-09-01 Thread Robert Schuster
more than 2 tab runs (like in our Swing demo). ChangeLog: 2006-09-01 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTabbedPaneUI.java: (calculateTabAreaHeight): Use getTabRunOverlay method instead of accessing variable di

[cp-patches] FYI: DefaultButtonModel - expression simplification

2006-08-17 Thread Robert Schuster
Hi, this small patch simplifies an expression. ChangeLog: 2006-08-17 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/DefaultButtonModel.java: (setRollover): Simplified statement. cya Robert Index: javax/swing/DefaultButtonMode

[cp-patches] FYI: more BasicTabbedPaneUI & MetalTabbedPaneUI fixes

2006-08-16 Thread Robert Schuster
06-08-17 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTabbedPaneUI.java: (getTabBounds(JTabbedPane, int)): Added code to shift rectangle by current scroll offset, added method documention. (getTabBounds(int, Rectangle)): Added method do

[cp-patches] FYI: BasicTabbedPaneUI fixes

2006-08-16 Thread Robert Schuster
ation and redispatches a properly modified MouseEvent to the JTabbedPane. With that patch my PopupMenu-enhanced JTabbedPane demo (yay!) works now more like on the RI. Still need to figure out how they make it react on actions in the content area ... 2006-08-17 Robert Schuster <[EMAIL P

[cp-patches] FYI: change to JTabbedPane demo

2006-08-15 Thread Robert Schuster
mode. ChangeLog: 2006-08-16 Robert Schuster <[EMAIL PROTECTED]> * examples/gnu/classpath/demo/swing/TabbedPaneDemo.java: (createContent): Rewritten. (createPlacementChangingMenuItem): New method. (createLayoutPolicyChangingMenuItem): New method. (creat

[cp-patches] FYI: BasicTabbedPaneUI fix

2006-08-15 Thread Robert Schuster
a click on a disabled tab. Finally a part of the if-else cascade was wrongly indented. I fixed that, too. 2006-08-16 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTabbedPaneUI.java: (MouseHandler.mousePressed): Fixed indentation, intercept cli

[cp-patches] FYI: WrappedPlainView fix

2006-08-15 Thread Robert Schuster
Hi all. After Roman did this* change the NavigationFilter demo did not work anymore. I fixed the problem in WrappedPlainView. Another small change corrects the argument of the BadLocationException. 2006-08-16 Robert Schuster <[EMAIL PROTECTED]> * javax/swin

Re: [cp-patches] FYI: Vector fixlet

2006-08-15 Thread Robert Schuster
Hi Roman, could you please add a comment to these methods that says that the NPEs are supposed to be thrown implicitly. Otherwise I find it a bit odd that the javadoc mentions the exceptions explicitly. cya Robert Roman Kennke wrote: > This removes 2 explicit null checks in Vector. The Mauve test

[cp-patches] FYI: DomIterator fix

2006-08-03 Thread Robert Schuster
Hi, this small patchlet, suggested by Henrik Gulbrandsen, fixes another case of PR27864. 2006-08-04 Robert Schuster <[EMAIL PROTECTED]> Reported by Henrik Gulbrandsen <[EMAIL PROTECTED]> Fixes PR27864. * gnu/xml/dom/DomIterator.java: (successo

Re: [cp-patches] FYI: MetalBorders and MetalMenuBarUI

2006-08-03 Thread Robert Schuster
Sorry, I attached the wrong patch. Here is the correct one. @Mark: This is a small fix which may enter 0.92. cya Robert Robert Schuster wrote: > Hi, > this fumbles a bit with the way the gradient and the border is painted for > JMenu > components. > > Still need to find out

[cp-patches] FYI: MetalBorders and MetalMenuBarUI

2006-08-03 Thread Robert Schuster
Hi, this fumbles a bit with the way the gradient and the border is painted for JMenu components. Still need to find out how 'they' manage to join the painting of a JMenu with a adjacent JToolBar ... 2006-08-04 Robert Schuster <[EMAIL PROTECTED]> * javax/

[cp-patches] FYI: CairoGraphics2D.drawLine fix

2006-07-26 Thread Robert Schuster
Hi, Roman asked me to look again at the drawLine issue and I now changed the code to unconditionally apply a shift to all non-1-pixel lines. With that Swing compos look good again and 1-pixel lines still work. ChangeLog: 2006-07-26 Robert Schuster <[EMAIL PROTECTED]> * gnu/ja

[cp-patches] FYI: ColorConvertOp and ColorModel fix

2006-07-26 Thread Robert Schuster
prevents a call the setRenderingHints() when the argument (a Map) is null. With these patches I can start and play jrisk.sf.net :) ChangeLog: 2006-07-26 Robert Schuster <[EMAIL PROTECTED]> * java/awt/image/ColorConvertOp.java: Fixed copyright header. (copyimage): Do no

Re: [cp-patches] RFC: Stroking fix

2006-07-26 Thread Robert Schuster
Hi, unfortunately I cannot say whether your fixes are mathematically right. However I tried some piccolo apps[0] which I wrote years ago. Some of them worked already but the ones that indirectly make use of BasicStroke did not work yet. With your patch these problems are solved. The piccolo distri

Re: [cp-patches] FYI: revert JTabbedPane.setSelectedIndex patch

2006-07-26 Thread Robert Schuster
Hi, actually the patch was applied in the following way: 2006-07-26 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java: (setSelectedIndex): Removed updating of component visibility status, added note. (remove(Component)): Use indexOfCom

[cp-patches] FYI: revert JTabbedPane.setSelectedIndex patch

2006-07-26 Thread Robert Schuster
Hi, this reverts yesterdays change to JTabbedPane.setSelectedIndex and adds a note. ChangeLog: 2006-07-26 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java: (setSelectedIndex): Removed updating of component visibility status, added note. cya

Re: [cp-patches] FYI: JTabbedPane fixes

2006-07-26 Thread Robert Schuster
added here. Please add notes to code which relies on a certain behavior of the UI. cya Robert Mark Wielaard wrote: > Hi Robert, > > On Tue, 2006-07-25 at 21:21 +0200, Robert Schuster wrote: > >>Hi, >>this patch fixes some minor JTabbedPane issues. >> >>

Re: [cp-patches] RFC: Stroking fix

2006-07-25 Thread Robert Schuster
Wow, this looks interesting. I will test it tommorow with piccolo[0]. cya Robert [0] - http://www.cs.umd.edu/hcil/jazz/ Francis Kung wrote: > Hello, > > Attached is a patch to implement, fix, and clean up aspects of > BasicStroke.createStrokedShape() > > I would appreciate any comments anyone

[cp-patches] FYI: fix for CairoGraphics.drawLine

2006-07-25 Thread Robert Schuster
Hi, my former patch for drawLine had an unwanted impact on all non-1-pixel lines. This version intercepts 1-pixel line drawing actions and finishes the job by painting a 1 pixel rectangle. ChangeLog: 2006-07-25 Robert Schuster <[EMAIL PROTECTED]> * java/awt/peer/gtk/CairoGraphic

[cp-patches] FYI: Fix for PR27844

2006-07-25 Thread Robert Schuster
Hi, the attached patch fixes the drawing problem for one pixel sized lines. ChangeLog: 2006-07-25 Robert Schuster <[EMAIL PROTECTED]> Fixes PR27844. * java/awt/peer/gtk/CairoGraphics.java: (drawLine): Removed calls to shifted(). cya Robert Index: gnu/java/awt/pe

[cp-patches] FYI: JTabbedPane fixes

2006-07-25 Thread Robert Schuster
Hi, this patch fixes some minor JTabbedPane issues. 2006-07-25 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JTabbedPane.java: (remove(Component)): Rewritten. (setSelectedIndex): Implemented updating of component visibility state. cya Robert Index: javax

[cp-patches] FYI: BasicLookAndFeel in Swing Demo

2006-07-25 Thread Robert Schuster
Hi, this patch makes it possible to see the basic look and feel in action in our Swing demo. In the future this may help to get customs LaFs working which directly build upon the Basic Look And Feel. 2006-07-25 Robert Schuster <[EMAIL PROTECTED]> * examples/gnu/classpath/examples

[cp-patches] FYI: small MetalLookAndFeel fixes

2006-07-23 Thread Robert Schuster
Hi, the attached adds two properties to the look and feel and documents some overrides and additions of OceanTheme. ChangeLog: 2006-07-22 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalLookAndFeel: (initComponentDefaults): Added new properties,

Re: [cp-patches] RFC: fix for PR28350

2006-07-11 Thread Robert Schuster
Hi, thanks for looking at it. Committed with this ChangeLog: 2006-07-11 Robert Schuster <[EMAIL PROTECTED]> Fixes PR28350. * native/jni/gconf-peer/GConfNativePeer.c: (Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1set_1string): Chan

[cp-patches] RFC: fix for PR28350

2006-07-11 Thread Robert Schuster
Hi, this patch fixes PR28350 for me. Ok to commit? ChangeLog: 2006-07-11 Robert Schuster <[EMAIL PROTECTED]> * native/jni/gconf-peer/GConfNativePeer.c: (Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1set_1string): Changed if-expr

Re: [cp-patches] FYI: Generate name the same way as Sun

2006-07-08 Thread Robert Schuster
Hi Tania >>+if (type == 0) >>+ name = "Default Cursor"; >>+else if (type == 1) >>+ name = "Crosshair Cursor"; >>+else if (type == 2) >>+ name = "Text Cursor"; >>+else if (type == 3) >>+ name = "Wait Cursor"; >>+else if (type == 4) >>+ name = "Southwest

[cp-patches] FYI: BasicArrowButton paint fix

2006-07-05 Thread Robert Schuster
07-05 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicArrowButton.java: (paint): Removed getBounds() call, changed center point calculation. Index: javax/swing/plaf/basic/BasicArrow

[cp-patches] FYI: Insets.toString fix

2006-06-22 Thread Robert Schuster
Hi, this small patch makes Insets.toString() return the information formatted in the same way as on the RI. ChangeLog: 2006-06-22 Robert Schuster <[EMAIL PROTECTED]> * java/awt/Insets.java: Updated copyright year. (toString): Changed string, removed a line fr

[cp-patches] FYI: fix NPE in JMenu

2006-06-22 Thread Robert Schuster
Hi, this patch fixes a NullPointerException which happens in JMenu.removeAll. This problem was easily spotable using our Swing demo. The ChangeLog: 2006-06-22 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/JMenu.java: (removeAll): Added check for popupMenu not bein

[cp-patches] FYI: fix for BasicRadioButtonUI

2006-06-16 Thread Robert Schuster
-16 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicRadioButtonUI.java: (installDefaults): Removed unneccessary code. (paint): Removed complex if-cascade, revert to default icon if icon property is not set. (getPreferredSize): New

[cp-patches] FYI: fix for MetalMenuBarUI

2006-06-16 Thread Robert Schuster
. :) ChangeLog: 2006-06-16 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalMenuBarUI.java: (update): Added subexpression to if-statement. cya Robert Index: javax/swing/plaf/metal/MetalMenuBarU

[cp-patches] RFC: change painting and layouting of buttons and radiobuttons

2006-06-15 Thread Robert Schuster
Hi, I need help for this one. I had the following problem: BasicRadioButtonUI.installDefaults sets default values for the icon, selectedIcon, disabledIcon etc properties. This is wrong, as the RI does not do this. Minitestcase: assert(new JRadioButton().getIcon() == null) I changed this and modif

[cp-patches] FYI: allow null tileIcon for MatteBorder

2006-06-08 Thread Robert Schuster
HI, an app written by me years ago demonstrates that MatteBorder can accept a null tileIcon. Classpath' implementation throw an exception in that case. The attached patch fixes that and make the paintBorder method aware of a possibly null tileIcon. ChangeLog: 2006-06-08 Robert Schuster &l

  1   2   3   4   >