Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-06 Thread Raif S. Naffah
hello Mark, On Monday 06 February 2006 09:53, Mark Wielaard wrote: > Hi Raif, > > On Sun, 2006-02-05 at 09:12 +1100, Raif S. Naffah wrote: > > > > if (!(key instanceof DSSPublicKey)) > > > > throw new InvalidParameterException("key"); > > > > > > Officially there is a space after each op

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-05 Thread Mark Wielaard
Hi Raif, On Sun, 2006-02-05 at 09:12 +1100, Raif S. Naffah wrote: > > > if (!(key instanceof DSSPublicKey)) > > > throw new InvalidParameterException("key"); > > > > Officially there is a space after each operator, so also for ! to > > make it more clearly stand out... > > yes we can do

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-04 Thread Raif S. Naffah
hello Mark, On Sunday 05 February 2006 00:03, Mark Wielaard wrote: > On Sat, 2006-02-04 at 22:19 +1100, Raif S. Naffah wrote: > > ... > > // > > --- > >--- > > > > // gnu.java.security.key.IKeyPairCodec interface implementatio

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-04 Thread Mark Wielaard
Hi Raif, On Sat, 2006-02-04 at 22:19 +1100, Raif S. Naffah wrote: > > > Although I don't want to claim to be a GNU source formatting > > > expert. > > > > I am neither, but emacs is mostly right :) > > Normally we try to follow the generic GNU C formatting: > > http://www.gnu.org/prep/standards/ht

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-04 Thread Raif S. Naffah
hello all, On Saturday 04 February 2006 20:52, Mark Wielaard wrote: > On Fri, 2006-02-03 at 16:34 -0800, Casey Marshall wrote: > > Looks wrong to me; you usually break lines after `,' or `+' in long > > expressions like this, not after the `(' (Emacs will break the > > formatting here, and will in

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-04 Thread Mark Wielaard
On Fri, 2006-02-03 at 16:34 -0800, Casey Marshall wrote: > Looks wrong to me; you usually break lines after `,' or `+' in long > expressions like this, not after the `(' (Emacs will break the > formatting here, and will indent the "Parameters.." line to line up > with the opening parenthesis)

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-03 Thread Casey Marshall
On Feb 3, 2006, at 5:10 PM, Raif S. Naffah wrote: On Saturday 04 February 2006 11:34, Casey Marshall wrote: On Feb 3, 2006, at 1:31 PM, Raif S. Naffah wrote: hello there, this patch makes the keypair-generators wrapped in gnu.java.security.jce.sig.KeyPairGeneratorAdapter extend the java.secur

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-03 Thread Raif S. Naffah
On Saturday 04 February 2006 11:34, Casey Marshall wrote: > On Feb 3, 2006, at 1:31 PM, Raif S. Naffah wrote: > > hello there, > > > > this patch makes the keypair-generators wrapped in > > gnu.java.security.jce.sig.KeyPairGeneratorAdapter extend the > > java.security.KeyPairGenerator rather than K

Re: [cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-03 Thread Casey Marshall
On Feb 3, 2006, at 1:31 PM, Raif S. Naffah wrote: hello there, this patch makes the keypair-generators wrapped in gnu.java.security.jce.sig.KeyPairGeneratorAdapter extend the java.security.KeyPairGenerator rather than KeyPairGeneratorSpi making it possible for adapted classes to be cast to othe

[cp-patches] DSSKeyPairGenerator JCE Adapter

2006-02-03 Thread Raif S. Naffah
hello there, this patch makes the keypair-generators wrapped in gnu.java.security.jce.sig.KeyPairGeneratorAdapter extend the java.security.KeyPairGenerator rather than KeyPairGeneratorSpi making it possible for adapted classes to be cast to other specific keypair-generators. DSSKeyPairGenerat