[cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Ian Rogers
Hi, the attached patch reduces the number of warnings emitted when compiling classpath with jikes (in particular as part of the Jikes RVM build process). The warnings were: 1) by a negative amount - this was in the code to achieve a rotate. To make the code readable the patch adds a rotate

Re: [cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Tom Tromey
Ian == Ian Rogers [EMAIL PROTECTED] writes: Ian 1) by a negative amount - this was in the code to achieve a Ianrotate. To make the code readable the patch adds a rotate Ianmethod which is called instead. As the rotate method is private Ianit should be an excellent

Re: [cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Ian Rogers
Thanks Tom, I thought I'd fix all the warnings and wait for people to complain. I agree with what you say and I've attached a fixed patch for just MD4 and MD5, any idea on how to stop the $ symbols being generated by rmic? They are on private fields so altering the names shouldn't matter.

Re: [cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Ian Rogers
Hi Audrius, Wouldn't it be better to regenerate the sources rather than manually remove the $ signs? I don't know how the RMI compiler generated the sources. I'm happy to modify the files by hand otherwise. Thanks! Ian Audrius Meskauskas wrote: any idea on how to stop the $ symbols being

Re: [cp-patches] Patch: Reduce number of compilation warnings

2006-04-13 Thread Casey Marshall
On Apr 13, 2006, at 8:52 AM, Ian Rogers wrote: Hi, the attached patch reduces the number of warnings emitted when compiling classpath with jikes (in particular as part of the Jikes RVM build process). The warnings were: 1) by a negative amount - this was in the code to achieve a